On Thu, 5 Sep 2024 15:12:55 GMT, Viktor Klang <vkl...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> change impl class to use byte arrays rather than SecretKey objects where >> possible > > src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java > line 167: > >> 165: // Since we're defining these values internally, it is >> unlikely. >> 166: throw new ProviderException( >> 167: "could not instantiate a Mac with the provided >> algorithm", > > There's a bit of inconsistency in using capitalization on abbreviations, > examples are: "HKDF" vs "Mac"/"Hmac" vs "ikm". I'd suggest aligning with > prior art and use that consistently. I agree with this. I'll make a pass through and update where appropriate. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1745926164
