On Mon, 13 May 2024 14:10:38 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line >> 351: >> >>> 349: * <a href="http://tools.ietf.org/html/rfc5869";>RFC 5869</a>. >>> 350: */ >>> 351: final class ExtractExpand implements HKDFParameterSpec { >> >> This may have come up previously but I'm curious why ExtractExpand doesn't >> extend Extract. It's not quite an Expand because of the pseudorandom key. > > My opinion is that it's not worth doing. People would write `obj instanceof > Extract` and forget the expand part. Agreed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1600451197
