On Mon, 13 May 2024 14:01:46 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> re-enable preview annotations
>
> src/java.base/share/classes/javax/crypto/KDFSpi.java line 59:
>
>> 57: * <p>
>> 58: * An {@code AlgorithmParameterSpec} may be specified for PRF
>> algorithms that
>> 59: * may require this. Though no such KDF algorithms are currently
>> defined,
>
> You really want to say "Though no such KDF algorithms are currently defined"?
> First, you need to remove this when we invent one. Second, I think we allow
> 3rd party provider to support non-standard KDF algorithms.
Agree, I would remove the second sentence.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1598821570
