On Mon, 13 May 2024 09:27:57 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> re-enable preview annotations
>
> src/java.base/share/classes/javax/crypto/KDF.java line 457:
>
>> 455: * <p>
>> 456: * The {@code deriveData} method may be called multiple times once a
>> 457: * {@code KDF} object is initialized.
>
> What does "once a KDF object is initialized" mean? The getInstance methods
> return a KDF that is initialized, are you saying it's possible to KDF that is
> only partly initialized? Is this about lazy binding to the provider?
I changed it to:
* The {@code deriveXXX} method may be called multiple times on a particular
* {@code KDF} instance.
Let me know if you view that as an improvement or not.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1599177280
