On Tue, 13 Feb 2024 06:44:30 GMT, Sibabrata Sahoo <ssa...@openjdk.org> wrote:
>> Hi, >> >> I need a code review of what is really a text change. This changes the >> alert type returned during some TLS CertificateMessage failures to what is >> recommended in [RFC 8446](https://tools.ietf.org/html/rfc8446). An >> additional change was to add the alert description to the thrown exception. >> This makes it easier for the user to know the alert type and makes testing >> easier. Two of the three changes are tested as the final one is too hard to >> test. A few tests needed change as they did string comparing on exception >> messages. >> >> Tony > > test/jdk/javax/net/ssl/SSLSession/CertMsgCheck.java line 51: > >> 49: pass = true; >> 50: System.out.println("Found correct exception: " + >> args[0] + >> 51: " in " + e.getMessage()); > > break; required? I could just return out of the method ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17717#discussion_r1500017048
