On Tue, 13 Feb 2024 12:09:40 GMT, John Jiang <jji...@openjdk.org> wrote:
>> Hi, >> >> I need a code review of what is really a text change. This changes the >> alert type returned during some TLS CertificateMessage failures to what is >> recommended in [RFC 8446](https://tools.ietf.org/html/rfc8446). An >> additional change was to add the alert description to the thrown exception. >> This makes it easier for the user to know the alert type and makes testing >> easier. Two of the three changes are tested as the final one is too hard to >> test. A few tests needed change as they did string comparing on exception >> messages. >> >> Tony > > src/java.base/share/classes/sun/security/ssl/Alert.java line 126: > >> 124: >> 125: if (cause instanceof IOException) { >> 126: return new SSLException("("+ description + ") " + reason, >> cause); > > It should need a space between `"("` and `+`. > > Could you please define a new local variable for this expression? > This variable can be reused by the below exceptions. Spacing yes. Some other exception use the description too, so I wanted to limit the scope of the change ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17717#discussion_r1500018025
