On Tue, 6 Feb 2024 01:23:00 GMT, Anthony Scarpino <ascarp...@openjdk.org> wrote:
> Hi, > > I need a code review of what is really a text change. This changes the alert > type returned during some TLS CertificateMessage failures to what is > recommended in [RFC 8446](https://tools.ietf.org/html/rfc8446). An > additional change was to add the alert description to the thrown exception. > This makes it easier for the user to know the alert type and makes testing > easier. Two of the three changes are tested as the final one is too hard to > test. A few tests needed change as they did string comparing on exception > messages. > > Tony test/jdk/javax/net/ssl/templates/TLSBase.java line 105: > 103: char[] pwd = passwd.toCharArray(); > 104: KeyStore ks = KeyStore.getInstance(KeyStore.getDefaultType()); > 105: ks.load(fis, pwd); Should this input stream be closed? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17717#discussion_r1487769746
