On Tue, 6 Feb 2024 01:23:00 GMT, Anthony Scarpino <ascarp...@openjdk.org> wrote:
> Hi, > > I need a code review of what is really a text change. This changes the alert > type returned during some TLS CertificateMessage failures to what is > recommended in [RFC 8446](https://tools.ietf.org/html/rfc8446). An > additional change was to add the alert description to the thrown exception. > This makes it easier for the user to know the alert type and makes testing > easier. Two of the three changes are tested as the final one is too hard to > test. A few tests needed change as they did string comparing on exception > messages. > > Tony test/jdk/javax/net/ssl/SSLSession/CheckSessionContext.java line 59: > 57: byte[] id = ss.getId(); > 58: System.out.print("id = "); > 59: System.out.println(hex.formatHex(id)); Similar to the change at line 63, it may also use a single print statement, System.out.println("id = " + hex.formatHex(id)); ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17717#discussion_r1487796879
