Re: [PATCH] Config.mk: drop -Wdeclaration-after-statement

2023-11-28 Thread Jan Beulich
On 28.11.2023 18:47, Alexander Kanavin wrote: > Such constructs are fully allowed by C99: > https://gcc.gnu.org/onlinedocs/gcc-12.2.0/gcc/Mixed-Labels-and-Declarations.html#Mixed-Labels-and-Declarations There's more to this: It may also be a policy of ours (or of any sub-component) to demand that

[xen-unstable-smoke test] 183925: regressions - all pass

2023-11-28 Thread osstest service owner
flight 183925 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/183925/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 7 xen-build/dist-test fail REGR. vs. 183851 build-arm64-

[ovmf test] 183923: all pass - PUSHED

2023-11-28 Thread osstest service owner
flight 183923 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/183923/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 88580a79d49f923ed9347d6161a5cff28a46f627 baseline version: ovmf cdf36b1e36805884a8dc1

[linux-5.4 test] 183907: regressions - FAIL

2023-11-28 Thread osstest service owner
flight 183907 linux-5.4 real [real] flight 183924 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/183907/ http://logs.test-lab.xenproject.org/osstest/logs/183924/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: t

xen | Successful pipeline for staging | 72ec0709

2023-11-28 Thread GitLab
Pipeline #1088683622 has passed! Project: xen ( https://gitlab.com/xen-project/xen ) Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) Commit: 72ec0709 ( https://gitlab.com/xen-project/xen/-/commit/72ec070930fa4a34d7665ba2a7a42a91d0c85bed ) Commit Message: xen: replace

[xen-unstable-smoke test] 183920: regressions - all pass

2023-11-28 Thread osstest service owner
flight 183920 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/183920/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 7 xen-build/dist-test fail REGR. vs. 183851 build-arm64-

Re: MISRA: Compatible declarations for sort and bsearch

2023-11-28 Thread Stefano Stabellini
On Mon, 27 Nov 2023, Nicola Vetrini wrote: > > > /* > > > * TODO: make first_valid_mfn static when NUMA is supported on Arm, this > > > * is required because the dummy helpers are using it. > > > */ > > > extern mfn_t first_valid_mfn; > > > > > > it should probably be deviated. > > > > NUMA

Re: [XEN PATCH v5 1/2] automation/eclair: make the docs for MISRA C:2012 Dir 4.1 visible to ECLAIR

2023-11-28 Thread Stefano Stabellini
On Tue, 28 Nov 2023, Stefano Stabellini wrote: > On Fri, 17 Nov 2023, Nicola Vetrini wrote: > > To be able to check for the existence of the necessary subsections in > > the documentation for MISRA C:2012 Dir 4.1, ECLAIR needs to have a source > > file that is built. > > > > This file is generated

Re: [XEN PATCH v5 1/3] arm/bitops: encapsulate violation of MISRA C:2012 Rule 10.1

2023-11-28 Thread Stefano Stabellini
On Fri, 24 Nov 2023, Nicola Vetrini wrote: > On 2023-11-24 09:06, Jan Beulich wrote: > > On 23.11.2023 08:37, Nicola Vetrini wrote: > > > The definitions of ffs{l}? violate Rule 10.1, by using the well-known > > > pattern (x & -x); its usage is wrapped by the ISOLATE_LSB macro. > > > > > > No func

Re: [XEN PATCH v5 1/2] automation/eclair: make the docs for MISRA C:2012 Dir 4.1 visible to ECLAIR

2023-11-28 Thread Stefano Stabellini
On Fri, 17 Nov 2023, Nicola Vetrini wrote: > To be able to check for the existence of the necessary subsections in > the documentation for MISRA C:2012 Dir 4.1, ECLAIR needs to have a source > file that is built. > > This file is generated from 'C-runtime-failures.rst' in docs/misra > and the conf

Re: [PATCH] ubsan: Introduce CONFIG_UBSAN_FATAL to panic on UBSAN failure

2023-11-28 Thread Stefano Stabellini
On Tue, 28 Nov 2023, Julien Grall wrote: > On 28/11/2023 18:15, Michal Orzel wrote: > > On 28/11/2023 18:09, Julien Grall wrote: > > > On 28/11/2023 18:00, Michal Orzel wrote: > > > > On 28/11/2023 17:14, Julien Grall wrote: > > > > > On 27/11/2023 15:41, Michal Orzel wrote: > > > > > > Introduce t

[ovmf test] 183914: all pass - PUSHED

2023-11-28 Thread osstest service owner
flight 183914 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/183914/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf cdf36b1e36805884a8dc115b1316ac09ce77feee baseline version: ovmf e1627f77201ac55d24e9d

[seabios test] 183912: tolerable FAIL - PUSHED

2023-11-28 Thread osstest service owner
flight 183912 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/183912/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 182944 test-amd64-i386-xl-qemuu-win7-amd64 19 gu

Re: [PATCH v10 13/17] vpci: add initial support for virtual PCI bus topology

2023-11-28 Thread Volodymyr Babchuk
Hi Roger, Roger Pau Monné writes: > On Wed, Nov 22, 2023 at 01:18:32PM -0800, Stefano Stabellini wrote: >> On Wed, 22 Nov 2023, Roger Pau Monné wrote: >> > On Tue, Nov 21, 2023 at 05:12:15PM -0800, Stefano Stabellini wrote: >> > > Let me expand on this. Like I wrote above, I think it is importan

Re: We are not able to virtualize FreeBSD using xen 4.17 on Arm 32 bit

2023-11-28 Thread Elliott Mitchell
On Tue, Nov 28, 2023 at 04:10:50PM +0100, Roger Pau Monné wrote: > On Tue, Nov 28, 2023 at 03:09:14PM +0100, Mario Marietto wrote: > > For booting a FreeBSD kernel as a guest OS on XEN,should we install xen > > 4.18 from source ? > I don't think so, I'm not aware of the FreeBSD port requiring a >

Re: [PATCH] cirrus-ci: update FreeBSD versions

2023-11-28 Thread Stefano Stabellini
On Tue, 28 Nov 2023, Andrew Cooper wrote: > On 28/11/2023 5:11 pm, Roger Pau Monne wrote: > > FreeBSD 14.0 has already been released, so switch to the release version > > image, > > and introduce a FreeBSD 15.0 version to track current FreeBSD unstable > > (development) branch. > > > > Sample outp

Re: [PATCH v10 03/17] vpci: use per-domain PCI lock to protect vpci structure

2023-11-28 Thread Volodymyr Babchuk
Hi Roger Thank you for the review. Roger Pau Monné writes: > On Thu, Oct 12, 2023 at 10:09:15PM +, Volodymyr Babchuk wrote: >> From: Oleksandr Andrushchenko >> >> Use a previously introduced per-domain read/write lock to check >> whether vpci is present, so we are sure there are no access

Re: [PATCH v4 10/14] xen/asm-generic: introduce stub header monitor.h

2023-11-28 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > The header is shared between several archs so it is > moved to asm-generic. > > Signed-off-by: Oleksii Kurochko > Acked-by: Jan Beulich . > --- > Changes in V4: > - Removed the double blank line. > - Added Acked-by: Jan Beulich . > -

Re: [PATCH v4 09/14] xen/asm-generic: introduce generic header altp2m.h

2023-11-28 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > is common between several archs so it is > moved to asm-generic. > > Arm and PPC were switched to asm-generic version of altp2m.h. > Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v4 08/14] xen/asm-generic: introduce generic div64.h header

2023-11-28 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > All archs have the do_div implementation for BITS_PER_LONG == 64 > so do_div64.h is moved to asm-generic. > > x86 and PPC were switched to asm-generic version of div64.h. > Acked-by: Shawn Anastasio Thanks, Shawn

[xen-unstable-smoke test] 183908: regressions - FAIL

2023-11-28 Thread osstest service owner
flight 183908 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/183908/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 7 xen-build/dist-test fail REGR. vs. 183851 build-arm64-

Re: [PATCH v4 07/14] xen/asm-generic: introduce generalized hardirq.h

2023-11-28 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > is common through archs thereby it is moved > to asm-generic. > > Arm and PPC were switched to asm generic verstion of hardirq.h. > Acked-by: Shawn Anastasio Thanks, Shawn

[linux-linus test] 183884: tolerable FAIL - PUSHED

2023-11-28 Thread osstest service owner
flight 183884 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/183884/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 183859 test-amd64-amd64-xl-qemut-win7-amd64

Re: [PATCH v4 06/14] xen/asm-generic: introduce generic header percpu.h

2023-11-28 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > The patch introduces generic percpu.h which was based on Arm's version > with the following changes: > * makes __per_cpu_data_end[] constant > * introduce get_per_cpu_offset() for macros this_cpu() and this_cpu_ptr() > * add inclustion

Re: [PATCH v4 05/14] xen/asm-generic: introduce stub header

2023-11-28 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > is common for Arm, PPC and RISC-V thereby it > is moved to asm-generic. > Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v4 04/14] xen/asm-generic: introduce generic header iocap.h

2023-11-28 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > iocap.h is common for Arm, PPC and RISC-V architectures thereby > it was moved to asm-generic. > > Also Arm and PPC were switched to asm-generic version of iocap.h. > Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v4 03/14] xen/asm-generic: introduce generic hypercall.h

2023-11-28 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > Introduce an empty generic hypercall.h for archs which don't > implement it. > > Drop PPC's hypercall.h and switch to generic one instead. Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v4 02/14] xen/asm-generic: introduce generic device.h

2023-11-28 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 1:46 PM, Oleksii wrote: > On Mon, 2023-11-27 at 15:31 +0100, Jan Beulich wrote: >> On 27.11.2023 15:13, Oleksii Kurochko wrote: >>> --- a/xen/arch/ppc/include/asm/irq.h >>> +++ b/xen/arch/ppc/include/asm/irq.h >>> @@ -3,7 +3,9 @@ >>> #define __ASM_PPC_IRQ_H__ >>> >>> #i

Re: [PATCH v4 02/14] xen/asm-generic: introduce generic device.h

2023-11-28 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > diff --git a/xen/arch/ppc/include/asm/Makefile > b/xen/arch/ppc/include/asm/Makefile > index ece7fa66dd..df4c1ebb08 100644 > --- a/xen/arch/ppc/include/asm/Makefile > +++ b/xen/arch/ppc/include/asm/Makefile > @@ -1,3 +1,4 @@ > # SPDX-Lic

xen | Successful pipeline for staging | 18540a31

2023-11-28 Thread GitLab
Pipeline #1088270744 has passed! Project: xen ( https://gitlab.com/xen-project/xen ) Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) Commit: 18540a31 ( https://gitlab.com/xen-project/xen/-/commit/18540a313cc66a04eb15a67d74c7992a8576fbec ) Commit Message: arm/dom0less:

[ovmf test] 183909: all pass - PUSHED

2023-11-28 Thread osstest service owner
flight 183909 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/183909/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf e1627f77201ac55d24e9d0e3380f9dbdc600843c baseline version: ovmf 9eec96bd4fc53d7836b56

Re: [PATCH v4 01/14] xen/asm-generic: introduce stub header paging.h

2023-11-28 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > The patch introduces generic paging.h header for Arm, PPC and > RISC-V. > > All mentioned above architectures use hardware virt extensions > and hardware pagetable extensions thereby it makes sense to set > paging_mode_translate and pagin

Re: [PATCH v2] xen: remove

2023-11-28 Thread Shawn Anastasio
My apologies for the delay on this and thank you for reaching to me for the ping, Oleksii. Acked-by: Shawn Anastasio On 11/27/23 4:26 AM, Oleksii wrote: > Hello Shawn, > > Could you kindly review the patch when you have a moment? > It can help with merging other patch series. > > Thanks in adv

Re: [PATCH v6 3/5] arm/dom0less: put dom0less feature code in a separate module

2023-11-28 Thread Luca Fancellu
> On 28 Nov 2023, at 18:25, Julien Grall wrote: > > Hi, > > On 24/11/2023 12:01, Michal Orzel wrote: >> On 24/11/2023 10:48, Luca Fancellu wrote: >>> >>> >>> Currently the dom0less feature code is mostly inside domain_build.c >>> and setup.c, it is a feature that may not be useful to everyon

Re: [PATCH v2 27/29] tools/xenstored: add helpers for filename handling

2023-11-28 Thread Jason Andryuk
On Wed, Nov 15, 2023 at 1:14 AM Juergen Gross wrote: > > On 14.11.23 21:53, Julien Grall wrote: > > Hi Juergen, > > > > On 14/11/2023 09:26, Juergen Gross wrote: > >> On 14.11.23 10:10, Julien Grall wrote: > >>> Hi Juergen, > >>> > >>> On 14/11/2023 06:45, Juergen Gross wrote: > On 13.11.23 2

Re: [PATCH v2 18/29] tools/xenstored: rename xenbus_evtchn()

2023-11-28 Thread Jason Andryuk
On Fri, Nov 10, 2023 at 11:23 AM Juergen Gross wrote: > > Rename the xenbus_evtchn() function to get_xenbus_evtchn() in order to > avoid two externally visible symbols with the same name when Xenstore- > stubdom is being built with a Mini-OS with CONFIG_XENBUS set. > > Signed-off-by: Juergen Gross

Re: [PATCH v2 16/29] tools/xl: support new 9pfs backend xen-9pfsd

2023-11-28 Thread Jason Andryuk
On Fri, Nov 10, 2023 at 11:19 AM Juergen Gross wrote: > > Add support for the new 9pfs backend "xen-9pfsd". For this backend type > the tag defaults to "Xen" and the host side path to > "/var/log/xen/guests/". > > Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk

Re: [PATCH v2 11/29] tools/xenlogd: add 9pfs create request support

2023-11-28 Thread Jason Andryuk
On Fri, Nov 10, 2023 at 12:14 PM Juergen Gross wrote: > > Add the create request of the 9pfs protocol. > > Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk

Re: [PATCH v2 10/29] tools/xenlogd: add 9pfs clunk request support

2023-11-28 Thread Jason Andryuk
On Fri, Nov 10, 2023 at 11:22 AM Juergen Gross wrote: > > Add the clunk request of the 9pfs protocol. > > Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk

[PATCH v8 2/2] xen/vpci: header: filter PCI capabilities

2023-11-28 Thread Stewart Hildebrand
Currently, Xen vPCI only supports virtualizing the MSI and MSI-X capabilities. Hide all other PCI capabilities (including extended capabilities) from domUs for now, even though there may be certain devices/drivers that depend on being able to discover certain capabilities. We parse the physical PC

[PATCH v8 1/2] xen/vpci: header: status register handler

2023-11-28 Thread Stewart Hildebrand
Introduce a handler for the PCI status register, with ability to mask the capabilities bit. The status register contains RsvdZ bits, read-only bits, and write-1-to-clear bits. Additionally, we use RsvdP to mask the capabilities bit. Introduce bitmasks to handle these in vPCI. If a bit in the bitmas

[PATCH v8 0/2] vPCI capabilities filtering

2023-11-28 Thread Stewart Hildebrand
This small series enables vPCI to filter which PCI capabilities we expose to a domU. This series adds vPCI register handlers within xen/drivers/vpci/header.c:init_bars(), along with some supporting functions. Note there are minor rebase conflicts with the in-progress vPCI series [1]. These conflic

Re: [PATCH v12 24/37] x86/idtentry: Incorporate definitions/declarations of the FRED entries

2023-11-28 Thread Borislav Petkov
On Tue, Nov 28, 2023 at 10:58:50AM -0800, H. Peter Anvin wrote: > >You have a very good sense 😊 I've been reading code of a couple of people for a couple of years. :-) > Remember that Signed-off-by: relates to the *patch flow*. Yes, you should take the time to read Documentation/process/ and esp

RE: [PATCH v12 24/37] x86/idtentry: Incorporate definitions/declarations of the FRED entries

2023-11-28 Thread H. Peter Anvin
On November 28, 2023 10:39:01 AM PST, "Li, Xin3" wrote: >> > FRED and IDT can share most of the definitions and declarations so >> > that in the majority of cases the actual handler implementation is the >> > same. >> > >> > The differences are the exceptions where FRED stores exception related >>

RE: [PATCH v12 24/37] x86/idtentry: Incorporate definitions/declarations of the FRED entries

2023-11-28 Thread Li, Xin3
> > FRED and IDT can share most of the definitions and declarations so > > that in the majority of cases the actual handler implementation is the > > same. > > > > The differences are the exceptions where FRED stores exception related > > information on the stack and the sysvec implementations as F

Re: [PATCH v6 3/5] arm/dom0less: put dom0less feature code in a separate module

2023-11-28 Thread Julien Grall
Hi, On 24/11/2023 12:01, Michal Orzel wrote: On 24/11/2023 10:48, Luca Fancellu wrote: Currently the dom0less feature code is mostly inside domain_build.c and setup.c, it is a feature that may not be useful to everyone so put the code in a different compilation module in order to make it easi

Re: [PATCH] ubsan: Introduce CONFIG_UBSAN_FATAL to panic on UBSAN failure

2023-11-28 Thread Julien Grall
Hi Michal, On 28/11/2023 18:15, Michal Orzel wrote: On 28/11/2023 18:09, Julien Grall wrote: On 28/11/2023 18:00, Michal Orzel wrote: Hi Julien, On 28/11/2023 17:14, Julien Grall wrote: Hi Michal, On 27/11/2023 15:41, Michal Orzel wrote: Introduce the CONFIG_UBSAN_FATAL option to cat

[PATCH] Config.mk: drop -Wdeclaration-after-statement

2023-11-28 Thread Alexander Kanavin
Such constructs are fully allowed by C99: https://gcc.gnu.org/onlinedocs/gcc-12.2.0/gcc/Mixed-Labels-and-Declarations.html#Mixed-Labels-and-Declarations If the flag is present, then building against python 3.12 will fail thusly: | In file included from /srv/storage/alex/yocto/build-virt/tmp/work

Re: [PATCH] xen/livepatch: fix livepatch tests

2023-11-28 Thread Andrew Cooper
On 28/11/2023 5:41 pm, Roger Pau Monne wrote: > The current set of in-tree livepatch tests in xen/test/livepatch started > failing after the constify of the payload funcs array, and the movement of the > status data into a separate array. > > Fix the tests so they respect the constness of the funcs

[PATCH] xen/livepatch: fix livepatch tests

2023-11-28 Thread Roger Pau Monne
The current set of in-tree livepatch tests in xen/test/livepatch started failing after the constify of the payload funcs array, and the movement of the status data into a separate array. Fix the tests so they respect the constness of the funcs array and also make use of the new location of the per

[xen-unstable-smoke test] 183899: regressions - all pass

2023-11-28 Thread osstest service owner
flight 183899 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/183899/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 7 xen-build/dist-test fail REGR. vs. 183851 build-arm64-

Re: [XEN PATCH 04/11] xen/dmi: address a violation of MISRA C:2012 Rule 8.2

2023-11-28 Thread Jan Beulich
On 24.11.2023 15:03, Federico Serafini wrote: > Add missing parameter name. No functional change. > > Signed-off-by: Federico Serafini Acked-by: Jan Beulich

Re: [XEN PATCH 03/11] xen/cpumask: address violations of MISRA C:2012 Rule 8.2

2023-11-28 Thread Jan Beulich
On 24.11.2023 15:03, Federico Serafini wrote: > Add missing parameter names. No functional change. > > Signed-off-by: Federico Serafini Acked-by: Jan Beulich irrespective of this being one of the examples where types alone are entirely sufficient and descriptive. Jan > --- a/xen/include/xen/c

Re: [XEN PATCH 02/11] xen/aclinux: address violations of MISRA C:2012 Rule 8.2

2023-11-28 Thread Jan Beulich
On 24.11.2023 15:03, Federico Serafini wrote: > Add missing parameter names. No functional change. > > Signed-off-by: Federico Serafini Acked-by: Jan Beulich Albeit as to the subject: There's no component named "aclinux" in Xen. I think this wants to be "acpi". Jan

Re: [XEN PATCH 01/11] xen/console: address violations of MISRA C:2012 Rule 8.2

2023-11-28 Thread Jan Beulich
On 24.11.2023 15:03, Federico Serafini wrote: > Add missing parameter names. No functional change. > > Signed-off-by: Federico Serafini Acked-by: Jan Beulich

Re: [PATCH v12 16/37] x86/ptrace: Add FRED additional information to the pt_regs structure

2023-11-28 Thread H. Peter Anvin
On November 28, 2023 12:51:22 AM PST, Borislav Petkov wrote: >On Mon, Oct 02, 2023 at 11:24:37PM -0700, Xin Li wrote: >> FRED defines additional information in the upper 48 bits of cs/ss >> fields. Therefore add the information definitions into the pt_regs >> structure. >> >> Specially introduce

Re: [PATCH] ubsan: Introduce CONFIG_UBSAN_FATAL to panic on UBSAN failure

2023-11-28 Thread Michal Orzel
On 28/11/2023 18:15, Andrew Cooper wrote: > > > On 27/11/2023 2:41 pm, Michal Orzel wrote: >> diff --git a/xen/common/ubsan/ubsan.c b/xen/common/ubsan/ubsan.c >> index a3a80fa99eec..dd5ee0013648 100644 >> --- a/xen/common/ubsan/ubsan.c >> +++ b/xen/common/ubsan/ubsan.c >> @@ -174,6 +174,10 @@

Re: [XEN PATCH] automation/eclair: add deviations for MISRA C:2012 Rule 5.6

2023-11-28 Thread Jan Beulich
On 28.11.2023 18:09, Federico Serafini wrote: > --- a/docs/misra/deviations.rst > +++ b/docs/misra/deviations.rst > @@ -90,6 +90,22 @@ Deviations related to MISRA C:2012 Rules: > - __emulate_2op and __emulate_2op_nobyte > - read_debugreg and write_debugreg > > + * - R5.6 > +

Re: [PATCH] cirrus-ci: update FreeBSD versions

2023-11-28 Thread Andrew Cooper
On 28/11/2023 5:11 pm, Roger Pau Monne wrote: > FreeBSD 14.0 has already been released, so switch to the release version > image, > and introduce a FreeBSD 15.0 version to track current FreeBSD unstable > (development) branch. > > Sample output at: > > https://github.com/royger/xen/runs/1910527818

Re: [PATCH] ubsan: Introduce CONFIG_UBSAN_FATAL to panic on UBSAN failure

2023-11-28 Thread Andrew Cooper
On 27/11/2023 2:41 pm, Michal Orzel wrote: > diff --git a/xen/common/ubsan/ubsan.c b/xen/common/ubsan/ubsan.c > index a3a80fa99eec..dd5ee0013648 100644 > --- a/xen/common/ubsan/ubsan.c > +++ b/xen/common/ubsan/ubsan.c > @@ -174,6 +174,10 @@ static void ubsan_epilogue(unsigned long *flags) >

Re: [PATCH] ubsan: Introduce CONFIG_UBSAN_FATAL to panic on UBSAN failure

2023-11-28 Thread Michal Orzel
On 28/11/2023 18:09, Julien Grall wrote: > > > On 28/11/2023 18:00, Michal Orzel wrote: >> Hi Julien, >> >> On 28/11/2023 17:14, Julien Grall wrote: >>> >>> >>> Hi Michal, >>> >>> On 27/11/2023 15:41, Michal Orzel wrote: Introduce the CONFIG_UBSAN_FATAL option to cater to scenarios where

[PATCH] cirrus-ci: update FreeBSD versions

2023-11-28 Thread Roger Pau Monne
FreeBSD 14.0 has already been released, so switch to the release version image, and introduce a FreeBSD 15.0 version to track current FreeBSD unstable (development) branch. Sample output at: https://github.com/royger/xen/runs/19105278189 Signed-off-by: Roger Pau Monné --- .cirrus.yml | 8 +

Re: [PATCH] ubsan: Introduce CONFIG_UBSAN_FATAL to panic on UBSAN failure

2023-11-28 Thread Andrew Cooper
On 28/11/2023 5:00 pm, Michal Orzel wrote: > Hi Julien, > > On 28/11/2023 17:14, Julien Grall wrote: >> >> Hi Michal, >> >> On 27/11/2023 15:41, Michal Orzel wrote: >>> Introduce the CONFIG_UBSAN_FATAL option to cater to scenarios where prompt >>> attention to undefined behavior issues, notably dur

[XEN PATCH] automation/eclair: add deviations for MISRA C:2012 Rule 5.6

2023-11-28 Thread Federico Serafini
Update ECLAIR configuration to take into account the adopted files and type "ret_t". Update docs/misra/deviations.rst accordingly. Signed-off-by: Federico Serafini --- automation/eclair_analysis/ECLAIR/deviations.ecl | 12 docs/misra/deviations.rst| 16 ++

Re: [PATCH] ubsan: Introduce CONFIG_UBSAN_FATAL to panic on UBSAN failure

2023-11-28 Thread Julien Grall
On 28/11/2023 18:00, Michal Orzel wrote: Hi Julien, On 28/11/2023 17:14, Julien Grall wrote: Hi Michal, On 27/11/2023 15:41, Michal Orzel wrote: Introduce the CONFIG_UBSAN_FATAL option to cater to scenarios where prompt attention to undefined behavior issues, notably during CI test runs,

[xen-unstable-smoke bisection] complete build-amd64

2023-11-28 Thread osstest service owner
branch xen-unstable-smoke xenbranch xen-unstable-smoke job build-amd64 testid xen-build/dist-test Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug

Re: [PATCH] ubsan: Introduce CONFIG_UBSAN_FATAL to panic on UBSAN failure

2023-11-28 Thread Michal Orzel
Hi Julien, On 28/11/2023 17:14, Julien Grall wrote: > > > Hi Michal, > > On 27/11/2023 15:41, Michal Orzel wrote: >> Introduce the CONFIG_UBSAN_FATAL option to cater to scenarios where prompt >> attention to undefined behavior issues, notably during CI test runs, is >> essential. When enabled,

Re: [RFC XEN PATCH v2 3/3] tools: Add new function to get gsi from irq

2023-11-28 Thread Juergen Gross
On 28.11.23 17:11, Roger Pau Monné wrote: On Tue, Nov 28, 2023 at 03:42:31PM +0100, Juergen Gross wrote: On 28.11.23 15:25, Roger Pau Monné wrote: On Fri, Nov 24, 2023 at 06:41:36PM +0800, Jiqian Chen wrote: In PVH dom0, it uses the linux local interrupt mechanism, when it allocs irq for a gsi

Re: [PATCH] ubsan: Introduce CONFIG_UBSAN_FATAL to panic on UBSAN failure

2023-11-28 Thread Julien Grall
Hi Michal, On 27/11/2023 15:41, Michal Orzel wrote: Introduce the CONFIG_UBSAN_FATAL option to cater to scenarios where prompt attention to undefined behavior issues, notably during CI test runs, is essential. When enabled, this option causes Xen to panic upon detecting UBSAN failure (as the las

Re: [RFC XEN PATCH v2 3/3] tools: Add new function to get gsi from irq

2023-11-28 Thread Roger Pau Monné
On Tue, Nov 28, 2023 at 03:42:31PM +0100, Juergen Gross wrote: > On 28.11.23 15:25, Roger Pau Monné wrote: > > On Fri, Nov 24, 2023 at 06:41:36PM +0800, Jiqian Chen wrote: > > > In PVH dom0, it uses the linux local interrupt mechanism, > > > when it allocs irq for a gsi, it is dynamic, and follow >

Re: [PATCH v7 2/2] xen/vpci: header: filter PCI capabilities

2023-11-28 Thread Stewart Hildebrand
On 11/17/23 06:44, Roger Pau Monné wrote: > On Wed, Sep 13, 2023 at 10:35:47AM -0400, Stewart Hildebrand wrote: >> Currently, Xen vPCI only supports virtualizing the MSI and MSI-X >> capabilities. >> Hide all other PCI capabilities (including extended capabilities) from domUs >> for >> now, even

Re: [PATCH v2 09/29] tools/xenlogd: add 9pfs open request support

2023-11-28 Thread Jason Andryuk
On Fri, Nov 10, 2023 at 12:16 PM Juergen Gross wrote: > > Add the open request of the 9pfs protocol. > > Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk

[ovmf test] 183895: all pass - PUSHED

2023-11-28 Thread osstest service owner
flight 183895 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/183895/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 9eec96bd4fc53d7836b5606f2a8bbb10713cc8f5 baseline version: ovmf d451bba399687b4102459

Re: [RFC XEN PATCH v2 2/3] x86/pvh: Open PHYSDEVOP_map_pirq for PVH dom0

2023-11-28 Thread Jan Beulich
On 24.11.2023 11:41, Jiqian Chen wrote: > --- a/xen/arch/x86/hvm/hypercall.c > +++ b/xen/arch/x86/hvm/hypercall.c > @@ -74,6 +74,8 @@ long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) > arg) > { > case PHYSDEVOP_map_pirq: > case PHYSDEVOP_unmap_pirq: > +if (is_hardwa

Re: We are not able to virtualize FreeBSD using xen 4.17 on Arm 32 bit

2023-11-28 Thread Roger Pau Monné
On Tue, Nov 28, 2023 at 03:09:14PM +0100, Mario Marietto wrote: > For booting a FreeBSD kernel as a guest OS on XEN,should we install xen > 4.18 from source ? Please avoid top-posting. I don't think so, I'm not aware of the FreeBSD port requiring a specific version of Xen. I do think the work is

Re: [PATCH v2 08/29] tools/xenlogd: add 9pfs walk request support

2023-11-28 Thread Jason Andryuk
On Fri, Nov 10, 2023 at 1:16 PM Juergen Gross wrote: > > Add the walk request of the 9pfs protocol. > > Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk 9P2000.u has support for symlinks which you're explicitly not supporting. A symlink would only be present if someone on the backend s

Re: [PATCH] .gitignore: generalize *.new

2023-11-28 Thread Oleksii
Hi Jan, On Tue, 2023-11-28 at 13:51 +0100, Jan Beulich wrote: > It's not only in xen/include/xen/ that we generate (intermediate) > *.new > files. > > Signed-off-by: Jan Beulich > --- > Really I don't think I can spot what *.new we create in that specific > directory. xen/include/ certainly has

Re: [RFC XEN PATCH v2 3/3] tools: Add new function to get gsi from irq

2023-11-28 Thread Juergen Gross
On 28.11.23 15:25, Roger Pau Monné wrote: On Fri, Nov 24, 2023 at 06:41:36PM +0800, Jiqian Chen wrote: In PVH dom0, it uses the linux local interrupt mechanism, when it allocs irq for a gsi, it is dynamic, and follow the principle of applying first, distributing first. And if you debug the kerne

Re: [RFC XEN PATCH v2 3/3] tools: Add new function to get gsi from irq

2023-11-28 Thread Roger Pau Monné
On Fri, Nov 24, 2023 at 06:41:36PM +0800, Jiqian Chen wrote: > In PVH dom0, it uses the linux local interrupt mechanism, > when it allocs irq for a gsi, it is dynamic, and follow > the principle of applying first, distributing first. And > if you debug the kernel codes, you will find the irq > numb

[xen-unstable-smoke test] 183891: regressions - all pass

2023-11-28 Thread osstest service owner
flight 183891 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/183891/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 7 xen-build/dist-test fail REGR. vs. 183851 build-arm64-

Re: [RFC XEN PATCH v2 2/3] x86/pvh: Open PHYSDEVOP_map_pirq for PVH dom0

2023-11-28 Thread Roger Pau Monné
On Fri, Nov 24, 2023 at 06:41:35PM +0800, Jiqian Chen wrote: > If we run Xen with PVH dom0 and hvm domU, hvm will map a pirq for > a passthrough device by using gsi, see xen_pt_realize->xc_physdev_map_pirq > and pci_add_dm_done->xc_physdev_map_pirq. Then xc_physdev_map_pirq will > call into Xen, bu

[libvirt test] 183880: tolerable all pass - PUSHED

2023-11-28 Thread osstest service owner
flight 183880 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/183880/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 183861 test-armhf-armhf-libvirt-qcow2 15 saveres

Re: [EXTERNAL] [PATCH v3 2/5] xen: backends: don't overwrite XenStore nodes created by toolstack

2023-11-28 Thread David Woodhouse
On Tue, 2023-11-28 at 01:20 +, Volodymyr Babchuk wrote: > Hi David, > > Thank you for the review > > David Woodhouse writes: > > > [[S/MIME Signed Part:Undecided]] > > On Fri, 2023-11-24 at 23:24 +, Volodymyr Babchuk wrote: > > > Xen PV devices in QEMU can be created in two ways: either

Re: We are not able to virtualize FreeBSD using xen 4.17 on Arm 32 bit

2023-11-28 Thread Mario Marietto
For booting a FreeBSD kernel as a guest OS on XEN,should we install xen 4.18 from source ? On Tue, Nov 28, 2023 at 2:45 PM Roger Pau Monné wrote: > On Mon, Nov 27, 2023 at 03:04:30PM -0800, Elliott Mitchell wrote: > > BTW Roger Pau Monné, now that Xen 4.18 is out, take a look at the > > "royger"

Re: [RFC XEN PATCH v2 1/3] xen/vpci: Clear all vpci status of device

2023-11-28 Thread Roger Pau Monné
On Fri, Nov 24, 2023 at 06:41:34PM +0800, Jiqian Chen wrote: > When a device has been reset on dom0 side, the vpci on Xen > side won't get notification, so the cached state in vpci is > all out of date compare with the real device state. > To solve that problem, this patch add new hypercall to clea

Re: [XEN PATCH] x86/guest_walk: address violations of MISRA C:2012 Rule 8.3

2023-11-28 Thread Jan Beulich
On 28.11.2023 14:11, Federico Serafini wrote: > On 28/11/23 14:00, Jan Beulich wrote: >> On 28.11.2023 10:46, Federico Serafini wrote: >>> Uniform declaration and definition of guest_walk_tables() using >>> parameter name "pfec_walk": >>> this name highlights the connection with PFEC_* constants an

Re: We are not able to virtualize FreeBSD using xen 4.17 on Arm 32 bit

2023-11-28 Thread Roger Pau Monné
On Mon, Nov 27, 2023 at 03:04:30PM -0800, Elliott Mitchell wrote: > BTW Roger Pau Monné, now that Xen 4.18 is out, take a look at the > "royger" branch? I've pushed a bunch of those, there are still some, I've made comments on the branch. I think there isn't much left after the swept I've done.

Re: [XEN PATCH] x86/guest_walk: address violations of MISRA C:2012 Rule 8.3

2023-11-28 Thread Jan Beulich
On 28.11.2023 14:17, Andrew Cooper wrote: > On 28/11/2023 1:00 pm, Jan Beulich wrote: >> On 28.11.2023 10:46, Federico Serafini wrote: >>> Uniform declaration and definition of guest_walk_tables() using >>> parameter name "pfec_walk": >>> this name highlights the connection with PFEC_* constants an

Re: [PATCH v3 04/13] xen/spinlock: introduce new type for recursive spinlocks

2023-11-28 Thread Jan Beulich
On 28.11.2023 14:16, Juergen Gross wrote: > On 24.11.23 19:59, Alejandro Vallejo wrote: >> On 20/11/2023 11:38, Juergen Gross wrote: >>> --- a/xen/include/xen/spinlock.h >>> +++ b/xen/include/xen/spinlock.h >> > [snip] >>> @@ -182,8 +191,10 @@ typedef struct spinlock { >>>   #endif >>>   } spinloc

[ovmf test] 183890: all pass - PUSHED

2023-11-28 Thread osstest service owner
flight 183890 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/183890/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf d451bba399687b4102459db5a447fc9abb8fdee1 baseline version: ovmf 0e9ce9146a6dc50a35488

Re: [PATCH v4 13/14] xen: ifdef inclusion of in

2023-11-28 Thread Oleksii
On Tue, 2023-11-28 at 13:53 +0100, Jan Beulich wrote: > On 28.11.2023 12:49, Oleksii wrote: > > On Tue, 2023-11-28 at 10:58 +0100, Jan Beulich wrote: > > > On 28.11.2023 10:28, Oleksii wrote: > > > > On Tue, 2023-11-28 at 08:57 +0100, Jan Beulich wrote: > > > > > On 27.11.2023 20:38, Oleksii wrote:

Re: [PATCH v3 06/13] xen/spinlock: add rspin_[un]lock_irq[save|restore]()

2023-11-28 Thread Juergen Gross
On 24.11.23 20:23, Alejandro Vallejo wrote: On 20/11/2023 11:38, Juergen Gross wrote: Instead of special casing rspin_lock_irqsave() and rspin_unlock_irqrestore() for the console lock, add those functions to spinlock handling and use them where needed. Signed-off-by: Juergen Gross --- V2: - ne

Re: [PATCH v3 04/13] xen/spinlock: introduce new type for recursive spinlocks

2023-11-28 Thread Juergen Gross
On 24.11.23 19:59, Alejandro Vallejo wrote: On 20/11/2023 11:38, Juergen Gross wrote: Introduce a new type "rspinlock_t" to be used for recursive spinlocks. For now it is only an alias of spinlock_t, so both types can still be used for recursive spinlocks. This will be changed later, though. S

Re: [XEN PATCH] x86/guest_walk: address violations of MISRA C:2012 Rule 8.3

2023-11-28 Thread Andrew Cooper
On 28/11/2023 1:00 pm, Jan Beulich wrote: > On 28.11.2023 10:46, Federico Serafini wrote: >> Uniform declaration and definition of guest_walk_tables() using >> parameter name "pfec_walk": >> this name highlights the connection with PFEC_* constants and it is >> consistent with the use of the parame

Re: [XEN PATCH] x86/guest_walk: address violations of MISRA C:2012 Rule 8.3

2023-11-28 Thread Federico Serafini
On 28/11/23 14:00, Jan Beulich wrote: On 28.11.2023 10:46, Federico Serafini wrote: Uniform declaration and definition of guest_walk_tables() using parameter name "pfec_walk": this name highlights the connection with PFEC_* constants and it is consistent with the use of the parameter within func

Re: [PATCH v3 02/13] xen/spinlock: reduce lock profile ifdefs

2023-11-28 Thread Juergen Gross
On 24.11.23 18:59, Alejandro Vallejo wrote: Hi, On 20/11/2023 11:38, Juergen Gross wrote:> With some small adjustments to the LOCK_PROFILE_* macros some #ifdefs can be dropped from spinlock.c. Signed-off-by: Juergen Gross --- V2: - new patch V3: - add variable name to macros parameter (Jan B

Re: [XEN PATCH] x86/guest_walk: address violations of MISRA C:2012 Rule 8.3

2023-11-28 Thread Jan Beulich
On 28.11.2023 10:46, Federico Serafini wrote: > Uniform declaration and definition of guest_walk_tables() using > parameter name "pfec_walk": > this name highlights the connection with PFEC_* constants and it is > consistent with the use of the parameter within function body. > No functional change

Re: [PATCH v4 13/14] xen: ifdef inclusion of in

2023-11-28 Thread Jan Beulich
On 28.11.2023 12:49, Oleksii wrote: > On Tue, 2023-11-28 at 10:58 +0100, Jan Beulich wrote: >> On 28.11.2023 10:28, Oleksii wrote: >>> On Tue, 2023-11-28 at 08:57 +0100, Jan Beulich wrote: On 27.11.2023 20:38, Oleksii wrote: > On Mon, 2023-11-27 at 15:41 +0100, Jan Beulich wrote: >> On

[PATCH] .gitignore: generalize *.new

2023-11-28 Thread Jan Beulich
It's not only in xen/include/xen/ that we generate (intermediate) *.new files. Signed-off-by: Jan Beulich --- Really I don't think I can spot what *.new we create in that specific directory. xen/include/ certainly has some. --- a/.gitignore +++ b/.gitignore @@ -17,6 +17,7 @@ *.so.[0-9]* *.bin

Re: [PATCH v6 0/5] Fine granular configuration

2023-11-28 Thread Luca Fancellu
> On 28 Nov 2023, at 12:38, Michal Orzel wrote: > > Hi Luca, > > On 28/11/2023 11:36, Luca Fancellu wrote: >> >> >>> On 24 Nov 2023, at 09:59, Luca Fancellu wrote: >>> >>> + CC Maintainers >>> On 24 Nov 2023, at 09:48, Luca Fancellu wrote: This serie aims to add more mod

  1   2   >