On 28.11.2023 14:11, Federico Serafini wrote: > On 28/11/23 14:00, Jan Beulich wrote: >> On 28.11.2023 10:46, Federico Serafini wrote: >>> Uniform declaration and definition of guest_walk_tables() using >>> parameter name "pfec_walk": >>> this name highlights the connection with PFEC_* constants and it is >>> consistent with the use of the parameter within function body. >>> No functional change. >>> >>> Signed-off-by: Federico Serafini <federico.seraf...@bugseng.com> >> >> I'm curious what other x86 maintainers think. I for one don't like this, >> but not enough to object if others are happy. That said, there was earlier >> discussion (and perhaps even a patch), yet without a reference I don't >> think I can locate this among all the Misra bits and pieces. >> > > The last thread about guest_walk_tables(): > > https://lists.xenproject.org/archives/html/xen-devel/2023-10/msg02055.html > > Do you have any suggestions on how to handle this?
This simply will need solving - see my reply to Andrew sent a minute ago. Personally the best route I would see is to leave things as they are for now, hoping that Andrew's indicated code change will arrive in not too distant a future. Jan
