> On 28 Nov 2023, at 18:25, Julien Grall <jul...@xen.org> wrote: > > Hi, > > On 24/11/2023 12:01, Michal Orzel wrote: >> On 24/11/2023 10:48, Luca Fancellu wrote: >>> >>> >>> Currently the dom0less feature code is mostly inside domain_build.c >>> and setup.c, it is a feature that may not be useful to everyone so >>> put the code in a different compilation module in order to make it >>> easier to disable the feature in the future. >>> >>> Move gic_interrupt_t in domain_build.h to use it with the function >>> declaration, move its comment above the declaration. >>> >>> The following functions are now visible externally from domain_build >>> because they are used also from the dom0less-build module: >>> - get_allocation_size >>> - set_interrupt >>> - domain_fdt_begin_node >>> - make_memory_node >>> - make_resv_memory_node >>> - make_hypervisor_node >>> - make_psci_node >>> - make_cpus_node >>> - make_timer_node >>> - handle_device_interrupts >>> - construct_domain >>> - process_shm >>> - allocate_bank_memory >>> >>> The functions allocate_static_memory and assign_static_memory_11 >>> are now externally visible, so put their declarations into >>> domain_build.h and move the #else and stub definition in the header >>> as well. >>> >>> Move is_dom0less_mode from setup.c to dom0less-build.c and make it >>> externally visible. >>> >>> The function allocate_bank_memory is used only by dom0less code >>> at the moment, but it's been decided to leave it in domain_build.c >>> in case that in the future the dom0 code can use it. >>> >>> Where spotted, fix code style issues. >>> >>> No functional change is intended. >>> >>> Signed-off-by: Luca Fancellu <luca.fance...@arm.com> >>> Reviewed-by: Michal Orzel <michal.or...@amd.com> >>> --- >>> Changes from v5: >>> - remove unneeded include (Michal) >> Including asm/kernel.h was indeed not required. However, I'm thinking that >> if we want the header >> to be self-contained and given that ... >> [...] >>> diff --git a/xen/arch/arm/include/asm/dom0less-build.h >>> b/xen/arch/arm/include/asm/dom0less-build.h >>> new file mode 100644 >>> index 000000000000..c5625925d940 >>> --- /dev/null >>> +++ b/xen/arch/arm/include/asm/dom0less-build.h >>> @@ -0,0 +1,18 @@ >>> +/* SPDX-License-Identifier: GPL-2.0-only */ >>> + >>> +#ifndef __ASM_DOM0LESS_BUILD_H_ >>> +#define __ASM_DOM0LESS_BUILD_H_ >>> + >>> +void create_domUs(void); >>> +bool is_dom0less_mode(void); >> here we use bool, I think we should include <xen/stdbool.h> > > I have done the change on commit. However, this introduced a clash in the > next patch. > > I have done it this time because it is minor.
Thank you for that Julien, I didn’t realise there would have been a clash, sorry for the Inconvenience. Cheers, Luca > > Cheers, > > -- > Julien Grall
