Re: [Xen-devel] [PATCH 0/9] xen: build fixes with gcc5 and binutils 2.25.0

2016-02-11 Thread Olaf Hering
On Tue, Feb 09, Luis R. Rodriguez wrote: > The error log from compiling the libSDL test is: > /tmp/qemu-conf--5604-.c:1:17: fatal error: SDL.h: No such file or directory This is just the configure test, it can be ignored. Olaf ___ Xen-devel mailing li

[Xen-devel] [PATCH] libxl: fix handling returns in libxl_get_version_info()

2016-02-11 Thread Harmandeep Kaur
Avoid handling issue of the return value of xc_version() in many cases. Coverity ID 1351217 Signed-off-by: Harmandeep Kaur --- tools/libxl/libxl.c | 39 ++- 1 file changed, 30 insertions(+), 9 deletions(-) diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl

[Xen-devel] [PATCH v2] libxc: fix leak of t_info in xc_tbuf_get_size()

2016-02-11 Thread Harmandeep Kaur
Avoid leaking the memory mapping of the trace buffer Coverity ID 1351228 Signed-off-by: Harmandeep Kaur --- v2: call to unmapping function reduced to one from two --- tools/libxc/xc_tbuf.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/libxc/xc_tbuf.c b/tools/

Re: [Xen-devel] [PATCH v2] libxc: fix leak of t_info in xc_tbuf_get_size()

2016-02-11 Thread Dario Faggioli
On Thu, 2016-02-11 at 14:02 +0530, Harmandeep Kaur wrote: > Avoid leaking the memory mapping of the trace buffer > > Coverity ID 1351228 > > Signed-off-by: Harmandeep Kaur > Reviewed-by: Dario Faggioli Thanks and Regards, Dario -- <> (Raistlin Majere) -

[Xen-devel] [xen-4.6-testing test] 81632: tolerable FAIL - PUSHED

2016-02-11 Thread osstest service owner
flight 81632 xen-4.6-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/81632/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-qemut-win7-amd64 16 guest-stop fail like 78701 test-amd64-amd64-xl-qemuu-

[Xen-devel] [PATCH v2] tools: libxl: make it illegal to pass libxl__realloc(gc) a non-gc ptr

2016-02-11 Thread Ian Campbell
That is, if gc is not NOGC and ptr is not NULL then ptr must be associated gc. Currently in this case the new_ptr would not be registered with any gc, which Coverity rightly points out (in various different places) would be a memory leak. It would also be possible to fix this by adding a libxl__p

Re: [Xen-devel] [BUG} libxl.c:5947:libxl_send_trigger: Send trigger 'reset' failed: Function not implemented

2016-02-11 Thread Ian Campbell
On Thu, 2016-02-11 at 09:30 +1100, Alex Braunegg wrote: > So potentially before trying to make use of libxl__domain_pvcontrol for > the 'xl vm-list' command to provide feedback if PV control is available, > I will need to wait for the functionality to be exposed via an applicable > libxl header. Y

Re: [Xen-devel] [PATCH v2 1/1] XEN/ARM: Add Odroid-XU3/XU4 support

2016-02-11 Thread Ian Campbell
On Wed, 2016-02-10 at 17:47 -0800, Suriyan Ramasami wrote: > > > On Wed, Feb 10, 2016 at 2:03 AM, Ian Campbell > wrote: > > On Tue, 2016-02-09 at 10:20 -0800, Suriyan Ramasami wrote: > > >  I agree on the first two paragraphs. > > > > > For the third paragraph, the rebuttal is that the exynos580

Re: [Xen-devel] [PATCH] libxl: fix handling returns in libxl_get_version_info()

2016-02-11 Thread Dario Faggioli
Hi Harmandeep, So, I think the code in this patch is ok. Still, a few comments... On Thu, 2016-02-11 at 14:00 +0530, Harmandeep Kaur wrote: > Avoid handling issue of the return value of xc_version() in many > cases. > This can be rephrased to be easier to understand (I'm not sure I can tell what

Re: [Xen-devel] [PATCH] public/io/netif.h: fix typos

2016-02-11 Thread Ian Campbell
On Wed, 2016-02-10 at 16:49 +, Paul Durrant wrote: > Unfortunately my patch 162a81ab "document control ring and toeplitz > hashing" contained a couple of typos. This patch fixes them. > > Signed-off-by: Paul Durrant > Cc: Ian Campbell > Cc: Ian Jackson > Cc: Jan Beulich > Cc: Keir Fraser

Re: [Xen-devel] [PATCH v2] libxc: fix leak of t_info in xc_tbuf_get_size()

2016-02-11 Thread Ian Campbell
Copying George since he maintains xentrace which this relates to. On Thu, 2016-02-11 at 14:02 +0530, Harmandeep Kaur wrote: > Avoid leaking the memory mapping of the trace buffer > > Coverity ID 1351228 > > Signed-off-by: Harmandeep Kaur > --- > v2: call to unmapping function reduced to one fro

Re: [Xen-devel] [PATCH 1/3] xen/x86: Drop the uses of invbool_param()

2016-02-11 Thread Ian Campbell
On Tue, 2016-02-09 at 05:46 -0700, Jan Beulich wrote: > > > > On 08.02.16 at 18:07, wrote: > > There are only four users, and invbool_param() is an unnecessary > > cognitive > > overhead to use. > > While this isn't necessarily a bad change, I don't agree to either of > these arguments. So I'm go

Re: [Xen-devel] [PATCH v2] libxc: fix leak of t_info in xc_tbuf_get_size()

2016-02-11 Thread Dario Faggioli
On Thu, 2016-02-11 at 09:52 +, Ian Campbell wrote: > On Thu, 2016-02-11 at 14:02 +0530, Harmandeep Kaur wrote: > >  > > diff --git a/tools/libxc/xc_tbuf.c b/tools/libxc/xc_tbuf.c > > index 695939a..d96cc67 100644 > > --- a/tools/libxc/xc_tbuf.c > > +++ b/tools/libxc/xc_tbuf.c > > @@ -70,11 +70,

Re: [Xen-devel] [PATCH v2] libxc: fix leak of t_info in xc_tbuf_get_size()

2016-02-11 Thread Ian Campbell
On Thu, 2016-02-11 at 11:03 +0100, Dario Faggioli wrote: > On Thu, 2016-02-11 at 09:52 +, Ian Campbell wrote: > > On Thu, 2016-02-11 at 14:02 +0530, Harmandeep Kaur wrote: > > >   > > > diff --git a/tools/libxc/xc_tbuf.c b/tools/libxc/xc_tbuf.c > > > index 695939a..d96cc67 100644 > > > --- a/to

Re: [Xen-devel] [PATCH] libxl: fix handling returns in libxl_get_version_info()

2016-02-11 Thread Ian Campbell
On Thu, 2016-02-11 at 10:48 +0100, Dario Faggioli wrote: > I think it would be better if you make the patch in such a way that the > final code would look like this: > >     r = xc_version(ctx->xch, XENVER_extraversion, &u.xen_extra); >     if ( r < 0 ) >         goto out; >     info->xen_version_

Re: [Xen-devel] [PATCH v2] libxc: fix leak of t_info in xc_tbuf_get_size()

2016-02-11 Thread Dario Faggioli
On Thu, 2016-02-11 at 10:11 +, Ian Campbell wrote: > On Thu, 2016-02-11 at 11:03 +0100, Dario Faggioli wrote: > > On Thu, 2016-02-11 at 09:52 +, Ian Campbell wrote: > > > On Thu, 2016-02-11 at 14:02 +0530, Harmandeep Kaur wrote: > > > >   > > > > diff --git a/tools/libxc/xc_tbuf.c b/tools/l

Re: [Xen-devel] [PATCH v2 2/7] xen/x86: merge 2 hvm_event_... functions into 1

2016-02-11 Thread Jan Beulich
>>> On 10.02.16 at 21:56, wrote: > On 10/02/2016 17:11, Jan Beulich wrote: > On 10.02.16 at 18:04, wrote: >>> On 2/10/2016 6:18 PM, Jan Beulich wrote: >>> On 10.02.16 at 16:50, wrote: > --- a/xen/include/asm-x86/hvm/event.h > +++ b/xen/include/asm-x86/hvm/event.h > @@ -17,6 +

[Xen-devel] xl dev-detach hangs with missing frontends

2016-02-11 Thread Olaf Hering
How should libxl__initiate_device_generic_remove deal with devices which have no frontend driver? Right now it moves "state" from either XenbusStateInitialising or XenbusStateInitWait to XenbusStateClosing. Then it expects the backend to move "state" to XenbusStateClosed. This will never happen, at

Re: [Xen-devel] [PATCH v2] build: specify minimum versions of make and binutils

2016-02-11 Thread Jan Beulich
>>> On 10.02.16 at 21:36, wrote: > On 28/01/2016 13:47, Jan Beulich wrote: > On 28.01.16 at 14:02, wrote: >>> On Thu, 2016-01-28 at 05:49 -0700, Jan Beulich wrote: >>> On 28.01.16 at 00:12, wrote: > To help people avoid having to figure out what versions of make and > binutils ne

Re: [Xen-devel] [PATCH 8/8] x86/efi: Generate uefi_call_wrapper() when compiling with clang

2016-02-11 Thread Jan Beulich
>>> On 10.02.16 at 20:11, wrote: > On 10/02/16 13:41, Andrew Cooper wrote: >> On 10/02/16 13:31, Jan Beulich wrote: >> On 09.02.16 at 21:01, wrote: Signed-off-by: Andrew Cooper --- CC: Jan Beulich What is the GCC version check supposed to be achieving here? GCC has

Re: [Xen-devel] [PATCH 1/3] x86: avoid flush IPI when possible

2016-02-11 Thread Jan Beulich
>>> On 10.02.16 at 18:51, wrote: > On 10/02/16 15:37, Jan Beulich wrote: > On 10.02.16 at 16:00, wrote: >>> On 10/02/16 12:56, Jan Beulich wrote: Since CLFLUSH, other than WBINVD, is a coherency domain wide flush, >>> I can't parse this sentence. >> Should have been "..., is a cache cohe

[Xen-devel] [PATCH v2 2/2] x86/traps: Dump instruction stream in show_execution_state()

2016-02-11 Thread Andrew Cooper
For first pass triage of crashes, it is useful to have the instruction stream present, especially now that Xen binary patches itself. A sample output now looks like: (XEN) [ Xen-4.7-unstable x86_64 debug=y Not tainted ] (XEN) CPU:0 (XEN) RIP:e008:[] default_idle+0x76/0x7b (XEN)

[Xen-devel] [PATCH v2 1/2] x86/traps: Prevent interleaving of concurrent cpu state dumps

2016-02-11 Thread Andrew Cooper
If two cpus enter show_execution_state() concurrently, the resulting console output interleaved, and of no help debugging the situation further. As calls to these locations are rare and usually important, it is acceptable to serialise them. These codepaths are also on the terminal error paths, so

Re: [Xen-devel] [PATCH v2] build: specify minimum versions of make and binutils

2016-02-11 Thread Ian Campbell
On Thu, 2016-02-11 at 03:42 -0700, Jan Beulich wrote: > I think it is quite relevant which version is to be picked: Anything > older no-one could legitimately report issues against (and I would > very much like to continue to be able to submit build fixes I find > necessary on those two old boxes I

[Xen-devel] HVMlite ABI specification DRAFT C + implementation outline

2016-02-11 Thread Roger Pau Monné
Hello, I've Cced a bunch of people who have expressed interest in the HVMlite design/implementation, both from a Xen or OS point of view. If you would like to be removed, please say so and I will remove you in further iterations. The same applies if you want to be added to the Cc. This is an i

Re: [Xen-devel] [PATCH v2 2/2] x86/traps: Dump instruction stream in show_execution_state()

2016-02-11 Thread Jan Beulich
>>> On 11.02.16 at 11:52, wrote: > v2: Deal with %rip wrapping. In such a case, insert dashes into printed > line. I don't think this deals with wrapping now, since ... > --- a/xen/arch/x86/traps.c > +++ b/xen/arch/x86/traps.c > @@ -114,6 +114,56 @@ boolean_param("ler", opt_ler); > #define st

Re: [Xen-devel] [PATCH 1/2] xenmon: close qos_fd when finished with it in alloc_qos_data

2016-02-11 Thread Wei Liu
On Wed, Feb 10, 2016 at 04:26:24PM +, Ian Campbell wrote: > Otherwise the fd is leaked. NB the mmap'd memory in the global > cpu_qos_data[n] is not affected by closing the underlying fd. > > Compile tested only. > > CID: 1055930 > > Signed-off-by: Ian Campbell Acked-by: Wei Liu > --- >

Re: [Xen-devel] [PATCH 2/2] xenmon: initialise dummy array

2016-02-11 Thread Wei Liu
On Wed, Feb 10, 2016 at 04:26:25PM +, Ian Campbell wrote: > This is just used to expand the shared backing file to the expected > size (whether this is actually necessary I'm not sure). Rather than > leaking some small amount of the processes' heap set the array to > zeroes. > > While at it ad

Re: [Xen-devel] [PATCH] loadpolicy: only close polFd if it is valid

2016-02-11 Thread Wei Liu
On Wed, Feb 10, 2016 at 04:32:39PM +, Ian Campbell wrote: > It can be -1 at this point. > > CID 1055562 > Signed-off-by: Ian Campbell Acked-by: Wei Liu > --- > tools/flask/utils/loadpolicy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/flask/utils/loadpo

Re: [Xen-devel] [PATCH v2] build: specify minimum versions of make and binutils

2016-02-11 Thread Jan Beulich
>>> On 11.02.16 at 11:59, wrote: > On Thu, 2016-02-11 at 03:42 -0700, Jan Beulich wrote: >> I think it is quite relevant which version is to be picked: Anything >> older no-one could legitimately report issues against (and I would >> very much like to continue to be able to submit build fixes I fi

Re: [Xen-devel] [PATCH] init-xenstore-domain: cleanup all resources on a single exit path

2016-02-11 Thread Wei Liu
On Wed, Feb 10, 2016 at 04:56:22PM +, Ian Campbell wrote: > Previously xs_fd would be left open, which is CID 1055993 (previously > partially fixed by 3bca826aae5eb). > > Instead arrange for both success and error cases to cleanup everything > on a single exit path instead of doing partial cle

[Xen-devel] [distros-debian-wheezy test] 38737: all pass

2016-02-11 Thread Platform Team regression test user
flight 38737 distros-debian-wheezy real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/38737/ Perfect :-) All tests in this flight passed baseline version: flight 38725 jobs: build-amd64 pass build-armhf

Re: [Xen-devel] HVMlite ABI specification DRAFT C + implementation outline

2016-02-11 Thread Jan Beulich
>>> On 11.02.16 at 12:10, wrote: > * PCI Express MMCFG: no MMCFG areas will be mapped by default into the guest >memory map. In order to have these areas mapped the hardware domain >must use the PHYSDEVOP_pci_mmcfg_reserved hypercall. On successful return >from this hypercall the requ

Re: [Xen-devel] [PATCH v2] tools: libxl: make it illegal to pass libxl__realloc(gc) a non-gc ptr

2016-02-11 Thread Wei Liu
On Thu, Feb 11, 2016 at 09:23:54AM +, Ian Campbell wrote: > That is, if gc is not NOGC and ptr is not NULL then ptr must be > associated gc. > "associated with gc"? Anyway, I get the idea. > Currently in this case the new_ptr would not be registered with any > gc, which Coverity rightly poi

[Xen-devel] [PATCH 2/3] xen: sched: add wakeup flags to the scheduler interface

2016-02-11 Thread Dario Faggioli
For making it possible to pass to the specific scheduler code information about the nature of the wakeup, and let it act accordingly, if necessary. For now, this will only be useful to Credit1, that needs to differentiate between 'regular' wakeups (happening, for instance, because an I/O event), a

[Xen-devel] [PATCH 1/3] xen: credit1: trace vCPU boost/unboost

2016-02-11 Thread Dario Faggioli
Add tracepoints and a performance counter for boosting and unboosting in Credit1. Note that they (the trace points) do not cover the case of the idle vCPU being boosted to run a tasklet, as there already is TRC_CSCHED_SCHED_TASKLET for that. Signed-off-by: Dario Faggioli --- Cc: George Dunlap

[Xen-devel] [PATCH 3/3] xen: credit1: avoid boosting vCPUs being "just" migrated

2016-02-11 Thread Dario Faggioli
Moving a vCPU to a different pCPU means blocking it and waking it up (on the new pCPU). Credit1 grants BOOST priority to vCPUs that wakes up, with the aim of improving I/O latency. The end result is that vCPUs get boosted when migrating, which shouldn't happen. For instance, this causes scheduling

[Xen-devel] [PATCH 0/3] xen: sched: Credit1 shouldn't boost vcpus being migrated.

2016-02-11 Thread Dario Faggioli
Hi, This series aims at stopping the Credit1 scheduler from granting BOOST priority to vcpus that are migrated to a new pcpu. In fact, BOOST is for vcpus that are waking up after, e.g., having received an event, to, well, "boost" their wakeup latency and get them quickly to handle the event itsel

[Xen-devel] [xen-unstable baseline-only test] 38736: tolerable FAIL

2016-02-11 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 38736 xen-unstable real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/38736/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): build-amd64-rumpuserxen 6 xen-build

[Xen-devel] [PATCH v2] tools: probe for existence of qemu-xen stderr trace backend.

2016-02-11 Thread Ian Campbell
QEMU upstream commit ed7f5f1d8db0 ("trace: convert stderr backend to log") renamed the "stderr" trace backend to "log", which breaks the xen build when pointed at a QEMU tree after that point: ./configure of QEMU fail with: "ERROR: invalid trace backends Please choose supported trace backe

Re: [Xen-devel] [PATCH v2 2/2] x86/traps: Dump instruction stream in show_execution_state()

2016-02-11 Thread Andrew Cooper
On 11/02/16 11:16, Jan Beulich wrote: On 11.02.16 at 11:52, wrote: >> v2: Deal with %rip wrapping. In such a case, insert dashes into printed >> line. > I don't think this deals with wrapping now, since ... > >> --- a/xen/arch/x86/traps.c >> +++ b/xen/arch/x86/traps.c >> @@ -114,6 +114,56 @

Re: [Xen-devel] [PATCH v2 1/6] xen: factor out p2m list allocation into separate function

2016-02-11 Thread Daniel Kiper
On Thu, Feb 11, 2016 at 08:53:21AM +0100, Juergen Gross wrote: > Do the p2m list allocation of the to be loaded kernel in a separate > function. This will allow doing the p2m list allocation at different > times of the boot preparations depending on the features the kernel > is supporting. > > Whil

[Xen-devel] [PATCH v3 1/2] build: specify minimum versions of gcc and binutils

2016-02-11 Thread Ian Campbell
From: Doug Goldstein To help people avoid having to figure out what versions of gcc and binutils need to be supported document them explicitly. Signed-off-by: Doug Goldstein Signed-off-by: Ian Campbell --- v3: [ijc] Updated version for binutils and include gcc (separately for x86 and ARM in bo

[Xen-devel] [PATCH v3 2/2] build: specify minimum versions of make

2016-02-11 Thread Ian Campbell
From: Doug Goldstein To help people avoid having to figure out what versions of make needs to be supported document it explicitly. Signed-off-by: Doug Goldstein Signed-off-by: Ian Campbell --- v3: [ijc] Put make into a separate patch to reduce risk to gcc+binutils patch #1 (since I'm not sure

Re: [Xen-devel] [PATCH v2 2/6] xen: factor out allocation of special pages into separate function

2016-02-11 Thread Daniel Kiper
On Thu, Feb 11, 2016 at 08:53:22AM +0100, Juergen Gross wrote: > Do the allocation of special pages (start info, console and xenbus > ring buffers) in a separate function. This will allow to do the > allocation at different times of the boot preparations depending on > the features the kernel is su

Re: [Xen-devel] [PATCH v2 3/6] xen: factor out allocation of page tables into separate function

2016-02-11 Thread Daniel Kiper
On Thu, Feb 11, 2016 at 08:53:23AM +0100, Juergen Gross wrote: > Do the allocation of page tables in a separate function. This will > allow to do the allocation at different times of the boot preparations > depending on the features the kernel is supporting. > > Signed-off-by: Juergen Gross > ---

Re: [Xen-devel] [PATCH v3 2/2] build: specify minimum versions of make

2016-02-11 Thread Andrew Cooper
On 11/02/16 12:23, Ian Campbell wrote: > From: Doug Goldstein > > To help people avoid having to figure out what versions of make > needs to be supported document it explicitly. > > Signed-off-by: Doug Goldstein > Signed-off-by: Ian Campbell Reviewed-by: Andrew Cooper In particular, I have ha

Re: [Xen-devel] [PATCH v3 1/2] build: specify minimum versions of gcc and binutils

2016-02-11 Thread Andrew Cooper
On 11/02/16 12:23, Ian Campbell wrote: > From: Doug Goldstein > > To help people avoid having to figure out what versions of gcc and > binutils need to be supported document them explicitly. > > Signed-off-by: Doug Goldstein > Signed-off-by: Ian Campbell I would be tempted to abbreviate this to

Re: [Xen-devel] [PATCH v2 4/6] xen: add capability to load initrd outside of initial mapping

2016-02-11 Thread Daniel Kiper
On Thu, Feb 11, 2016 at 08:53:24AM +0100, Juergen Gross wrote: > Modern pvops linux kernels support an initrd not covered by the initial > mapping. This capability is flagged by an elf-note. > > In case the elf-note is set by the kernel don't place the initrd into > the initial mapping. This will a

Re: [Xen-devel] [PATCH v2 1/6] xen: factor out p2m list allocation into separate function

2016-02-11 Thread Juergen Gross
On 11/02/16 13:19, Daniel Kiper wrote: > On Thu, Feb 11, 2016 at 08:53:21AM +0100, Juergen Gross wrote: >> Do the p2m list allocation of the to be loaded kernel in a separate >> function. This will allow doing the p2m list allocation at different >> times of the boot preparations depending on the f

Re: [Xen-devel] [PATCH v2 2/6] xen: factor out allocation of special pages into separate function

2016-02-11 Thread Juergen Gross
On 11/02/16 13:21, Daniel Kiper wrote: > On Thu, Feb 11, 2016 at 08:53:22AM +0100, Juergen Gross wrote: >> Do the allocation of special pages (start info, console and xenbus >> ring buffers) in a separate function. This will allow to do the >> allocation at different times of the boot preparations

Re: [Xen-devel] [PATCH v2 5/6] xen: modify page table construction

2016-02-11 Thread Daniel Kiper
On Thu, Feb 11, 2016 at 08:53:25AM +0100, Juergen Gross wrote: > Modify the page table construction to allow multiple virtual regions > to be mapped. This is done as preparation for removing the p2m list > from the initial kernel mapping in order to support huge pv domains. > > This allows a cleane

Re: [Xen-devel] [PATCH v2 2/2] x86/traps: Dump instruction stream in show_execution_state()

2016-02-11 Thread Jan Beulich
>>> On 11.02.16 at 13:12, wrote: > On 11/02/16 11:16, Jan Beulich wrote: > On 11.02.16 at 11:52, wrote: >>> --- a/xen/arch/x86/traps.c >>> +++ b/xen/arch/x86/traps.c >>> @@ -114,6 +114,56 @@ boolean_param("ler", opt_ler); >>> #define stack_words_per_line 4 >>> #define ESP_BEFORE_EXCEPTION(r

[Xen-devel] [libvirt test] 81645: regressions - FAIL

2016-02-11 Thread osstest service owner
flight 81645 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/81645/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt-qcow2 4 host-ping-check-native fail REGR. vs. 80121 Tests which did not succe

Re: [Xen-devel] [PATCH v2 3/6] xen: factor out allocation of page tables into separate function

2016-02-11 Thread Juergen Gross
On 11/02/16 13:27, Daniel Kiper wrote: > On Thu, Feb 11, 2016 at 08:53:23AM +0100, Juergen Gross wrote: >> Do the allocation of page tables in a separate function. This will >> allow to do the allocation at different times of the boot preparations >> depending on the features the kernel is supporti

Re: [Xen-devel] [PATCH v2] tools: probe for existence of qemu-xen stderr trace backend.

2016-02-11 Thread Paul Durrant
> -Original Message- > From: Ian Campbell [mailto:ian.campb...@citrix.com] > Sent: 11 February 2016 12:11 > To: Ian Jackson; Wei Liu; xen-devel@lists.xen.org; Stefano Stabellini > Cc: Ian Campbell; Paul Durrant; Anthony Perard > Subject: [PATCH v2] tools: probe for existence of qemu-xen std

Re: [Xen-devel] [PATCH v3 1/2] build: specify minimum versions of gcc and binutils

2016-02-11 Thread Ian Campbell
On Thu, 2016-02-11 at 12:31 +, Andrew Cooper wrote: > On 11/02/16 12:23, Ian Campbell wrote: > > From: Doug Goldstein > > > > To help people avoid having to figure out what versions of gcc and > > binutils need to be supported document them explicitly. > > > > Signed-off-by: Doug Goldstein

Re: [Xen-devel] [PATCH 2/3] xen: sched: add wakeup flags to the scheduler interface

2016-02-11 Thread Jan Beulich
>>> On 11.02.16 at 12:38, wrote: > --- a/xen/include/xen/sched-if.h > +++ b/xen/include/xen/sched-if.h > @@ -144,7 +144,8 @@ struct scheduler { > void (*remove_vcpu)(const struct scheduler *, struct vcpu *); > > void (*sleep) (const struct scheduler *, stru

Re: [Xen-devel] [PATCH 3/3] xen: credit1: avoid boosting vCPUs being "just" migrated

2016-02-11 Thread Jan Beulich
>>> On 11.02.16 at 12:39, wrote: > --- a/xen/common/sched_credit.c > +++ b/xen/common/sched_credit.c > @@ -1022,11 +1022,14 @@ csched_vcpu_wake(const struct scheduler *ops, struct > vcpu *vc, unsigned wf) > * more CPU resource intensive VCPUs without impacting overall > * system fair

Re: [Xen-devel] [PATCH v3 1/2] build: specify minimum versions of gcc and binutils

2016-02-11 Thread Jan Beulich
>>> On 11.02.16 at 14:21, wrote: > On Thu, 2016-02-11 at 12:31 +, Andrew Cooper wrote: >> On 11/02/16 12:23, Ian Campbell wrote: >> > From: Doug Goldstein >> > >> > To help people avoid having to figure out what versions of gcc and >> > binutils need to be supported document them explicitly.

Re: [Xen-devel] [PATCH v2 2/2] x86/traps: Dump instruction stream in show_execution_state()

2016-02-11 Thread Andrew Cooper
On 11/02/16 12:52, Jan Beulich wrote: On 11.02.16 at 13:12, wrote: >> On 11/02/16 11:16, Jan Beulich wrote: >> On 11.02.16 at 11:52, wrote: --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -114,6 +114,56 @@ boolean_param("ler", opt_ler); #define stack_words_p

[Xen-devel] [linux-4.1 test] 81641: regressions - FAIL

2016-02-11 Thread osstest service owner
flight 81641 linux-4.1 real [real] http://logs.test-lab.xenproject.org/osstest/logs/81641/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-pvops3 host-install(3) broken in 81339 REGR. vs. 66399 build-amd64-rumpuserxen

Re: [Xen-devel] [PATCH v2 2/2] x86/traps: Dump instruction stream in show_execution_state()

2016-02-11 Thread Jan Beulich
>>> On 11.02.16 at 14:41, wrote: > Wherever %rip is pointing, the code under %rip is directly relevant to > the exact values of the registers and stack dump printed. > > It will be obvious from the numeric value of %rip whether it is bad > (also, whether symbol information is found), and making i

Re: [Xen-devel] [PATCH v2 4/6] xen: add capability to load initrd outside of initial mapping

2016-02-11 Thread Juergen Gross
On 11/02/16 13:33, Daniel Kiper wrote: > On Thu, Feb 11, 2016 at 08:53:24AM +0100, Juergen Gross wrote: >> Modern pvops linux kernels support an initrd not covered by the initial >> mapping. This capability is flagged by an elf-note. >> >> In case the elf-note is set by the kernel don't place the i

[Xen-devel] [PATCH v3 2/2] x86/traps: Dump instruction stream in show_execution_state()

2016-02-11 Thread Andrew Cooper
For first pass triage of crashes, it is useful to have the instruction stream present, especially now that Xen binary patches itself. A sample output now looks like: (XEN) [ Xen-4.7-unstable x86_64 debug=y Not tainted ] (XEN) CPU:0 (XEN) RIP:e008:[] default_idle+0x76/0x7b (XEN)

Re: [Xen-devel] [PATCH v2 5/6] xen: modify page table construction

2016-02-11 Thread Juergen Gross
On 11/02/16 13:47, Daniel Kiper wrote: > On Thu, Feb 11, 2016 at 08:53:25AM +0100, Juergen Gross wrote: >> Modify the page table construction to allow multiple virtual regions >> to be mapped. This is done as preparation for removing the p2m list >> from the initial kernel mapping in order to suppo

Re: [Xen-devel] [PATCH v7 3/5] libxl: add support for vscsi

2016-02-11 Thread Olaf Hering
On Fri, Feb 05, Olaf Hering wrote: > +static int libxl__vscsictrl_next_vscsidev_id(libxl__gc *gc, uint32_t domid, > + libxl_device_vscsictrl *vscsi, > + libxl_devid *vscsidev_id) > +{ > +path = GCSPRINTF("

Re: [Xen-devel] [PATCH v7 3/5] libxl: add support for vscsi

2016-02-11 Thread Olaf Hering
On Thu, Feb 11, Olaf Hering wrote: > I'm in the process to move the counter to the backend path. ... which fails due to libxl__device_exists(). So, back to /libxl Olaf ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

[Xen-devel] [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check

2016-02-11 Thread Boris Ostrovsky
Commit a18a0f6850d4 ("x86, microcode: Don't initialize microcode code on paravirt") added a paravirt test in microcode_init(), primarily to avoid making mc_bp_resume()->load_ucode_ap()->check_loader_disabled_ap() calls On 32-bit kernels this callchain ends up using __pa_nodebug() macro which is inv

Re: [Xen-devel] [PATCH v2] libxc: fix leak in xc_offline_page error path

2016-02-11 Thread Ian Campbell
On Wed, 2016-02-10 at 11:51 +, Ian Jackson wrote: > Harmandeep Kaur writes ("[PATCH v2] libxc: fix leak in xc_offline_page > error path"): > > Avoid leaking the mapping of the m2p in one of the possible failure > > cases. > > > > Coverity CID 1351225 > > > > Signed-off-by: Harmandeep Kaur >

Re: [Xen-devel] [PATCH] init-xenstore-domain: cleanup all resources on a single exit path

2016-02-11 Thread Ian Campbell
On Thu, 2016-02-11 at 11:27 +, Wei Liu wrote: > On Wed, Feb 10, 2016 at 04:56:22PM +, Ian Campbell wrote: > > Previously xs_fd would be left open, which is CID 1055993 (previously > > partially fixed by 3bca826aae5eb). > > > > Instead arrange for both success and error cases to cleanup eve

[Xen-devel] [PATCH v8 2/5] docs: add vscsi to xenstore-paths.markdown

2016-02-11 Thread Olaf Hering
Signed-off-by: Olaf Hering Acked-by: Ian Campbell Cc: Ian Campbell Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan --- docs/misc/xenstore-paths.markdown | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/misc/xenstore-paths.markdown b/docs/misc/xenstore-pat

[Xen-devel] [PATCH v8 5/5] Scripts to create and delete xen-scsiback nodes in Linux target framework

2016-02-11 Thread Olaf Hering
Just to make them public, not meant for merging: The scripts used during development to create a bunch of SCSI devices in dom0 using the Linux target framework. targetcli3 and rtslib3 is used. A patch is required for python-rtslib: http://article.gmane.org/gmane.linux.scsi.target.devel/8146 Signe

[Xen-devel] [PATCH v8 1/5] vscsiif.h: fix WWN notation for p-dev property

2016-02-11 Thread Olaf Hering
The pvops kernel expects either "naa.WWN:LUN" or "h:c:t:l" in the p-dev property. Add the missing :LUN part to the comment. Signed-off-by: Olaf Hering Acked-by: Ian Campbell Cc: Ian Campbell Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan --- xen/include/public/io/vscsiif.h

[Xen-devel] [PATCH v8 3/5] libxl: add support for vscsi

2016-02-11 Thread Olaf Hering
Port pvscsi support from xend to libxl: vscsi=['pdev,vdev{,options}'] xl scsi-attach xl scsi-detach xl scsi-list Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- docs/man/xl.cfg.pod.5| 55 +++ docs/man/xl.pod.1

[Xen-devel] [PATCH v8 0/5] libbxl: add support for pvscsi, iteration 8

2016-02-11 Thread Olaf Hering
Port vscsi=[] and scsi-{attach,detach,list} commands from xend to libxl. libvirt uses its existing SCSI support: http://lists.xenproject.org/archives/html/xen-devel/2015-04/msg02963.html targetcli/rtslib has to be aware of xen-scsiback (upstream unresponsive): http://article.gmane.org/gmane.linux

[Xen-devel] [PATCH v8 4/5] vscsiif.h: add some notes about xenstore layout

2016-02-11 Thread Olaf Hering
Signed-off-by: Olaf Hering Acked-by: Ian Campbell Cc: Ian Campbell Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan --- xen/include/public/io/vscsiif.h | 68 + 1 file changed, 68 insertions(+) diff --git a/xen/include/public/io/vscsiif.

Re: [Xen-devel] [PATCH v2] tools: libxl: make it illegal to pass libxl__realloc(gc) a non-gc ptr

2016-02-11 Thread Ian Campbell
On Thu, 2016-02-11 at 11:37 +, Wei Liu wrote: > On Thu, Feb 11, 2016 at 09:23:54AM +, Ian Campbell wrote: > > That is, if gc is not NOGC and ptr is not NULL then ptr must be > > associated gc. > > > > "associated with gc"? > > Anyway, I get the idea. Yeah, apparently I was having langua

[Xen-devel] [PATCH] tools/console: correct make dependencies for _paths.h

2016-02-11 Thread Olaf Hering
Correct dependencies for _paths.h to avoid build failure with make -j. Only main.c requires _paths.h. This fixes commit 8398ec70 ("xenconsole: Ensure exclusive access to console using locks") Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- S

Re: [Xen-devel] [PATCH] public/io/netif.h: fix typos

2016-02-11 Thread Ian Campbell
On Thu, 2016-02-11 at 09:53 +, Ian Campbell wrote: > On Wed, 2016-02-10 at 16:49 +, Paul Durrant wrote: > > Unfortunately my patch 162a81ab "document control ring and toeplitz > > hashing" contained a couple of typos. This patch fixes them. > > > > Signed-off-by: Paul Durrant > > Cc: Ian

Re: [Xen-devel] [PATCH v3 1/2] build: specify minimum versions of gcc and binutils

2016-02-11 Thread Ian Campbell
On Thu, 2016-02-11 at 06:32 -0700, Jan Beulich wrote: > > > > On 11.02.16 at 14:21, wrote: > > On Thu, 2016-02-11 at 12:31 +, Andrew Cooper wrote: > > > On 11/02/16 12:23, Ian Campbell wrote: > > > > From: Doug Goldstein > > > > > > > > To help people avoid having to figure out what versions

Re: [Xen-devel] [PATCH v2 3/7] xen/vm-events: Move monitor_domctl to common-side.

2016-02-11 Thread Tamas K Lengyel
> > * the #ifdefs make it possible for that code to be put in common => that > makes it *clear* that those code parts are NOT > architecture specific and their implementation can be safely used for all > architectures. > The current practice has been to put empty static inline functions into archi

Re: [Xen-devel] [PATCH 1/2] xenmon: close qos_fd when finished with it in alloc_qos_data

2016-02-11 Thread Ian Campbell
On Thu, 2016-02-11 at 11:18 +, Wei Liu wrote: > On Wed, Feb 10, 2016 at 04:26:24PM +, Ian Campbell wrote: > > Otherwise the fd is leaked. NB the mmap'd memory in the global > > cpu_qos_data[n] is not affected by closing the underlying fd. > > > > Compile tested only. > > > > CID: 1055930

Re: [Xen-devel] [PATCH v4 01/17] Xen: ACPI: Hide UART used by Xen

2016-02-11 Thread Stefano Stabellini
On Wed, 10 Feb 2016, Rafael J. Wysocki wrote: > On Tuesday, February 09, 2016 11:19:02 AM Stefano Stabellini wrote: > > On Mon, 8 Feb 2016, Rafael J. Wysocki wrote: > > > On Monday, February 08, 2016 10:57:01 AM Stefano Stabellini wrote: > > > > On Sat, 6 Feb 2016, Rafael J. Wysocki wrote: > > > >

Re: [Xen-devel] [PATCH] tools/console: correct make dependencies for _paths.h

2016-02-11 Thread Ian Campbell
On Thu, 2016-02-11 at 15:38 +, Olaf Hering wrote: > Correct dependencies for _paths.h to avoid build failure with make -j. > Only main.c requires _paths.h. This fixes commit 8398ec70 ("xenconsole: > Ensure exclusive access to console using locks") > > Signed-off-by: Olaf Hering > Cc: Ian Jack

Re: [Xen-devel] [PATCH v2] tools: probe for existence of qemu-xen stderr trace backend.

2016-02-11 Thread Stefano Stabellini
On Thu, 11 Feb 2016, Ian Campbell wrote: > QEMU upstream commit ed7f5f1d8db0 ("trace: convert stderr backend to > log") renamed the "stderr" trace backend to "log", which breaks the > xen build when pointed at a QEMU tree after that point: > > ./configure of QEMU fail with: > "ERROR: invalid trace

[Xen-devel] [BUG] gdbsx crashes Xen

2016-02-11 Thread Carl Patenaude Poulin
Hey folks, With gdbsx running, Running `gdb -ex "target remote localhost:" crashes Xen and reboots the server. Example session: http://i.imgur.com/UXh3RCy.png Minimal reproduction: https://github.com/lilred/xen-crash-repro Top line of `xl dmesg`: Xen version 4.6.0 (r...@cs.mcgill.ca) (

Re: [Xen-devel] [PATCH v2] tools: probe for existence of qemu-xen stderr trace backend.

2016-02-11 Thread Wei Liu
On Thu, Feb 11, 2016 at 12:11:21PM +, Ian Campbell wrote: > QEMU upstream commit ed7f5f1d8db0 ("trace: convert stderr backend to > log") renamed the "stderr" trace backend to "log", which breaks the > xen build when pointed at a QEMU tree after that point: > > ./configure of QEMU fail with: >

Re: [Xen-devel] [BUG] gdbsx crashes Xen

2016-02-11 Thread Andrew Cooper
On 11/02/16 16:25, Carl Patenaude Poulin wrote: > Hey folks, > > With gdbsx running, Running `gdb -ex "target remote localhost:" > crashes Xen and reboots the server. > > Example session: http://i.imgur.com/UXh3RCy.png > > Minimal reproduction: https://github.com/lilred/xen-crash-repro > > Top

Re: [Xen-devel] [PATCH] tools/console: correct make dependencies for _paths.h

2016-02-11 Thread Ian Campbell
On Thu, 2016-02-11 at 16:03 +, Ian Campbell wrote: > On Thu, 2016-02-11 at 15:38 +, Olaf Hering wrote: > > Correct dependencies for _paths.h to avoid build failure with make -j. > > Only main.c requires _paths.h. This fixes commit 8398ec70 ("xenconsole: > > Ensure exclusive access to consol

Re: [Xen-devel] [PATCH v2 1/6] xen: factor out p2m list allocation into separate function

2016-02-11 Thread Daniel Kiper
On Thu, Feb 11, 2016 at 01:38:10PM +0100, Juergen Gross wrote: > On 11/02/16 13:19, Daniel Kiper wrote: > > On Thu, Feb 11, 2016 at 08:53:21AM +0100, Juergen Gross wrote: > >> Do the p2m list allocation of the to be loaded kernel in a separate > >> function. This will allow doing the p2m list alloc

Re: [Xen-devel] [PATCH v2] tools: probe for existence of qemu-xen stderr trace backend.

2016-02-11 Thread Ian Campbell
On Thu, 2016-02-11 at 16:30 +, Wei Liu wrote: > On Thu, Feb 11, 2016 at 12:11:21PM +, Ian Campbell wrote: > > QEMU upstream commit ed7f5f1d8db0 ("trace: convert stderr backend to > > log") renamed the "stderr" trace backend to "log", which breaks the > > xen build when pointed at a QEMU tre

Re: [Xen-devel] [PATCH v2 3/6] xen: factor out allocation of page tables into separate function

2016-02-11 Thread Daniel Kiper
On Thu, Feb 11, 2016 at 01:53:51PM +0100, Juergen Gross wrote: > On 11/02/16 13:27, Daniel Kiper wrote: > > On Thu, Feb 11, 2016 at 08:53:23AM +0100, Juergen Gross wrote: > >> Do the allocation of page tables in a separate function. This will > >> allow to do the allocation at different times of th

Re: [Xen-devel] [PATCH v2 4/6] xen: add capability to load initrd outside of initial mapping

2016-02-11 Thread Daniel Kiper
On Thu, Feb 11, 2016 at 03:13:40PM +0100, Juergen Gross wrote: > On 11/02/16 13:33, Daniel Kiper wrote: > > On Thu, Feb 11, 2016 at 08:53:24AM +0100, Juergen Gross wrote: > >> Modern pvops linux kernels support an initrd not covered by the initial > >> mapping. This capability is flagged by an elf-

Re: [Xen-devel] [PATCH v3] travis: add initial Travis CI script to do builds

2016-02-11 Thread Doug Goldstein
On 2/9/16 6:33 PM, Dario Faggioli wrote: > On Tue, 2016-02-09 at 17:09 +, Andrew Cooper wrote: >> On 08/02/16 02:45, Doug Goldstein wrote: >>> This is just suppose to do a simple compile test on Travis CI. >>> Currently >>> due to linux86 (bcc/bin86/dev86) not being whitelisted the tools >>> ca

Re: [Xen-devel] [PATCH 3/3] xen: credit1: avoid boosting vCPUs being "just" migrated

2016-02-11 Thread Dario Faggioli
On Thu, 2016-02-11 at 06:30 -0700, Jan Beulich wrote: > > > > On 11.02.16 at 12:39, wrote: > > --- a/xen/common/sched_credit.c > > +++ b/xen/common/sched_credit.c > > @@ -1022,11 +1022,14 @@ csched_vcpu_wake(const struct scheduler > > *ops, struct vcpu *vc, unsigned wf) > >   * more CPU resour

Re: [Xen-devel] [PATCH 2/3] xen: sched: add wakeup flags to the scheduler interface

2016-02-11 Thread Dario Faggioli
On Thu, 2016-02-11 at 06:24 -0700, Jan Beulich wrote: > > > > On 11.02.16 at 12:38, wrote: > > --- a/xen/include/xen/sched-if.h > > +++ b/xen/include/xen/sched-if.h > > @@ -144,7 +144,8 @@ struct scheduler { > >  void (*remove_vcpu)(const struct scheduler *, > > struct vcpu *); > >

Re: [Xen-devel] [PATCH v3] travis: add initial Travis CI script to do builds

2016-02-11 Thread Doug Goldstein
On 2/7/16 8:45 PM, Doug Goldstein wrote: > This is just suppose to do a simple compile test on Travis CI. Currently > due to linux86 (bcc/bin86/dev86) not being whitelisted the tools cannot > be built. > > Signed-off-by: Doug Goldstein ping? -- Doug Goldstein signature.asc Description: Open

Re: [Xen-devel] [PATCH v2 5/6] xen: modify page table construction

2016-02-11 Thread Daniel Kiper
On Thu, Feb 11, 2016 at 03:35:45PM +0100, Juergen Gross wrote: > On 11/02/16 13:47, Daniel Kiper wrote: > > On Thu, Feb 11, 2016 at 08:53:25AM +0100, Juergen Gross wrote: > >> Modify the page table construction to allow multiple virtual regions > >> to be mapped. This is done as preparation for rem

[Xen-devel] [xen-unstable-smoke test] 81996: regressions - trouble: blocked/broken/pass

2016-02-11 Thread osstest service owner
flight 81996 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/81996/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf 4 host-build-prep fail REGR. vs. 81826 Tests which di

  1   2   >