On Wed, Feb 10, 2016 at 04:26:25PM +0000, Ian Campbell wrote:
> This is just used to expand the shared backing file to the expected
> size (whether this is actually necessary I'm not sure). Rather than
> leaking some small amount of the processes' heap set the array to
> zeroes.
>
> While at it add a check that the malloc succeeded before using the
> result.
>
> Compile tested only.
>
> CID: 1056095 (use of uninitialised data)
>
> Signed-off-by: Ian Campbell <ian.campb...@citrix.com>
Acked-by: Wei Liu <wei.l...@citrix.com>
> ---
> tools/xenmon/xenbaked.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/tools/xenmon/xenbaked.c b/tools/xenmon/xenbaked.c
> index 782f0c1..3d9e0ed 100644
> --- a/tools/xenmon/xenbaked.c
> +++ b/tools/xenmon/xenbaked.c
> @@ -663,6 +663,11 @@ static void alloc_qos_data(int ncpu)
> }
> pgsize = getpagesize();
> dummy = malloc(pgsize);
> + if (!dummy) {
> + PERROR("malloc");
> + exit(EXIT_FAILURE);
> + }
> + memset(dummy, 0, pgsize);
>
> for (n=0; n<ncpu; n++) {
>
> --
> 2.1.4
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
