Re: [Xen-devel] Xen on ARM: Read SP_usr and SP_svc in HYP mode

2015-08-31 Thread harry
Hi, Thank you very much! I have got the answer, we can use MSR/MRS instructions to load/save these regs. Thanks and regards, Harry At 2015-08-29 00:25:17, "Julien Grall" wrote: >On 25/08/15 05:43, harry wrote: >> Hi, > >Hi, > >> Now I want to implement some functions in other hypervisor, so

Re: [Xen-devel] [xen 4.6 retrospective] [bad] Code style checking takes up too much time

2015-08-31 Thread Jan Beulich
>>> On 28.08.15 at 17:39, wrote: > What may be a bigger issue, is that older code may not fully adhere to > coding standards. The open question is then > * Whether such a tool should only run on the diff/patch Isn't that the intended / expected behavior of such a tool anyway? If so, the real pro

[Xen-devel] [PATCH V4] xen/x86: Clean up vm_event-related code in asm-x86/domain.h

2015-08-31 Thread Razvan Cojocaru
As suggested by Jan Beulich, moved struct monitor_write_data from struct arch_domain to struct arch_vcpu, as well as moving all vm_event-related data from asm-x86/domain.h to struct vm_event, and allocating it dynamically only when needed. Signed-off-by: Razvan Cojocaru Acked-by: Tamas K Lengyel

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 5

2015-08-31 Thread Jan Beulich
>>> On 29.08.15 at 03:00, wrote: > On 2015/8/28 20:55, Julien Grall wrote: >> On 28/08/15 10:45, Shannon Zhao wrote: >>> All above tables will be mapped to Dom0 non-RAM space(e.g. the space >>> after Dom0 RAM). >> >> If I understand correctly what you are saying, you plan to put the >> tables jus

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 5

2015-08-31 Thread Jan Beulich
>>> On 29.08.15 at 03:29, wrote: > On 2015/8/28 23:06, Jan Beulich wrote: > On 28.08.15 at 11:45, wrote: >>> Create only one ConfigurationTable to store VendorGuid and VendorTable. >> >> What do you mean with "Create only one ..." - there is only one. >> DYM "Create one additional Configurat

Re: [Xen-devel] [xen-4.4-testing test] 60954: regressions - FAIL

2015-08-31 Thread Jan Beulich
>>> On 29.08.15 at 22:04, wrote: > flight 60954 xen-4.4-testing real [real] > http://logs.test-lab.xenproject.org/osstest/logs/60954/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > test-amd64-amd64-xl-qemuu-ovmf-amd64 19 guest-

Re: [Xen-devel] [xen-unstable test] 60971: regressions - FAIL

2015-08-31 Thread Jan Beulich
>>> On 30.08.15 at 17:22, wrote: > flight 60971 xen-unstable real [real] > http://logs.test-lab.xenproject.org/osstest/logs/60971/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > test-amd64-i386-xl-qemut-debianhvm-amd64 18 guest

Re: [Xen-devel] [PATCH] iommu/quirk: disable shared EPT for Sandybridge and earlier processors.

2015-08-31 Thread Jan Beulich
>>> On 28.08.15 at 17:41, wrote: > --- a/docs/misc/xen-command-line.markdown > +++ b/docs/misc/xen-command-line.markdown > @@ -896,7 +896,7 @@ debug hypervisor only). > > > `sharept` > > -> Default: `true` > +> Default: `true` if newer than SandyBridge or `false` if Sandybridge or > earlier.

[Xen-devel] [xen 4.6 retrospective] Possible solution together with the comments will be helpful

2015-08-31 Thread Wu, Feng
= Issue / Observation = Sometimes the review comments are quite open, it doesn't contain a possible solution or a clear direction, so it is not clear for the contributor on how to effectively address them. At least, in Linux kernel and KVM side, if the maintainers have objection to the implementa

Re: [Xen-devel] [PATCH v2] x86: wrap kexec feature with CONFIG_KEXEC

2015-08-31 Thread Jan Beulich
>>> On 28.08.15 at 17:02, wrote: > Changed since v1: > > * Reorder kexec files to be alphabetical in the makefile > * Create macros for the kexec functions that are called when disabled Did you try using inline functions wherever possible, and that didn't work _anywhere_? > * #define the k

Re: [Xen-devel] [xen 4.6 retrospective] Kicking off a retrospective for Xen 4.6 (deadline August 28th)

2015-08-31 Thread Wu, Feng
It is very helpful if the contributors can post a design document before sending the patches to community, It has the following advantages: 1. A design document can give people a whole picture of the feature before going to code details, which Makes it easier to follow the code when doing

Re: [Xen-devel] [xen 4.6 retrospective] [Good and Bad] Posting a design document first is helpful

2015-08-31 Thread Wu, Feng
Forgot changing the subject... From: Wu, Feng Sent: Monday, August 31, 2015 4:24 PM To: xen devel Cc: community.mana...@xenproject.org; Lars Kurth; Wu, Feng Subject: RE: [Xen-devel] [xen 4.6 retrospective] Kicking off a retrospective for Xen 4.6 (deadline August 28th) It is very helpful if the c

Re: [Xen-devel] [xen 4.6 retrospective] Possible solution together with the comments will be helpful

2015-08-31 Thread Jan Beulich
>>> On 31.08.15 at 10:24, wrote: > = Issue / Observation = > Sometimes the review comments are quite open, it doesn't contain a possible > solution or a clear direction, > so it is not clear for the contributor on how to effectively address them. > At least, in Linux kernel and KVM side, if the

Re: [Xen-devel] [xen 4.6 retrospective] [Good and Bad] Posting a design document first is helpful

2015-08-31 Thread Jan Beulich
>>> On 31.08.15 at 10:26, wrote: > The whole point of having such design discussions is to get maintainer's > feedbacks as early as possible > and have everyone agree on the solution architecture up front. This approach > has worked great when all > relevant maintainers actively participate in t

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 5

2015-08-31 Thread Shannon Zhao
Hi Jan, On 2015/8/31 15:39, Jan Beulich wrote: On 29.08.15 at 03:29, wrote: >> On 2015/8/28 23:06, Jan Beulich wrote: >> On 28.08.15 at 11:45, wrote: Create only one ConfigurationTable to store VendorGuid and VendorTable. >>> >>> What do you mean with "Create only one ..." - there

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 5

2015-08-31 Thread Jan Beulich
>>> On 31.08.15 at 10:51, wrote: > On 2015/8/31 15:39, Jan Beulich wrote: > On 29.08.15 at 03:29, wrote: >>> On 2015/8/28 23:06, Jan Beulich wrote: >>> On 28.08.15 at 11:45, wrote: > Create only one ConfigurationTable to store VendorGuid and VendorTable. What do you mean wi

[Xen-devel] [qemu-upstream-unstable test] 60996: tolerable FAIL - PUSHED

2015-08-31 Thread osstest service owner
flight 60996 qemu-upstream-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/60996/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: test-amd64-amd64-i386-pvgrub 10 guest-start fail baseline untested test-armhf

[Xen-devel] [PATCH v6 00/31] Add ITS support

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K This is based on DraftG version http://xenbits.xen.org/people/ianc/vits/draftG.pdf Following major features are supported - GICv3 ITS support for arm64 platform - Only Dom0 is supported. For DomU pci passthrough feature is required. Patches shared @ https://github.com/

[Xen-devel] [PATCH v6 01/31] xen/dt: Handle correctly node with interrupt-map in dt_for_each_irq_map

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K dt_for_each_irq_map() returns error if no irq mapping is found. With this patch, Ignore error and return success Signed-off-by: Vijaya Kumar K --- v6: - Change commit message --- xen/common/device_tree.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

[Xen-devel] [PATCH v6 04/31] xen/arm: Set nr_cpu_ids to available number of cpus

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K nr_cpu_ids for arm platforms is set to NR_CPUS irrespective of number of cpus supported by platform. Signed-off-by: Vijaya Kumar K --- v6: - Updated nr_cpu_ids in setup.c instead of creating a helper function --- xen/arch/arm/setup.c |2 ++ 1 file changed, 2 inse

[Xen-devel] [PATCH v6 03/31] xen: Add log2 functionality

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K log2 helper apis are ported from linux from commit 13c07b0286d340275f2d97adf085cecda37ede37 (linux/log2.h: Fix rounddown_pow_of_two(1)) Changes made for xen are: - Only required functionality is retained - Replace fls_long with flsl Signed-off-by: Vijaya Kumar K CC: Ian

[Xen-devel] [PATCH v6 09/31] xen/arm: ITS: Add APIs to add and assign device

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K Add APIs to add devices to RB-tree, assign and remove devices to domain. Signed-off-by: Vijaya Kumar K --- v6: - Moved this patch #19 to patch #8 - Used col_map to store collection id - Use helper functions to update msi_desc members v5: - Removed its_detach_device

[Xen-devel] [PATCH v6 02/31] xen/arm: Add bitmap_find_next_zero_area helper function

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K bitmap_find_next_zero_area helper function will be used by physical ITS driver. This is imported from linux 4.2 Signed-off-by: Vijaya Kumar K Acked-by: Jan Beulich CC: Ian Campbell CC: Ian Jackson CC: Jan Beulich CC: Keir Fraser CC: Tim Deegan --- v5: Ported from Linu

[Xen-devel] [PATCH v6 08/31] xen/arm: ITS: Introduce msi_desc for LPIs

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K Define msi_desc structure for arm and introduce helper functions to access msi_desc member variables. Signed-off-by: Vijaya Kumar K --- xen/arch/arm/gic-v3-its.c | 28 xen/arch/arm/irq.c| 12 xen/include/asm-arm

[Xen-devel] [PATCH v6 10/31] xen/arm: ITS: Introduce gic_is_lpi helper function

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K Helper function gic_is_lpi() is used to find if irq is lpi or not. For GICv2 platforms this function returns number of IRQ id bits which holds only number of line irqs. For GICv3 platform it read id_bits from GICD_TYPER Signed-off-by: Vijaya Kumar K CC: Zoltan Kiss --- v6:

[Xen-devel] [PATCH v6 06/31] xen/arm: ITS: Port ITS driver to Xen

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K The linux driver is based on 4.1 with below commit id 3ad2a5f57656a14d964b673a5a0e4ab0e583c870 Only following code from Linux ITS driver is ported and compiled - LPI initialization - ITS configuration code - Physical command queue management - ITS command building Also

[Xen-devel] [PATCH v6 11/31] xen/arm: ITS: Enable compilation of physical ITS driver

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K Enable compilation of pITS driver. Signed-off-by: Vijaya Kumar K http://lists.xen.org/xen-devel

[Xen-devel] [PATCH v6 07/31] xen/arm: ITS: Add helper functions to manage its_devices

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K Helper functions to manage its devices using RB-tree are introduced in physical ITS driver. This is global list of all the devices. Signed-off-by: Vijaya Kumar K Acked-by: Ian Campbell Reviewed-by: Julien Grall --- v5: - Added assert on spinlock v4: - Remove passing of r

[Xen-devel] [PATCH v6 16/31] xen/arm: ITS: Add virtual ITS commands support

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K Add Virtual ITS command processing support to Virtual ITS driver Signed-off-by: Vijaya Kumar K --- v6: - Updated printk to use correct PRI* - Moved vits_get_max_collection and is_valid_collection helper to this patch - Added vits_domain_free() - Few more r

[Xen-devel] [PATCH v6 14/31] xen/arm: ITS: Initialize physical ITS and export lpi support

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K Initialize physical ITS if HW supports LPIs. Signed-off-by: Vijaya Kumar K CC: Zoltan Kiss --- v6: - Updated lpi_supported gic_info member for GICv2 and GICv3 - Introduced helper gic_lpi_supported() and exported v5: - Made check of its dt node availability before

[Xen-devel] [PATCH v6 05/31] xen/arm: Rename NR_IRQs and vgic_num_irqs helper function

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K NR_IRQS define signifies number of SGIs, PPIs and SPIs. With introduction of LPIs, NR_IRQs is renamed to NR_LINE_IRQs. Similarly vgic_num_irqs() is renamed as vgic_num_line_irqs(). Signed-off-by: Vijaya Kumar K --- xen/arch/arm/gic.c |2 +- xen/arch/arm/irq.c

[Xen-devel] [PATCH v6 12/31] xen/arm: Move vgic locking inside get_irq_priority callback

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K Move vgic locking inside get_irq_priority callback. LPIs does not have vgic lock for reading LPI priority. So make generic vgic code cleaner. Signed-off-by: Vijaya Kumar K --- xen/arch/arm/vgic-v2.c |4 +++- xen/arch/arm/vgic-v3.c |4 +++- xen/arch/arm/vgic.c|

[Xen-devel] [PATCH v6 13/31] xen/arm: ITS: implement hw_irq_controller for LPIs

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K Implements hw_irq_controller api's required to handle LPI's. Changed callbacks gic_host_irq_type and gic_guest_irq_type to gic_get_host_irq_type and gic_get_guest_irq_type in gic_hw_operations, which returns hw_irq_controller based on irq type (SPI or LPI). Signed-off-by: V

[Xen-devel] [PATCH v6 15/31] xen/arm: ITS: Add virtual ITS driver

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K This patch introduces virtual ITS driver with following functionality - Introduces helper functions to manage device table and ITT table in guest memory - Helper function to handle virtual ITS devices assigned to domain Signed-off-by: Vijaya Kumar K --- v6: - Export

[Xen-devel] [PATCH v6 19/31] xen/arm: ITS: Export ITS info to Virtual ITS

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K Export physical ITS information to virtual ITS driver Signed-off-by: Vijaya Kumar K --- v6: - Passed only one physical ITS info - Passed all the values as parameters - Initialize vITS only if physical ITS is available --- xen/arch/arm/gic-v3-its.c | 11 ++

[Xen-devel] [PATCH v6 18/31] xen/arm: ITS: Enable virtual ITS driver

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K Enable compilation of virtual ITS driver. Signed-off-by: Vijaya Kumar K --- xen/arch/arm/Makefile |1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 4708716..cd10d42 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/a

[Xen-devel] [PATCH v6 20/31] xen/arm: ITS: Introduce helper to get number of event IDs

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K gic_nr_event_ids() helper to read number of event IDs that ITS hardware supports. Signed-off-by: Vijaya Kumar K --- xen/arch/arm/gic-v3-its.c |7 +++ xen/arch/arm/gic-v3.c |3 +++ xen/arch/arm/gic.c|5 + xen/include/asm-arm/gic-i

[Xen-devel] [PATCH v6 31/31] xen/arm: ITS: Add pci devices in ThunderX

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K ITS initialization required for all PCI devices in ThunderX platform are done by calling from specific mapping function. This patch can be reverted once XEN PCI passthrough framework for arm64 is in available. For now all the PCI devices are assigned to Dom0 Signed-off-by:

[Xen-devel] [PATCH v6 22/31] xen/arm: ITS: Add virtual ITS availability check helper

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K Introduce vgic_is_lpi_supported() helper function to know virtual ITS availability for a domain Signed-off-by: Vijaya Kumar K --- xen/arch/arm/vgic-v2.c |5 + xen/arch/arm/vgic-v3.c |6 ++ xen/arch/arm/vgic.c|5 + xen/include/asm-arm

[Xen-devel] [PATCH v6 17/31] xen/arm: ITS: Store LPIs allocated and IRQ ID bits per domain

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K Store number of lpis and number of id bits in vgic structure Signed-off-by: Vijaya Kumar K --- xen/arch/arm/irq.c |9 + xen/arch/arm/vgic-v3-its.c |2 ++ xen/arch/arm/vgic.c | 12 xen/include/asm-arm/domain.h |3 +++

[Xen-devel] [PATCH v6 24/31] xen/arm: ITS: Add GICR register emulation

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K Emulate LPI related changes to GICR registers Signed-off-by: Vijaya Kumar K --- v6: - Moved LPI handling code to vgic-v3.c - parse LPI property table on GICR_PROPBASER update - use vgic_is_lpi_supported() v5: - Handled all sizes access to LPI configuration table

[Xen-devel] [PATCH v6 21/31] xen/arm: ITS: Add GITS registers emulation

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K Emulate GITS* registers Signed-off-by: Vijaya Kumar K --- v6: - Removed unrelated code of this patch - Used vgic_regN_{read,write} v4: - Removed GICR register emulation --- xen/arch/arm/vgic-v3-its.c| 337 - xen/include/asm-

[Xen-devel] [PATCH v6 28/31] xen/arm: ITS: Add domain specific ITS initialization

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K Call domain specific ITS initialization and introduce callback in vgic for domain free Signed-off-by: Vijaya Kumar K --- v6: - Moved vits_domain_free() out of this patch --- xen/arch/arm/vgic-v3.c | 12 +++- xen/arch/arm/vgic.c|3 +++ xen/include/

[Xen-devel] [PATCH v6 27/31] xen/arm: ITS: Route LPIs

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K Allocate and initialize irq descriptor for LPIs and route LPIs to guest For LPIs deactivation is not required. Hence GICH_LR.HW is not required to set. Signed-off-by: Vijaya Kumar K --- v6: - Moved ITS specific code from irq.c to vgic.c and introduced vgic_vcpu_raise

[Xen-devel] [PATCH v6 26/31] xen/arm: ITS: Allocate pending_lpi descriptors for LPIs

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K Allocate dynamically pending_lpi descriptors for LPIs Signed-off-by: Vijaya Kumar K --- xen/arch/arm/vgic-v3-its.c |9 + xen/arch/arm/vgic.c | 20 +--- xen/include/asm-arm/domain.h |3 +++ xen/include/asm-arm/vgic.h |4 +++

[Xen-devel] [PATCH v6 29/31] xen/arm: ITS: Map ITS translation space

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K ITS translation space contains GITS_TRANSLATER register which is written by device to raise LPI. This space needs to mapped to every domain address space for all physical ITS available,so that device can access GITS_TRANSLATER register using SMMU. Signed-off-by: Vijaya Kumar

[Xen-devel] [PATCH v6 23/31] xen/arm: ITS: Add 32-bit access to GICR_TYPER

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K Add support to read 32-bit access to GICR_TYPER register Signed-off-by: Vijaya Kumar K --- xen/arch/arm/vgic-v3.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c index 771bfd1..4caac5e 100644 --- a

[Xen-devel] [PATCH v6 25/31] xen/arm: ITS: Allocate irq descriptors for LPIs

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K Allocate dynamically irq descriptors for LPIs Signed-off-by: Vijaya Kumar K --- v6: - Add separate patch for irq_pending structures - renamed and moved is_domain_lpi to vgic - Updated __irq_to_domain --- xen/arch/arm/gic-v3-its.c |4 xen/arch/arm/irq.c

[Xen-devel] [PATCH v6 30/31] xen/arm: ITS: Generate ITS node for Dom0

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K Parse host dt and generate ITS node for Dom0. ITS node resides inside GIC node so when GIC node is encountered look for ITS node. Signed-off-by: Vijaya Kumar K --- v6: - Introduced get_its_phandle in gic_hw_ops - Removed make_hwdom_its_dt_node callback in gic_hw_ops

Re: [Xen-devel] [PATCH v6 03/31] xen: Add log2 functionality

2015-08-31 Thread Jan Beulich
>>> On 31.08.15 at 13:06, wrote: > From: Vijaya Kumar K > > log2 helper apis are ported from linux from > commit 13c07b0286d340275f2d97adf085cecda37ede37 > (linux/log2.h: Fix rounddown_pow_of_two(1)) > Changes made for xen are: > - Only required functionality is retained > - Replace fls_long

Re: [Xen-devel] [PATCH v3 02/11] tmem: Add ASSERT in obj_rb_insert for pool->rwlock lock.

2015-08-31 Thread Jan Beulich
>>> On 28.08.15 at 20:53, wrote: > Manipulating the obj-> structures requires us to hold the > pool->rwlock lock. Lets make that obvious in this function to > catch any errant users (none found, but we may in future). > > Signed-off-by: Konrad Rzeszutek Wilk > Reviewed-by: Andrew Cooper > Acked

Re: [Xen-devel] [PATCH v3 05/11] tmem: Move TMEM_CONTROL subop of tmem hypercall to sysctl.

2015-08-31 Thread Jan Beulich
>>> On 28.08.15 at 20:53, wrote: > @@ -68,7 +69,11 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) > u_sysctl) > case XEN_SYSCTL_tbuf_op: > ret = tb_control(&op->u.tbuf_op); > break; > - > + > +case XEN_SYSCTL_tmem_op: > +ret = tmem_control(&op->u.tme

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 5

2015-08-31 Thread Shannon Zhao
On 2015/8/31 17:40, Jan Beulich wrote: On 31.08.15 at 10:51, wrote: >> On 2015/8/31 15:39, Jan Beulich wrote: >> On 29.08.15 at 03:29, wrote: On 2015/8/28 23:06, Jan Beulich wrote: On 28.08.15 at 11:45, wrote: >> Create only one ConfigurationTable to store VendorGuid

[Xen-devel] [PATCH v3 07/11] tmem: Make the uint64_t oid[3] a proper structure: tmem_oid

2015-08-31 Thread Jan Beulich
>>> On 28.08.15 at 20:53, wrote: > @@ -2714,7 +2719,7 @@ long do_tmem_op(tmem_cli_op_t uops) > write_unlock(&tmem_rwlock); > read_lock(&tmem_rwlock); > > -oidp = (struct oid *)&op.u.gen.oid[0]; > +oidp = (struct tmem_oid *)&op.u.gen.oid[0]; AIUI

Re: [Xen-devel] [PATCH v3 08/11] tmem/sysctl: Use 'struct tmem_oid' for every user.

2015-08-31 Thread Jan Beulich
>>> On 28.08.15 at 20:53, wrote: > Patch "tmem: Make the uint64_t oid[3] a proper structure: > tmem_oid" converted the sysctl API to use an > proper structure. But it did not do it for the tmem hypercall. > > This expands that and converts the tmem hypercall. For this > to work we define the stru

Re: [Xen-devel] [PATCH v3 09/11] tmem: Use 'struct tmem_oid' in tmem_handle and move it to sysctl header.

2015-08-31 Thread Jan Beulich
>>> On 28.08.15 at 20:53, wrote: > Instead of the three member uint64_t structure. > > The structure is used by the control stack for > XEN_SYSCTL_TMEM_OP_SAVE_GET_NEXT_[PAGE|INV] only so > moving it to the sysctl header. > > Also modified tmemc_save_get_next_page to deal with > the new type - a

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 5

2015-08-31 Thread Julien Grall
On 29/08/2015 02:00, Shannon Zhao wrote: Hi Julien, On 2015/8/28 20:55, Julien Grall wrote: Hi Shannon, On 28/08/15 10:45, Shannon Zhao wrote: 2. Copy and change some EFI and ACPI tables --- [..] All above tables will be mapped to Dom0 non-RAM spa

Re: [Xen-devel] [PATCH] x86: adjustments to memory_add()

2015-08-31 Thread Wei Liu
On Fri, Aug 28, 2015 at 07:54:09AM -0600, Jan Beulich wrote: > The function should clean up after a failed map_pages_to_xen(). > > Sharing the M2P table with Dom0 needs to happen before adding > the new pages to the heap. > > Avoid the IOMMU mapping loop whenever possible. > > Drop a redundant s

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 5

2015-08-31 Thread Jan Beulich
>>> On 31.08.15 at 13:31, wrote: > On 2015/8/31 17:40, Jan Beulich wrote: > On 31.08.15 at 10:51, wrote: >>> (I wonder why you didn't get this if you have a glance at the booting >>> process. uefi_init(arch/arm64/kernel/efi.c of Linux) --> >>> efi_config_parse_tables --> match_config_table. I

Re: [Xen-devel] [PATCH] x86/NUMA: fix setup_node()

2015-08-31 Thread Wei Liu
On Fri, Aug 28, 2015 at 07:58:46AM -0600, Jan Beulich wrote: > The function referenced an __initdata object (nodes_found). Since this > being a node mask was more complicated than needed, the variable gets > replaced by a simple counter. Check at once that the count of nodes > doesn't go beyond MAX

Re: [Xen-devel] [PATCH] x86/NUMA: don't account hotplug regions

2015-08-31 Thread Wei Liu
On Fri, Aug 28, 2015 at 07:59:45AM -0600, Jan Beulich wrote: > ... except in cases where they really matter: node_memblk_range[] now > is the only place all regions get stored. nodes[] and NODE_DATA() track > present memory only. This improves the reporting when nodes have > disjoint "normal" and h

Re: [Xen-devel] [xen 4.6 retrospective] [Good and Bad] Posting a design document first is helpful

2015-08-31 Thread Lars Kurth
> On 31 Aug 2015, at 09:39, Jan Beulich wrote: > On 31.08.15 at 10:26, wrote: >> The whole point of having such design discussions is to get maintainer's >> feedbacks as early as possible >> and have everyone agree on the solution architecture up front. This approach >> has worked great

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 5

2015-08-31 Thread Shannon Zhao
On 2015/8/31 19:44, Julien Grall wrote: > > > On 29/08/2015 02:00, Shannon Zhao wrote: >> Hi Julien, >> >> On 2015/8/28 20:55, Julien Grall wrote: >>> Hi Shannon, >>> >>> On 28/08/15 10:45, Shannon Zhao wrote: 2. Copy and change some EFI and ACPI tables ---

Re: [Xen-devel] [PATCH] python/xc: add missing Py_DECREF() to fix a memory leak

2015-08-31 Thread Wei Liu
On Fri, Aug 28, 2015 at 05:35:18PM -0400, Zhigang Wang wrote: > Python PyList_Append() will increase reference count of the item. We have to > decrease its reference count to let it garbage collected. > > We missed the Py_DECREF() for 'cpuinfo_obj' here, thus we have a memory leak. > > The memory

Re: [Xen-devel] [PATCH v8 1/3] Remove identical relationship between ioreq type and rangeset type.

2015-08-31 Thread Jan Beulich
>>> On 23.08.15 at 11:33, wrote: > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -2545,7 +2545,7 @@ struct hvm_ioreq_server *hvm_select_ioreq_server(struct > domain *d, >PCI_SLOT(CF8_BDF(cf8)), >PCI_FUNC(CF8_BDF(cf

Re: [Xen-devel] [xen-unstable test] 60971: regressions - FAIL

2015-08-31 Thread Wei Liu
On Mon, Aug 31, 2015 at 02:00:02AM -0600, Jan Beulich wrote: > >>> On 30.08.15 at 17:22, wrote: > > flight 60971 xen-unstable real [real] > > http://logs.test-lab.xenproject.org/osstest/logs/60971/ > > > > Regressions :-( > > > > Tests which did not succeed and are blocking, > > including tests

Re: [Xen-devel] [xen 4.6 retrospective] Possible solution together with the comments will be helpful

2015-08-31 Thread Lars Kurth
> On 31 Aug 2015, at 09:33, Jan Beulich wrote: > On 31.08.15 at 10:24, wrote: >> = Issue / Observation = >> Sometimes the review comments are quite open, it doesn't contain a possible >> solution or a clear direction, >> so it is not clear for the contributor on how to effectively address

Re: [Xen-devel] [PATCH v8 2/3] Differentiate IO/mem resources tracked by ioreq server

2015-08-31 Thread Jan Beulich
>>> On 23.08.15 at 11:33, wrote: > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -938,8 +938,9 @@ static int hvm_ioreq_server_alloc_rangesets(struct > hvm_ioreq_server *s, > > rc = asprintf(&name, "ioreq_server %d %s", s->id, >(i == HVMOP_IO_R

Re: [Xen-devel] [PATCH] python/xc: add missing Py_DECREF() to fix a memory leak

2015-08-31 Thread Andrew Cooper
On 31/08/2015 13:04, Wei Liu wrote: > On Fri, Aug 28, 2015 at 05:35:18PM -0400, Zhigang Wang wrote: >> Python PyList_Append() will increase reference count of the item. We have to >> decrease its reference count to let it garbage collected. >> >> We missed the Py_DECREF() for 'cpuinfo_obj' here, th

Re: [Xen-devel] [PATCH v8 3/3] Refactor rangeset structure for better performance.

2015-08-31 Thread Jan Beulich
>>> On 23.08.15 at 11:33, wrote: > static void insert_range( > struct rangeset *r, struct range *x, struct range *y) > { > -list_add(&y->list, (x != NULL) ? &x->list : &r->range_list); > +struct rb_node **node; > +struct rb_node *parent = NULL; > + > +if ( x == NULL ) > +

Re: [Xen-devel] [xen 4.6 retrospective] Possible solution together with the comments will be helpful

2015-08-31 Thread Wei Liu
On Mon, Aug 31, 2015 at 02:33:22AM -0600, Jan Beulich wrote: > >>> On 31.08.15 at 10:24, wrote: > > = Issue / Observation = > > Sometimes the review comments are quite open, it doesn't contain a possible > > solution or a clear direction, > > so it is not clear for the contributor on how to effec

Re: [Xen-devel] [PATCH] python/xc: add missing Py_DECREF() to fix a memory leak

2015-08-31 Thread Wei Liu
On Mon, Aug 31, 2015 at 01:27:35PM +0100, Andrew Cooper wrote: > On 31/08/2015 13:04, Wei Liu wrote: > > On Fri, Aug 28, 2015 at 05:35:18PM -0400, Zhigang Wang wrote: > >> Python PyList_Append() will increase reference count of the item. We have > >> to > >> decrease its reference count to let it

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 5

2015-08-31 Thread Julien Grall
On 31/08/2015 13:03, Shannon Zhao wrote: Currently I use the last RAM bank(kinfo->mem.bank[nr_banks - 1]) to calculate the start address of non-RAM place. I'm not sure there will be no MMIO at that place. Do you have any good idea to find such sure and safe non-ram place? It's not a safe plac

Re: [Xen-devel] PCI Pass-through in Xen ARM: Draft 4

2015-08-31 Thread Manish Jaggi
On Thursday 13 August 2015 03:12 PM, Manish Jaggi wrote: - | PCI Pass-through in Xen ARM | - manish.ja...@caviumnetworks.com --- Draft-

Re: [Xen-devel] [xen 4.6 retrospective] [bad] Code style checking takes up too much time

2015-08-31 Thread Andrew Cooper
On 31/08/15 08:27, Jan Beulich wrote: On 28.08.15 at 17:39, wrote: >> What may be a bigger issue, is that older code may not fully adhere to >> coding standards. The open question is then >> * Whether such a tool should only run on the diff/patch > Isn't that the intended / expected behavior

[Xen-devel] Improve or change devel mailing-list for improve efficiency and spending less time, is this possible?

2015-08-31 Thread Fabio Fantoni
I saw some discussions about the developer cycle, patch review and how to improve. Based on what I saw an important thing for improve efficiency and spending less time is the way of communication, actual seems only mailing-list/mails. It seems to me that currently has some limits and in many

Re: [Xen-devel] [xen 4.6 retrospective] Possible solution together with the comments will be helpful

2015-08-31 Thread Andrew Cooper
On 31/08/15 09:33, Jan Beulich wrote: On 31.08.15 at 10:24, wrote: >> = Issue / Observation = >> Sometimes the review comments are quite open, it doesn't contain a possible >> solution or a clear direction, >> so it is not clear for the contributor on how to effectively address them. >> At

Re: [Xen-devel] [PATCH v10 02/11] libxl: support SHUTDOWN_soft_reset shutdown reason

2015-08-31 Thread Wei Liu
On Tue, Jul 28, 2015 at 03:28:07PM +0200, Vitaly Kuznetsov wrote: > Use letter 'S' to indicate a domain in such state. Introduce new > 'on_soft_reset' action and default it to 'restart' for now. > > Signed-off-by: Vitaly Kuznetsov Acked-by: Wei Liu _

Re: [Xen-devel] [PATCH v10 11/11] (lib)xl: soft reset support

2015-08-31 Thread Wei Liu
On Tue, Jul 28, 2015 at 03:28:16PM +0200, Vitaly Kuznetsov wrote: > Use existing create/restore path to perform 'soft reset' for HVM > domains. Tear everything down, e.g. destroy domain's device model, > remove the domain from xenstore, save toolstack record and start > over. > > Signed-off-by: Vi

Re: [Xen-devel] [PATCH v6 04/31] xen/arm: Set nr_cpu_ids to available number of cpus

2015-08-31 Thread Julien Grall
title: Set nr_cpu_ids to the number of CPUs available On 31/08/2015 12:06, vijay.kil...@gmail.com wrote: From: Vijaya Kumar K nr_cpu_ids for arm platforms is set to NR_CPUS irrespective of s/is set/is incorrectly set/ to make clear that it's the previous behavior and not the one that you ar

Re: [Xen-devel] [PATCH v6 01/31] xen/dt: Handle correctly node with interrupt-map in dt_for_each_irq_map

2015-08-31 Thread Julien Grall
Hi Vijay, On 31/08/2015 12:06, vijay.kil...@gmail.com wrote: From: Vijaya Kumar K dt_for_each_irq_map() returns error if no irq mapping is found. With this patch, Ignore error and return success NIT: s/Ignore/ignore/ Signed-off-by: Vijaya Kumar K I think this could go in Xen 4.6 as it'

Re: [Xen-devel] Improve or change devel mailing-list for improve efficiency and spending less time, is this possible?

2015-08-31 Thread Wei Liu
CC Lars. On Mon, Aug 31, 2015 at 03:46:30PM +0200, Fabio Fantoni wrote: > I saw some discussions about the developer cycle, patch review and how to > improve. > > Based on what I saw an important thing for improve efficiency and spending > less time is the way of communication, actual seems only

Re: [Xen-devel] [PATCH v6 05/31] xen/arm: Rename NR_IRQs and vgic_num_irqs helper function

2015-08-31 Thread Julien Grall
Hi Vijay, On 31/08/2015 12:06, vijay.kil...@gmail.com wrote: From: Vijaya Kumar K NR_IRQS define signifies number of SGIs, PPIs and SPIs. I don' think signifies is the right word here. And I would mention that SGIs/PPIs/SPIs are an IRQ lines in order to make clear why we change the name. I

Re: [Xen-devel] [PATCH v3 07/11] tmem: Make the uint64_t oid[3] a proper structure: tmem_oid

2015-08-31 Thread Konrad Rzeszutek Wilk
On Mon, Aug 31, 2015 at 05:38:45AM -0600, Jan Beulich wrote: > >>> On 28.08.15 at 20:53, wrote: > > @@ -2714,7 +2719,7 @@ long do_tmem_op(tmem_cli_op_t uops) > > write_unlock(&tmem_rwlock); > > read_lock(&tmem_rwlock); > > > > -oidp = (struct oid *)&op.u.gen

Re: [Xen-devel] [PATCH v6 06/31] xen/arm: ITS: Port ITS driver to Xen

2015-08-31 Thread Julien Grall
Hi Vijay, This patch now looks good. A few comments below. First, I've noticed that you moved again its_send_inv into patch #13. On a previous version (v4) we asked you to keep all the code imported by Linux in a single patch. You moved it correctly in v5 but then moved again out in this vers

Re: [Xen-devel] [PATCH v3 07/11] tmem: Make the uint64_t oid[3] a proper structure: tmem_oid

2015-08-31 Thread Jan Beulich
>>> Konrad Rzeszutek Wilk 08/31/15 5:38 PM >>> >On Mon, Aug 31, 2015 at 05:38:45AM -0600, Jan Beulich wrote: >> >>> On 28.08.15 at 20:53, wrote: >> > @@ -2714,7 +2719,7 @@ long do_tmem_op(tmem_cli_op_t uops) >> > write_unlock(&tmem_rwlock); >> > read_lock(&tmem_rwlock);

Re: [Xen-devel] [PATCH RFC] xen: if on Xen, "flatten" the scheduling domain hierarchy

2015-08-31 Thread Boris Ostrovsky
On 08/20/2015 02:16 PM, Juergen Groß wrote: On 08/18/2015 05:55 PM, Dario Faggioli wrote: Hey everyone, So, as a followup of what we were discussing in this thread: [Xen-devel] PV-vNUMA issue: topology is misinterpreted by the guest http://lists.xenproject.org/archives/html/xen-devel/2015-

Re: [Xen-devel] [PATCH v3 07/11] tmem: Make the uint64_t oid[3] a proper structure: tmem_oid

2015-08-31 Thread Konrad Rzeszutek Wilk
> >And the 'container_of' macro looks to require only one level of > >nesting. > > I'm pretty sure the macro can deal with both. OK, let me experiement with it as at the first blush it does not work for me. > > >> > --- a/xen/include/public/sysctl.h > >> > +++ b/xen/include/public/sysctl.h > >>

[Xen-devel] [linux-linus test] 60998: regressions - FAIL

2015-08-31 Thread osstest service owner
flight 60998 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/60998/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm 14 guest-saverestore fail REGR. vs. 59254 test-amd64-i386-xl

Re: [Xen-devel] [PATCH v6 08/31] xen/arm: ITS: Introduce msi_desc for LPIs

2015-08-31 Thread Julien Grall
Hi Vijay, On 31/08/2015 12:06, vijay.kil...@gmail.com wrote: From: Vijaya Kumar K Define msi_desc structure for arm and introduce helper functions to access msi_desc member variables. IHMO none of those helpers are useful in the code given you are only using in an handful number of places a

Re: [Xen-devel] [PATCH v6 12/31] xen/arm: Move vgic locking inside get_irq_priority callback

2015-08-31 Thread Julien Grall
Hi Vijay, On 31/08/2015 12:06, vijay.kil...@gmail.com wrote: From: Vijaya Kumar K Move vgic locking inside get_irq_priority callback. LPIs does not have vgic lock for reading LPI priority. The commit message is wrong. We have to take the rank lock when reading the IRQ priority not the vGIC

Re: [Xen-devel] [PATCH v6 23/31] xen/arm: ITS: Add 32-bit access to GICR_TYPER

2015-08-31 Thread Julien Grall
Hi Vijay, On 31/08/2015 12:06, vijay.kil...@gmail.com wrote: From: Vijaya Kumar K Add support to read 32-bit access to GICR_TYPER register Signed-off-by: Vijaya Kumar K --- xen/arch/arm/vgic-v3.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/vgic

Re: [Xen-devel] [PATCH v6 10/31] xen/arm: ITS: Introduce gic_is_lpi helper function

2015-08-31 Thread Julien Grall
Hi Vijay, On 31/08/2015 12:06, vijay.kil...@gmail.com wrote: diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c index 758678d..2199963 100644 --- a/xen/arch/arm/gic.c +++ b/xen/arch/arm/gic.c @@ -62,6 +62,15 @@ enum gic_version gic_hw_version(void) return gic_hw_ops->info->hw_version; }

Re: [Xen-devel] Improve or change devel mailing-list for improve efficiency and spending less time, is this possible?

2015-08-31 Thread Lars Kurth
Adding Russell, On 31/08/2015 15:16, "Wei Liu" wrote: >CC Lars. > >On Mon, Aug 31, 2015 at 03:46:30PM +0200, Fabio Fantoni wrote: >> I saw some discussions about the developer cycle, patch review and how >>to >> improve. >> >> Based on what I saw an important thing for improve efficiency and >

[Xen-devel] Question about the CAT and CMT in Xen

2015-08-31 Thread Meng Xu
Hi Chao, I'm Meng Xu from the University of Pennsylvania. We purchased a computer that has Intel(R) Xeon(R) CPU E5-2618L v3 @ 2.30GHz inside. According to http://www.intel.com/content/www/us/en/communications/cache-monitoring-cache-allocation-technologies.html, Intel E5-2618L v3 should support bo

[Xen-devel] [PATCH v3] x86: wrap kexec feature with CONFIG_KEXEC

2015-08-31 Thread Jonathan Creekmore
Add the appropriate #if checks around the kexec code in the x86 codebase so that the feature can actually be turned off by the flag instead of always required to be enabled on x86. Signed-off-by: Jonathan Creekmore --- Changed since v2: * Switch macros over to static inline functions * #ifde

Re: [Xen-devel] [PATCH v6 13/31] xen/arm: ITS: implement hw_irq_controller for LPIs

2015-08-31 Thread Julien Grall
Hi Vijay, On 31/08/2015 12:06, vijay.kil...@gmail.com wrote: From: Vijaya Kumar K Implements hw_irq_controller api's required to handle LPI's. Changed callbacks gic_host_irq_type and gic_guest_irq_type s/Changed/Change the/ to gic_get_host_irq_type and gic_get_guest_irq_type in gic_hw_ope

Re: [Xen-devel] [PATCH v6 14/31] xen/arm: ITS: Initialize physical ITS and export lpi support

2015-08-31 Thread Julien Grall
Hi Vijay, On 31/08/2015 12:06, vijay.kil...@gmail.com wrote: diff --git a/xen/include/asm-arm/gic.h b/xen/include/asm-arm/gic.h index 6ece7cc..15c76d0 100644 --- a/xen/include/asm-arm/gic.h +++ b/xen/include/asm-arm/gic.h @@ -283,6 +283,8 @@ extern void gic_dump_info(struct vcpu *v); /* Numbe

Re: [Xen-devel] [PATCH v2] libxenstore: prefer using the character device

2015-08-31 Thread Jonathan Creekmore
Just wanted to follow-up and see if there was any more debate on this, since I hadn't seen any other commentary since last week. David Vrabel writes: On 27/08/15 19:03, Ian Jackson wrote: Wei Liu writes ("Re: [Xen-devel] [PATCH v2] libxenstore: prefer using the character device"): On Thu,

Re: [Xen-devel] Question about the CAT and CMT in Xen

2015-08-31 Thread Andrew Cooper
On 31/08/15 18:42, Meng Xu wrote: > Hi Chao, > > I'm Meng Xu from the University of Pennsylvania. > > We purchased a computer that has Intel(R) Xeon(R) CPU E5-2618L v3 @ > 2.30GHz inside. > According to > http://www.intel.com/content/www/us/en/communications/cache-monitoring-cache-allocation-techno

  1   2   >