>>> On 23.08.15 at 11:33, <yu.c.zh...@linux.intel.com> wrote:
> static void insert_range(
> struct rangeset *r, struct range *x, struct range *y)
> {
> - list_add(&y->list, (x != NULL) ? &x->list : &r->range_list);
> + struct rb_node **node;
> + struct rb_node *parent = NULL;
> +
> + if ( x == NULL )
> + node = &r->range_tree.rb_node;
> + else
> + {
> + node = &x->node.rb_right;
> + parent = &x->node;
> + }
> +
> + while ( *node )
Please be consistent throughout the patch: Either always compare
with NULL (like done earlier on) or (preferred) never spell this out
(like done here).
> @@ -410,7 +448,7 @@ void rangeset_domain_destroy(
>
> void rangeset_swap(struct rangeset *a, struct rangeset *b)
> {
> - LIST_HEAD(tmp);
> + struct rb_node* tmp;
* and blank want to be swapped.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
