>>> On 31.08.15 at 10:24, <feng...@intel.com> wrote: > = Issue / Observation = > Sometimes the review comments are quite open, it doesn't contain a possible > solution or a clear direction, > so it is not clear for the contributor on how to effectively address them. > At least, in Linux kernel and KVM side, if the maintainers have > objection to the implementation of the patches, they will give a possible > solution or a direction which is very > helpful for the contributor to address the comments. Hence this will make > the review discussion more effective and productive and save both reviewer > and developer's time. > > = Possible Solution / Improvement = > Try to give some possible solutions with the comments, especially for some > big changes which affect a lot > to the whole patch-set.
I think when a solution can be thought of in the context of reviewing, it is being given. I believe I know which case you allude to here, and I'm afraid it's not always reasonable for the reviewer(s) to do the contributor's work of finding a solution when none is obvious. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
