Re: [Xen-devel] [PATCH] unmodified-drivers: tolerate IRQF_DISABLED being undefined

2015-07-21 Thread Jan Beulich
>>> On 21.07.15 at 08:52, wrote: > On Mon, Jun 01, Jan Beulich wrote: > >> >>> On 01.06.15 at 15:56, wrote: >> > On Mon, 2015-06-01 at 14:50 +0100, Jan Beulich wrote: >> >> It's being removed in Linux 4.1. >> >> >> >> Signed-off-by: Jan Beulich >> > >> > Not sure who should, but: >> >> I gue

Re: [Xen-devel] [PATCH] blktap2: update connection handling to fix build with gcc5

2015-07-21 Thread Olaf Hering
On Tue, Jul 21, Jan Beulich wrote: > But anyway, the primary question remains - isn't what you're seeing > a compiler bug? If yes, that's imo _yet another_ reason for doing a > minimal workaround (if any at all). I dont think its a compiler bug. How should the compiler know that the index variabl

Re: [Xen-devel] [PATCH] VT-d: add iommu=igfx_off option to workaround graphics issues

2015-07-21 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Tuesday, July 21, 2015 2:57 PM > > >>> On 21.07.15 at 02:57, wrote: > >> From: Andrew Cooper [mailto:am...@hermes.cam.ac.uk] On Behalf Of Andrew > > Cooper > >> Sent: Monday, July 20, 2015 4:21 PM > >> > >> On 20/07/2015 02:28, Tian, Kevin w

Re: [Xen-devel] [PATCH] unmodified-drivers: tolerate IRQF_DISABLED being undefined

2015-07-21 Thread Olaf Hering
On Tue, Jul 21, Jan Beulich wrote: > Taking it to mean "all maintained", that's possible, but since I can't > immediately see the point I'd like to ask for some justification. Us - > SUSE - apparently being the only consumer of that code, and us > not using Xen 4.4 together with Linux 4.1, and our

Re: [Xen-devel] [PATCH] VT-d: add iommu=igfx_off option to workaround graphics issues

2015-07-21 Thread Jan Beulich
>>> On 21.07.15 at 09:05, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Tuesday, July 21, 2015 2:57 PM >> >>> On 21.07.15 at 02:57, wrote: >> >> From: Andrew Cooper [mailto:am...@hermes.cam.ac.uk] On Behalf Of Andrew >> > Cooper >> >> Sent: Monday, July 20, 2015 4:21 PM >> > T

Re: [Xen-devel] [PATCH] VT-d: add iommu=igfx_off option to workaround graphics issues

2015-07-21 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Tuesday, July 21, 2015 3:17 PM > >>> On 21.07.15 at 09:05, wrote: > >> From: Jan Beulich [mailto:jbeul...@suse.com] > >> Sent: Tuesday, July 21, 2015 2:57 PM > >> >>> On 21.07.15 at 02:57, wrote: > >> >> From: Andrew Cooper [mailto:am...@

Re: [Xen-devel] [PATCH] blktap2: update connection handling to fix build with gcc5

2015-07-21 Thread Jan Beulich
>>> On 21.07.15 at 09:04, wrote: > On Tue, Jul 21, Jan Beulich wrote: >> But anyway, the primary question remains - isn't what you're seeing >> a compiler bug? If yes, that's imo _yet another_ reason for doing a >> minimal workaround (if any at all). > > I dont think its a compiler bug. How shoul

Re: [Xen-devel] [PATCH] VT-d: add iommu=igfx_off option to workaround graphics issues

2015-07-21 Thread Jan Beulich
>>> On 21.07.15 at 09:23, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Tuesday, July 21, 2015 3:17 PM > >> >>> On 21.07.15 at 09:05, wrote: >> >> From: Jan Beulich [mailto:jbeul...@suse.com] >> >> Sent: Tuesday, July 21, 2015 2:57 PM >> >> >>> On 21.07.15 at 02:57, wrote:

Re: [Xen-devel] [PATCH] blktap2: update connection handling to fix build with gcc5

2015-07-21 Thread Ian Campbell
On Tue, 2015-07-21 at 00:50 -0600, Jan Beulich wrote: > > What is the longterm goal of that binary? > > It being mostly unmaintained, it's probably a candidate for removal > not too far in the future. George already posted a series to remove the in tree copy and treat blktap2 as an out of tree p

[Xen-devel] [PATCH v2] blktap2: update connection handling to fix build with gcc5

2015-07-21 Thread Olaf Hering
blktap2 fails to build with gcc5 because it fails to recognize that there can be just one active connection (enforced in ctl_accept). Add a hack to use MAX_CONNECTIONS instead of ARRAY_SIZE: gives a smaller patch, and the code does not handle holes in connections[] anyway. [ 198s] block-log.c:

Re: [Xen-devel] [PATCH v2] blktap2: update connection handling to fix build with gcc5

2015-07-21 Thread Jan Beulich
>>> On 21.07.15 at 10:42, wrote: > --- a/tools/blktap2/drivers/block-log.c > +++ b/tools/blktap2/drivers/block-log.c > @@ -359,7 +359,7 @@ static int ctl_close_sock(struct tdlog_state* s, int fd) > { >int i; > > - for (i = 0; i < s->connected; i++) { > + for (i = 0; i < s->connected && i

Re: [Xen-devel] [PATCH v9 0/8] pci: add pci_iomap_wc() and pci_ioremap_wc_bar()

2015-07-21 Thread Ingo Molnar
* Luis R. Rodriguez wrote: > On Wed, Jul 08, 2015 at 06:54:11PM -0700, Luis R. Rodriguez wrote: > > From: "Luis R. Rodriguez" > > > > Ingo, > > > > Boris is on vacation, he picked up these patches on his bp#tip-mm tree [0] > > and they have baked there for a while now. That tree receives 0-da

Re: [Xen-devel] [PATCH v2] blktap2: update connection handling to fix build with gcc5

2015-07-21 Thread Ian Campbell
On Tue, 2015-07-21 at 02:48 -0600, Jan Beulich wrote: > >>> On 21.07.15 at 10:42, wrote: > > --- a/tools/blktap2/drivers/block-log.c > > +++ b/tools/blktap2/drivers/block-log.c > > @@ -359,7 +359,7 @@ static int ctl_close_sock(struct tdlog_state* s, int fd) > > { > >int i; > > > > - for (i

Re: [Xen-devel] [PATCH 3/3] xen-blkback: rm BUG_ON() in purge_persistent_gnt()

2015-07-21 Thread Roger Pau Monné
El 21/07/15 a les 5.30, Bob Liu ha escrit: > This BUG_ON() will be triggered when previous purge work haven't finished. > It's reasonable under pretty extreme load and should not panic the system. > > Signed-off-by: Bob Liu > --- > drivers/block/xen-blkback/blkback.c |4 +++- > 1 file change

Re: [Xen-devel] [PATCH 2/3] xen-blkfront: rm BUG_ON(info->feature_persistent) in blkif_free

2015-07-21 Thread Roger Pau Monné
El 21/07/15 a les 5.30, Bob Liu ha escrit: > This BUG_ON() in blkif_free() is incorrect, because indirect page can be added > to list info->indirect_pages in blkif_completion() no matter > feature_persistent > is true or false. > > Signed-off-by: Bob Liu Acked-by: Roger Pau Monné This was pro

Re: [Xen-devel] [PATCH v2 0/6] add xsaves/xrstors support

2015-07-21 Thread Ruan, Shuai
Hi Andrew: Thanks for your review. In V2 , I have test migrate VM between two different servers, one which is xsaves capable and one which is not. There is 2 bugs related with my code in migrating between two servers( in v1 I just test migrate using localhost) and I fix it by add change the code

Re: [Xen-devel] [PATCH 1/3] xen-blkfront: introduce blkfront_gather_backend_features()

2015-07-21 Thread Roger Pau Monné
El 21/07/15 a les 5.30, Bob Liu ha escrit: > There is a bug when migrate from !feature-persistent host to > feature-persistent > host, because domU still think new host/backend don't support persistent. > Dmesg like: > backed has not unmapped grant: 839 > backed has not unmapped grant: 773 > backe

[Xen-devel] [xen-unstable test] 59772: regressions - FAIL

2015-07-21 Thread osstest service owner
flight 59772 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/59772/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 9 debian-hvm-install fail REGR. vs. 58965 Tes

Re: [Xen-devel] [PATCH v2 02/23] x86/boot: copy only text section from *.lnk file to *.bin file

2015-07-21 Thread Jan Beulich
>>> On 20.07.15 at 16:28, wrote: Without any explanation (description) I'm inclined to say this makes things more fragile instead of improving the situation. As it looks like we indeed pointlessly copy .eh_frame, but I think this would better be avoided by suppressing its generation (i.e. add -fn

[Xen-devel] [qemu-upstream-4.5-testing test] 59774: regressions - trouble: broken/fail/pass

2015-07-21 Thread osstest service owner
flight 59774 qemu-upstream-4.5-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/59774/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-arndale 3 host-install(3) broken REGR. vs. 58413 test-am

Re: [Xen-devel] [PATCH for-4.6 1/3] libxl: include sys/endian.h for FreeBSD

2015-07-21 Thread Wei Liu
On Mon, Jul 20, 2015 at 04:55:00PM +0200, Roger Pau Monne wrote: > be64toh and friends are declared in sys/endian.h on FreeBSD, so include it > as part of libxl_osdeps.h. > > Signed-off-by: Roger Pau Monné > Cc: Ian Jackson > Cc: Ian Campbell > Cc: Wei Liu Acked-by: Wei Liu > --- > tools/l

Re: [Xen-devel] [PATCH 4/6] libxc: expose xsaves/xgetbv1/xsavec to hvm guest

2015-07-21 Thread Ruan, Shuai
Thanks for your reviews Jan. Can you give me some suggestion on this? In PATCH03, I change hvm_cpuid function to make sure the CPUID data can be exposed to guest when xsaves supported. -Original Message- From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Friday, July 17, 2015 6:47 PM

Re: [Xen-devel] [PATCH v2 03/23] x86: zero BSS using stosl instead of stosb

2015-07-21 Thread Jan Beulich
>>> On 20.07.15 at 16:28, wrote: ... because of ??? Nowadays - with X86_FEATURE_ERMS - rep stosb is expected to be faster than rep stosl. Jan ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 00/23] x86: multiboot2 protocol support

2015-07-21 Thread Jan Beulich
>>> On 20.07.15 at 16:28, wrote: > This series, in general, is not targeted to Xen 4.6. However, there are > some fixes at the beginning of it which are worth considering, I think. I looked at the first few, and didn't spot any fixes. If you meant just cleanup or other cosmetic adjustments, then

Re: [Xen-devel] [Xen-Devel] Enabling IRQ Crossbar (Secondary Interrupt Controller) Support

2015-07-21 Thread Julien Grall
On 21/07/2015 00:17, Brandon Perez wrote: Hello All, Hi Brandon, We use to send one mail by patch rather than sending them as an attachment of a single email. It's easier for reviewing the patches. You also need to add you Signed-off-by on each patch and CC all the relevant maintainers. Pl

Re: [Xen-devel] [v10][PATCH 06/16] hvmloader/pci: Try to avoid placing BARs in RMRRs

2015-07-21 Thread George Dunlap
On 07/21/2015 01:53 AM, Chen, Tiejun wrote: >>> Okay, I regenerate this patch online. And I just hope its good to be >>> acked here: >> >> Provided it also works, >> Reviewed-by: Jan Beulich >> > > Why is this marked as Acked-by this time? The same question is raised to > another hvmloader patch

Re: [Xen-devel] [PATCH 1/6] x86/xsaves: enable xsaves/xrstors for pv guest

2015-07-21 Thread Ruan, Shuai
Thanks for your review, konrad 1.If the hardware does not support xsaves, then hypersior will not expose xsaves feature to guest. Then the guest will not excute xsaves. But your suggestion is important, I will add code to verify that the host can excute xsaves or not. 2.Using 'ASSERT' here is

Re: [Xen-devel] [PATCH] blktap2: update connection handling to fix build with gcc5

2015-07-21 Thread George Dunlap
On 07/21/2015 09:38 AM, Ian Campbell wrote: > On Tue, 2015-07-21 at 00:50 -0600, Jan Beulich wrote: > >>> What is the longterm goal of that binary? >> >> It being mostly unmaintained, it's probably a candidate for removal >> not too far in the future. > > George already posted a series to remove

Re: [Xen-devel] [PATCH 4/6] libxc: expose xsaves/xgetbv1/xsavec to hvm guest

2015-07-21 Thread Jan Beulich
Please don't top post. >>> On 21.07.15 at 11:33, wrote: > Thanks for your reviews Jan. > Can you give me some suggestion on this? In PATCH03, I change hvm_cpuid > function to make sure the CPUID data can be exposed to guest when xsaves > supported. Not sure what recommendations you're after

Re: [Xen-devel] [PATCH v2 05/20] block/xen-blkfront: Split blkif_queue_request in 2

2015-07-21 Thread Roger Pau Monné
El 09/07/15 a les 22.42, Julien Grall ha escrit: > Currently, blkif_queue_request has 2 distinct execution path: > - Send a discard request > - Send a read/write request > > The function is also allocating grants to use for generating the > request. Although, this is only used for read/wri

Re: [Xen-devel] [PATCH v6 01/15] common/domain: Helpers to pause a domain while in context

2015-07-21 Thread George Dunlap
On Tue, Jul 21, 2015 at 12:57 AM, Ed White wrote: > From: Andrew Cooper > > For use on codepaths which would need to use domain_pause() but might be in > the target domain's context. In the case that the target domain is in > context, all other vcpus are paused. > > Signed-off-by: Andrew Cooper

Re: [Xen-devel] [PATCH v6 05/15] x86/altp2m: basic data structures and support routines.

2015-07-21 Thread Jan Beulich
>>> On 21.07.15 at 01:58, wrote: > Add the basic data structures needed to support alternate p2m's and > the functions to initialise them and tear them down. > > Although Intel hardware can handle 512 EPTP's per hardware thread > concurrently, only 10 per domain are supported in this patch for >

Re: [Xen-devel] [PATCH v2 06/20] block/xen-blkfront: Store a page rather a pfn in the grant structure

2015-07-21 Thread Roger Pau Monné
El 09/07/15 a les 22.42, Julien Grall ha escrit: > All the usage of the field pfn are done using the same idiom: > > pfn_to_page(grant->pfn) > > This will return always the same page. Store directly the page in the > grant to clean up the code. > > Signed-off-by: Julien Grall > Cc: Konrad Rzes

[Xen-devel] [linux-3.4 test] 59771: regressions - FAIL

2015-07-21 Thread osstest service owner
flight 59771 linux-3.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/59771/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-win7-amd64 6 xen-boot fail REGR. vs. 30511 Tests which are failing

Re: [Xen-devel] [PATCH v2 07/20] block/xen-blkfront: split get_grant in 2

2015-07-21 Thread Roger Pau Monné
El 09/07/15 a les 22.42, Julien Grall ha escrit: > Prepare the code to support 64KB page granularity. The first > implementation will use a full Linux page per indirect and persistent > grant. When non-persistent grant is used, each page of a bio request > may be split in multiple grant. > > Furth

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Ian Jackson
I wrote: > If the domain configuration has rdms and num_rdms already set, then > the strategy should presumably be ignored. (Passing the same domain > configuration struct to libxl_domain_create_new, after destroying the > domain, ought to work, even after the first call has modified it.) But eve

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Ian Jackson
Chen, Tiejun writes ("Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM"): > I hope the following can address all comments below: You now write this: > +static void > +add_rdm_entry(libxl__gc *gc, libxl_domain_config *d_config, > + uint64_t rdm_start, uint64_t

Re: [Xen-devel] [PATCH 3/3] xen-blkback: rm BUG_ON() in purge_persistent_gnt()

2015-07-21 Thread Bob Liu
On 07/21/2015 05:13 PM, Roger Pau Monné wrote: > El 21/07/15 a les 5.30, Bob Liu ha escrit: >> This BUG_ON() will be triggered when previous purge work haven't finished. >> It's reasonable under pretty extreme load and should not panic the system. >> >> Signed-off-by: Bob Liu >> --- >> drivers/b

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Chen, Tiejun
On 2015/7/21 18:41, Ian Jackson wrote: I wrote: If the domain configuration has rdms and num_rdms already set, then the strategy should presumably be ignored. (Passing the same domain configuration struct to libxl_domain_create_new, after destroying the domain, ought to work, even after the fir

Re: [Xen-devel] [PATCH for-4.6 3/3] hotplug/FreeBSD: fix xendriverdomain rc.d script

2015-07-21 Thread Wei Liu
On Mon, Jul 20, 2015 at 04:55:02PM +0200, Roger Pau Monne wrote: > hotplugpath.sh by default is located in /usr/local/etc/xen/scripts on > FreeBSD. Instead of hardcoding it's location use the XEN_SCRIPT_DIR variable > like it's used on the xencommons rc.d script. > > Signed-off-by: Roger Pau Monné

Re: [Xen-devel] [PATCH v2 15/20] block/xen-blkfront: Make it running on 64KB page granularity

2015-07-21 Thread Roger Pau Monné
El 09/07/15 a les 22.42, Julien Grall ha escrit: > From: Julien Grall > > The PV block protocol is using 4KB page granularity. The goal of this > patch is to allow a Linux using 64KB page granularity using block > device on a non-modified Xen. > > The block API is using segment which should at l

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Ian Jackson
Chen, Tiejun writes ("Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM"): > I would add this check at the beginning of this function: > > assert(!d_config->num_rdms && !d_config->rdms). As Ian Campbell and I have explained, that is not OK. The caller may choose to pass bo

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Chen, Tiejun
+static void +add_rdm_entry(libxl__gc *gc, libxl_domain_config *d_config, + uint64_t rdm_start, uint64_t rdm_size, int rdm_policy) +{ +assert(d_config->num_rdms); + +d_config->rdms = libxl__realloc(NOGC, d_config->rdms, +d_config->num_rdms * sizeof(

Re: [Xen-devel] [PATCH v2 05/20] block/xen-blkfront: Split blkif_queue_request in 2

2015-07-21 Thread Julien Grall
Hi Roger, On 21/07/15 10:54, Roger Pau Monné wrote: > El 09/07/15 a les 22.42, Julien Grall ha escrit: >> Currently, blkif_queue_request has 2 distinct execution path: >> - Send a discard request >> - Send a read/write request >> >> The function is also allocating grants to use for generat

Re: [Xen-devel] [PATCH for-4.6 2/3] libxl/psr: use Xen error codes when checking hypercall return values

2015-07-21 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH for-4.6 2/3] libxl/psr: use Xen error codes when checking hypercall return values"): > We cannot use the systems errno values when checking return values from Xen, > because some OSes don't have the same set of errno definitions. Instead > use the definitions presen

Re: [Xen-devel] [PATCH v2 06/20] block/xen-blkfront: Store a page rather a pfn in the grant structure

2015-07-21 Thread Julien Grall
Hi Roger, On 21/07/15 11:16, Roger Pau Monné wrote: > El 09/07/15 a les 22.42, Julien Grall ha escrit: >> All the usage of the field pfn are done using the same idiom: >> >> pfn_to_page(grant->pfn) >> >> This will return always the same page. Store directly the page in the >> grant to clean up th

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Chen, Tiejun
On 2015/7/21 19:11, Ian Jackson wrote: Chen, Tiejun writes ("Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM"): I would add this check at the beginning of this function: assert(!d_config->num_rdms && !d_config->rdms). As Ian Campbell and I have explained, that is not

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Ian Jackson
Chen, Tiejun writes ("Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM"): > On 2015/7/21 19:11, Ian Jackson wrote: > > The most obvious case is something like the following code > > > >libxl_domain_config cfg; > >cfg.stuff = blah; > >cfg.rdm.strategy = HOST; > >

Re: [Xen-devel] [PATCH for-4.6 2/3] libxl/psr: use Xen error codes when checking hypercall return values

2015-07-21 Thread Ian Jackson
Ian Jackson writes ("Re: [PATCH for-4.6 2/3] libxl/psr: use Xen error codes when checking hypercall return values"): > Acked-by: Ian Jackson Actually, I withdraw that. I was confused about how things worked. To summarise an irc discussion: * On NetBSD, hypercall numbers are translated by the

Re: [Xen-devel] [PATCH for-4.6 2/3] libxl/psr: use Xen error codes when checking hypercall return values

2015-07-21 Thread Andrew Cooper
On 21/07/15 12:36, Ian Jackson wrote: > Ian Jackson writes ("Re: [PATCH for-4.6 2/3] libxl/psr: use Xen error codes > when checking hypercall return values"): >> Acked-by: Ian Jackson > Actually, I withdraw that. I was confused about how things worked. > To summarise an irc discussion: > > * On

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Chen, Tiejun
The domain destroy would not change cfg at all. Okay. If not, I should double check this duplication so what about a return in the case of duplicating one entry? What I am looking for is a *decision* about what the right behaviour is, backed up by a *rationale*. The most obvious answer to

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Chen, Tiejun
On 2015/7/21 19:11, Ian Jackson wrote: Chen, Tiejun writes ("Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM"): I would add this check at the beginning of this function: assert(!d_config->num_rdms && !d_config->rdms). As Ian Campbell and I have explained, that is not

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Ian Jackson
Chen, Tiejun writes ("Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM"): > [Ian Jackson:] > > The most obvious answer to me would be that if an rdms array is > > specified, the strategy should be ignored. That is how the automatic > > numa placement API works. > > I'm not

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Ian Jackson
Chen, Tiejun writes ("Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM"): > If you're talking to create the domain twice I think this should be > reasonable, Right. > if (d_config->num_rdms) return 0; Yes. > Because RDMs are always associated to the platform so we shoul

[Xen-devel] [libvirt test] 59787: regressions - FAIL

2015-07-21 Thread osstest service owner
flight 59787 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/59787/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 5 xen-build fail REGR. vs. 58842 build-i386-pvops

Re: [Xen-devel] [PATCH for-4.6 2/3] libxl/psr: use Xen error codes when checking hypercall return values

2015-07-21 Thread Ian Jackson
Andrew Cooper writes ("Re: [Xen-devel] [PATCH for-4.6 2/3] libxl/psr: use Xen error codes when checking hypercall return values"): > EBADSLT isn't the only example here. I believe ENODATA is a similar > example. http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/errno.h.html http://cvsweb

Re: [Xen-devel] [PATCH v6 05/15] x86/altp2m: basic data structures and support routines.

2015-07-21 Thread George Dunlap
On 07/21/2015 11:13 AM, Jan Beulich wrote: On 21.07.15 at 01:58, wrote: >> Add the basic data structures needed to support alternate p2m's and >> the functions to initialise them and tear them down. >> >> Although Intel hardware can handle 512 EPTP's per hardware thread >> concurrently, only

Re: [Xen-devel] [PATCH for-4.6 2/3] libxl/psr: use Xen error codes when checking hypercall return values

2015-07-21 Thread Ian Campbell
On Tue, 2015-07-21 at 13:40 +0100, Ian Jackson wrote: > Andrew Cooper writes ("Re: [Xen-devel] [PATCH for-4.6 2/3] libxl/psr: > use Xen error codes when checking hypercall return values"): > > EBADSLT isn't the only example here. I believe ENODATA is a > > similar > > example. > > http://pubs.o

Re: [Xen-devel] [PATCH 0/4] Fix to libxl migration v2 issue blocking OSSTest

2015-07-21 Thread Wei Liu
On Mon, Jul 20, 2015 at 11:11:28AM +0100, Andrew Cooper wrote: > On 20/07/15 10:56, Wei Liu wrote: > > On Fri, Jul 17, 2015 at 05:51:14PM +0100, Andrew Cooper wrote: > >> And three improvements to debugging. > >> > >> Note that there is still a bug in libxl__toolstack_save() which > >> valgrind ide

Re: [Xen-devel] [PATCH v2 07/20] block/xen-blkfront: split get_grant in 2

2015-07-21 Thread Julien Grall
Hi, On 21/07/15 11:30, Roger Pau Monné wrote: > El 09/07/15 a les 22.42, Julien Grall ha escrit: >> Prepare the code to support 64KB page granularity. The first >> implementation will use a full Linux page per indirect and persistent >> grant. When non-persistent grant is used, each page of a bio

Re: [Xen-devel] [PATCH v2 15/20] block/xen-blkfront: Make it running on 64KB page granularity

2015-07-21 Thread Julien Grall
Hi Roger, On 21/07/15 12:06, Roger Pau Monné wrote: > El 09/07/15 a les 22.42, Julien Grall ha escrit: >> From: Julien Grall >> >> The PV block protocol is using 4KB page granularity. The goal of this >> patch is to allow a Linux using 64KB page granularity using block >> device on a non-modified

Re: [Xen-devel] [PATCH 1/6] x86/xsaves: enable xsaves/xrstors for pv guest

2015-07-21 Thread Konrad Rzeszutek Wilk
On Tue, Jul 21, 2015 at 09:43:22AM +, Ruan, Shuai wrote: > Thanks for your review, konrad > > 1.If the hardware does not support xsaves, then hypersior will not expose > xsaves feature to guest. Then the guest will not excute xsaves. But your > suggestion is important, I will add code to ver

Re: [Xen-devel] [PATCH for-4.6 2/3] libxl/psr: use Xen error codes when checking hypercall return values

2015-07-21 Thread Jan Beulich
>>> On 21.07.15 at 14:47, wrote: > On Tue, 2015-07-21 at 13:40 +0100, Ian Jackson wrote: >> Andrew Cooper writes ("Re: [Xen-devel] [PATCH for-4.6 2/3] libxl/psr: >> use Xen error codes when checking hypercall return values"): >> > EBADSLT isn't the only example here. I believe ENODATA is a >> >

Re: [Xen-devel] [PATCH v6 10/15] x86/altp2m: add remaining support routines.

2015-07-21 Thread George Dunlap
On 07/21/2015 12:58 AM, Ed White wrote: > Add the remaining routines required to support enabling the alternate > p2m functionality. > > Signed-off-by: Ed White > > Reviewed-by: Andrew Cooper > --- > xen/arch/x86/hvm/hvm.c | 58 +- > xen/arch/x86/mm/hap/Makefile | 1 + > x

Re: [Xen-devel] [PATCH v9 0/8] pci: add pci_iomap_wc() and pci_ioremap_wc_bar()

2015-07-21 Thread Bjorn Helgaas
On Tue, Jul 21, 2015 at 10:52:52AM +0200, Ingo Molnar wrote: > > * Luis R. Rodriguez wrote: > > > On Wed, Jul 08, 2015 at 06:54:11PM -0700, Luis R. Rodriguez wrote: > > > From: "Luis R. Rodriguez" > > > > > > Ingo, > > > > > > Boris is on vacation, he picked up these patches on his bp#tip-mm

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Chen, Tiejun
On 2015/7/21 20:33, Ian Jackson wrote: Chen, Tiejun writes ("Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM"): [Ian Jackson:] The most obvious answer to me would be that if an rdms array is specified, the strategy should be ignored. That is how the automatic numa plac

Re: [Xen-devel] [PATCH for-4.6 2/3] libxl/psr: use Xen error codes when checking hypercall return values

2015-07-21 Thread Ian Campbell
On Tue, 2015-07-21 at 07:14 -0600, Jan Beulich wrote: > > > > > > On 21.07.15 at 14:47, wrote: > > On Tue, 2015-07-21 at 13:40 +0100, Ian Jackson wrote: > > > Andrew Cooper writes ("Re: [Xen-devel] [PATCH for-4.6 2/3] > > > libxl/psr: > > > use Xen error codes when checking hypercall return val

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Chen, Tiejun
But another answer would be to take the union of the specified regions. That would be more complicated, because the union would have to be computed. if (d_config->rdms[i].start == rdm_start) return; That doesn't, of course, compute the union. Sorry I don't

Re: [Xen-devel] Request a freeze exception for COLO in v4.6

2015-07-21 Thread Ian Campbell
On Mon, 2015-07-20 at 15:27 +0800, Yang Hongyang wrote: > > On 07/17/2015 06:18 PM, Ian Jackson wrote: > > Wei Liu writes ("Re: [Xen-devel] Request a freeze exception for > > COLO in v4.6"): > > > Ian and Ian, anything to add? What are your opinions? > > > > I think COLO is an exciting and impor

Re: [Xen-devel] [PATCH] xen/HVM: atomically access pointers in bufioreq handling

2015-07-21 Thread Stefano Stabellini
On Thu, 18 Jun 2015, Jan Beulich wrote: > The number of slots per page being 511 (i.e. not a power of two) means > that the (32-bit) read and write indexes going beyond 2^32 will likely > disturb operation. The hypervisor side gets I/O req server creation > extended so we can indicate that we're us

[Xen-devel] [qemu-upstream-unstable test] 59777: regressions - trouble: broken/fail/pass

2015-07-21 Thread osstest service owner
flight 59777 qemu-upstream-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/59777/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 3 host-install(3) broken REGR. vs. 58880 test-amd64

Re: [Xen-devel] [PATCH RFC] libxl: fix build with glibc < 2.9

2015-07-21 Thread Ian Campbell
On Mon, 2015-07-20 at 15:30 +0100, Jan Beulich wrote: > htobe*() and be*toh() don't exist there. While replacing the 32-bit > ones with hton() and ntoh() would be possible, there wouldn't be an > obvious replacement for the 64-bit ones. Hence just take what current > glibc (2.21) has (assuming __bs

Re: [Xen-devel] [PATCH 1/5] xl: Command line: Adjust "Fix segfaults from `xl psr-cat-cbm-set`..."

2015-07-21 Thread Ian Campbell
On Fri, 2015-07-17 at 18:00 +0100, Ian Jackson wrote: Replying here in lieu of a 0/N: Is any subset of this aimed at 4.6? > This adjust commit a49077e5 "Fix segfaults from `xl psr-cat-cbm-set` > command line handling": > > * Do not use the constant `required_argument' here (we simply use 1 >

Re: [Xen-devel] [PATCH for 4.6] xen/tools: Widen the machine_irq in xc_domain_*bind_pt_irq_int

2015-07-21 Thread Ian Campbell
On Fri, 2015-07-17 at 15:06 +0100, Julien Grall wrote: > The DOMCTLs {,un}bind_pt_irq are using uint32_t for the machine_irq > while the helper is using uint8_t. > > Currently on ARM, we are supporting SPIs whose irq number can go up > to > 1019 which doesn't fit in an uint8_t. The helpers > xc_

Re: [Xen-devel] [PATCH v2] xl: fix vcpus to vnode assignement in config file

2015-07-21 Thread Ian Campbell
On Mon, 2015-07-20 at 11:30 +0200, Dario Faggioli wrote: > In fact, right now, if the "vcpus=" list (where the > user specifies what vcpus should be part of a vnode) > has multiple elements, things don't work. > E.g., the following examples all result in failure > to create the guest: What is the

Re: [Xen-devel] [PATCH 1/5] xl: Command line: Adjust "Fix segfaults from `xl psr-cat-cbm-set`..."

2015-07-21 Thread Ian Jackson
Ian Campbell writes ("Re: [PATCH 1/5] xl: Command line: Adjust "Fix segfaults from `xl psr-cat-cbm-set`...""): > On Fri, 2015-07-17 at 18:00 +0100, Ian Jackson wrote: > > Replying here in lieu of a 0/N: > > Is any subset of this aimed at 4.6? Yes, ideally, all of them. I think they are bugfixe

Re: [Xen-devel] [PATCH 1/5] xl: Command line: Adjust "Fix segfaults from `xl psr-cat-cbm-set`..."

2015-07-21 Thread Wei Liu
On Tue, Jul 21, 2015 at 03:27:26PM +0100, Ian Jackson wrote: > Ian Campbell writes ("Re: [PATCH 1/5] xl: Command line: Adjust "Fix segfaults > from `xl psr-cat-cbm-set`...""): > > On Fri, 2015-07-17 at 18:00 +0100, Ian Jackson wrote: > > > > Replying here in lieu of a 0/N: > > > > Is any subset

Re: [Xen-devel] [PATCH for-4.6 3/3] hotplug/FreeBSD: fix xendriverdomain rc.d script

2015-07-21 Thread Ian Campbell
On Tue, 2015-07-21 at 12:03 +0100, Wei Liu wrote: > On Mon, Jul 20, 2015 at 04:55:02PM +0200, Roger Pau Monne wrote: > > hotplugpath.sh by default is located in /usr/local/etc/xen/scripts > > on > > FreeBSD. Instead of hardcoding it's location use the XEN_SCRIPT_DIR > > variable > > like it's use

Re: [Xen-devel] [PATCH for-4.6 1/3] libxl: include sys/endian.h for FreeBSD

2015-07-21 Thread Ian Campbell
On Tue, 2015-07-21 at 10:36 +0100, Wei Liu wrote: > On Mon, Jul 20, 2015 at 04:55:00PM +0200, Roger Pau Monne wrote: > > be64toh and friends are declared in sys/endian.h on FreeBSD, so > > include it > > as part of libxl_osdeps.h. > > > > Signed-off-by: Roger Pau Monné > > Cc: Ian Jackson > > C

Re: [Xen-devel] [PATCH] xen: arm: gic-v3: avoid \n in the middle of log messages

2015-07-21 Thread Ian Campbell
On Fri, 2015-07-17 at 15:10 +0100, Julien Grall wrote: > Hi Ian, > > On 17/07/15 14:21, Ian Campbell wrote: > > These result in log messages such as: > > > > (XEN) d0v0: vGICD: RAZ on reserved register offset 0x0c > > (XEN) d0v0: vGICR: write r2 offset 0x000180 > > (XEN) not found<3>traps.c:

Re: [Xen-devel] [PATCH] xen: arm: Avoid reading beyond the last module

2015-07-21 Thread Ian Campbell
On Mon, 2015-07-20 at 13:32 +0100, Julien Grall wrote: > Hi Chris, > > On 17/07/15 21:48, Chris (Christopher) Brand wrote: > > nr_mods is set in add_boot_module() to the number of module > > array elements used. This function also ensures that nr_mods > > never exceeds MAX_MODULES (the size of the

Re: [Xen-devel] [PATCH v4 3/3] libxl: call libxl_cpupoolinfo_{init, dispose} in numa_place_domain

2015-07-21 Thread Ian Campbell
On Fri, 2015-07-17 at 18:03 +0100, Ian Jackson wrote: > Wei Liu writes ("[PATCH v4 3/3] libxl: call > libxl_cpupoolinfo_{init,dispose} in numa_place_domain"): > > Call libxl_cpupoolinfo_init at the beginning. Change two returns > > to > > goto out so that libxl_cpupoolinfo_dispose is called in f

Re: [Xen-devel] [PATCH v4 1/3] libxl: make libxl__strdup and libxl__strndup handle NULL

2015-07-21 Thread Ian Campbell
On Fri, 2015-07-17 at 18:03 +0100, Ian Jackson wrote: > Wei Liu writes ("[PATCH v4 1/3] libxl: make libxl__strdup and > libxl__strndup handle NULL"): > > Signed-off-by: Wei Liu > > Acked-by: Ian Jackson Applied. thanks. Ian. ___ Xen-devel mailing

Re: [Xen-devel] [Xen-Devel] Enabling IRQ Crossbar (Secondary Interrupt Controller) Support

2015-07-21 Thread Brandon Perez
On 07/21/2015 05:41 AM, Julien Grall wrote: On 21/07/2015 00:17, Brandon Perez wrote: Hello All, Hi Brandon, We use to send one mail by patch rather than sending them as an attachment of a single email. It's easier for reviewing the patches. You also need to add you Signed-off-by on each pa

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Ian Jackson
Chen, Tiejun writes ("Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM"): > +static void > +add_rdm_entry(libxl__gc *gc, libxl_domain_config *d_config, > + uint64_t rdm_start, uint64_t rdm_size, int rdm_policy) > +{ > +d_config->num_rdms++; > +d_config->

Re: [Xen-devel] [PATCH 0/4] Fix to libxl migration v2 issue blocking OSSTest

2015-07-21 Thread Ian Campbell
On Tue, 2015-07-21 at 15:51 +0100, Ian Campbell wrote: > On Tue, 2015-07-21 at 13:49 +0100, Wei Liu wrote: > > On Mon, Jul 20, 2015 at 11:11:28AM +0100, Andrew Cooper wrote: > > > On 20/07/15 10:56, Wei Liu wrote: > > > > On Fri, Jul 17, 2015 at 05:51:14PM +0100, Andrew Cooper wrote: > > > > > And

Re: [Xen-devel] [PATCH 0/4] Fix to libxl migration v2 issue blocking OSSTest

2015-07-21 Thread Ian Campbell
On Tue, 2015-07-21 at 13:49 +0100, Wei Liu wrote: > On Mon, Jul 20, 2015 at 11:11:28AM +0100, Andrew Cooper wrote: > > On 20/07/15 10:56, Wei Liu wrote: > > > On Fri, Jul 17, 2015 at 05:51:14PM +0100, Andrew Cooper wrote: > > > > And three improvements to debugging. > > > > > > > > Note that there

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Ian Jackson
Chen, Tiejun writes ("Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM"): > [Ian Jackson:] > > That is, an address would be reserved if it was reserved in any of the > > rdm regions implied by the config. > > Are you saying this point? > > "The union of two sets A and B is

Re: [Xen-devel] [PATCH] build: use correct qemu path in systemd service file and init script

2015-07-21 Thread Ian Campbell
On Fri, 2015-07-17 at 00:15 +0800, Ting-Wei Lan wrote: This all looks pretty good. One comment: > +if test "x$qemu_xen_path" = "x" || test "x$qemu_xen_path" = "xqemu"; > then : > + > +qemu_xen_path_service="$LIBEXEC_BIN/qemu-system-i386" It's a shame we have to repeat the "qemu-system-i386"

Re: [Xen-devel] [Xen-Devel] Enabling IRQ Crossbar (Secondary Interrupt Controller) Support

2015-07-21 Thread Ian Campbell
On Tue, 2015-07-21 at 10:07 -0400, Brandon Perez wrote: > > I'm not sure that these patches are quite ready yet to be put > into > the Xen repo. That's ok, but even for an RFC (Request For Comments) please post them one patch per email in the manner of git send-email. You can use - -subjec

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Chen, Tiejun
Just to your example, libxl_domain_config cfg; cfg.stuff = blah; cfg.rdm.strategy = HOST; libxl_domain_create_new(&cfg, &domid); libxl_domain_destroy(domid); Here looks you mean d_config->rdms would be changed, right? Currently this shouldn't be allowed. But I think we need

Re: [Xen-devel] [PATCH 1/5] xl: Command line: Adjust "Fix segfaults from `xl psr-cat-cbm-set`..."

2015-07-21 Thread Ian Campbell
On Tue, 2015-07-21 at 15:36 +0100, Wei Liu wrote: > On Tue, Jul 21, 2015 at 03:27:26PM +0100, Ian Jackson wrote: > > Ian Campbell writes ("Re: [PATCH 1/5] xl: Command line: Adjust "Fix > > segfaults from `xl psr-cat-cbm-set`...""): > > > On Fri, 2015-07-17 at 18:00 +0100, Ian Jackson wrote: > > >

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Ian Jackson
Chen, Tiejun writes ("Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM"): > Indeed, I'm not a fan to Xen tools so I can't picture what this real > scenario would happen. So if I'm misunderstanding what you mean, just > please correct me. Or if you still think its hard to e

Re: [Xen-devel] [PATCH v2 4/6] xen/x86/pvh: Set up descriptors for 32-bit PVH guests

2015-07-21 Thread Boris Ostrovsky
On 07/17/2015 01:52 PM, Boris Ostrovsky wrote: On 07/17/2015 12:43 PM, Konrad Rzeszutek Wilk wrote: On Fri, Jul 17, 2015 at 11:36:29AM -0400, Boris Ostrovsky wrote: On 07/17/2015 11:21 AM, Konrad Rzeszutek Wilk wrote: On Thu, Jul 16, 2015 at 05:43:39PM -0400, Boris Ostrovsky wrote: Signed-off

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Chen, Tiejun
On 2015/7/21 23:09, Ian Jackson wrote: Chen, Tiejun writes ("Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM"): +static void +add_rdm_entry(libxl__gc *gc, libxl_domain_config *d_config, + uint64_t rdm_start, uint64_t rdm_size, int rdm_policy) +{ +d_confi

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Ian Jackson
Chen, Tiejun writes ("Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM"): > Sorry, I just ignore the line in brackets since I always think this kind > of thing is often not a big deal, and next time I should pay more > attention to the (). But indeed, before I post this wh

[Xen-devel] [PATCH for-4.6 2/3] xen: replace non-POSIX error codes

2015-07-21 Thread Roger Pau Monne
Some DOMCTLs returned non-POSIX error codes, replace them with POSIX compilant values instead. EBADRQC and EBADSLT are replaced by EINVAL, while EUSERS is replaced with EOVERFLOW. Signed-off-by: Roger Pau Monné Cc: George Dunlap Cc: Jan Beulich Cc: Andrew Cooper --- Nothing in libxc or libxl s

[Xen-devel] [PATCH for-4.6 0/3] Get rid of non-POSIX error codes

2015-07-21 Thread Roger Pau Monne
This patch series gets rid of non-POSIX error codes in the hypervisor and the toolstack. This is needed for OS compatibility. I think the patch series is fairly small and non-intrusive, hence the for-4.6 tag. Thanks, Roger. ___ Xen-devel mailing list

[Xen-devel] [PATCH for-4.6 3/3] xen: remove non-POSIX error codes

2015-07-21 Thread Roger Pau Monne
Xen was using some non-POSIX error codes that are removed in this patch. For future reference, the list of POSIX error codes has been obtained from: http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/errno.h.html The error codes already present and defined as optional (XSR), have been left

[Xen-devel] [PATCH for-4.6 1/3] xen/x86/libxl: replace non-POSIX error codes used by PSR code

2015-07-21 Thread Roger Pau Monne
PSR was using EBADSLT and EUSERS which are not POSIX error codes, replace them with EINVAL and EOVERFLOW respectively. Signed-off-by: Roger Pau Monné Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu Cc: Jan Beulich Cc: Andrew Cooper --- tools/libxl/libxl_psr.c | 6 +++---

  1   2   >