On Fri, 2015-07-17 at 00:15 +0800, Ting-Wei Lan wrote: This all looks pretty good. One comment:
> +if test "x$qemu_xen_path" = "x" || test "x$qemu_xen_path" = "xqemu"; > then : > + > + qemu_xen_path_service="$LIBEXEC_BIN/qemu-system-i386" It's a shame we have to repeat the "qemu-system-i386" here and in libxl_dm.c. I think rather than adding a new qemu_xen_path_service we should just make the existing $qemu_xen_path default to the full $LIBEXEC_BIN/qemu -system-i386 and have it substituted everywhere much like you've done here. Then libxl_dm.c:qemu_xen_path() can return QEMU_XEN_PATH always. What do you think? Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
