Thanks for your reviews Jan. Can you give me some suggestion on this? In PATCH03, I change hvm_cpuid function to make sure the CPUID data can be exposed to guest when xsaves supported.
-----Original Message----- From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Friday, July 17, 2015 6:47 PM To: Ruan, Shuai Cc: andrew.coop...@citrix.com; ian.campb...@citrix.com; wei.l...@citrix.com; ian.jack...@eu.citrix.com; stefano.stabell...@eu.citrix.com; Dong, Eddie; Nakajima, Jun; Tian, Kevin; xen-devel@lists.xen.org; k...@xen.org Subject: RE: [PATCH 4/6] libxc: expose xsaves/xgetbv1/xsavec to hvm guest >>> On 17.07.15 at 10:10, <shuai.r...@intel.com> wrote: > Ok, Thanks Jan. > I will add the descriptions in next version. > > Below is the short descriptions. > For CPUID with eax=0xd and ecx=0x1, ebx\ecx\edx may not be zero when > xsaves supported. Also with ecx>2, ecx\edx may not be zero. If we want > expose xsaves to HVM guest , we should not set them to zero. > > So in your opinions ,is it proper to add these code here? Sure, provided you don't leak any bits that may become defined in the future, and the non-zero setting of which might be inconsistent with other CPUID data. I.e. without looking at the manual, I'd guess the above is still a little too vague. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
