Roger Pau Monne writes ("[PATCH for-4.6 2/3] libxl/psr: use Xen error codes 
when checking hypercall return values"):
> We cannot use the systems errno values when checking return values from Xen,
> because some OSes don't have the same set of errno definitions. Instead
> use the definitions present in Xen public errno.h header.
> 
> Signed-off-by: Roger Pau Monné <roger....@citrix.com>
> Cc: Ian Jackson <ian.jack...@eu.citrix.com>
> Cc: Ian Campbell <ian.campb...@citrix.com>
> Cc: Wei Liu <wei.l...@citrix.com>

Acked-by: Ian Jackson <ian.jack...@eu.citrix.com>

> I have not checked if there are other places in libxl that need similar
> treatment, I just came around this because FreeBSD doesn't have EBADSLT
> defined.

Right.  There is probably more of this, but that's not a blocker for
this patch.

Maybe it would be worth mentioning this issue in CODING_STYLE.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Reply via email to