Re: Releasing...

2012-10-21 Thread Michael MacFadden
Please referer to the previous email from Angus posted to the dev list titles "Release Update" on 9/29/12: -- Hi All, The last review for licensing stuff is up, i'd appreciate it if you all looked at it and pointed out any errors i've made. There's a couple of things going on at once at the

Re: Releasing...

2012-10-21 Thread Angus Turner
The apache licence is compatible to varying degrees to other licences. Some are only allowed to be included when they've been obfuscated to prevent easy tinkering. I can't find it at the moment but there is a page on the apache website which explains it better. If I can find it I'll let you know. T

Re: Releasing...

2012-10-21 Thread Ed - 0x1b, Inc.
I'm sorry, why is an open source project obfuscating anything? On Sun, Oct 21, 2012 at 1:06 PM, Michael MacFadden wrote: > Angus, > > In regards to obfuscation. You might take a look at ProGuard: > > http://proguard.sourceforge.net/index.html# > > It's an open source obfuscator. > > And yep. I'

Re: Releasing...

2012-10-21 Thread Michael MacFadden
Angus, In regards to obfuscation. You might take a look at ProGuard: http://proguard.sourceforge.net/index.html# It's an open source obfuscator. And yep. I'll help with the final signing. ~Michael From: Angus Turner Reply-To: Date: Sunday, October 21, 2012 12:58 PM To: Subject: Re:

Re: Releasing...

2012-10-21 Thread Angus Turner
Sorry i'm the hold up. My script that I used to remove the copyright headers changed all the comments to not being javadocs anymore. I've been busy lately and haven't had time to fix it. The next step is working out how to obfuscate the jars in a couple of the libraries to make them compatible wit

Re: Review Request: Fix for "WAVE-354: SimpleSearch.DigestProxy should undate only the opened wave on changes"

2012-10-21 Thread wavegrove
> On Oct. 21, 2012, 4:16 p.m., Yuri Zelikov wrote: > > Hi > > I think the original issue was fixed by > > https://github.com/apache/wave/commit/2fbdcb9200b972d87d3667211ed0ce5db3326f53 > > and by > > https://github.com/apache/wave/commit/f34e33031801a1f2de4715a670a9c8c515c867d0 > > Or are there

Re: Review Request: Horizontal lines in the editor

2012-10-21 Thread Vicente J. Ruiz Jurado
> On Oct. 21, 2012, 6:08 p.m., Yuri Zelikov wrote: > > The patch LGTM, but can you please send link to the hr_line.png binary file > > or send it in email? I'm trying to send a new patch following Patrick comments, but for now, I didn't find the way to enforce that hr constraint. I'll try aga

Re: Review Request: Fix for deadlock in UserManager

2012-10-21 Thread Vicente J. Ruiz Jurado
> On Oct. 1, 2012, 11:25 a.m., Yuri Zelikov wrote: > > I asked Andrew if he experienced similar issues on wiab.pro and he replied > > that yes and his solution was to remove synchronization on userManager in > > ClientFrontendImpl. > > I also tend to think that this is the probable source of de

Re: Review Request: Fix some regresion with new edit_done button patch (review 6336)

2012-10-21 Thread Yuri Zelikov
> On Aug. 13, 2012, 8:12 p.m., Ali Lown wrote: > > src/org/waveprotocol/wave/client/wavepanel/view/dom/full/BlipMetaViewBuilder.java, > > line 133 > > > > > > Did you mean for these to be a different order to > > MENU

Re: Review Request: Fix for deadlock in UserManager

2012-10-21 Thread Yuri Zelikov
> On Oct. 1, 2012, 11:25 a.m., Yuri Zelikov wrote: > > I asked Andrew if he experienced similar issues on wiab.pro and he replied > > that yes and his solution was to remove synchronization on userManager in > > ClientFrontendImpl. > > I also tend to think that this is the probable source of de

Re: Review Request: Horizontal lines in the editor

2012-10-21 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7364/#review12643 --- The patch LGTM, but can you please send link to the hr_line.png binar

Re: Review Request: Line-through editor shortcut

2012-10-21 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7548/#review12642 --- Hmm, strange, but it doesn't work for me for some reason. I tried ctr

Re: Review Request: Webclient should use socketio when websocket does not connect

2012-10-21 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7602/#review12640 --- Committed as r1400686. - Yuri Zelikov On Oct. 17, 2012, 12:40 a.m.

Re: Review Request: socketio updated (xhr-polling utf8 fix, and websocket disabled)

2012-10-21 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7600/#review12639 --- Committed as r1400684 - Yuri Zelikov On Oct. 15, 2012, 6:01 p.m.,

Re: Review Request: Webclient should use socketio when websocket does not connect

2012-10-21 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7602/#review12638 --- Ship it! Ship It! - Yuri Zelikov On Oct. 17, 2012, 12:40 a.m., Vi

Re: Review Request: socketio updated (xhr-polling utf8 fix, and websocket disabled)

2012-10-21 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7600/#review12637 --- Ship it! Ship It! - Yuri Zelikov On Oct. 15, 2012, 6:01 p.m., Vic

Re: Review Request: Implementing the feature "New wave with the participants of the current wave"

2012-10-21 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7353/#review12634 --- Great patch - just minor comments. Thanks for doing this! The only is

Re: Review Request: Attachments.

2012-10-21 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7471/#review12633 --- Great job! I tested it and it works fine - just minor comments. ./s

Re: Review Request: Fix for "WAVE-354: SimpleSearch.DigestProxy should undate only the opened wave on changes"

2012-10-21 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7683/#review12631 --- Hi I think the original issue was fixed by https://github.com/apache

Releasing...

2012-10-21 Thread Upayavira
Where did we get to on preparing a tet release? Have we got licensing headers in order? Does anything else stand in our way? Thx, Upayavira