----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7600/#review12639 -----------------------------------------------------------
Committed as r1400684 - Yuri Zelikov On Oct. 15, 2012, 6:01 p.m., Vicente J. Ruiz Jurado wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7600/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2012, 6:01 p.m.) > > > Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown. > > > Description > ------- > > This patch includes: > * utf8 fix for xhr-polling this fix > * websocket transport disabled in socketio (because doesn't work and better > use jetty implementation). > > More details in Oct 15 commits: > https://github.com/vjrj/Socket.IO-Java/commits/master > > Binaries are in: > http://homes.ourproject.org/~vjrj/otros/socketio-xhr-polling-ut8-websocket-disabled.tgz > > > This addresses bug WAVE-331. > https://issues.apache.org/jira/browse/WAVE-331 > > > Diffs > ----- > > third_party/codegen/socketio/README.google 7ef7641 > third_party/codegen/socketio/socketio-gwt-0.1-SNAPSHOT.jar a55dc9c > third_party/runtime/socketio/README.google 7ef7641 > third_party/runtime/socketio/socketio-core-0.1-SNAPSHOT-sources.jar 6c0635e > third_party/runtime/socketio/socketio-core-0.1-SNAPSHOT.jar 000d3a3 > third_party/runtime/socketio/socketio-jetty-0.1-SNAPSHOT-sources.jar > bc86967 > > Diff: https://reviews.apache.org/r/7600/diff/ > > > Testing > ------- > > $ ant dist-server compile-gwt > > Tests with: > * firefox with websocket enabled and disabled (in about:config) > * chrommium and google-chrome with and without websockets > (--disable-web-sockets param) > > > Thanks, > > Vicente J. Ruiz Jurado > >
