Re: [PATCH 1/4] common/board_f: remove XTRN_DECLARE_GLOBAL_DATA_PTR dead code

e reservation of a specific register for it), but that the implementation uses a register nevertheless because this results in smaller code? Maybe add such a comment instead ? Thanks! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munic

Re: [PATCH] image: Ensure image header name is null terminated

*hdr, const char *name) > { > - strncpy(image_get_name(hdr), name, IH_NMLEN); > + char *hdr_name = image_get_name(hdr); > + > + strncpy(hdr_name, name, IH_NMLEN - 1); > + hdr_name[IH_NMLEN - 1] = '\0'; > } Why don't you use strlcpy() instead? This covers

Re: [PATCH 1/3] Licenses: Clarify exceptions for standalone apps

Dear Paul Barker, In message <20220505153242.1598807-2-paul.bar...@sancloud.com> you wrote: > On 2010-01-27, an email [1] was sent to the mailing list by Wolfgang > Denk which clarified the intended licensing exceptions for standalone > applications. As the "export.h"

Re: [PATCH 3/3] exports: Fix export of SPI access functions

inclluded. I2C was there because it was needed for reading the environment from an EEPROM, but then the interface was frozen ano no more new interfices / drivers should be allowed. Viele Grüße, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich,

Re: [PATCH 2/3] examples: hello_world: Drop inclusion of common header

a standalone app can be built without > it. > > Signed-off-by: Paul Barker > --- > examples/standalone/hello_world.c | 1 - > 1 file changed, 1 deletion(-) Acked-off-by: Wolfgang Denk Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgan

Re: [ANN] U-Boot v2021.04 released

4 (2.0%) DENX Software Engineering4 (2.0%) Marvell 4 (2.0%) ... Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (

Re: [cmd] clarification on syntax of 'chpart' command

t found! you would use: => mmc dev 0 2 Hope this helps. Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@de

Re: U-Boot statistics update

.7%) ... Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The trouble with our times is that the future

Re: [RFC PATCH] tools: env: Add an option to have an empty default environment

y etc. There are good chances to brick your board with such settings. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 E

Re: [PATCH v4 1/9] CONFIG_NR_DRAM_BANKS: Remove unreferenced code as its always defined

; "#ifndef CONFIG_NR_DRAM_BANKS" (and similar). This patch removes > all these unreferenced code paths. ...thus futher hiding where we just lost another lof of memory, for no advantage. Sic... Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolf

Re: [PATCH v4 4/9] global: Move from bi_memstart/memsize -> gd->ram_base/ram_size

r to write something like: "With the _planned_ removal ..." or such? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66

Re: U-Boot stats

enx.de/wiki/U-Boot/UbootStat_2020_07 Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Sorry, but my

Re: [PATCH v4 1/9] CONFIG_NR_DRAM_BANKS: Remove unreferenced code as its always defined

is changed to use such an array, it should not waste even more memory be defining room for 4 banks where there usually will be only one. Sorry, I know that you are not to blame for that... Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165

Re: [RFC PATCH] tools: env: Add an option to have an empty default environment

uld not call this any longer "default" then). Patches welcome! > Content-Type: text/html; charset="UTF-8" > Content-Transfer-Encoding: quoted-printable And please - stop sending HTML to the list! Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH,

Re: Bug tracking

) or allowing only OAUTH logins from other platforms as it's done for example here [1]. [1] https://gitlab.gnome.org/users/sign_in And we should make sure that only bugs against mainline versions can be reported - it makes no sense to collect bug information for out-of-tree code where we m

[IMPORTANT] gitlab downtime

Hi all, I just reeived a notification from our hoster that our gitlab server ( source.denx.de ) will be offline for approx. 2 hours between now and 15:45 CEST (urgent maintenance work). Sorry for the inconvenience, but there is nothing we can do... Best regards, Wolfgang Denk -- DENX

Re: [PATCH] powerpc: remove WATCHDOG_RESET call from wait_ticks()

; udelay() itself does one WATCHDOG_RESET() per __udelay() call. Which exact platforms have you tested this on? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-814

Re: [PATCH] powerpc: remove WATCHDOG_RESET call from wait_ticks()

specific redefinition of the WATCHDOG_RESET macro would be less intrusive and risky than changing code that has been there since the beginning of time (well, at least more than 18 years). Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 1652

Re: [PATCH] powerpc: remove WATCHDOG_RESET call from wait_ticks()

improve any code, the first thing you must do is to guarantee it continues to work on all affected systems. I don't dare to give even a prognosis before testing this on a number of different hardware configurations. Testing on a single platform (which apparently has aother problems, or you woul

Re: [PATCH] powerpc: remove WATCHDOG_RESET call from wait_ticks()

early two decades this code has been doing what it does, and I guess there were good reasons at that time (like memory footprint and resources to fix a specific problem). I agree that from a design point of view this is not nice, but that's not the point here. Best regards, Wolfgang Denk

Re: [PATCH] powerpc: remove WATCHDOG_RESET call from wait_ticks()

ing boards. This other patch lacks documentation - just from reading the code nobody will be able to understand what this piece of code is intended for, so there is a risk that it might be removed by some later "cleanup". Please add some comment in the code to explain the intent

Re: [PATCH 3/3] cmd: dm: Fixed/Added DM driver listing subcommands

Devices\n"); > puts("--\n"); Or even less code: puts("Driveruid uclass Devices\n" "--\n"); Best regards, Wolfgang Denk -- DENX Software Engineer

Re: [PATCH 07/10] board: stm32mp1: add finished good in board identifier OTP

Dear Patrick, In message <20200212183744.5309-8-patrick.delau...@st.com> you wrote: > Update the command stboard to support the coding of OTP 59 with > finished good: Can you please explain what "finished good" means? I can't parse the sentence above, sorry. B

Re: [RFC RFT PATCH] env: spl: filter the variables in default environment of SPL or TPL

per would be using different settings. If your default environment is too big for the SPL, then make it smaller. If you need additional settings in U-Boot, there are many ways to load thise there. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk

Re: [PATCH v2] powerpc: allow opting out of WATCHDOG_RESET() from timer interrupt

ime.c and wherever else similar code may exist. Only changing one plase is not a good idea. And please add some documentation also to the README. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5

Re: [PATCH 07/10] board: stm32mp1: add finished good in board identifier OTP

anation to the commit message and maybe even comment in the code. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w

Re: [PATCH v3 0/3] Add command to display or save Linux PStore dumps

es logged by U-Boot. To me this sounds very much like what you are adding here (plus a few features more). Does it make sense to unify such code? Added Heiko to Cc:, as he is currently working on fixes to get shared logbuffer working again for another project. Best regards, Wolfgang Denk

Re: [PATCH v3 2/3] test: Add PStore command tests

Dear Frédéric, In message <20200319175737.10166-3-frederic.da...@collabora.com> you wrote: > > +++ b/test/py/tests/test_pstore.py > @@ -0,0 +1,73 @@ > +# SPDX-License-Identifier: GPL-2.0 Can we please make new code always GPL-2.0+ ? Thanks! Best regards, Wolfgang Denk

Re: [PATCH] cmd: ubi: add a command to rename volume

Dear Philippe, In message <1584644739-10258-1-git-send-email-philippe.rey...@softathome.com> you wrote: > This commit add the command ubi rename to rename an ubi volume. > The format of the command is: ubi rename . Can we plase make this optional / configurable? Thanks! W

Re: [PATCH v3 0/3] Add command to display or save Linux PStore dumps

in 2002. > git grep -GHrn 'shared log' finds nothing in U-Boot. So if any part of > the old implementation in U-Boot exists, could you, please, point us to > the coding. The shared log buffer support was added by commit 56f94be3ef63: commit 56f94be3ef63732384063e110277ed89701b6

Re: [PATCH v3 0/3] Add command to display or save Linux PStore dumps

rom U-Boot to Linux kernel and further into Linux user land in a standard way. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-6

Re: [PATCH v2 1/2] spi: call WATCHDOG_RESET() in spi_nor_wait_till_ready_with_timeout()

if (info->id_len) { there, while all the rest is idential. Lack of synchronization? Also the differences in spi_nor_select_read() make we wonder... This extensive code duplication looks really painful and error prone to me. Do you have any intentions to clean this up

Re: [PATCH v3 1/2] timer: mpc83xx_timer: fix build with CONFIG_{HW_, }WATCHDOG

so we can see easily what has changed between patch version and and 2, and between version 2 and 3? Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8

Re: [PATCH v3 0/3] Add command to display or save Linux PStore dumps

and we had such a feature working and in mainline already 17+ years ago. It's sad that people rather reinvent the wheel instead of using existing functionality (or reviving it, if it has been broken over time). Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing

Re: [PATCH] tools: fw_env: use erasesize from MEMGETINFO ioctl

if (DEVESIZE(dev) == 0) > /* Assume the erase size is the same as the env-size */ > DEVESIZE(dev) = ENVSIZE(dev); What happens if you - say - have an environment size of 16 KiB and an erase block size of 4 KiB? Best regards, Wolfgang Denk -- DENX Softw

Re: [U-Boot] Sharing a hardware lab

Dear Harald, In message you wrote: > > I added something similar to this in our DENX internal tbot configurations but > did not yet publish it anywhere (maybe I should add it to tbot_contrib?). > Just Yes, please do! Best regards, Wolfgang Denk -- DENX Software Engi

Re: Totally wrecked my ENV

not, and you can still load and flash an image in U-Boot, then try that. If this doesn't work either, then you probably have to use a JTAG debugger (if you have a JTAG connector on your board). Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolf

Re: [PATCH v2 1/2] spi: call WATCHDOG_RESET() in spi_nor_wait_till_ready_with_timeout()

if (info->id_len) { > > > > here, and > > In case of tiny stack, we save space by not storing flash names in > spi_nor_ids[] table (its a significant saving) and hence have to rely on > another field to detect EOL. You could still use the same method in both

Re: [PATCH 0/5] CMD_SAVEENV ifdef cleanup

t's only #ifdef changes without impact on function, then we should get exactly the same images. You did not comment if you have verified that. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-8219

Re: [PATCH 0/5] CMD_SAVEENV ifdef cleanup

behave as intented? I think there have been cases before where code changes had ... let's say unexpected side effects... You should build a few (if not all!) such boards with and without your patches applied and _verify_ the the code does not change. Just guessing is not good enough. >

Re: [PATCH v2 1/2] spi: call WATCHDOG_RESET() in spi_nor_wait_till_ready_with_timeout()

i-nor-tiny to avoid code size increase. Understood. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de As long as w

Re: [PATCH v2 0/2] allow CONFIG_SPL_SAVEENV to work with ENV_IS_IN_SPI_FLASH

en easier using tbot, and it would have been possible to cover many more / all boards, but I don't intend to ask more from you. Thanks, both for the additional testing and your patience. Reviewed-by: Wolfgang Denk Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Direct

Re: [PATCH v2 0/2] allow CONFIG_SPL_SAVEENV to work with ENV_IS_IN_SPI_FLASH

dware lab" [2] [1] https://tbot.tools/ [2] https://lists.denx.de/pipermail/u-boot/2020-February/399278.html Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49

Re: [PATCH 03/16] arm: stm32mp: reset to default environment when serial# change

move - as a user I find such things completely unacceptable. If I make any changes, they must never ever be killed without my explicit confirmation. I strongly advice against such a method. Please drop that. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director:

Re: [PATCH 04/16] arm: stm32mp: detect U-Boot version used to save environment

er? Are you by chance reinventing the wheel? The U-Boot version is stored in the environment variable "ver"; there should be no need for something similar. Also. where is $env_ver coming from? It does not exist in mainline, nor in any of the 3 patches that preceed this patch # 4/16 ? Bes

Re: [PATCH 05/16] arm: stm32mp: spl: add bsec driver in SPL

y this is needed, and if it's unrelated, spilt into a separate commit. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80

Re: [PATCH 06/16] arm: stm32mp: spl: display error in board_init_f

/* enable console uart printing */ > preloader_console_init(); > > + if (clk || reset || pinctrl) > + printf("%s: probe failed clk=%d reset=%d pinctrl=%d\n", > +__func__, clk, reset, pinctrl); > + This change makes littl

Re: [PATCH 08/16] board: stm32mp1: update management of boot-led

onsistent, please use CONFIG_IS_ENABLED() everywhere instead of #ifdef's. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-

Re: [PATCH 09/16] board: stm32mp1: gt9147 IRQ before reset on EV1

.. > + ret = uclass_get_device_by_driver(UCLASS_NOP, DM_GET_DRIVER(goodix), > + &dev); > + if (ret) > + debug("goodix init failed: %d\n", ret); If this is an error condition, you should use printf(), and not paper over it with a debug()

Re: [PATCH 11/16] board: stm32mp1: check env_get result in board_late_init

a user defines a specific bootdelay setting in his environment, this must be respected. I really hate vendors who believe they know better than me what I want or what is good to me. Please get rid of such stuff. "bootdelay" is an environment variable that is intentionally user definabl

Re: [PATCH 02/18] common: Drop flash.h from common header

l. I think this should be in a separate commit. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A rollin

Re: [PATCH 03/16] arm: stm32mp: reset to default environment when serial# change

ommon for all board based on STM32MP15x). See signature below :-) Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w.

Re: [PATCH 04/16] arm: stm32mp: detect U-Boot version used to save environment

ps. I've seen too often that they did things I nver intended to do or would have accepted if I had a chance to decide. Use extremely careful, please. >From a user point of view, it's me who owns the environment, and nobody should mess with my data without me confirming it. Best reg

Re: [PATCH v1 1/1] cmd: setexpr: add dec operation for converting variable to decimal

s and the third _not_ being "dec" ? Like "setexpr foo hex 42" ? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-

Re: [PATCH v1 1/1] cmd: setexpr: add dec operation for converting variable to decimal

; > I believe hex is the right default. We just need an easy way to use decimal. Maybe we should make this more general and support an even wirder range of formats? Instead of just converting to decimal, we could pass a format string for sprintf() ? Like: # setexpr foo fmt %d $value

Re: [PATCH v1 1/1] cmd: setexpr: add dec operation for converting variable to decimal

"dec") != 0) { print error message bail our } ... } But see my other suggestion anyway - why add just decimal format when using sprintf() with a format string allows for all kinds of fancy uses? Best

Re: [RFC PATCH 1/1] cmd: nvedit: Forbid key to be empty.

g a library function here you could use the same shortcut as in the patch you referenced: if (*name == 0) { > + printf("## Error: variable name cannot be empty\n"); s/cannot/must not/ ?? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managin

Re: [PATCH 0/3] cmd: setexpr: add fmt format string operation

e able to construct any kind of data from pieces; say, for example: => setexpr foo fmt "%0x08x-%s-%d-%s" $a $b $c $d Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzel

Re: [PATCH 1/3] cmd: setexpr: add fmt format string operation

> + return CMD_RET_FAILURE; > + } Please get rid of this restriction. > + /* Search type field of format specifier */ > + while (*first && !isalpha(*first)) > + first++; > + > + /* Test if type is supported */ > + if (!strchr(&

Re: [PATCH 1/3] cmd: setexpr: add fmt format string operation

n that code, indeed. > I think allowing "arbitrary" format strings, restricted to those > expected exactly one integer argument, is too fragile and error-prone. Indeed. See for example the "printf" (bash) shell builtin - we should have a similar flexibility her

Re: [PATCH 0/3] cmd: setexpr: add fmt format string operation

$ printf '%s\n' 0x 0x > > => setexpr foo fmt "%0x08x-%s-%d-%s" $a $b $c $d > > I think the only way to support such expressions in a save way would > be implementing an own format string parser for setexpr with Maybe it makes sense to hav

Re: [PATCH 0/3] cmd: setexpr: add fmt format string operation

e kept out of the generic *printf() code; it could then be optional/configurable with the "fmt" option in the setexpr command. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenz

Re: [RFC PATCH v2 1/1] cmd: nvedit: Forbid key to be empty.

) { > + printf("## Error: variable name must no be empty\n"); > + return 1; > + } > + > env_id++; > > /* Delete only ? */ Reviewed-by: Wolfgang Denk Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Directo

Re: [PATCH 0/3] cmd: setexpr: add fmt format string operation

not a "checking" problem. The issue is that "123" cannot > be passed directly to %d. So you have dig into the guts of snprintf > anyway. Did you read my recommendation to have a look for example at the implementation of the printf bash builting? Best regards, Wolfgang Den

Re: [RFC PATCH 02/28] cli: Add LIL shell

st of the exact differencec between LIL and a standard shell? I wonder, if we deviate from standard shell syntax anyway, we could also have a look at lua, for example? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirche

Re: [RFC PATCH 00/28] cli: Add a new shell

of these, lil does make the most sense. You mean, adding a complete new, incompatible and non-standard shell is a better approach than updating to a recent version of hush? What makes you think so? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk

Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup

erent results. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Ever try. Ever fail. No matte

Re: [RFC PATCH 02/28] cli: Add LIL shell

as it was already suggested before, _replacing_ the standard shell is only one way to use lua - another would be to use lua as a command that can be started from the shell when needed - assuming you want to pay the price in terms of size. Best regards, Wolfgang Denk -- DENX Software Engineer

Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup

actively > developed. I believe the author sees his work as essentially > feature-complete, so I expect no major features which we might like to > backport. This sounds like an advantage, indeed, but then you can also interpret this as betting on a dead horse... Best regards, Wolfgang

Re: [RFC PATCH 02/28] cli: Add LIL shell

ion of reasons to move _from_ that language many, many years ago. Intoducing this as new "shell" language in U-Boot does not look attractive to me. Actually, it gives me the creeps. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk

Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup

> we use Hush or some other language), we should pick one which has better > support for single-threaded programming. In which way do you think "a new language" needs to be ported when switching from an old to a new version of hush? It would be still a (mostly) POSIX compatible

Re: [RFC PATCH 05/28] cli: lil: Rename some functions to be more like TCL

oking... To me such an approach is unacceptable. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email:

Re: [RFC PATCH 02/28] cli: Add LIL shell

ial level. Do you really think that replacing standard shell syntax with Tcl is "something that's comfortable to a large audience"? I seriously doubt that. > Something that has "sh" syntax but also clear to the user errors when > trying to do something not sup

Re: [RFC PATCH 02/28] cli: Add LIL shell

of today. I view adding > functions as one of the most important usability improvements we can > make. Again: this is not an issue with hush as is, but only with our resource-limited port of a nearly 20 year old version of it. Updating to a current version would fix this, in an almost 100% bac

Re: [RFC PATCH 05/28] cli: lil: Rename some functions to be more like TCL

. If you were right, there would be far less users of bash (or other "bourne derived shells"). Guess which percentage of users of UNIX operating systems is using a Tcl based command interpreter as their login shell? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH,

Re: [RFC PATCH 05/28] cli: lil: Rename some functions to be more like TCL

a full NAK from me when when you think of it as a _replacement_ (even an optional one) of the standard shell. If you like, have it added as an _additional_ command, of course fully optional and without impact on the rest of U-Boot if not intentionally selected. Best regards, Wolfgang Denk --

Re: [ANN] U-Boot v2021.07 released

7 (3.7%) ARM 3 (1.6%) Intel3 (1.6%) Toradex 3 (1.6%) ... Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germ

Re: [RFC PATCH 02/28] cli: Add LIL shell

r no error handling, and comes with an incompatible command line interface? There is a zillion of shell scripts in the field, from non-trivial boot sequences to complex download-and-upgrade scripts. You can't really even think of breaking compatibility on such a level. Best regards, Wolfga

Re: [RFC PATCH 02/28] cli: Add LIL shell

mmand interpreter - the question we hear are more like: "When will you support IPv6?", "NFS does not work with recent Linux distros, will this be fixed?", "Can I download over WiFi?", "Can I download using HTTP/HTTPS?", "How can I harden U-Boot for secu

Re: [RFC PATCH 05/28] cli: lil: Rename some functions to be more like TCL

e be doing or need to be doing before we hand things over to the OS? You are shooting yourself in the knee here. If you think out CLI should not be adding new features, then we should just stick with our ancient hush and neither update it nor replace it with something else that adds not only new f

Re: [RFC PATCH 02/28] cli: Add LIL shell

o that if there are any systems with > non-trivial scripts but upgrade U-Boot and don't / won't / can't > re-validate their entire sequence, they can just use the old cli. Do you actually have an example where code working on our ancient port of hush would fail on the current upstrea

Re: [RFC PATCH 02/28] cli: Add LIL shell

h risk-adverse groups that just > dropping our old hush entirely might not be possible right away. Of > course, if all of the current in-tree complex cases Just Work, that > might be a good argument against needing to keep such levels of > backwards compatibility. There is only one way t

Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup

ould be akin to going over the > entire upstream codebase and porting it from scratch. Agreed. But this means porting some code, which still implements the very same language (i. e. "shell"). There would be no new language in this case - just a bigger subset, less restrictions, mo

Re: [RFC PATCH 05/28] cli: lil: Rename some functions to be more like TCL

systems. Hey, they even list Forth there. Maybe somebody should port OpenBoot, so we can have a Forth interpreter as new commandline language? We could implement device trees in the old, traditional way then, too :-) Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managin

Re: [RFC PATCH 02/28] cli: Add LIL shell

roblems+in+Tcl [3] https://wiki.tcl-lang.org/page/Why+can+I+not+place+unmatched+braces+in+Tcl+comments [4] https://tbot.tools/ Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,

Re: [PATCH] efidebug: Introduce bootmgr command

efidebug' could be kept, but the new name would be 'efi debug'; likewise, your new command would be 'efi bootmgr' [or just 'efi boot' ?] Thanks! Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirche

Re: [PATCH] efidebug: Introduce bootmgr command

e been in use forever): env print -> printenv env save-> saveenv env set -> setenv etc. Maybe a similar approach makes sense for "efi" (with or without backward compatibility, as you like - after all, this is just a little name space p

Re: [PATCH] efidebug: Introduce bootmgr command

y used before, it makes a lot of sense to break combined functionality into separate subcommands (probably also with separate Kconfig options so you can select what you really need only). Thanks! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang De

Re: [PATCH] efidebug: Introduce bootmgr command

nnecessary sub commands - memory footprint: comes with configurability - style: it follows existing practise. Just to name a few. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, G

Re: [PATCH 00/15] lib: Add support for a decimal 0m prefix for numbers

e for typical configurations? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Sorry, but my karma just ran over your dogma.

Re: [PATCH 00/15] lib: Add support for a decimal 0m prefix for numbers

is it worth the code size? Simon's patches include some cleanup, which probably even reduces the size, so good. But whether it's 0m123 or 0t123 or 0!123 or ... is pretty much irrelevant - chose one symbol, use it, and be done with that. Best regards, Wolfgang Denk -- DENX Software

Re: [PATCH 13/15] RFC: lib: Support a binary prefix 0y

her interesting numberbases, like 42. But ... do we really *need* all this stuff? %% (signatures) Perfection is reached, not when there is no longer anything to add, but when there is no longer anything to take away. - Antoine de Saint-Exupery Best regard

Re: [PATCH 13/15] RFC: lib: Support a binary prefix 0y

hed: 0b please That doesn't work, as 0b010101 is in U-Boot in alost all contexts interpreted as 0x0b010101 (hex) = 184615169 (dec) Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenze

Re: [PATCH 13/15] RFC: lib: Support a binary prefix 0y

I can't see how this should work... > Well, yes. Perhaps we should just drop octal? Drop? AFAICT we never supported octal. Something like "md 040" will start dumping at 0x0040, right? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Direc

Re: [PATCH 13/15] RFC: lib: Support a binary prefix 0y

ng starts with 0 it is interpreted > as octal. That's a bug, then. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de panic: can't find /

Re: [PATCH 13/15] RFC: lib: Support a binary prefix 0y

it is a 19-year-old bug: (was lib_generic/vsprintc.c) > > 153d511e369 Initial revision Mea culpa. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-814

Re: [PATCH] lib: rsa: Add debug message on algo mismatch

> + info->name, algo); > return -EFAULT; > + } If this is considered an error, should that not be a printf() then instead of a debug() which users will never see? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wol

[IMPORTANT] gitlab relocation / rename

2021-02-28. We will send a further announcement once everything is back up and running. Thanks for your understanding and patience! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzel

Re: [PATCH 1/1] Correct U-Boot upstream repository

I posted it on the U-Boot list, and on the Custodian and Board Mainteiner lists, too (plus on the Xenomai list). I also update the link on the web page. What else can be done? If people don't even read messages flagged as important ? Best regards, Wolfgang Denk -- DENX Software Engin

Re: [PATCH 1/1] Correct U-Boot upstream repository

logging in on source.denx.de . Access to | gitlab.denx.de will no longer work! | | - CI runners connected to gitlab.denx.de need to be re-registered | with source.denx.de . And just to avoid misunderstandings: MTTPS too, of course. Best regards, Wolfgang Denk -- DENX Software Engin

  1   2   3   4   5   6   7   8   9   10   >