Dear Rasmus, In message <20200316212337.30204-1-rasmus.villem...@prevas.dk> you wrote: > wait_ticks() is only used by the ppc-specific __udelay() > function. Having the powerpc version of __udelay implicitly call > WATCHDOG_RESET() is inconsistent with other architectures' (and the > generic __udelay() in lib/time.c) implementations. It also means a > driver cannot use __udelay() as the raw primitive it is supposed to be > - e.g. a watchdog driver that needs to do a short delay between two > operations needed to perform a ping sequence.
Many PPC processors implement the watchdog differently than other sysytems - for example, on many systems the watchdog is automatically enabled after power on / reset. > There are not that many __udelay() calls, so I doubt this causes a > regression for anyone. Callers of udelay() are not affected, since > udelay() itself does one WATCHDOG_RESET() per __udelay() call. Which exact platforms have you tested this on? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Diplomacy is the art of saying "nice doggy" until you can find a rock.
