Re: [PATCH v3 2/3] arm: Add an __image_copy_start symbol for ARMv8

2021-08-04 Thread Scott Wood
On Sun, 2021-08-01 at 14:59 -0600, Simon Glass wrote: > This symbol is needed for binman to locate the start of the image. Add it. > > Note: the existing line to bring in the .__image_copy_start symbol does > not appear to do anything. > > Signed-off-by: Simon Glass > ---

Re: [U-Boot] [PATCH 08/13 v3] ARM: OMAP3: Add NAND support

2008-10-13 Thread Scott Wood
On Sat, Oct 11, 2008 at 10:55:37AM +0200, Dirk Behme wrote: > >It's looking decent. I have some concerns about the ECC switching, > >though. > > Yes, I know, agreed. But changing existing kernels isn't easy, too. I meant the implementation (specifically, the re-init of things done by nand_scan_t

Re: [U-Boot] [PATCH] Flex-OneNAND driver

2008-10-14 Thread Scott Wood
On Tue, Oct 14, 2008 at 01:30:03PM +0200, Wolfgang Denk wrote: > Dear Scott, > > In message <[EMAIL PROTECTED]> apgmoorthy wrote: > > > > This patch adds support for Samsung Flex-OneNAND devices. > > > > Flex-OneNAND combines SLC and MLC technologies into a single > > device. SLC area provides i

Re: [U-Boot] fsl_elbc_nand.c and nand_boot_fsl_elbc.c for large page devices

2008-10-16 Thread Scott Wood
On Tue, Oct 14, 2008 at 01:24:09PM -0700, Ron Madrid wrote: > 1. I don't see anywhere that the AL (address length, or number of > address cycles) can be set to anything other than 2. It appears to be > hard coded in both files. Correct. AFAICT, setting AL to anything less than 2 is just an opti

Re: [U-Boot] fsl_elbc_nand.c and nand_boot_fsl_elbc.c for large page devices

2008-10-16 Thread Scott Wood
Ron Madrid wrote: > So is there a particular convention for which bytes should be used > within the OOB area for an ECC? I've looked for information on this > but haven't been able to come up with anything. The 8313 manual says that when booting from NAND, it expects ECCM 0 on small page and ECC

[U-Boot] [PATCH] 83xx NAND boot: wait for LTESR[CC]

2008-10-17 Thread Scott Wood
oblems when booting from NAND on 8313erdb. Signed-off-by: Scott Wood <[EMAIL PROTECTED]> Acked-by: Kim Phillips <[EMAIL PROTECTED]> --- Applied to u-boot-nand-flash cpu/mpc83xx/start.S | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/cpu/mpc83xx/sta

[U-Boot] Pull request: nand-flash

2008-10-17 Thread Scott Wood
The following changes since commit bf29e0ea0af03d593c64614136acc723a7a022a2: Yuri Tikhonov (1): ppc4xx: PPC44x MQ initialization are available in the git repository at: git://www.denx.de/git/u-boot-nand-flash.git master Lepcha Suchit (1): 83xx NAND boot: wait for LTESR[CC] cp

Re: [U-Boot] IBAT and DBAT question

2008-10-17 Thread Scott Wood
On Thu, Oct 16, 2008 at 01:04:37PM -0200, Alemao wrote: > If Im not going to use PCI in U-Boot (just in linux kernel), do I have > to set IBAT and DBAT in the board configuration file? No. > Or linux kernel sets them again in arch/powerpc/mm/ppc_mmu_32.c ? Yes. -Scott _

Re: [U-Boot] [PATCH] Flex-OneNAND driver

2008-10-22 Thread Scott Wood
On Mon, Sep 22, 2008 at 11:58:51AM +0530, apgmoorthy wrote: > Hi All, > This patch adds support for Samsung Flex-OneNAND devices. > > Flex-OneNAND combines SLC and MLC technologies into a single > device. SLC area provides increased reliability and speed, suitable > for storing code and data, such

Re: [U-Boot] [PATCH] NAND Send RESET before initial READID

2008-10-23 Thread Scott Wood
On Fri, Oct 17, 2008 at 01:01:48PM -0400, David George wrote: > We had a problem where NAND device ID would be corrupted after a > power-cycle. According to the Micron datasheet it requires a RESET > after power-up before any commands may be issued. Without this patch > the manufacturer ID wou

[U-Boot] [PATCH] NAND: sync with 2.6.27

2008-10-24 Thread Scott Wood
t was recently synced by Kyungmin Park, and I'm not sure exactly what the common ancestor is. Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- Applied to u-boot-nand-flash drivers/mtd/nand/diskonchip.c | 43 +--- drivers/mtd/nand/nand_bas

[U-Boot] [PATCH] NAND: Reset chip on power-up

2008-10-24 Thread Scott Wood
PROTECTED]> Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- Applied to u-boot-nand-flash drivers/mtd/nand/nand_base.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c index 4069ab1..ba05b76 100644

Re: [U-Boot] [PATCH 08/13 v4] ARM: OMAP3: Add NAND support

2008-10-27 Thread Scott Wood
On Fri, Oct 17, 2008 at 09:28:50PM +0200, [EMAIL PROTECTED] wrote: > + if (nand_curr_device < 0 || > + nand_curr_device >= CONFIG_SYS_MAX_NAND_DEVICE || > + !nand_info[nand_curr_device].name) { > + printf("Error: Can't switch ecc, no devices available\n"); >

Re: [U-Boot] [PATCH] Flex-OneNAND driver

2008-10-27 Thread Scott Wood
On Fri, Oct 24, 2008 at 07:20:12PM +0530, Rohit wrote: > On DDP Flex-OneNAND, regions can be 1, 2, 3 or 4 based on boundary setting. > Exposing as separate devices will be bit complex in these scenarios. Why? If it's dynamic changes to the boundary that concern you, you could tear down the device

Re: [U-Boot] [PATCH 08/13 v4] ARM: OMAP3: Add NAND support

2008-10-27 Thread Scott Wood
Jean-Christophe PLAGNIOL-VILLARD wrote: > >> Otherwise ACK, if the ARM maintainers are OK with passing integers as >> addresses to writel(). > No not really :-) I figured I'd already complained about it a couple times, so it's your turn now. -Scott

Re: [U-Boot] [PATCH] - fix "nand erase clean" problem

2008-10-27 Thread Scott Wood
On Sun, Oct 26, 2008 at 05:48:47PM +0100, Ilko Iliev wrote: > With this patch "nand erase clean" writes correctly the cleanmarkers. > Without this patch "nand erase clean" fills the OOB with zeros which > marks all blocks as bad. > > Signed-off-by: Ilko Iliev <[EMAIL PROTECTED]> > --- > drivers/

Re: [U-Boot] [PATCH] - fix "nand erase clean" problem

2008-10-27 Thread Scott Wood
Ilko Iliev wrote: >> Why must the cleanmarker fit in the first free segment? >> > The Linux NAND driver looks for the cleanmarkers at this place. AFAICT, it does a read using MTD_OOB_AUTO, which can span multiple free segments. >> What if oobsize > 64 (as with 4k pages)? Why write anything a

[U-Boot] [PATCH] NAND: Align right column of the shorthelp with other commands.

2008-10-27 Thread Scott Wood
I accidentally broke this in when making consistent the partial alignment of the longhelp. Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- Applied to u-boot-nand-flash. common/cmd_nand.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/common/cmd_nand.c b/

[U-Boot] [PATCH] mpc8313erdb: Document NAND boot.

2008-10-27 Thread Scott Wood
Previously, the documentation claimed that NAND boot is not supported. This is no longer true. Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- doc/README.mpc8313erdb | 36 1 files changed, 32 insertions(+), 4 deletions(-) diff --git

Re: [U-Boot] [PATCH] Flex-OneNAND driver

2008-10-28 Thread Scott Wood
On Tue, Oct 28, 2008 at 01:53:24PM +0900, Kyungmin Park wrote: > > Of course, I may simply be missing something about how this hardware works. > > > >> Also, comments from MTD mailing list have been included. > > > > If this is going to go into Linux, perhaps we should wait until it is merged > > t

Re: [U-Boot] [PATCH 2/3] iMX31: Add support to copy NAND Flash code to RAM

2008-10-28 Thread Scott Wood
Wolfgang Denk wrote: > Dear "Alan Carvalho de Assis", > > In message <[EMAIL PROTECTED]> you wrote: >> This code is executed from internal 2KB NAND Flash Controller RAM buffer >> and will copy the remaining U-Boot code from NAND Flash verifying its >> bad blocks (case it exists). >> >> Signed-off-

[U-Boot] [PATCH] mpc83xx pci: Round up memory size in inbound window.

2008-10-28 Thread Scott Wood
The current calculation will fail to cover all memory if its size is not a power of two. Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- cpu/mpc83xx/pci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cpu/mpc83xx/pci.c b/cpu/mpc83xx/pci.c index 5b8eeb7..a

Re: [U-Boot] [PATCH] - fix "nand erase clean" problem

2008-10-28 Thread Scott Wood
On Tue, Oct 28, 2008 at 11:45:21AM +0100, Ilko Iliev wrote: > > AFAICT, it does a read using MTD_OOB_AUTO, which can span multiple > > free segments. > Yes, but the current U-BOOT uses MTD_OOB_PLACE and the command "nand > erase clean" marks all blocks as bad. I'm not defending the current code.

[U-Boot] [PATCH 3/4] NAND fsl elbc: Set FMR[ECCM] based on page size.

2008-10-29 Thread Scott Wood
Hardware expects ECCM 0 for small page and ECCM 1 for large page when booting from NAND, so use those defaults. Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- drivers/mtd/nand/fsl_elbc_nand.c | 16 ++-- 1 files changed, 14 insertions(+), 2 deletions(-) diff --git a/drive

[U-Boot] [PATCH 2/4] NAND: Add support for MPC8572DS board

2008-10-29 Thread Scott Wood
code size with NAND enabled. Signed-off-by: Jason Jin <[EMAIL PROTECTED]> Signed-off-by: Haiying Wang <[EMAIL PROTECTED]> Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- board/freescale/mpc8572ds/law.c |1 + board/freescale/mpc8572ds/tlb.c |6 include/co

[U-Boot] [PATCH 1/4] Make Freescale local bus registers available for both 83xx and 85xx.

2008-10-29 Thread Scott Wood
R from mpc83xx.h to asm/fsl_lbc.h so that 85xx can share them. Signed-off-by: Jason Jin <[EMAIL PROTECTED]> Signed-off-by: Haiying Wang <[EMAIL PROTECTED]> Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- board/freescale/mpc8313erdb/sdram.c |2 +- board/freescale/mpc8349e

[U-Boot] [PATCH 4/4] NAND: Properly create JFFS2 cleanmarkers.

2008-10-29 Thread Scott Wood
As reported by Ilko Iliev <[EMAIL PROTECTED]>, the "nand erase clean" command is currently broken, and among other things causes all blocks to be marked bad. This implements it properly using MTD_OOB_AUTO, along with some indentation fixes. Signed-off-by: Scott Wood &

Re: [U-Boot] [PATCH v2] ADS5121 NAND driver

2008-10-29 Thread Scott Wood
John Rigby wrote: > ADS5121 rev4 / MPC5121e rev2 only What is unique about that revision that it cannot share a driver? It certainly shouldn't be board-specific... > This controller treats 2K pages as 4 512 byte pages > and the hw ecc is over the combined 512 byte main > area and the first 7 byt

[U-Boot] Pull request: nand flash

2008-10-29 Thread Scott Wood
registers available for both 83xx and 85xx. NAND: Add support for MPC8572DS board Karl Beldan (1): NAND: Reset chip on power-up Scott Wood (5): NAND: sync with 2.6.27 NAND: Align right column of the shorthelp with other commands. NAND fsl elbc: Set FMR[ECCM] based on page

Re: [U-Boot] [PATCH v2] ADS5121 NAND driver

2008-10-31 Thread Scott Wood
On Wed, Oct 29, 2008 at 05:37:52PM -0600, John Rigby wrote: > Scott, thanks for your feedback. I can easily fix most of the issues. > > The one question I have is if this can go in only supporting 5121 rev2. > If I need to add rev1 support it will take more time than I have right now. If rev1

Re: [U-Boot] [PATCH] dataflash: fix a problem with the last partition

2008-10-31 Thread Scott Wood
Wolfgang Denk wrote: > In message <[EMAIL PROTECTED]> you wrote: diff --git a/drivers/mtd/dataflash.c b/drivers/mtd/dataflash.c index 201e518..43746e7 100644 --- a/drivers/mtd/dataflash.c +++ b/drivers/mtd/dataflash.c >>> Who is supposed to handle this one? >>> >>> Stefan is it

Re: [U-Boot] [patch] U-Boot Firetux board support

2008-10-31 Thread Scott Wood
On Fri, Oct 31, 2008 at 03:30:33PM +0100, Juergen Schoew wrote: > +#ifdef CONFIG_CMD_NAND > +void firetux_nandflash_init(void) > +{ > + /* Hardware configuration */ > + /* setup GPIOB18 / FMP40 to GPIO input with internal pullup */ > + /* clear bits */ > + *(vu_long *)(PNX8181_SCON_

Re: [U-Boot] [PATCH 1/2] NAND: Fix CONFIG_ENV_ADDR for MPC8572DS

2008-10-31 Thread Scott Wood
On Fri, Oct 31, 2008 at 05:06:14AM -0500, Kumar Gala wrote: > From: Haiying Wang <[EMAIL PROTECTED]> > > CONFIG_ENV_ADDR should be (CONFIG_SYS_MONITOR_BASE - CONFIG_ENV_SECT_SIZE). > > Signed-off-by: Haiying Wang <[EMAIL PROTECTED]> > Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> Applied 1-2 to

Re: [U-Boot] [PATCH 4/4] New board support: nand_spl specific files

2008-10-31 Thread Scott Wood
On Fri, Oct 31, 2008 at 11:21:09AM -0700, Ron Madrid wrote: > This is a patch containing all board specific files for the nand_spl > directory tree for the support of booting from NAND. > > Signed off by: Ron Madrid <[EMAIL PROTECTED]> Patch is whitespace-mangled; TABs seem to have been replaced

Re: [U-Boot] [PATCH 3/4] New board support: board dir tree files

2008-10-31 Thread Scott Wood
Ron Madrid wrote: > +int board_early_init_f(void) > +{ > +volatile immap_t *im = (immap_t *)CFG_IMMR; > + > +if (im->pmc.pmccr1 & PMCCR1_POWER_OFF) > +gd->flags |= GD_FLG_SILENT; > + > +return 0; > +} You include this bit of suspend/resume support from mpc8313erdb, but not the

Re: [U-Boot] onenand and nand together

2008-10-31 Thread Scott Wood
On Thu, Oct 30, 2008 at 08:55:22AM +0100, Alessandro Rubini wrote: > Unfortunately, jffs2 code in head complains if both CONFIG_CMD_NAND > and CONFIG_CMD_ONENAND are defined. > > This trivial one-liner seems to fix one of the problems (although it > introduces a warning if neither one is defined),

[U-Boot] [PATCH] JFFS2: Eliminate compiler error when both NAND and OneNAND are enabled.

2008-10-31 Thread Scott Wood
Reported-by: Alessandro Rubini <[EMAIL PROTECTED]> Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- Applied to u-boot-nand-flash fs/jffs2/jffs2_1pass.c | 12 +--- 1 files changed, 5 insertions(+), 7 deletions(-) diff --git a/fs/jffs2/jffs2_1pass.c b/fs/jffs2/jffs2_1

[U-Boot] Pull request: nand flash

2008-10-31 Thread Scott Wood
): NAND: Fix CONFIG_ENV_ADDR for MPC8572DS Jason Jin (1): NAND: Add NAND support for MPC8536DS board Scott Wood (1): JFFS2: Eliminate compiler error when both NAND and OneNAND are enabled. board/freescale/mpc8536ds/law.c |1 + board/freescale/mpc8536ds/tlb.c |5 +++ fs/jffs2

Re: [U-Boot] [PATCH] Allow Nand and OneNand to coexist

2008-10-31 Thread Scott Wood
ling code for a board hosting both Nand and OneNand chips. > > Reported-by: Scott Wood <[EMAIL PROTECTED]> > Signed-off-by: Alessandro Rubini <[EMAIL PROTECTED]> Applied to u-boot-nand-flash, thanks. You may want to submit a similar patch to Linux. -Scott __

[U-Boot] Pull request: nand flash

2008-10-31 Thread Scott Wood
://git.denx.de/u-boot-nand-flash.git master Alessandro Rubini (1): NAND: Allow NAND and OneNAND to coexist Haiying Wang (1): NAND: Fix CONFIG_ENV_ADDR for MPC8572DS Jason Jin (1): NAND: Add NAND support for MPC8536DS board Scott Wood (1): JFFS2: Eliminate compiler error when both

Re: [U-Boot] [PATCH] JFFS2: Eliminate compiler error when both NAND and OneNAND are enabled.

2008-10-31 Thread Scott Wood
Alessandro Rubini wrote: >> Reported-by: > > I didn't find a policy for "Reported-by:" or other tags besides > Signed-off-by: and Acked-by: . Mine are surely wronh in the patch I sent. > Any pointer for us to get a culture? I don't think it's anything as official as those other two; just a way

Re: [U-Boot] [patch 1/1] Remove linking to libgcc while compiling U-boot

2008-10-31 Thread Scott Wood
On Fri, Oct 31, 2008 at 11:37:33PM +0100, Remy Bohmer wrote: > Currently U-boot is linking against libgcc. This should not be needed > because the compiler toolchain is usually compiled with a certain OS > interface in mind, and can even be configured for GNU-EABI interfaces. > This can cause linki

Re: [U-Boot] [patch] U-Boot Firetux board support

2008-11-03 Thread Scott Wood
Jürgen Schöw wrote: > This seems to be similair to the Steppingstone bootloader from Samsung. This > SPL is already in the eeprom of the system and will be (hopefully) integrated > in the cpu rom mask for the next revision. > > If I see it correct, I have to define the whole parameterset for the

Re: [U-Boot] [PATCH] strings: use puts() rather than printf()

2008-11-05 Thread Scott Wood
Mike Frysinger wrote: > When running `strings` on really long strings, the stack tends to get > smashed due to printf(). Switch to puts() instead since we're only passing > the data through. ...which raises the question of why we don't have vsnprintf(). -Scott ___

Re: [U-Boot] [PATCH v3] Freescale NFC NAND driver

2008-11-05 Thread Scott Wood
On Tue, Nov 04, 2008 at 07:02:41PM -0700, John Rigby wrote: > +#define MIN(x, y)((x < y) ? x : y) Please use the min() macro defined in include/common.h. > +static struct fsl_nfc_private { > + struct mtd_info mtd; > + char spare_only; > + char status_req; > + u16 col_a

Re: [U-Boot] [PATCH] Flex-OneNAND driver

2008-11-06 Thread Scott Wood
On Thu, Nov 06, 2008 at 08:59:06AM +0530, Amit Kumar Sharma wrote: > We can provide two device registration for SLC and MLC are > but I don't know how useful it is because FlexOneNand > provides boundary settings and user can configure SLC and > MLC area and other point is still device registra

Re: [U-Boot] [PATCH 8/9] mpc8641: Change 32-bit memory map

2008-11-06 Thread Scott Wood
Becky Bruce wrote: > The memory map on the 8641hpcn is modified to look more like > the 85xx boards; this is a step towards a more standardized > layout going forward. As part of this change, we now relocate > the flash. > > The regions for some of the mappings were far larger than they > needed t

Re: [U-Boot] [PATCH] toplevel Makefile: Add MPC8641HPCN_36BIT target

2008-11-06 Thread Scott Wood
Becky Bruce wrote: > This will enable CONFIG_PHYS_36BIT for MPC8641HPCN. > > Signed-off-by: Becky Bruce <[EMAIL PROTECTED]> > --- > Makefile |8 +++- > 1 files changed, 7 insertions(+), 1 deletions(-) > > diff --git a/Makefile b/Makefile > index 983a3cd..09e671d 100644 > --- a/Makefile >

Re: [U-Boot] [PATCH] toplevel Makefile: Add MPC8641HPCN_36BIT target

2008-11-06 Thread Scott Wood
Becky Bruce wrote: > We don't want PHYS_64BIT on unconditionally. It has the effect of > moving all the devices into high physical memory, which means you need a > different Linux/dts. Another reason we should really be packaging the device trees with u-boot. > I expect the normal case to be

Re: [U-Boot] [PATCH 8/9] mpc8641: Change 32-bit memory map

2008-11-06 Thread Scott Wood
Becky Bruce wrote: > We *do* need a comment in the release notes for this revision of u-boot > that the map for 8641 has changed so it doesn't catch anyone by surprise. How about a runtime check in the board fdt code to print a warning if it finds an old device tree? Unfortunately, using new dt

Re: [U-Boot] [PATCH 8/9] mpc8641: Change 32-bit memory map

2008-11-06 Thread Scott Wood
Becky Bruce wrote: > On Nov 6, 2008, at 4:16 PM, Scott Wood wrote: >> How about a runtime check in the board fdt code to print a warning if >> it finds an old device tree? Unfortunately, using new dts with old >> u-boot isn't as easy to detect. > > Where exactly

Re: [U-Boot] [PATCH v2] OneNAND: Bad block aware read/write command support

2008-11-07 Thread Scott Wood
On Fri, Nov 07, 2008 at 04:01:13PM +0100, Stefan Roese wrote: > Update OneNAND command to support bad block awareness. > Also change the OneNAND command style to better match the > NAND version. Is there any chance that we could merge this code with cmd_nand.c? > +static struct mtd_info *mtd = &o

Re: [U-Boot] [PATCH] OneNAND: Fix compiler warnings and add weak attribute to memcpy_16()

2008-11-07 Thread Scott Wood
Stefan Roese wrote: > This patch adds memcpy_16_from_onenand() and memcpy_16_to_onenand() > functions and defaults them to the already available memcpy_16() > function. They are defined weak so that they can be overwritten by > a board/platform specific version. > > This is needed for the vcth boa

Re: [U-Boot] [PATCH] OneNAND: Fix compiler warnings and add weak attribute to memcpy_16()

2008-11-10 Thread Scott Wood
Stefan Roese wrote: > On Friday 07 November 2008, Scott Wood wrote: >> Stefan Roese wrote: >>> This is needed for the vcth board support (still to come) which needs >>> custom access routines here. >> Can it just override write_bufferram and read_bufferram? >

Re: [U-Boot] OMAP3 broken NAND hardware ECC generation

2008-11-10 Thread Scott Wood
Dirk Behme wrote: > I'm not sure, but it seems to me, that omap_enable_hwecc() is never > called. An printf() in this function is not shown. > > Maybe call of nand_scan_tail(mtd); in omap_nand_switch_ecc() resets > anything? Or any other idea? You never cleared out nand->ecc.write_page (and oth

Re: [U-Boot] [PATCH] mpc8641: Try to detect old .dts files

2008-11-10 Thread Scott Wood
On Fri, Nov 07, 2008 at 01:45:57PM -0600, Becky Bruce wrote: > + if (tmp) { > + u64 addr; > + if (addrcells && (*addrcells == 2)) > + addr = *tmp; > + else > + addr = *(u32 *)tmp; If #address-cells is missing (not that

Re: [U-Boot] [PATCH] OneNAND: Fix compiler warnings

2008-11-11 Thread Scott Wood
On Tue, Nov 11, 2008 at 10:28:53AM +0100, Stefan Roese wrote: > Signed-off-by: Stefan Roese <[EMAIL PROTECTED]> > --- > This patch has to be applied on top of the patch submitted by Kyungmin Park > on 2008-11-04: > [PATCH] [OneNAND] Sync with 2.6.27 > > It replaces my patch "[PATCH] OneNAND: Fix c

Re: [U-Boot] [PATCH] OneNAND: Save version_id in onenand_chip struct

2008-11-11 Thread Scott Wood
On Tue, Nov 11, 2008 at 10:29:09AM +0100, Stefan Roese wrote: > The version (ver_id) was not stored in the onenand_chip structure and > because of this the continuous locking scheme could be enabled on some > chips. > > Signed-off-by: Stefan Roese <[EMAIL PROTECTED]> Applied to u-boot-nand-flash/

Re: [U-Boot] [PATCH-OMAP3] OMAP3: Fix broken NAND ECC HW switch

2008-11-11 Thread Scott Wood
[EMAIL PROTECTED] wrote: > Fix broken NAND ECC HW switch and invert logic of if(!hardware) for easier > reading. Acked-by: Scott Wood <[EMAIL PROTECTED]> -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] mpc83xx: enable eLBC NAND support for MPC8315ERDB board

2008-11-11 Thread Scott Wood
On Tue, Nov 04, 2008 at 02:55:06PM +0800, Dave Liu wrote: > Signed-off-by: Dave Liu <[EMAIL PROTECTED]> Applied to u-boot-nand-flash/next. -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] [OneNAND] Sync with 2.6.27

2008-11-11 Thread Scott Wood
On Tue, Nov 04, 2008 at 09:24:07AM +0900, Kyungmin Park wrote: > Sync with OneNAND kernel codes > > Signed-off-by: Kyungmin Park <[EMAIL PROTECTED]> Applied to u-boot-nand-flash/next, minus one instance of trailing whitespace. -Scott ___ U-Boot mailing

Re: [U-Boot] [PATCH v3] OneNAND: Bad block aware read/write command support

2008-11-12 Thread Scott Wood
On Wed, Nov 12, 2008 at 01:47:24PM +0100, Stefan Roese wrote: > Update OneNAND command to support bad block awareness. > Also change the OneNAND command style to better match the > NAND version. > > Signed-off-by: Stefan Roese <[EMAIL PROTECTED]> > Acked-by: Kyungmin Park <[EMAIL PROTECTED]> > ---

Re: [U-Boot] [PATCH] mpc83xx: New board support SIMPC8313

2008-11-12 Thread Scott Wood
Ron Madrid wrote: >>> +*((u32 *)(CFG_IMMR + addr)) = data; >> use the out_be32 i/o memory accessor and friends please (here and >> elsewhere in the patch). >> > > I am trying to resolve this last issue with your review and replacing > all of the i/o memory accesses with in/out_be* has caus

Re: [U-Boot] samsung 1GB nand flash

2008-11-12 Thread Scott Wood
chandan wrote: > I am using 1GB nand flash K9F1G08 flash series with SAM > 9263microcontroller. Here I am not able load the U boot in to the > board.because 1GB nand flash not defined in the nand.h and nand.c > .how to make changes in the code and where.Please educate on this > issue. The NAND dev

Re: [U-Boot] [PATCH] mpc83xx: New board support SIMPC8313

2008-11-13 Thread Scott Wood
Ron Madrid wrote: >> Use raw accessors and make sure that explicit barriers are used where >> needed. > > Is there somewhere that I can find information regarding when and where are > the appropriate places are to use barriers? Basically, you need a barrier any time ordering matters. If access

Re: [U-Boot] [PATCH] [ONENAND] Add markbad function

2008-11-17 Thread Scott Wood
On Thu, Nov 13, 2008 at 03:14:33PM +0900, Kyungmin Park wrote: > Add missing markbad function > If not, it's hang when it entered the mtd->mard_bad(). Applied to u-boot-nand-flash/next. > It's not against the u-boot-nand. Hmm? It appears to apply to the NAND next branch, and not mainline... -S

Re: [U-Boot] [PATCH] NAND: fixed bugs in nand_[read, write]_skip_bad()

2008-11-21 Thread Scott Wood
On Tue, Nov 18, 2008 at 07:27:29PM +0200, Valeriy Glushkov wrote: > - fixed bugs in nand_[read,write]_skip_bad() to double speed Changelog should specify what the bugs are. > - added printing of dots to show progress > > Signed-off-by: Valeriy Glushkov <[EMAIL PROTECTED]> > --- > drivers/mtd/na

Re: [U-Boot] [PATCH 3/3] NAND FSL elbc: Use virt_to_phys to determine which bank is in use

2008-11-24 Thread Scott Wood
Kumar Gala wrote: > diff --git a/drivers/mtd/nand/fsl_elbc_nand.c > b/drivers/mtd/nand/fsl_elbc_nand.c > index 367c7d7..3f318e0 100644 > --- a/drivers/mtd/nand/fsl_elbc_nand.c > +++ b/drivers/mtd/nand/fsl_elbc_nand.c > @@ -718,7 +718,7 @@ static void fsl_elbc_ctrl_init(void) > int board_nand_init

Re: [U-Boot] [PATCH 3/3] ppc: Use addrmap in virt_to_phys and map_physmem.

2008-11-24 Thread Scott Wood
On Mon, Nov 24, 2008 at 10:47:40AM -0600, Kumar Gala wrote: > @@ -287,7 +291,11 @@ extern inline void out_be32(volatile unsigned __iomem > *addr, int val) > static inline void * > map_physmem(phys_addr_t paddr, unsigned long len, unsigned long flags) > { > +#ifdef CONFIG_ADDR_MAP > + return

Re: [U-Boot] [PATCH 1/3] Introduce addr_map library

2008-11-24 Thread Scott Wood
On Mon, Nov 24, 2008 at 10:47:38AM -0600, Kumar Gala wrote: > +static struct { > + phys_addr_t paddr; > + unsigned int vaddr; > + unsigned int size; vaddr/size should be unsigned long (or uintptr_t/size_t). > +phys_addr_t addrmap_virt_to_phys(unsigned int vaddr) > +{ > + int i; >

Re: [U-Boot] [PATCH v2] NAND: fixed bugs in nand_[read, write]_skip_bad()

2008-11-25 Thread Scott Wood
Valeriy Glushkov wrote: > - fixed bugs with returning from nand_[read,write]_skip_bad() to double > read/write speed > > Signed-off-by: Valeriy Glushkov <[EMAIL PROTECTED]> Patch is still whitespace-damaged; applied by hand to u-boot-nand-flash. In the future, do not use Outlook to send patches

Re: [U-Boot] [PATCH v3] mpc83xx: New board support SIMPC8313

2008-11-25 Thread Scott Wood
Kim Phillips wrote: > On Fri, 21 Nov 2008 16:44:18 -0800 (PST) > Ron Madrid <[EMAIL PROTECTED]> wrote: >> This would allow for more board specific nand_spl boot code. >> Would something like this be allowed or am I barking up the >> wrong tree? > > I'd rather we find stuff that can be ifdeffed out

[U-Boot] Pull request: nand flash

2008-11-25 Thread Scott Wood
The following changes since commit 49a4c7476f5f7c67dc8159537d9fbcdcfa91afb8: Wolfgang Denk (1): Merge branch 'master' of git://git.denx.de/u-boot-arm are available in the git repository at: git://git.denx.de/u-boot-nand-flash.git master Scott Wood (1): NAND: Fix

Re: [U-Boot] [PATCH v2] nand: Fix cache and memory inconsistent issue

2008-12-01 Thread Scott Wood
On Fri, Nov 28, 2008 at 08:16:28PM +0800, Dave Liu wrote: > +static void __flush_cache(ulong start, ulong size) No gratuitous underscores. > +{ > + ulong addr, end; > + ulong cache_line = CONFIG_SYS_CACHELINE_SIZE; > + > + end = start + size; > + > + /* clean the dcache, make sure

Re: [U-Boot] [PATCH] lib_ppc: rework the flush_cache

2008-12-02 Thread Scott Wood
Dave Liu wrote: > - It is possible to miss flush/invalidate the last > cache line, we fix it at here. That comment was on the version you posted in the NAND patch; the lib_ppc version actually looks worse -- it tried to round down to avoid the issue, but it was missing a ~. Thus, it flushed e

Re: [U-Boot] frescale NAND FLASH problems

2008-12-02 Thread Scott Wood
Carlos kescuin wrote: > Hi, everyone: > > I'm working with u-boot 2008 version for a freescale M5329EVB. Which version? There were multiple releases in 2008. > nand.c: In function 'nand_hwcontrol': > nand.c:50: error: 'NAND_CTL_SETNCE' undeclared (first use in this function) > nand.c:50: error:

Re: [U-Boot] [PATCH] OneNAND: Add missing mtd info struct before calling onenand_erase()

2008-12-02 Thread Scott Wood
On Thu, Nov 27, 2008 at 02:11:37PM +0100, Stefan Roese wrote: > Without this patch "saveenv" crashes when MTD partitions are enabled (e.g. > for use in UBI) via CONFIG_MTD_PARTITIONS. > > Signed-off-by: Stefan Roese <[EMAIL PROTECTED]> Applied to u-boot-nand-flash -Scott

Re: [U-Boot] [PATCH] lib_ppc: rework the flush_cache

2008-12-03 Thread Scott Wood
Liu Dave wrote: > The lib_ppc version basically is as below. > void flush_cache (ulong start_addr, ulong size) > { > ulong addr, end_addr = start_addr + size; > addr = start_addr & (CONFIG_SYS_CACHELINE_SIZE - 1); > for (addr = start_addr; addr < end_addr; addr += > CONFIG_SYS_CA

Re: [U-Boot] Problem in Optimizing the Boot Loader in Start.s of MPC85xx

2008-12-03 Thread Scott Wood
On Wed, Dec 03, 2008 at 04:05:14PM +0530, Vignesh Kumar B wrote: > I have tried modifying the Start.s of uboot as mentioned below. > When I try to link I get an error "`.bootpg' can't be allocated in > segment 1". > Can someone guide me on this. I am also attaching the start.o and the > linker sc

Re: [U-Boot] [PATCH] OneNAND: Additional sync with 2.6.27

2008-12-03 Thread Scott Wood
On Tue, Dec 02, 2008 at 11:06:47AM +0100, Stefan Roese wrote: > - Add subpage write support > - Add onenand_oob_64/32 ecclayout > > This has been missing and without it UBI has some incompatibilies issues > with the current (>= 2.6.27) Linux kernel version. vid_hdr_offset is > placed differently (

[U-Boot] Pull request: nand flash

2008-12-03 Thread Scott Wood
The following changes since commit 2077e348c2a84901022ad95311b47b70361e6daa: Scott Wood (1): NAND: Fix misplaced return statement in nand_{read,write}_skip_bad(). are available in the git repository at: git://git.denx.de/u-boot-nand-flash.git master Stefan Roese (1): OneNAND

Re: [U-Boot] [PATCH] OneNAND: Fix compiler warnings

2008-12-09 Thread Scott Wood
On Tue, Dec 09, 2008 at 07:27:30AM +0100, Stefan Roese wrote: > Till now Scott has takes care of the OneNAND related patches in his NAND > repository. The latest patches are already present in his next branch, IIRC. > > I'm not sure how you feel about this Scott. Are you willing to officially >

Re: [U-Boot] mtd partitions

2008-12-09 Thread Scott Wood
On Tue, Dec 09, 2008 at 06:09:08PM +0100, Carlos kescuin wrote: > I'm using a Coldfire m5329EVB and I would like to make some partitions (one > for kernel and one for filsystem) on my NAND FLASH (16Mb). I've tryied to > search the u-boot options (u-boo 2008.10) but it doesn't work at all. > > Does

Re: [U-Boot] [PATCH] [ONENAND] Reduce OneNAND IPL code size v2

2008-12-09 Thread Scott Wood
On Mon, Nov 10, 2008 at 01:53:46PM +0900, Kyungmin Park wrote: > OneNAND IPL has common codes for RAM init, load data, and jump to 2nd > bootloader, but it's common code used about 300~400 bytes. So board > specific codes, such as lowlevel_init, can't has enough code. It make > a difficult to imple

Re: [U-Boot] [PATCH v2] Add support for boards where the NOR FLASH is not memory-mapped

2008-12-10 Thread Scott Wood
On Wed, Dec 10, 2008 at 11:41:11AM +0100, Stefan Roese wrote: > +void *board_flash_read_memcpy(void *__to, __const__ void *__from, int n); > + > +#if defined(CONFIG_FLASH_NOT_MEM_MAPPED) > +static inline int flash_read(void *__to, __const__ void *__from, int n) __const__? The other underscores se

Re: [U-Boot] Adding NAND Boot to uboot

2008-12-10 Thread Scott Wood
On Wed, Dec 10, 2008 at 11:37:10AM -0500, Fahd Abidi wrote: > I am relatively new to uboot development and was wondering if someone > can give me some pointers. I am trying to configure uboot to bootup from > NAND on CS0 on an MPC8536 platform. This isn't yet supported, at least in mainline (the

Re: [U-Boot] [PATCH] [ONENAND] Reduce OneNAND IPL code size v2

2008-12-11 Thread Scott Wood
On Wed, Dec 10, 2008 at 09:05:00AM +0900, Kyungmin Park wrote: > >> diff --git a/cpu/arm1136/start.S b/cpu/arm1136/start.S > >> index e622338..132cc4a 100644 > >> --- a/cpu/arm1136/start.S > >> +++ b/cpu/arm1136/start.S > >> @@ -33,23 +33,7 @@ > >> .globl _start > >> _start: breset > >> #ifd

Re: [U-Boot] SATA/IDE/etc... init

2008-12-11 Thread Scott Wood
On Thu, Dec 11, 2008 at 07:47:18AM -0500, Mike Frysinger wrote: > btw, does nand_init() fall into the same category ? Hmm, in general I'd say yes, but that raises the issue with certain drivers (such as fsl elbc) of how to communicate the ECC layout being used to the kernel. Currently (or at lea

Re: [U-Boot] [PATCH] nand: move board_nand_init to nand.h

2008-12-11 Thread Scott Wood
On Sat, Dec 06, 2008 at 02:40:55AM -0500, Mike Frysinger wrote: > Rather than putting the function prototype for board_nand_init() in the one > place where it gets called, put it into nand.h so that every place that also > defines it gets the prototype. Otherwise, errors can go silently unnoticed

Re: [U-Boot] [PATCH] V2 NAND_SPL support for phycore imx31

2008-12-11 Thread Scott Wood
On Fri, Dec 05, 2008 at 02:13:51PM +0300, Maxim Artamonov wrote: > +#ifdef CONFIG_NAND_SPL > +/* somewhat macro to reduce bin size for CONFIG_NAND_SPL*/ > +.macro FILLREGS begreg, val, count, step Why not use this macro always? > @@ -32,6 +35,15 @@ > #include > .globl _start > _start: bre

Re: [U-Boot] [PATCH] SATA: do not auto-initialize during boot

2008-12-11 Thread Scott Wood
Mike Frysinger wrote: > On Thursday 11 December 2008 15:51:32 Kumar Gala wrote: >> 'sata init' isn't safe. It seems like you should only be able to call >> it once. However I think we can keep issuing it and cause bad things >> to happen. > > i dont think so. the SATA driver should be doing the

Re: [U-Boot] [PATCH] SATA: do not auto-initialize during boot

2008-12-11 Thread Scott Wood
Mike Frysinger wrote: > On Thursday 11 December 2008 16:01:33 Scott Wood wrote: >> Mike Frysinger wrote: >>> why ? if the hardware doesnt support it, then the user shouldnt be >>> attempting to use it. if they do, that's their fault for doing something >

Re: [U-Boot] [PATCH] SATA: do not auto-initialize during boot

2008-12-11 Thread Scott Wood
Mike Frysinger wrote: > it made sense when the init step was automatic. but you're telling me users > of your board are incapable of looking at it and going "hmm, this has a SATA > disk" ? it isnt like disks are tiny and they have to scan a board for some > obscure IC. disks are friggin huge.

Re: [U-Boot] [PATCH] SATA: do not auto-initialize during boot

2008-12-11 Thread Scott Wood
Mike Frysinger wrote: > On Thursday 11 December 2008 18:53:00 Wolfgang Denk wrote: >> And if they do, the code should fail gracefully, i. e. print some >> friendly error message like that S-ATA is not available. > > in this case, i think that's up to the controller. i.e. the controller > doesnt

Re: [U-Boot] [PATCH] mpc83xx: Size optimization of start.S

2008-12-15 Thread Scott Wood
On Mon, Dec 15, 2008 at 08:26:03AM +0100, Jens Gehrlein wrote: > Hi Ron, > > Ron Madrid schrieb: > > Currently there are in excess of 100 bytes located at the beginning of the > > image > > built by start.S that are not being utilized. > > Hmmm, are you sure? What if someone designs a board, whe

Re: [U-Boot] [PATCH 06/15 v6] OMAP3: Add NAND support

2008-12-15 Thread Scott Wood
Dirk Behme wrote: > Add NAND support. > > Signed-off-by: Nishanth Menon > Signed-off-by: Syed Mohammed Khasim > Signed-off-by: Dirk Behme > > --- ACK -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 1/4] Flex-OneNAND driver

2008-12-15 Thread Scott Wood
On Thu, Dec 11, 2008 at 07:57:18PM +0530, Rohit Hagargundgi wrote: > This patch adds support for MLC OneNAND and Flex-OneNAND devices. Patch does not apply to u-boot-nand-flash/next (the master branch is for 2008.12 bugfixes only). It's looking a lot better (though I'm not familiar enough with th

Re: [U-Boot] [PATCH] NAND CMD: Add bad block skipping for nboot

2008-12-15 Thread Scott Wood
On Thu, Dec 11, 2008 at 01:32:40PM -0500, david.kond...@onqlegrand.com wrote: > > This patch adds bad block skipping for nboot command by using > nand_read_skip_bad function. Patch is whitespace-mangled. > > The initial read size had to be increased because there seems to be an > issue with nan

Re: [U-Boot] [PATCH] MTD:NAND Enable nand lock, unlock feature

2008-12-15 Thread Scott Wood
stead > of page boundary. Details in: > http://www.micron.com/products/partdetail?part=MT29C2G24MAKLAJG-6%20IT > > Intial solution provided by Vikram Pandita > Includes preliminary suggestions from Scott Wood > > Signed-off-by: Nishanth Menon Applied to u-b

Re: [U-Boot] Warning in ffs2_1pass.c

2008-12-15 Thread Scott Wood
On Sat, Dec 13, 2008 at 06:30:21PM +0100, Dirk Behme wrote: > Just fyi: Using git head (89d56f5503eed351efe5ab0b4dd0f1e888fd2336: > Merge branch 'master' of git://git.denx.de/u-boot-ppc4xx) I get warning: > > -- cut -- > ffs2_1pass.c:1411:1: warning: "min_t" redefined > In file include/nand.h:30,

  1   2   3   4   5   6   7   8   9   10   >