Re: [U-Boot] [PATCH] ehci-omap: fix for enabling the correct usb port

2012-04-20 Thread Govindraj
On Fri, Apr 20, 2012 at 2:55 AM, Jeroen Hofstee wrote: > This is just a patch for the problem reported here: > http://lists.denx.de/pipermail/u-boot/2012-February/117580.html originally > reported by Igor. > > "Looks like this is copy paste error from my side,(for port2/3 it should have > been b

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-10 Thread Govindraj
Hi Marek, Thanks for you review. On Tue, Jan 10, 2012 at 9:37 PM, Marek Vasut wrote: >> From: "Govindraj.R" >> >> Clean up added ehci-omap.c and make it generic for re-use across >> soc having same ehci ip block. Also pass the modes to be configured >> and configure the ports accordingly. All u

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-11 Thread Govindraj
On Wed, Jan 11, 2012 at 4:22 PM, Marek Vasut wrote: >> Hi Marek, >> >> Thanks for you review. >> >> On Tue, Jan 10, 2012 at 9:37 PM, Marek Vasut wrote: >> >> From: "Govindraj.R" >> >> >> >> Clean up added ehci-omap.c and make it generic for re-use across >> >> soc having same ehci ip block. Also

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-11 Thread Govindraj
On Wed, Jan 11, 2012 at 6:16 PM, Marek Vasut wrote: >> On Wed, Jan 11, 2012 at 4:22 PM, Marek Vasut wrote: >> >> Hi Marek, >> >> >> >> Thanks for you review. >> >> >> >> On Tue, Jan 10, 2012 at 9:37 PM, Marek Vasut >> >> wrote: >> >> >> From: "Govindraj.R" >> >> >> >> >> >> Clean up added ehci

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-11 Thread Govindraj
On Wed, Jan 11, 2012 at 6:58 PM, Marek Vasut wrote: >> On Wed, Jan 11, 2012 at 6:16 PM, Marek Vasut wrote: >> >> On Wed, Jan 11, 2012 at 4:22 PM, Marek Vasut >> >> wrote: >> >> >> Hi Marek, >> >> >> >> >> >> Thanks for you review. >> >> >> >> >> >> On Tue, Jan 10, 2012 at 9:37 PM, Marek Vasut

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-11 Thread Govindraj
Hi Igor, On Wed, Jan 11, 2012 at 8:33 PM, Igor Grinberg wrote: > Hi Guys, > > On 01/11/12 16:34, Marek Vasut wrote: >>> On Wed, Jan 11, 2012 at 6:58 PM, Marek Vasut wrote: > On Wed, Jan 11, 2012 at 6:16 PM, Marek Vasut > wrote: >>> On Wed, Jan 11, 2012 at 4:22 PM, Marek Vasut >> w

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-12 Thread Govindraj
On Thu, Jan 12, 2012 at 2:53 PM, Igor Grinberg wrote: > Hi Govindraj, > > On 01/12/12 07:45, Govindraj wrote: >> Hi Igor, >> >> On Wed, Jan 11, 2012 at 8:33 PM, Igor Grinberg >> wrote: >>> Hi Guys, >>> >>> On 01/11/12 16:34, Marek Vas

Re: [U-Boot] [PATCH V4 1/2] ehci-omap: driver for EHCI host on OMAP3

2012-01-15 Thread Govindraj
On Mon, Jan 16, 2012 at 3:34 AM, Tom Rini wrote: > On Sun, Jan 15, 2012 at 1:40 PM, Remy Bohmer wrote: >> Hi All, >> >> 2011/12/22 Ilya Yanok : >>> Hi Govindraj, >>> >>> On 22.12.2011 10:55, Govindraj wrote: >>>>> >>>>

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-16 Thread Govindraj
On Thu, Jan 12, 2012 at 4:22 PM, Govindraj wrote: > On Thu, Jan 12, 2012 at 2:53 PM, Igor Grinberg > wrote: >> Hi Govindraj, >> >> On 01/12/12 07:45, Govindraj wrote: >>> Hi Igor, >>> >>> On Wed, Jan 11, 2012 at 8:33 PM, Igor Grinberg &

Re: [U-Boot] [PATCH V4 1/2] ehci-omap: driver for EHCI host on OMAP3

2012-01-16 Thread Govindraj
On Mon, Jan 16, 2012 at 3:27 PM, Stefano Babic wrote: > On 16/01/2012 08:58, Govindraj wrote: > >> Th v2 patch series [1] posted is based on top of this patch. > > If I understand well, we need in any case Ilya's patch. In this case, it > is maybe worth to merge Ilya

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-19 Thread Govindraj
On Wed, Jan 18, 2012 at 11:21 PM, Igor Grinberg wrote: > Hi Govindraj, > > On 01/17/12 08:10, Govindraj wrote: >> >> And just to clarify further there is no code duplication for ulpi read writes >> in ehci-omap.c done with this patch. > > This is not just about

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-25 Thread Govindraj
Hi Igor, On Sun, Jan 22, 2012 at 5:50 PM, Igor Grinberg wrote: > On 01/19/12 10:15, Govindraj wrote: >> On Wed, Jan 18, 2012 at 11:21 PM, Igor Grinberg >> wrote: >>> Hi Govindraj, >>> >>> On 01/17/12 08:10, Govindraj wrote: >>>> [...]

Re: [U-Boot] [PATCH V4 1/2] ehci-omap: driver for EHCI host on OMAP3

2012-01-27 Thread Govindraj
On Thu, Jan 26, 2012 at 2:19 AM, Tom Rini wrote: > On Wed, Jan 25, 2012 at 3:32 AM, Stefano Babic wrote: >> On 17/01/2012 07:14, Govindraj wrote: >>> On Mon, Jan 16, 2012 at 3:27 PM, Stefano Babic wrote: >>>> On 16/01/2012 08:58, Govindraj wrote: >>>&

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-27 Thread Govindraj
On Wed, Jan 25, 2012 at 7:10 PM, Igor Grinberg wrote: > Hi Govindraj, > > On 01/25/12 11:04, Govindraj wrote: >> Hi Igor, >> >> On Sun, Jan 22, 2012 at 5:50 PM, Igor Grinberg >> wrote: >>> On 01/19/12 10:15, Govindraj wrote: >>>> On Wed

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-02-03 Thread Govindraj
Hi Igor, Sorry for late reply, Was really busy with some other tasks. On Sun, Jan 29, 2012 at 3:12 PM, Igor Grinberg wrote: > Hi Govindraj, > > Put Remy on Cc. > Yes Sure, > Note: my new mail client for some reason, messes with white spaces... > (Thunderbird (9) just gets

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-02-03 Thread Govindraj
On Sun, Jan 29, 2012 at 5:12 PM, Stefano Babic wrote: > On 29/01/2012 10:42, Igor Grinberg wrote: >> Hi Govindraj, >> > > Hi all, > >> Put Remy on Cc. > > Remy resigned as USB maintainer - but Tom is aware about these patches... > >> >> Note: my

Re: [U-Boot] [PATCH v3 6/7] usb: ulpi: Extend the existing ulpi framework.

2012-02-06 Thread Govindraj
Hi Igor, On Mon, Feb 6, 2012 at 2:25 PM, Igor Grinberg wrote: > Hi Govindraj, > > I was about to ask Tom to reorder the patches while applying, but > there are still several things to fix. > I'm also fine with fixing these by a follow up patch (after merging this). > [..

Re: [U-Boot] [PATCH v3 3/7] OMAP3+: Clock: Adding ehci clock enabling

2012-02-06 Thread Govindraj
On Mon, Feb 6, 2012 at 5:12 PM, Igor Grinberg wrote: > On 02/03/12 15:38, Govindraj.R wrote: >> From: "Govindraj.R" >> >> Adding ehci clock enabling mechanism part of clock framework. >> When essential clocks are enabled during init phase usb host >> clocks can also be enabled from clock framewor

Re: [U-Boot] [PATCH] OMAP3: TAM3517: update ehci interface

2012-02-07 Thread Govindraj
Hi Stefano, On Tue, Feb 7, 2012 at 9:03 PM, Stefano Babic wrote: > On 07/02/2012 16:13, Stefano Babic wrote: >> This is a strange effect. I have tested setting OMAP_EHCI_PORT_MODE_PHY >> (of course the phy is on another port), and everything works. However, >> after setting port_mode[2] to OMAP_U

Re: [U-Boot] [PATCH v4 4/7] ehci-omap: Clean up added ehci-omap.c

2012-02-07 Thread Govindraj
rch/arm/include/asm/arch-omap4/ehci.h b/arch/arm/include/asm/arch-omap4/ehci.h new file mode 100644 index 000..984c8b9 --- /dev/null +++ b/arch/arm/include/asm/arch-omap4/ehci.h @@ -0,0 +1,49 @@ +/* + * OMAP EHCI port support + * Based on LINUX KERNEL + * drivers/usb/host/ehci-omap.c and drivers/mfd/

Re: [U-Boot] [PATCH v3 6/7] usb: ulpi: Extend the existing ulpi framework.

2012-02-08 Thread Govindraj
Hi Subhashini, On Wed, Feb 8, 2012 at 11:12 PM, SUBHASHINI MANNE wrote: > > Govindraj, >  I have Gumstix overo board with OM3730 + USB 3326 USB PHY.I want to add EHCI > and ULPI support in u-boot. You can refer to the v4 patch series posted earlier: http://www.mail-archiv

Re: [U-Boot] OMAP USB, beagle-xm fail

2012-02-13 Thread Govindraj
Hi Peter, On Mon, Feb 13, 2012 at 1:52 PM, Peter Meerwald wrote: > Hello, > > the recent OMAP USB changes (43b62393da6dfdd7f503d1b37344463a05ea47b5, > 29321c0518d99494ab2a250e5b4f75b3add83b11) fail on beagleboard-xm rev. C, > see below The errors have nothing to do with ehci patch merges, (I had

Re: [U-Boot] [PATCH 1/6] omap4: usb: Add omap-ehci support

2011-12-14 Thread Govindraj
Hi Chris, On Wed, Dec 14, 2011 at 7:08 PM, Chris Lalancette wrote: > On Wed, Dec 14, 2011 at 7:09 AM, Govindraj.R wrote: >> From: "Govindraj.R" >> >> Adds ehci-omap and two funcs omap_ehci_hcd_init/omap_ehci_hcd_stop >> Which can be called from any board file implementing the ehci_hcd_init/rese

Re: [U-Boot] [PATCH 1/6] omap4: usb: Add omap-ehci support

2011-12-15 Thread Govindraj
Hi Tom, On Wed, Dec 14, 2011 at 9:30 PM, Tom Rini wrote: > On Wed, Dec 14, 2011 at 5:09 AM, Govindraj.R wrote: >> From: "Govindraj.R" > [snip] >> +/* TLL Register Set */ >> +#define        OMAP_USBTLL_SYSCONFIG_SIDLEMODE                 (1 << 3) > > Globally, please fix all #define to #define.

Re: [U-Boot] [PATCH 6/6] OMAP4: config: Add usb support for panda config.

2011-12-15 Thread Govindraj
On Wed, Dec 14, 2011 at 9:54 PM, Tom Rini wrote: > On Wed, Dec 14, 2011 at 5:21 AM, Govindraj.R wrote: >> From: "Govindraj.R" >> >> Enable usb ehci support and Ethernet support for panda board. >> Disable dcache as usb uses dma operations and to avoid any >> resulting cache coherency issue. >> >

Re: [U-Boot] [PATCH 6/6] OMAP4: config: Add usb support for panda config.

2011-12-15 Thread Govindraj
On Wed, Dec 14, 2011 at 9:57 PM, Tom Rini wrote: > On Wed, Dec 14, 2011 at 9:24 AM, Tom Rini wrote: >> On Wed, Dec 14, 2011 at 5:21 AM, Govindraj.R wrote: >>> From: "Govindraj.R" >>> >>> Enable usb ehci support and Ethernet support for panda board. >>> Disable dcache as usb uses dma operations

Re: [U-Boot] [PATCH 6/6] OMAP4: config: Add usb support for panda config.

2011-12-15 Thread Govindraj
On Wed, Dec 14, 2011 at 9:54 PM, Tom Rini wrote: > On Wed, Dec 14, 2011 at 5:21 AM, Govindraj.R wrote: >> From: "Govindraj.R" >> >> Enable usb ehci support and Ethernet support for panda board. >> Disable dcache as usb uses dma operations and to avoid any >> resulting cache coherency issue. >>

Re: [U-Boot] [PATCH V4 1/2] ehci-omap: driver for EHCI host on OMAP3

2011-12-21 Thread Govindraj
Hi IIya Yanok, Sorry for late comments. On Tue, Dec 13, 2011 at 4:45 AM, Ilya Yanok wrote: > Taken from Beagle code. Tested on mcx board (AM3517-based). > > Signed-off-by: Ilya Yanok > --- > Changes from V3: >  - None > Changes from V2: >  - None > Changes from V1: >  - CONFIG_OMAP_EHCI_PHYx_RE

Re: [U-Boot] [PATCH V4 1/2] ehci-omap: driver for EHCI host on OMAP3

2011-12-22 Thread Govindraj
Hi Igor, On Thu, Dec 22, 2011 at 1:44 PM, Igor Grinberg wrote: > Hi Govindraj, > > On 12/22/11 08:55, Govindraj wrote: >> Hi IIya Yanok, >> >> Sorry for late comments. > > Better late than never... > >> >> On Tue, Dec 13, 2011 at 4:45 AM, Ilya Yan

Re: [U-Boot] [PATCH V4 1/2] ehci-omap: driver for EHCI host on OMAP3

2011-12-22 Thread Govindraj
On Thu, Dec 22, 2011 at 3:29 PM, Igor Grinberg wrote: > On 12/22/11 11:26, Govindraj wrote: >> Hi Igor, >> [...] >> >> probably the right method to do is as we did for panda, >> >> Add to armv7/omap3/clock.c (soc specific code) to enable usb-host clocks.

Re: [U-Boot] [PATCH V4 1/2] ehci-omap: driver for EHCI host on OMAP3

2011-12-22 Thread Govindraj
On Thu, Dec 22, 2011 at 4:48 PM, Igor Grinberg wrote: > On 12/22/11 12:49, Govindraj wrote: >> On Thu, Dec 22, 2011 at 3:29 PM, Igor Grinberg >> wrote: >>> On 12/22/11 11:26, Govindraj wrote: >>>> Hi Igor, >>>> >> >> [...] >>

Re: [U-Boot] [PATCH v2 0/4] Clean up ehci-omap and extend support for omap3/4 socs

2012-02-26 Thread Govindraj
Hi Marek, On Mon, Feb 27, 2012 at 4:43 AM, Marek Vasut wrote: >> From: "Govindraj.R" >> >> Clean up ehci-omap added and make it generic to extend support for omap4 >> socs. Add ehci support for panda board. >> >> Patch series depends on below patch: >>       http://patchwork.ozlabs.org/patch/130

Re: [U-Boot] usb ethernet working on panda?

2012-02-28 Thread Govindraj
On Wed, Feb 29, 2012 at 4:47 AM, Kumar Gala wrote: > Does anyone have usb ethernet working on top of git tree on a panda board? > yes. > If so any gotcha's or details on how you have it working. I use following commands: setenv usbethaddr 0:0:1:2:3:4;usb start; After Ethernet enumerates, from

Re: [U-Boot] usb ethernet working on panda?

2012-03-02 Thread Govindraj
On Thu, Mar 1, 2012 at 8:08 PM, Kumar Gala wrote: > > On Feb 29, 2012, at 12:17 AM, Govindraj wrote: > >> On Wed, Feb 29, 2012 at 4:47 AM, Kumar Gala >> wrote: >>> Does anyone have usb ethernet working on top of git tree on a panda board? >>> >> yes

[U-Boot] [PATCH 1/2] MIPS: add clrbits and setbits and add phy_to_bus support.

2015-08-19 Thread Govindraj Raja
From: Govindraj Raja usb stack utilizes the clr/set_bits macros also usb stack needs phy_to_bus/bus_to_phys functions. Thus adding these macro and functions for mips platform. This makes usb stack usable with mips platform. Also fixes a checkpatch warning with virt_to_phys forward declaration

[U-Boot] [PATCH 0/2] MIPS: add support to support usb stack for mips and minor cleanup

2015-08-19 Thread Govindraj Raja
Patch prepares to support usb stack compiled for mips platform. Also fix fdt usage api's from bootm. Govindraj Raja (2): MIPS: add clrbits and setbits and add phy_to_bus support. MIPS: fix syntax for fdt_chosen/initrd. arch/mips/include/asm/io.h

[U-Boot] [PATCH 2/2] MIPS: fix syntax for fdt_chosen/initrd.

2015-08-19 Thread Govindraj Raja
From: Govindraj Raja The syntax for the fdt_chosen/initrd functions seem to deprecated in usage from MIPS bootm implementation. Third parameter is no more used in these api's Refer to : include/fdt_support.h Signed-off-by: Govindraj Raja --- arch/mips/lib/bootm.c | 4 ++-- 1 file chang

[U-Boot] [PATCH v2 1/2] MIPS: add clrbits and setbits and add phy_to_bus support.

2015-08-20 Thread Govindraj Raja
From: Govindraj Raja usb stack utilizes the clr/set_bits macros also usb stack needs phy_to_bus/bus_to_phys functions. Thus adding these macro and functions for mips platform. This makes usb stack usable with mips platform. Signed-off-by: Govindraj Raja --- Changes from v1

Re: [U-Boot] [PATCH v2 1/2] MIPS: add clrbits and setbits and add phy_to_bus support.

2015-08-21 Thread Govindraj Raja
> -Original Message- > From: Daniel Schwierzeck [mailto:daniel.schwierz...@gmail.com] > Sent: 21 August 2015 02:21 PM > To: Govindraj Raja > Cc: u-boot@lists.denx.de > Subject: Re: [U-Boot][PATCH v2 1/2] MIPS: add clrbits and setbits and add > phy_to_bus support. >

[U-Boot] [PATCH] MIPS: add atomic operations support.

2015-08-25 Thread Govindraj Raja
some of the u-boot frameworks like ubi-fs and eth_gadget uses atomic_* api's. So add atomic api's for mips. This makes ubi-fs on nand work with mips platform. Signed-off-by: Govindraj Raja --- arch/mips/include/asm/atomic.h | 90 ++ 1 file c