On Wed, Dec 14, 2011 at 9:54 PM, Tom Rini <tom.r...@gmail.com> wrote: > On Wed, Dec 14, 2011 at 5:21 AM, Govindraj.R <govindraj...@gmail.com> wrote: >> From: "Govindraj.R" <govindraj.r...@ti.com> >> >> Enable usb ehci support and Ethernet support for panda board. >> Disable dcache as usb uses dma operations and to avoid any >> resulting cache coherency issue. >> >> Signed-off-by: Govindraj.R <govindraj.r...@ti.com> > > I'm not thrilled with disabling dcache globally for this. We can just > do 'dcache off' and then start doing USB ops, or since this won't get > in until 2012.03, can we spend more time making USB cache coherent? > >> --- >> include/configs/omap4_common.h | 1 + >> include/configs/omap4_panda.h | 21 +++++++++++++++++++++ >> 2 files changed, 22 insertions(+), 0 deletions(-) >> >> diff --git a/include/configs/omap4_common.h b/include/configs/omap4_common.h >> index a989721..43a98f9 100644 >> --- a/include/configs/omap4_common.h >> +++ b/include/configs/omap4_common.h >> @@ -152,6 +152,7 @@ >> "loadaddr=0x82000000\0" \ >> "console=ttyO2,115200n8\0" \ >> "usbtty=cdc_acm\0" \ >> + "usbethaddr=00:02:03:04:05:06\0" \ >> "vram=16M\0" \ >> "mmcdev=0\0" \ >> "mmcroot=/dev/mmcblk0p2 rw\0" \ > > Just like you can't hard-code ethaddr into config files, I'm pretty > sure you can't do that for usbethaddr.
I think this can be set even in the command line will check the options and do the changes as required. >> diff --git a/include/configs/omap4_panda.h b/include/configs/omap4_panda.h >> index e9ef2a3..1475012 100644 >> --- a/include/configs/omap4_panda.h >> +++ b/include/configs/omap4_panda.h >> @@ -33,7 +33,28 @@ >> */ >> #define CONFIG_PANDA 1 /* working with Panda */ >> >> +#define CONFIG_SYS_DCACHE_OFF 1 >> + >> +/* USB UHH support options */ >> +#define CONFIG_CMD_USB 1 >> +#define CONFIG_USB_HOST 1 >> +#define CONFIG_USB_EHCI 1 >> +#define CONFIG_USB_EHCI_OMAP 1 >> +#define CONFIG_USB_STORAGE 1 >> +#define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS 3 > > Just '#define CONFIG_CMD_USB' okay fine. > (and if you want to do a > separate pre-patch cleaning up the existing config files I'd > appreciate it). > Sure. >> +/* USB Networking options */ >> +#define CONFIG_USB_HOST_ETHER 1 >> +#define CONFIG_USB_ETHER_SMSC95XX 1 >> + >> +#define CONFIG_UBOOT_ENABLE_PADS_ALL 1 >> + >> +#define CONFIG_NET_MULTI 1 > > CONFIG_NET_MULTI went away. > my bad I missed that. Will clean up. -- Thanks, Govindraj.R _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
