Re: [U-Boot] rk3288: broken boot

> On 14 Feb 2018, at 11:47, Jagan Teki wrote: > > On Wed, Feb 14, 2018 at 5:38 AM, Dr. Philipp Tomsich > <mailto:philipp.toms...@theobroma-systems.com>> wrote: >> Jagan, >> >>> On 13 Feb 2018, at 13:20, Jagan Teki wrote: >>> >&

Re: [U-Boot] [PATCH] rockchip: add text_offset to kernel_addr_r on aarch64 platforms

> On 19 Feb 2018, at 08:02, Klaus Goger > wrote: > > Booting a aarch64 Linux kernel requires the image to be placed > text_offset bytes from a 2MB aligned address. > See https://www.kernel.org/doc/Documentation/arm64/booting.txt > > booti_setup() takes care about this alignment and will reloca

Re: [U-Boot] [U-Boot, v4, 07/11] spl: add support to booting with OP-TEE

Bryan, > On 21 Feb 2018, at 04:27, Bryan O'Donoghue wrote: > > On 19/02/18 15:44, Tom Rini wrote: >> On Fri, Feb 02, 2018 at 04:56:57PM +0100, Dr. Philipp Tomsich wrote: >>> Bryan, >>> >>>> On 2 Feb 2018, at 16:37, Bryan O'Donoghue &

Re: [U-Boot] [PATCH v2 0/9] rockchip: rk3288-vyasa: dts fixes/additions

> On 23 Feb 2018, at 16:17, Jagan Teki wrote: > > Philipp, > > On Wed, Feb 14, 2018 at 9:26 PM, Jagan Teki > wrote: >> Series add new dts nodes like gmac, usb, io_domains and fixed existing >> regulator, pmic stuff as per schematic. >> >> Changes for v2: >> -

Re: [U-Boot] [PATCH v2 0/9] rockchip: rk3288-vyasa: dts fixes/additions

> On 23 Feb 2018, at 16:29, Jagan Teki wrote: > > > > On 23-Feb-2018 8:53 PM, "Dr. Philipp Tomsich" > <mailto:philipp.toms...@theobroma-systems.com>> wrote: > >> On 23 Feb 2018, at 16:17, Jagan Teki > <mailto:jagannadh.t...@gmail.com>

Re: [U-Boot] [PATCH] rockchip: i2c: enable I2C inside GRF for rk3066 and rk3188

> On 20 Feb 2018, at 09:43, Alexander Kochetkov wrote: > > In order to make I2C work on rk3066 and rk3188 boards GFR > must be updated. The commit message does not really tell me what the change is… …see below for a couple questions. > > Signed-off-by: Alexander Kochetkov Acked-by: Philipp

Re: [U-Boot] [PATCH 0/5] rockchip: video: migrate RK3399 w/ HDMI to livetree

Tom et al., I’d like to see this bug fix included in 2018.03, but don’t want to take the decision on my own: - some of this should have come via Anatolij’s tree - if touches ofnode.h/c and also needs a change by Kever that Simon reviewed (and noted that test cases should also

[U-Boot] [PULL] Please pull u-boot-rockchip/master

Tom, we have additional fixes ready for you: * the TPL-build process for the Vyasa board was fixed by Jagan (by providing the correct TEXT_BASE) * a regression on Ethernet for the RK3399 and RK3368 has been resolved by adding support for its clocks * a regression on PMIC

Re: [U-Boot] [PATCH] core: do not fail in device_probe() when clk set default fail

> On 25 Feb 2018, at 11:24, Kever Yang wrote: > > Assigned clocks are widely used in kernel, but not in U-Boot yet, > many U-Boot clock driver do not have the API while dts port from kernel > have "assigned-clocks" node. > > Just give a warning now instead of a device probe fail. I strongly di

Re: [U-Boot] [PATCH v2 1/2] rockchip: rk3288: Add TPL_LDSCRIPT

Kever, Cleaning this up will be great. Once ready, we can merge this onto next … Regards, Philipp. > On 26 Feb 2018, at 07:26, Kever Yang wrote: > > > I prefer to share the TPL script between all Rockchip SoCs, > > and put this at arch/arm/mach-rockchip/. > > I got one in my local branch, w

Re: [U-Boot] [PATCH] rockchip: i2c: enable I2C inside GRF for rk3066 and rk3188

Alexander, > On 26 Feb 2018, at 10:25, Alexander Kochetkov wrote: > > Hello, Philipp! > >> >> What exactly are you trying to configure here? >> >> Do you need to bring these out of reset, is this some IO config or >> are these clock gates? Note that if it’s any of these, then the >> respect

Re: [U-Boot] [PATCH] rockchip: i2c: enable I2C inside GRF for rk3066 and rk3188

Simon, please take a look and advise whether you want this as a reset-driver and have us adding auto-processing of resets to the initial bind/probe/init cycle. Thanks, Philipp. > On 26 Feb 2018, at 10:43, Dr. Philipp Tomsich > wrote: > > Alexander, > >> On 26 Feb 2018

Re: [U-Boot] [PATCH] rockchip: i2c: enable I2C inside GRF for rk3066 and rk3188

Simon, please take a look and advise whether you want this as a reset-driver and have us adding auto-processing of resets to the initial bind/probe/init cycle. Thanks, Philipp. > On 26 Feb 2018, at 10:43, Dr. Philipp Tomsich > wrote: > > Alexander, > >> On 26 Feb 2018

Re: [U-Boot] [PATCH v2 1/2] core: add uclass_get_device_by_phandle_id() api

Kever, > On 26 Feb 2018, at 04:07, Kever Yang wrote: > > Hi Simon, > > > On 02/25/2018 11:54 PM, Simon Glass wrote: >> Hi Kever, >> >> On 23 February 2018 at 19:08, Kever Yang wrote: >>> Hi Simon, >>> >>> >>> On 02/12/2018 10:35 PM, Simon Glass wrote: Hi Kever, On 8 Februar

Re: [U-Boot] [PATCH] NET: designware: fix clock enable

> On 6 Feb 2018, at 15:12, Eugeniy Paltsev wrote: > > After commit ba1f966725223 "net: designware: add clock support" > we got NET broken on axs101 and axs103 platforms. > > Some clock don't support gating so their clock drivers don't > implement .enable/.disable callbacks. In such case clk_ena

Re: [U-Boot] [PATCH] rockchip: clk: rk3188: update dpll settings to make EMAC work

Kever, please review. Thanks, Philipp. > On 26 Feb 2018, at 12:27, Alexander Kochetkov wrote: > > The patch set dpll settings for 300MHz to values used by binary > blob[1]. With new values dpll still generate 300MHz clock, but > EMAC work. Probably with new values dpll generate more stable clo

[U-Boot] Moving the rk_board_late_init() hook to a device-model based implementation.

Simon & Kever, We have the rk_board_late_init() hook for the Rockchip boards and I’d like to convert these to some sort of device-model based implementation. Here’s what I’d propose as a minimal implementation: 1. Introduce a new UCLASS_BOARD 2. Trigger on the top-level ‘compatible’ st

Re: [U-Boot] [PATCH v4 08/12] doc: TEE: Add documentation describing TEE in u-boot

> On 26 Feb 2018, at 13:36, Bryan O'Donoghue wrote: > > This patch adds a brief description of TEE in u-boot. > > It gives a basic introduction, description of image generation with mkimage > plus the various ways u-boot can install or chainload a TEE. > > Methods covered in this patch are >

Re: [U-Boot] [PATCH v4 08/12] doc: TEE: Add documentation describing TEE in u-boot

Bryan, > On 26 Feb 2018, at 15:39, Bryan O'Donoghue wrote: > > > > On 26/02/18 13:53, Dr. Philipp Tomsich wrote: >>> + To identify this type of image to u-boot you should use mkimage like >>> this: >>> + >>> + mkimage -A arm -T

Re: [U-Boot] [PATCH v4 08/12] doc: TEE: Add documentation describing TEE in u-boot

> On 26 Feb 2018, at 16:26, Andrew F. Davis wrote: > > On 02/26/2018 09:06 AM, Bryan O'Donoghue wrote: >> >> >> On 26/02/18 14:56, Dr. Philipp Tomsich wrote: >>> Now, I am confused. >> >> Fair enough. >> >> In my view there

Re: [U-Boot] [PATCH v2] rockchip: i2c: enable new I2C controller for rk3066 and rk3188

Alexander, Sorry for being a bother. See below for two comments. Cheers, Phil. > On 26 Feb 2018, at 18:42, Alexander Kochetkov wrote: > > rk3066 and rk3188 has two I2C controller implementations. > Current I2C driver wan't work with legacy implementation. > Switching between controllers is pe

[U-Boot] [PULL] Please pull u-boot-rockchip

Tom, Please pull the following changes (rebased from what was previously our next-branch) from u-boot-rockchip/master. The respective run on TravisCI is https://travis-ci.org/ptomsich/u-boot-rockchip/builds/352948410. Thanks, Philipp. The following changes since commit f95ab1fb6e37f0601f397091

Re: [U-Boot] [PATCH v1] rtc: rewrite isl1208 to support DM

> On 18 Mar 2018, at 18:35, Klaus Goger > wrote: > > Adds devicemodel support to the ISL1208 driver. > This patch drops the non-dm API as no board was using it anyway. > Also add it to Kconfig. > > Signed-off-by: Klaus Goger Reviewed-by: Philipp Tomsich _

Re: [U-Boot] [PATCH 1/1] video: rk3399_mipi: correct error checking

Punit, > On 19 Mar 2018, at 18:21, Punit Agrawal wrote: > > Heinrich Schuchardt mailto:xypron.g...@gmx.de>> writes: > >> Pointers are never negative. Use macro IS_ERR() for checking. >> cf. rk3288_mipi.c >> >> Signed-off-by: Heinrich Schuchardt >> --- >> drivers/video/rockchip/rk3399_mipi.c |

Re: [U-Boot] Moving the rk_board_late_init() hook to a device-model based implementation.

Simon, ping? Thanks, Philipp. > On 26 Feb 2018, at 14:02, Dr. Philipp Tomsich > wrote: > > Simon & Kever, > > We have the rk_board_late_init() hook for the Rockchip boards and I’d like to > convert > these to some sort of device-model based implementation. >

Re: [U-Boot] [PATCH v2 47/56] rockchip: dts: rk3368: add DMC node in rk3368.dtsi

Andy, > On 28 Jul 2017, at 10:34, Andy Yan wrote: > > Hi Philipp: > > > On 2017年07月26日 18:40, Philipp Tomsich wrote: >> For full SPL support, including DRAM initialisation, we need a few >> nodes from the DTS: this commit adds the DMC (DRAM controller) node, >> the service_msch (memory schedul

Re: [U-Boot] [PATCH v2 46/56] rockchip: rk3368: add DRAM controller driver with DRAM initialisation

> On 28 Jul 2017, at 05:39, Simon Glass wrote: > > Hi Philipp, > > On 26 July 2017 at 04:40, Philipp Tomsich > wrote: >> This adds a DRAM controller driver for the RK3368 and places it in >> drivers/ddr/rockchip (where the other DM-enabled DRAM controller >> drivers for rockchip devices should

Re: [U-Boot] [PATCH v2 44/56] net: gmac_rockchip: Add support for the RK3368 GMAC

> On 28 Jul 2017, at 05:39, Simon Glass wrote: > > Hi Philipp, > > On 26 July 2017 at 04:40, Philipp Tomsich > wrote: >> The GMAC in the RK3368 once again is identical to the incarnation in >> the RK3288 and the RK3399, except for where some of the configuration >> and control registers are lo

Re: [U-Boot] [PATCH v2 32/56] rockchip: pinctrl: rk3368: move IOMUX bit-definitions to pinctrl driver

> On 28 Jul 2017, at 05:38, Simon Glass wrote: > > On 26 July 2017 at 04:40, Philipp Tomsich > wrote: >> There is no real reason to keep the bit-definitions for the IOMUX in >> the grf header file (which defines the register layout of the GRF block): >> these should only be used by our pinctrl

Re: [U-Boot] [PATCH v2 29/56] rockchip: rk3368: grf: use shifted-constants

> On 28 Jul 2017, at 05:38, Simon Glass wrote: > > Hi Philipp, > > On 26 July 2017 at 04:40, Philipp Tomsich > wrote: >> The RK3368 GRF header was still defines with a shifted-mask but with >> non-shifted function selectors for the IOMUX defines. As the RK3368 >> support is still fresh enough

Re: [U-Boot] [PATCH v2 28/56] rockchip: rk3368: syscon: MSCH/PMUGRF/GRF support for OF_PLATDATA

> On 28 Jul 2017, at 05:38, Simon Glass wrote: > > On 26 July 2017 at 04:40, Philipp Tomsich > wrote: >> The RK3368 has both a limited SPL size (just 0x7000 bytes) and the >> added challenge of booting in AArch64, which increases the code size >> for SPL (particularily when using the LP64 progr

Re: [U-Boot] [PATCH v3 60/66] spl: moveconfig: migrate CONFIG_SPL_LDSCRIPT

> On 28 Jul 2017, at 21:52, Siarhei Siamashka > wrote: > > On Fri, 28 Jul 2017 21:22:32 +0200 > Philipp Tomsich wrote: > >> With SPL_LDSCRIPT defined via Kconfig, we can run moveconfig... this >> will touch every configuration that uses SPL, even if there was an >> implicit resolution of the

Re: [U-Boot] [PATCH v2 29/56] rockchip: rk3368: grf: use shifted-constants

> On 01 Aug 2017, at 11:49, Simon Glass wrote: > > On 28 July 2017 at 02:53, Dr. Philipp Tomsich > wrote: >> >>> On 28 Jul 2017, at 05:38, Simon Glass wrote: >>> >>> Hi Philipp, >>> >>> On 26 July 2017 at 04:40, Philipp Tomsic

Re: [U-Boot] [PATCH v3 48/66] net: gmac_rockchip: Add support for the RK3368 GMAC

Simon, > On 01 Aug 2017, at 11:49, Simon Glass wrote: > > Hi Philipp, > > On 28 July 2017 at 13:22, Philipp Tomsich > wrote: >> The GMAC in the RK3368 once again is identical to the incarnation in >> the RK3288 and the RK3399, except for where some of the configuration >> and control registers

Re: [U-Boot] [PATCH v3 65/66] rockchip: board: puma-rk3399: fix warnings in puma_rk3399/fit_spl_atf.its

Kever, We use a fork of the ATF repository and have the M3 firmware completely factored out and have changed parts of the SRAM setup. In other words: there will be two separate .bin files created that need to be loaded to two separate locations. Please refer to our board’s README for the steps t

Re: [U-Boot] [PATCH v3 50/66] rockchip: rk3368: add DRAM controller driver with DRAM initialisation

Andy, The functionality of the new driver should be equivalent for the non-TPL case. All the code from the original driver is still present in the new driver for non-TPL (see rk3368_dmc_probe). Seeing that -19 is -ENODEV, I suspect that something went wrong in the DM binding/probing: did you set

Re: [U-Boot] [RFC PATCH 0/6] rockchip: rk3368: remove secure timer usage and use DM timer

Kever, This patchset does not force the use of the DM timer for any chipsets/boards. It is essentially opt-in and (for now—i.e. until we enable it for the RK3399) it is enabled for the RK3368 only. Note that this does not currently target any ARMv7 devices, as it is meant to decouple the ARMv8 g

Re: [U-Boot] [RFC PATCH 3/6] rockchip: timer: add device-model timer driver for RK3368 (and similar)

> On 01 Aug 2017, at 11:48, Simon Glass wrote: > > On 28 July 2017 at 10:31, Philipp Tomsich > wrote: >> This adds a device-model driver for the timer block in the RK3368 (and >> similar devices that share the same timer block, such as the RK3288) for >> the down-counting (i.e. non-secure) time

Re: [U-Boot] [PATCH v3 56/66] rockchip: rk3368: spl: mark SPL and TPL as supported for ROCKCHIP_RK3368

Looks like SPL_SEPARATE_BSS is special. Guess, I’ll need to figure out how to best deal with that one (or fall back to defining it via defconfig until we can enable TPL/SPL for all RK3368 board). I wonder how an implies would behave here... > On 02 Aug 2017, at 14:47, Andy Yan wrote: > > Hi Ph

Re: [U-Boot] [PATCH 1/1] lcd: avoid possible NULL dereference

> On 30 Jul 2017, at 21:59, Heinrich Schuchardt wrote: > > Do not dereference bmp before the check if it is NULL. > > The problem was indicated by cppcheck. > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Philipp Tomsich ___ U-Boot mailing li

Re: [U-Boot] [PATCH 2/3] rockchip: set Pre-reloc malloc pool size to 4kb for rk3368 based boards

> On 02 Aug 2017, at 15:10, Andy Yan wrote: > > The default 1kb pre-reloc malloc pool is not enough for dm > core to enable the dm-pre-reloc device drivers. > > Signed-off-by: Andy Yan > — Acked-by: Philipp Tomsich Reviewed-by: Philipp Tomsich See comment below. > > configs/evb-px5_defco

Re: [U-Boot] [PATCH 3/3] rockchip: remove the hard coded uart iomux setting for px5 evb

> On 02 Aug 2017, at 15:10, Andy Yan wrote: > > As the debug uart is marked as dm-pre-reloc, the pinctrl driver > will handle the correct iomux setting. > > Signed-off-by: Andy Yan > — Acked-by: Philipp Tomsich Reviewed-by: Philipp Tomsich ___ U-B

Re: [U-Boot] [PATCH v2] rockchip: phycore: Read configuration EEPROM & set ethaddr in late init

Wadim, The earlier version of your patch already made it onto master. Could you please resubmit this fix as a new patch? Thanks, Philipp. > On 03 Aug 2017, at 13:48, Wadim Egorov wrote: > > Read SoM information from EEPROM and set ethaddr in late init. > > Signed-off-by: Wadim Egorov > ---

Re: [U-Boot] [PATCH v2] rockchip: phycore: Read configuration EEPROM & set ethaddr in late init

10 2017 +0200 > > rockchip: phycore: Add ID page of M24C32-D EEPROM > > I dropped the above patch from the series. > > Regards, > Wadim > > > Am 03.08.2017 um 14:14 schrieb Dr. Philipp Tomsich: >> Wadim, >> >> The earlier version of your p

Re: [U-Boot] [PATCH 12/13] armv7: support rk3066 early back to bootrom in start.S

> On 04 Aug 2017, at 18:33, Paweł Jarosz wrote: > > Hi, > > > W dniu 15.06.2017 o 18:40, Simon Glass pisze: >> Hi Pawel, >> >> On 15 June 2017 at 10:32, Paweł Jarosz wrote: >>> >>> W dniu 15.06.2017 o 18:00, Simon Glass pisze: >>> (just repeating other thread for completeness) >

Re: [U-Boot] [PATCH v2] wdt: Update uclass to make clear that the timeout is in ms

> On 04 Aug 2017, at 23:48, Simon Glass wrote: > > From: Andy Shevchenko > > Convert name to show explicitly that we are using milliseconds. For a > watchdog timer this is precise enough. > > No functional change intended. > > Signed-off-by: Andy Shevchenko > Signed-off-by: Simon Glass > -

Re: [U-Boot] [PATCH v2] wdt: Update uclass to make clear that the timeout is in ms

> On 05 Aug 2017, at 00:30, Simon Glass wrote: > > +Tom > > Hi Philipp, > > On 4 August 2017 at 16:21, Dr. Philipp Tomsich > wrote: >> >>> On 04 Aug 2017, at 23:48, Simon Glass wrote: >>> >>> From: Andy Shevchenko >>>

Re: [U-Boot] [PATCH] rockchip: clk: rk3399: fix SPI clock code for SPI3

> On 06 Aug 2017, at 07:15, Simon Glass wrote: > > On 26 July 2017 at 04:28, Philipp Tomsich > wrote: >> On the RK3399, SPI3 is special (it's configured via PMUGRF). The >> implementation of the clock-setup for SPI3 was never supported (and >> the comments reflected this), but the implementatio

Re: [U-Boot] [U-Boot, v4, 60/66] rockchip: Kconfig: preset TPL_LDSCRIPT via Kconfig for the RK3368

Andy, Doing a non-buildman defconfig + make works fine. I’ve seen this too (I did a full buildman for all arm, x86 and powerpc boards) and it seems as if a shell-script is trying to source the generated auto.config file. I couldn’t spot where in buildman that happens, so I’ll need to leave this

Re: [U-Boot] [U-Boot, v4, 60/66] rockchip: Kconfig: preset TPL_LDSCRIPT via Kconfig for the RK3368

Hm, ok: let me check again, maybe I can spot this now. I wonder why this didn’t show for me when I tried earlier. > On 07 Aug 2017, at 10:38, Andy Yan wrote: > > Hi Philipp: > > > On 2017年08月07日 16:24, Dr. Philipp Tomsich wrote: >> Andy, >> >> Doing a non-

Re: [U-Boot] [U-Boot, v4, 60/66] rockchip: Kconfig: preset TPL_LDSCRIPT via Kconfig for the RK3368

the changes to Kconfig, but we’re triggering a weakness in our build infrastructure here. I guess we’ll have to implement a save version of scripts/localversion that does not allow for the execution of arbitrary script code from auto.conf ... > On 07 Aug 2017, at 10:38, Andy Yan wrote: >

Re: [U-Boot] [U-Boot, v4, 60/66] rockchip: Kconfig: preset TPL_LDSCRIPT via Kconfig for the RK3368

Tom, > On 07 Aug 2017, at 16:05, Tom Rini wrote: > > On Mon, Aug 07, 2017 at 10:48:12AM +0200, Dr. Philipp Tomsich wrote: >> +Tom >> >> Ok, so the problem is 'scripts/setlocalversion’, which does the following: >>> if test -e include/config/auto.conf; t

Re: [U-Boot] [U-Boot, v4, 60/66] rockchip: Kconfig: preset TPL_LDSCRIPT via Kconfig for the RK3368

Masahiro & Tom, the proposed fix is at https://patchwork.ozlabs.org/patch/799172/ Thanks, Phil. > On 07 Aug 2017, at 16:05, Tom Rini wrote: > > On Mon, Aug 07, 2017 at 10:48:12AM +0200, Dr. Philipp Tomsich wrote: >> +Tom >> >> Ok, so the problem is &

Re: [U-Boot] [PATCH] common:usb_kbd:Add key values of F1~F12

> On 08 Aug 2017, at 03:27, Leo Wen wrote: > > When you press the F1~F12 button from the USB keyboard, the reference Fn > key table(usb_kbd_fn_key[]),the key value(0xf0~0xfb) will be returned, > and you can use it to do more things. How does doing this code (in usb_kbd.c) relate to the translat

Re: [U-Boot] [PATCH 12/13] armv7: support rk3066 early back to bootrom in start.S

> On 04 Aug 2017, at 19:01, Paweł Jarosz wrote: > > Hi Philipp, > > > W dniu 04.08.2017 o 18:51, Dr. Philipp Tomsich pisze: >>> On 04 Aug 2017, at 18:33, Paweł Jarosz wrote: >>> >>> Hi, >>> >>> >>> W dniu 15.06.2017

[U-Boot] Please pull u-boot-rockchip/master

Hello Tom, The following changes since commit d529124fdcf941c34074fd1ce600f4b1b4a7dd07: Merge git://git.denx.de/u-boot-x86 (2017-08-08 17:06:19 -0400) are available in the git repository at: git://git.denx.de/u-boot-rockchip.git master for you to fetch changes up to 6785e701b70a5e12a3dbb2f

[U-Boot] [GIT PULL v2] Please pull u-boot-rockchip/master

Tom, Here’s another pull-request for u-boot-rockchip. This one shows no regressions with Travis after fixing up a few more defconfig files and adjusting the target-list when the mxs-variant of the SPL ldscript should be used. Regards, Phil. The following changes since commit da0227f7d2568c0cb0e

Re: [U-Boot] [PATCH 0/3] dtoc: Add support for 64-bit addresses

Simon, > On 20 Jun 2017, at 05:34, Simon Glass wrote: > > This series updates dtoc to support 64-bit addresses automatically. These > appear in C code as fdt64_t arrays: > > struct dtd_test1 { > fdt64_t reg[2]; > > }; > > static struct dtd_test1 dtv_test1 = { > .reg

Re: [U-Boot] [PATCH 3/3] dtoc: Add support for 32 or 64-bit addresses

> On 20 Jun 2017, at 05:34, Simon Glass wrote: > > When using 32-bit addresses dtoc works correctly. For 64-bit addresses it > does not since it ignores the #address-cells and #size-cells properties. > > Update the tool to use fdt64_t as the element type for reg properties when > either the add

Re: [U-Boot] [PATCH] ARM: rockchip: rock: Correct test to use CONFIG_IS_ENABLED not defined

> On 14 Aug 2017, at 19:24, Tom Rini wrote: > > While it is likely that this entire case is superfluous and can be > removed, correct the test now to match what is in rockchip-common.h and > makes sense based on context of the code. Otherwise we get a large > number of warnings. > > Cc: hilipp

Re: [U-Boot] [PATCH] armv8: mmu: remove unused macro definition

> On 16 Aug 2017, at 10:16, Andy Yan wrote: > > Macro VA_BITS and PTE_BLOCK_BITS are not used > in the code, so remove them. > > Signed-off-by: Andy Yan > — Reviewed-by: Philipp Tomsich See below for a requested change. > > arch/arm/include/asm/armv8/mmu.h | 9 - > scripts/config_wh

Re: [U-Boot] [PATCH] arm, at91: fix taurus board

> On 16 Aug 2017, at 09:47, Heiko Schocher wrote: > > since commit: b529993e0222 "spl: add hierarchical defaults for SPL_LDSCRIPT" > > taurus board stopped working. Use the ldscript from > arch/arm/cpu/u-boot-spl.lds (as before this patch) fixed it. > > Signed-off-by: Heiko Schocher Reviewed

Re: [U-Boot] [PATCH v2 00/19] add support for rk3066 platform.

Pawel, Could you rebase this onto the current master (the SPL/TPL changes for the RK3368 are likely to have affected a few things) and resubmit? Thanks, Philipp. > On 11 Aug 2017, at 22:53, Paweł Jarosz wrote: > > This patch serie adds support for Rockchip RK3066 processor. > > Paweł Jarosz (

Re: [U-Boot] rk3288: 32KB SPL size restriction

Jagan, > On 16 Aug 2017, at 15:12, Jagan Teki wrote: > > Hi Simon, > > On Mon, Aug 14, 2017 at 11:01 PM, Jagan Teki wrote: >> On Mon, Aug 14, 2017 at 10:03 AM, Jagan Teki >> wrote: >>> Hi Simon, >>> >>> On Mon, Aug 14, 2017 at 3:06 AM, Simon Glass wrote: Hi Jagan, On 10 Aug

Re: [U-Boot] [PATCH v2 00/19] add support for rk3066 platform.

Either will be fine for me: u-boot-rockchip/master is only one DTS fix ahead of u-boot/master. > On 16 Aug 2017, at 17:48, Paweł Jarosz wrote: > > Hi, > > > W dniu 16.08.2017 o 16:28, Dr. Philipp Tomsich pisze: >> Pawel, >> >> Could you rebase this

[U-Boot] [GIT PULL] Please pull u-boot-rockchip/master

Tom, there's a (trivial) fix for some fallout from f94e643 (spl: consistently use $(SPL_TPL_) to select features for SPL and TPL builds) (and one unrelated trivial DTS change) in u-boot-rockchip/master ready for you. Please pull. Regards, Philipp. The following changes since commit 3

Re: [U-Boot] [PATCH] rockchip: rk3288: update the mmc number for fastboot

> On 17 Aug 2017, at 09:51, Kever Yang wrote: > > Hi Philipp, > > > On 07/27/2017 09:09 PM, Dr. Philipp Tomsich wrote: >>> On 27 Jul 2017, at 15:04, Kever Yang wrote: >>> >>> Philipp, >>> >>> >>> On 07/27/2017 08:16 P

Re: [U-Boot] rk3288: 32KB SPL size restriction

Jagan, > On 17 Aug 2017, at 08:39, Kever Yang wrote: > > Hi Jagan, > > > On 08/10/2017 05:07 PM, Jagan Teki wrote: >> Hi Simon/Philipp or any, >> >> I believe rk3288 has 20KB BootRom and 100KB internal SRAM and current >> u-boot can archive the maximum size of u-boot-spl-dtb.bin which the >>

Re: [U-Boot] [PATCH v2 0/5] rockchip: rk3229: add sdram and sd support

> On 17 Aug 2017, at 09:17, Kever Yang wrote: > > > Add sdram driver for rk3229 and other fix like pinctrl and sd node. > > > Changes in v2: > - split this patch in two patches > > Kever Yang (5): > rockchip: rk322x: update dram bank size > rockchip: rk322x: add sdram driver > rockchip: r

Re: [U-Boot] [PATCH v2 0/5] rockchip: rk3229: add sdram and sd support

> On 18 Aug 2017, at 08:26, Kever Yang wrote: > > Philipp, > > > On 08/17/2017 04:34 PM, Dr. Philipp Tomsich wrote: >>> On 17 Aug 2017, at 09:17, Kever Yang wrote: >>> >>> >>> Add sdram driver for rk3229 and other fix like pinctrl and

Re: [U-Boot] [U-Boot, v2] rockchip: phycore: Read configuration EEPROM & set ethaddr in late init

Wadim, > On 18 Aug 2017, at 15:28, Philipp Tomsich > wrote: > >> Read SoM information from EEPROM and set ethaddr in late init. >> >> Signed-off-by: Wadim Egorov >> Acked-by: Philipp Tomsich >> --- >> Changes in v2: >> - Fixed fdt_path_offset() error handling >> This patch breaks the build

Re: [U-Boot] [PATCH] spl: fix usage of $(SPL_TPL_) for some files

Vikas, thanks for reporting this. Fortunately, a fix has already been merged by Tom as commit b5c4d81b3507b3abb239ea8323515fce09dc378f Best, Philipp. > On 20 Aug 2017, at 19:45, Vikas Manocha wrote: > > Signed-off-by: Vikas Manocha > --- > common/spl/Makefile | 6 +++--- > 1 file chan

Re: [U-Boot] [PATCH] dm: serial: Add .pre_probe() function to to wait for previous transmission end

Hi Lukasz, > On 27 Oct 2017, at 00:51, Lukasz Majewski wrote: >> >>> On 27 Oct 2017, at 00:13, Lukasz Majewski wrote: >>> >>> It may happen that the serial IP block is performing some ongoing >>> transmission (started at e.g. board_init()) when the serial "probe" >>> is called. >>> >>> As a r

[U-Boot] [PULL] Please pull u-boot-rockchip

Tom, The rockchip-tree has connected a few minor fixes and defconfig-changes. Please pull. Thanks, Philipp. The following changes since commit 3c1af17c5eebc3718095907c254ae3eb8a3412f8: Merge branch 'master' of git://www.denx.de/git/u-boot-imx (2017-10-31 08:14:53 -0400) are available in th

Re: [U-Boot] [PATCH] armv8: update gd after relocate

> On 3 Nov 2017, at 03:10, Kever Yang wrote: > > We need to update gd in assamble code after relocate, > this is a fix to: > adc421e arm: move gd handling outside of C code > > Signed-off-by: Kever Yang Reviewed-by: Philipp Tomsich ___ U-Boot mail

Re: [U-Boot] [PATCH 2/3] rockchip: doc: update U-Boot location info

> On 2 Nov 2017, at 08:16, Kever Yang wrote: > > Update rockchip U-Boot location to 0x4000/16384. > > Signed-off-by: Kever Yang > --- > > doc/README.rockchip | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/doc/README.rockchip b/doc/README.rockchip > index 4b7be0b

Re: [U-Boot] [PATCH 1/2] rockchip: config: sync the ENV offset from rockchip legacy U-Boot

> On 31 Oct 2017, at 08:52, Kever Yang wrote: > > Using the ENV offset from rockchip legacy U-Boot for all SoCs, > the offset is 4MB-32KB > > Signed-off-by: Kever Yang > --- > > include/configs/rockchip-common.h | 15 +++ > 1 file changed, 3 insertions(+), 12 deletions(-) > > diff

Re: [U-Boot] [PATCH v5 07/18] socfpga: boot0 hook: adjust to unified boot0 semantics

Marek & Tien Fong, could either of you have a look at the below change (in the context of https://patchwork.ozlabs.org/patch/823872/, which is also contained in the same series) and give me an ok on this, so I can merge this series early in the upcoming merge window? Thanks, Philipp. > On 10 Oc

Re: [U-Boot] [PATCH v5 07/18] socfpga: boot0 hook: adjust to unified boot0 semantics

> On 6 Nov 2017, at 18:54, Marek Vasut wrote: > > On 11/06/2017 06:26 PM, Dr. Philipp Tomsich wrote: >> Marek & Tien Fong, >> >> could either of you have a look at the below change (in the context of >> https://patchwork.ozlabs.org/patch/823872/, which is

[U-Boot] [PULL] Please pull u-boot-rockchip

Tom, Here’s another pull-request for u-boot-rockchip for some last-minute DTS-updates and config-changes for the upcoming release. Regards, Philipp. The following changes since commit 7a69604bce9a9a9476753af64e5a1870880c1333: Prepare v2017.11-rc4 (2017-11-06 18:25:37 -0500) are available i

Re: [U-Boot] [PATCH 07/15] spl: atf: introduce spl_invoke_atf and make bl31_entry private

> On 17 Sep 2017, at 19:53, Simon Glass wrote: > > Hi Philipp, > > On 13 September 2017 at 13:29, Philipp Tomsich > > wrote: >> This adds a new interface spl_invoke_atf() that takes a spl_image_info >> argument and then derives the necessary parame

Re: [U-Boot] [PATCH 10/15] rockchip: dts: rk3399-puma: add /config/arm-trusted-firmware, reset-gpio property

> On 17 Sep 2017, at 19:54, Simon Glass wrote: > > On 13 September 2017 at 13:29, Philipp Tomsich > wrote: >> With the ATF capable of accessing the FDT passed to the next stage, >> we can specify configuration items for the ATF in the /config path. >> >> This adds the arm-trusted-firmware,rese

Re: [U-Boot] [PATCH v5 02/18] rockchip: boot0: align to 0x20 for armv7 '_start'

Andy, On 9 Nov 2017, at 13:59, Andy Yan wrote: > > Hi Phipipp, Kever: > > > On 2017年10月10日 22:21, Philipp Tomsich wrote: >> From: Kever Yang >> >> The '_start' is using as vector table base address, and will write >> to VBAR register, so it needs to be aligned to 0x20 for armv7. >> >> Signe

Re: [U-Boot] [U-Boot, 2/3] rockchip: doc: update U-Boot location info

Kever, > On 10 Nov 2017, at 08:24, Goldschmidt Simon > wrote: > >>> Update rockchip U-Boot location to 0x4000/16384. At least the location given in the commit message is consistent: (gdb) p 0x4000 $1 = 16384 >>> Signed-off-by: Kever Yang >>> Acked-by: Philipp Tomsich >>> Rev

Re: [U-Boot] [U-Boot, 2/3] rockchip: doc: update U-Boot location info

Jagan, > On 10 Nov 2017, at 12:12, Jagan Teki wrote: > > On Fri, Nov 10, 2017 at 3:53 PM, Dr. Philipp Tomsich > wrote: >> Kever, >> >>> On 10 Nov 2017, at 08:24, Goldschmidt Simon >>> wrote: >>> >>>>> Update rockchip U-Bo

Re: [U-Boot] [U-Boot, 2/3] rockchip: doc: update U-Boot location info

> On 10 Nov 2017, at 12:26, Jagan Teki wrote: > > On Fri, Nov 10, 2017 at 4:48 PM, Dr. Philipp Tomsich > wrote: >> Jagan, >> >>> On 10 Nov 2017, at 12:12, Jagan Teki wrote: >>> >>> On Fri, Nov 10, 2017 at 3:53 PM, Dr. Philipp Tomsich >&g

Re: [U-Boot] [U-Boot, 2/3] rockchip: doc: update U-Boot location info

> On 10 Nov 2017, at 12:30, Goldschmidt Simon > wrote: > >>> I just found this commit has calculated the size wrong. 16384 blocks should >>> be 8MB, not 4MB. >> >> Yes, 8MB is what expected here and even Kever[1] commented the same, what is >> 4MB here? can you elaborate. > > I know. It's o

[U-Boot] [PULL] Please pull u-boot-rockchip

Tom, as it turns out, we have some more fixes (for documentation and a board-specific header file) for 2017.11. Thanks, Philipp. The following changes since commit 1c4043e53236d94f217e98625ea201690e85f56d: Merge branch 'master' of git://git.denx.de/u-boot-sunxi (2017-11-09 08:11:40 -0500)

Re: [U-Boot] [PATCH 1/2] usb: xhci: implement FEAT_POWER hook for switching regulators for ports

Bin, > On 17 Nov 2017, at 10:27, Bin Meng wrote: > > Hi Philipp, > > On Tue, Nov 7, 2017 at 6:04 AM, Philipp Tomsich > > wrote: >> When the FEAT_POWER flag is set/cleared for a port, power to this port >> should be enabled/disabled. As many embedd

Re: [U-Boot] [PATCH v3 0/3] Most rockchip platform based boards use a key to instruct

Andy, Thanks for the reminder. I had this on my list as one of the next ones to be merged. Cheers, Philipp. > On 17 Nov 2017, at 11:09, Andy Yan wrote: > > Hi Philipp: > > Please remember to take this series if they are looks ok for you. And if > you have questions about them, please let

Re: [U-Boot] [PATCH 1/2] usb: xhci: implement FEAT_POWER hook for switching regulators for ports

> On 17 Nov 2017, at 14:19, Bin Meng wrote: > > Hi Philipp, > > On Fri, Nov 17, 2017 at 5:43 PM, Dr. Philipp Tomsich > wrote: >> Bin, >> >> On 17 Nov 2017, at 10:27, Bin Meng wrote: >> >> Hi Philipp, >> >> On Tue, Nov 7,

Re: [U-Boot] [U-Boot,V9,1/4] usb: rockchip: add the rockusb gadget

Kever & Eddie, > On 2 Oct 2017, at 12:51, Dr. Philipp Tomsich > wrote: > > +Kever, +Eddie > > Kever & Eddie, > >> On 2 Oct 2017, at 12:41, Marek Vasut wrote: >> >> On 10/02/2017 12:40 PM, Dr. Philipp Tomsich wrote: >>> Lukasz &

Re: [U-Boot] [U-Boot, v3, 1/3] rockchip: make boot_mode related codes reused across all platforms

Andy, > On 21 Nov 2017, at 01:48, Andy Yan wrote: > > Hi Philipp: > > > On 2017年11月20日 22:50, Philipp Tomsich wrote: >> >> >> On Wed, 11 Oct 2017, Andy Yan wrote: >> >>> setup_boot_mode function use the same logic but different >>> mode register address across all the rockchip platforms, >>

Re: [U-Boot] [U-Boot, v3, 3/3] rockchip: check download key before bootup

Andy, > On 21 Nov 2017, at 02:02, Andy Yan wrote: > > Hi Philipp: > > > On 2017年11月20日 22:51, Philipp Tomsich wrote: >> >> >> On Wed, 11 Oct 2017, Andy Yan wrote: >> >>> Enter download mode if the download key pressed. >>> >>> Signed-off-by: Andy Yan >>> Acked-by: Philipp Tomsich >> >>

[U-Boot] [PULL] Please pull from u-boot-rockchip/master

Tom, Please pull from u-boot-rockchip/master. The associated Travis run (prior to a final rebase) is at https://travis-ci.org/ptomsich/u-boot-rockchip/builds/305523168. Thanks, Philipp. The following changes since commit 16fa2eb95172e63820ee5f3d4052f3362a6de84e: ARM: dra7: Kconfig: Add the

Re: [U-Boot] [PATCH v2 1/3] usb: hub: identify the hub-device to usb_hub_reset_devices

> On 22 Nov 2017, at 16:59, Marek Vasut wrote: > > On 11/22/2017 04:57 PM, Philipp Tomsich wrote: >> When usb_hub_reset_devices is called, it should be passed both an >> indicator which hub it should operate on and what port number (local >> to that hub) should be reset. > > Why ? Simply becau

Re: [U-Boot] [PATCH v3 1/3] usb: hub: identify the hub-device to usb_hub_reset_devices

> On 22 Nov 2017, at 17:23, Marek Vasut wrote: > > On 11/22/2017 05:15 PM, Philipp Tomsich wrote: >> When usb_hub_reset_devices is called, it should be passed both an >> indicator which hub it should operate on and what port number (local >> to that hub) should be reset. >> >> Previously, the u

Re: [U-Boot] [U-Boot, 10/15] rockchip: dts: rk3399-puma: add /config/arm-trusted-firmware, reset-gpio property

> On 23 Nov 2017, at 15:51, Philipp Tomsich > wrote: > >> With the ATF capable of accessing the FDT passed to the next stage, >> we can specify configuration items for the ATF in the /config path. >> >> This adds the arm-trusted-firmware,reset-gpio that conveys the number >> of the GPIO used to

[U-Boot] sun50i blocking SPL changes

Jagan, Maxime & Tom, I have a couple of changes to spl_fit.c queued that we need to get merged to fix some issues for ATF support on Rockchip platforms. However, due to internal alignment before the ARMv8 vectors, this breaks the sun50i builds (all exceeding their SPL size by up to approx. 1KB),

Re: [U-Boot] sun50i blocking SPL changes

> On 24 Nov 2017, at 21:36, Jagan Teki wrote: > > On Sat, Nov 25, 2017 at 1:17 AM, Dr. Philipp Tomsich > wrote: >> Jagan, Maxime & Tom, >> >> I have a couple of changes to spl_fit.c queued that we need to get merged to >> fix some issues for ATF supp

<    1   2   3   4   5   6   >