Simon, > On 01 Aug 2017, at 11:49, Simon Glass <s...@chromium.org> wrote: > > Hi Philipp, > > On 28 July 2017 at 13:22, Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: >> The GMAC in the RK3368 once again is identical to the incarnation in >> the RK3288 and the RK3399, except for where some of the configuration >> and control registers are located in the GRF. >> >> This adds the RK3368-specific logic necessary to reuse this driver. >> >> Signed-off-by: Philipp Tomsich <philipp.toms...@theobroma-systems.com> >> >> Acked-by: Joe Hershberger <joe.hershber...@ni.com> >> --- >> >> Changes in v3: None >> Changes in v2: >> - moves the bit-definitions (for GRF registers) specific to the GMAC >> into the GMAC driver: these include interface speed selection and >> configuring the RGMII output mode >> >> arch/arm/include/asm/arch-rockchip/grf_rk3368.h | 1 + >> drivers/net/gmac_rockchip.c | 78 >> +++++++++++++++++++++++++ >> 2 files changed, 79 insertions(+) >> > > Reviewed-by: Simon Glass <s...@chromium.org> > > I still think we should look at splitting these out into (e.g.) ioctl > operations on syscon.
I still agree with you and plan to look into this for the next cycle. Thanks, Philipp. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
