> On 31 Oct 2017, at 08:52, Kever Yang <kever.y...@rock-chips.com> wrote: > > Using the ENV offset from rockchip legacy U-Boot for all SoCs, > the offset is 4MB-32KB > > Signed-off-by: Kever Yang <kever.y...@rock-chips.com> > --- > > include/configs/rockchip-common.h | 15 +++------------ > 1 file changed, 3 insertions(+), 12 deletions(-) > > diff --git a/include/configs/rockchip-common.h > b/include/configs/rockchip-common.h > index 96b5fce..3fc1b71 100644 > --- a/include/configs/rockchip-common.h > +++ b/include/configs/rockchip-common.h > @@ -61,19 +61,10 @@ > > #endif > > -#if CONFIG_IS_ENABLED(ROCKCHIP_BACK_TO_BROM) > -/* SPL @ 32k for 34k > - * u-boot directly after @ 68k for 400k or so > - * ENV @ 992k > - */ > -#define CONFIG_ENV_OFFSET ((1024-32) * 1024) > -#else > -/* SPL @ 32k for ~36k > - * ENV @ 96k > - * u-boot @ 128K > +/* > + * Rockchip SoCs use fixed ENV 32KB@(4MB-32KB) > */ > -#define CONFIG_ENV_OFFSET (96 * 1024) > -#endif > +#define CONFIG_ENV_OFFSET (SZ_4M - SZ_32K)
Is there a reason why we don’t move this to the DTS (there is a /config/u-boot,mmc-env-offset property node for this)? > > #define CONFIG_DISPLAY_BOARDINFO_LATE > > -- > 1.9.1 > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
