Re: [RFT PATCH v1 2/5] usb: Handle XACTERR error in DATA phase of USB storage

2020-03-23 Thread Lukasz Majewski
Hi Marek, > On 3/22/20 2:00 PM, Lukasz Majewski wrote: > > This change brings support for handling XACTERR error during DATA > > phase of USB BBB (bulk) transmission. > > > > The fix is to clear stall'ed endpoint and reset recovery on the USB > > mass storage class. > > > > This code is the port

Re: [RFT PATCH v1 3/5] usb: Add some delay to wait for slow USB devices to be operational

2020-03-23 Thread Lukasz Majewski
Hi Marek, > On 3/22/20 2:00 PM, Lukasz Majewski wrote: > > This change provides some extra time for some slow (or degraded) > > USB devices to become fully operational. > > > > This code is the port to newest U-Boot of the fix from - "rayvt" > > (from [1]). > > > > Links: > > [1] - https://forum

Re: [PATCH 1/6] net: dwc_eth_qos: Fully rewrite RX descriptor field 3

2020-03-23 Thread Ramon Fried
On Mon, Mar 23, 2020 at 3:45 AM Marek Vasut wrote: > > The RX descriptor field 3 should contain only OWN and BUF1V bits before > being used for receiving data by the DMA engine. However, right now, if > the descriptor was already used for receiving data and is being cleared, > the field 3 is only

Re: [PATCH 2/6] net: dwc_eth_qos: Correctly wrap around TX descriptor tail pointer

2020-03-23 Thread Ramon Fried
On Mon, Mar 23, 2020 at 3:45 AM Marek Vasut wrote: > > This code programs the next descriptor in the TX descriptor ring into > the hardware as the last valid TX descriptor. The problem is that if > the currenty descriptor is the last one in the array, the code will > not wrap around correctly and

Re: [PATCH 5/6] net: dwc_eth_qos: Invalidate RX packet DMA buffer

2020-03-23 Thread Ramon Fried
On Mon, Mar 23, 2020 at 3:45 AM Marek Vasut wrote: > > This patch prevents an issue where the RX packet might have been > accessed by the CPU, which now has cached data from the packet in > the caches and possibly various write buffers, and these data may > be evicted from the caches into the DRAM

Re: [PATCH 3/6] net: dwc_eth_qos: Flush the RX descriptors on init

2020-03-23 Thread Ramon Fried
On Mon, Mar 23, 2020 at 3:45 AM Marek Vasut wrote: > > Currently the code only flushes the first RX descriptor, not every entry > in the RX descriptor ring. Fix this, to make sure the DMA engine can pick > the RX descriptors correctly. > > Signed-off-by: Marek Vasut > Cc: Joe Hershberger > Cc: P

Re: [PATCH 4/6] net: dwc_eth_qos: Invalidate RX descriptor before reading

2020-03-23 Thread Ramon Fried
On Mon, Mar 23, 2020 at 3:45 AM Marek Vasut wrote: > > The current code polls the RX desciptor ring for new packets by reading > the RX descriptor status. This works by accident, as the RX descriptors > are often in non-cacheable memory. However, the driver does support use > of RX descriptors in

Re: [PATCH 6/6] net: dwc_eth_qos: Prevent DMA from writing updated RX DMA descriptor

2020-03-23 Thread Ramon Fried
On Mon, Mar 23, 2020 at 3:45 AM Marek Vasut wrote: > > The DMA may attempt to write a DMA descriptor in the ring while it is > being updated. By writing the DMA descriptor buffer address to 0, it > is assured the DMA will not use such a buffer and the buffer can be > updated without any interferen

[RFC PATCH 0/4] qemu: arm64: Add support for uefi firmware management protocol routines

2020-03-23 Thread Sughosh Ganu
This series is based on the capsule update rfc series sent by Takahiro Akashi[1]. These routines have been tested on the qemu arm64 platform for updating the u-boot firmware through the capsule-on-disk functionality of the uefi spec. A sub-command has been added under the 'efidebug capsule' catego

[RFC PATCH 2/4] semihosting: Change semihosting file operation functions into global symbols

2020-03-23 Thread Sughosh Ganu
Change the semihosting file operation functions into external symbols so that they can be called from outside the file. These functions would be required to be called for implementing firmware update functionality for the qemu arm64 platform. Signed-off-by: Sughosh Ganu --- arch/arm/lib/semihost

[RFC PATCH 3/4] semihosting: Add support for writing to a file

2020-03-23 Thread Sughosh Ganu
Add a function to enable writing to a file. Currently, support is added for writing to a binary file. This would be used for implementing the firmware update functionality for the qemu arm64 platform. Signed-off-by: Sughosh Ganu --- arch/arm/lib/semihosting.c | 41 +++

[RFC PATCH 1/4] efidebug: capsule: Add a command to update capsule on disk

2020-03-23 Thread Sughosh Ganu
Add a efidebug subcommand to initiate a firmware update using the efi firmware management protocol(fmp) set_image routine. The firmware update can be initiated through 'efidebug capsule disk-update' This would locate the efi capsule file on the efi system partition, and call the platform's set_i

[RFC PATCH 4/4] qemu: arm64: Add support for efi firmware management protocol routines

2020-03-23 Thread Sughosh Ganu
Add support for the get_image_info and set_image routines, which are part of the efi firmware management protocol. The current implementation uses the set_image routine for updating the u-boot binary image for the qemu arm64 platform. This is supported using the capsule-on-disk feature of the uefi

Re: [RFT PATCH v1 5/5] usb: Handle QT_TOKEN_STATUS_XACTERR error when sending data

2020-03-23 Thread Lukasz Majewski
Hi Marek, > On 3/22/20 2:00 PM, Lukasz Majewski wrote: > > This code adds check if QT_TOKEN_STATUS_XACTERR error occurred. > > When it is detected the token is reconfigured and transmission is > > retried. > > > > This code is the port to newest U-Boot of the fix from - "rayvt" > > (from [1]). >

Re: [RFT PATCH v1 4/5] usb: Provide code to handle spinup of USB usb devices (mostly HDDs)

2020-03-23 Thread Lukasz Majewski
Hi Marek, > On 3/22/20 2:00 PM, Lukasz Majewski wrote: > [...] > > diff --git a/common/usb_storage.c b/common/usb_storage.c > > index 92e1e54d1c..3c2324fa1a 100644 > > --- a/common/usb_storage.c > > +++ b/common/usb_storage.c > > @@ -729,6 +729,7 @@ static int usb_stor_BBB_transport(struct > > scs

RE: [PATCH 07/10] board: stm32mp1: add finished good in board identifier OTP

2020-03-23 Thread Patrick DELAUNAY
Hi Wolfgang, > From: Wolfgang Denk > Sent: jeudi 19 mars 2020 10:14 > > Dear Patrick, > > In message <07159b22a76a445089aa6cd646c0e...@sfhdag6node3.st.com> > you wrote: > > > > > I can't parse the sentence above, sorry. > > > > It is a part of the codification used in production of ST board, so

Re: [PATCH v5 00/12] ClearFog Base static variant support

2020-03-23 Thread Stefan Roese
Hi Joel, On 22.03.20 19:46, Joel Johnson wrote: I just wanted to ping on this review (http://patchwork.ozlabs.org/project/uboot/list/?series=155533) to see if it had reached an agreeable state or if there were still lingering issues. I've been using it without issue against RC releases. If t

Re: [PATCH v5 01/12] arm: mvebu: fix SerDes table alignment

2020-03-23 Thread Stefan Roese
On 27.01.20 21:01, Joel Johnson wrote: Tested on Solidrun ClearFog Base. Table alignment was: | Lane # | Speed | Type | | 0| 3 | SATA0 | | 1| 0 | SGMII1 | | 2| 3 | SATA1 | | 3| 5 | USB3 H

Re: [PATCH v5 02/12] arm: mvebu: solidrun: remove hardcoded DTS MAC address

2020-03-23 Thread Stefan Roese
On 27.01.20 21:01, Joel Johnson wrote: Using a consistent hardcoded MAC address from the DTS file causes issues when using multiple devices on the same network segment. Instead rely on environment configuration or random generation. Signed-off-by: Joel Johnson Reviewed-by: Stefan Roese Than

Re: [PATCH v5 03/12] arm: mvebu: clearfog: use Pro name by default

2020-03-23 Thread Stefan Roese
On 27.01.20 21:01, Joel Johnson wrote: Make the board version printed indicate the Pro variant default. Also adjust static name casing to match what is expected for EEPROM product name to share string constants. --- v4 changes: - newly added v5 changes: - none Signed-off-by: Joel Johnson

Re: [PATCH v5 04/12] arm: mvebu: clearfog: initial ClearFog Base variant

2020-03-23 Thread Stefan Roese
On 27.01.20 21:01, Joel Johnson wrote: Add a unique entry for ClearFog Base variant, reflected in the board name and adjusted SerDes topology. Signed-off-by: Joel Johnson --- v2 changes: - reworked based on Baruch's run-time TLV EEPROM detection series v3 changes: - rebased on mvebu mer

Re: [PATCH v5 05/12] arm: mvebu: clearfog: Add option for 2.5 Gbps SFP

2020-03-23 Thread Stefan Roese
On 27.01.20 21:01, Joel Johnson wrote: While newer Linux kernels provide autoconfiguration of SFP, provide an option for setting in U-Boot Kconfig for use prior to booting. Signed-off-by: Joel Johnson --- v2 changes: - fixed help indentation v3 changes: - none v4 changes: - adjust st

Re: [PATCH v5 06/12] arm: mvebu: clearfog: Add SATA mode flags

2020-03-23 Thread Stefan Roese
On 27.01.20 21:01, Joel Johnson wrote: The mPCIe slots on ClearFog Pro and ClearFog Base may be alternately configured for SATA usage. Signed-off-by: Joel Johnson --- v2 changes: - fixed help indentation v3 changes: - none v4 changes: - adjust static SerDes configuration at runtime i

Re: [PATCH v5 07/12] arm: mvebu: clearfog: Unify DT selection paths

2020-03-23 Thread Stefan Roese
On 27.01.20 21:01, Joel Johnson wrote: Unify the location of DT selection into board_late_init instead of split between detection and static configuration paths. --- v2 changes - newly added in V2 series based on run-time rebasing v3 changes - none v4 changes - separate change to expli

Re: [PATCH v5 09/12] arm: mvebu: enable working default boot support

2020-03-23 Thread Stefan Roese
On 27.01.20 21:01, Joel Johnson wrote: With the move to driver model usage, ensure that the required driver support for SPI and MMC booting is available in SPL. Tested on SolidRun ClearFog devices. Signed-off-by: Joel Johnson Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH v5 08/12] arm: mvebu: clearfog: add SPI offsets

2020-03-23 Thread Stefan Roese
On 27.01.20 21:01, Joel Johnson wrote: Add reasonable default SPI offsets and ENV size when configured to boot from SPI flash. Signed-off-by: Joel Johnson Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH v5 10/12] arm: mvebu: clearfog: move ENV params to Kconfig

2020-03-23 Thread Stefan Roese
On 27.01.20 21:01, Joel Johnson wrote: Migrate the values for ENV_SIZE and ENV_OFFSET into board specific Kconfig defaults so they're more accessible for configuration. --- v2 changes: - none v3 changes: - none v4 changes: - none v5 changes: - none Signed-off-by: Joel Johnson Re

Re: [PATCH v5 11/12] arm: mvebu: clearfog: don't always use SPL MMC

2020-03-23 Thread Stefan Roese
On 27.01.20 21:01, Joel Johnson wrote: Move MMC booting assuptions from defconfig to Kconfig which includes as needed based on dependent options. Signed-off-by: Joel Johnson Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH v5 12/12] arm: mvebu: clearfog: Use Pro DT by default

2020-03-23 Thread Stefan Roese
On 27.01.20 21:01, Joel Johnson wrote: Switch to explicitly using the Pro variant DT, which has been available since Linux 4.11. --- v4 changes: - new v5 changes: - none I separated out this change to the end of the series since it drew questioning on prior review. I'd still advocate for

Re: [PATCH v5 05/12] arm: mvebu: clearfog: Add option for 2.5 Gbps SFP

2020-03-23 Thread Baruch Siach
Hi Stefan, On Mon, Mar 23 2020, Stefan Roese wrote: > On 27.01.20 21:01, Joel Johnson wrote: >> While newer Linux kernels provide autoconfiguration of SFP, provide >> an option for setting in U-Boot Kconfig for use prior to booting. >> >> Signed-off-by: Joel Johnson >> >> --- >> >> v2 changes: >

Re: [PATCH v5 05/12] arm: mvebu: clearfog: Add option for 2.5 Gbps SFP

2020-03-23 Thread Stefan Roese
On 23.03.20 10:33, Baruch Siach wrote: Hi Stefan, On Mon, Mar 23 2020, Stefan Roese wrote: On 27.01.20 21:01, Joel Johnson wrote: While newer Linux kernels provide autoconfiguration of SFP, provide an option for setting in U-Boot Kconfig for use prior to booting. Signed-off-by: Joel Johns

Re: [PATCH v2 1/5] cmd: mvebu: bubt: add A38x support

2020-03-23 Thread Stefan Roese
On 29.01.20 15:50, Joel Johnson wrote: Add support for Armada 38x devices in bubt flashing utility. This is based on (and streamlined from) the support in the SolidRun master-a38x vendor fork branch. Signed-off-by: Joel Johnson Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH v2 2/5] cmd: mvebu: bubt: correct U-Boot spelling

2020-03-23 Thread Stefan Roese
On 29.01.20 15:50, Joel Johnson wrote: Replace "U-BOOT" text with correct spelling Signed-off-by: Joel Johnson Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH v2 3/5] cmd: mvebu: bubt: verify A38x target device type

2020-03-23 Thread Stefan Roese
On 29.01.20 15:50, Joel Johnson wrote: Ensure that the device to which an image is being written includes header information indicating boot support for the destination device. This is derived from the support in the SolidRun master-a38x vendor fork branch. Signed-off-by: Joel Johnson --- v2

Re: [PATCH v2 4/5] arm: mvebu: clearfog: enable bubt command

2020-03-23 Thread Stefan Roese
On 29.01.20 15:50, Joel Johnson wrote: With support added for Armada 38x, include the bubt command in ClearFog defconfig. Signed-off-by: Joel Johnson Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH v2 5/5] cmd: mvebu: bubt: show image boot device

2020-03-23 Thread Stefan Roese
On 29.01.20 15:50, Joel Johnson wrote: When a mismatch is found trying to write an image for one boot method to a different boot device, print an error message including the image header marked target boot device type. Signed-off-by: Joel Johnson Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH v2 1/5] cmd: mvebu: bubt: add A38x support

2020-03-23 Thread Stefan Roese
Hi Joel, On 22.03.20 19:48, Joel Johnson wrote: I just wanted to ping on this review (http://patchwork.ozlabs.org/project/uboot/list/?series=155850). I haven't seen any review feedback, so would like to check if it's agreeably in a state ready for merging in the next merge window or if there

Re: [PATCH 1/2] arm: mvebu: clearfog: add SCSI to distro bootcmd

2020-03-23 Thread Stefan Roese
Added Josua to Cc. On 29.01.20 04:59, Joel Johnson wrote: Include attempting to boot from SCSI (SATA) devices within generated board distro bootcmd environment. The reasoning for boot ordering is that MMC and USB are external and removable, while when a case is in use, replacing M.2 or mSATA dri

RE: [PATCH 1/3] net: fman: add support for all RGMII delay modes

2020-03-23 Thread Priyanka Jain (OSS)
>-Original Message- >From: U-Boot On Behalf Of Madalin Bucur >Sent: Thursday, March 12, 2020 6:24 PM >To: joe.hershber...@ni.com; u-boot@lists.denx.de >Cc: Madalin Bucur (OSS) >Subject: [PATCH 1/3] net: fman: add support for all RGMII delay modes > >The RGMII modes that include internal d

Re: [PATCH 2/2] arm: mvebu: clearfog: support multiple SATA boot

2020-03-23 Thread Stefan Roese
Added Josua to Cc. On 29.01.20 04:59, Joel Johnson wrote: Enabled distro bootcmd support for additional SATA ports if enabled. Signed-off-by: Joel Johnson --- This patch builds on and requires the separate patch series adding configurable SATA support ("arm: mvebu: clearfog: Add SATA mode f

Re: [PATCH 1/2] arm: mvebu: clearfog: add SCSI to distro bootcmd

2020-03-23 Thread Stefan Roese
Hi Joel, On 22.03.20 19:53, Joel Johnson wrote: As with other related ClearFog patches, I haven't received any review responses on this series (http://patchwork.ozlabs.org/project/uboot/list/?series=155760) and would like to ping out for additional review. I'd especially like feedback on the

Re: [U-Boot] Sharing a hardware lab

2020-03-23 Thread Harald Seiler
Hello Simon, On Sun, 2020-03-22 at 12:42 -0600, Simon Glass wrote: > Hi Harald, > > On Sun, 22 Mar 2020 at 03:56, Harald Seiler wrote: > > Hi Simon, > > > > On Sat, 2020-03-21 at 13:07 -0600, Simon Glass wrote: [...] > > > > Huh, actually I messed up in the patch I sent you. Please apply the

RE: [PATCH 2/3] armv8/ls1043ardb: RGMII ports require internal delay

2020-03-23 Thread Priyanka Jain (OSS)
>-Original Message- >From: U-Boot On Behalf Of Madalin Bucur >Sent: Thursday, March 12, 2020 6:24 PM >To: joe.hershber...@ni.com; u-boot@lists.denx.de >Cc: Madalin Bucur (OSS) >Subject: [PATCH 2/3] armv8/ls1043ardb: RGMII ports require internal delay The changes are in net driver. Please

RE: [PATCH 2/3] armv8/ls1043ardb: RGMII ports require internal delay

2020-03-23 Thread Madalin Bucur (OSS)
> -Original Message- > From: Priyanka Jain (OSS) > Sent: Monday, March 23, 2020 12:30 PM > To: Madalin Bucur (OSS) ; > joe.hershber...@ni.com; u-boot@lists.denx.de > Subject: RE: [PATCH 2/3] armv8/ls1043ardb: RGMII ports require internal > delay > > >-Original Message- > >From: U-

Re: [RFC PATCH 1/4] efidebug: capsule: Add a command to update capsule on disk

2020-03-23 Thread Heinrich Schuchardt
On 3/23/20 8:11 AM, Sughosh Ganu wrote: > Add a efidebug subcommand to initiate a firmware update using the efi > firmware management protocol(fmp) set_image routine. > > The firmware update can be initiated through > > 'efidebug capsule disk-update' > > This would locate the efi capsule file on th

Re: [PATCH 6/6] net: dwc_eth_qos: Prevent DMA from writing updated RX DMA descriptor

2020-03-23 Thread Marek Vasut
On 3/23/20 8:09 AM, Ramon Fried wrote: > On Mon, Mar 23, 2020 at 3:45 AM Marek Vasut wrote: >> >> The DMA may attempt to write a DMA descriptor in the ring while it is >> being updated. By writing the DMA descriptor buffer address to 0, it >> is assured the DMA will not use such a buffer and the b

Re: [RFT PATCH v1 1/5] Revert "usb: ehci-hcd: Keep async schedule running"

2020-03-23 Thread Marek Vasut
On 3/23/20 7:57 AM, Lukasz Majewski wrote: > Hi Marek, Hi, >> On 3/22/20 2:00 PM, Lukasz Majewski wrote: >>> This reverts commit 02b0e1a36c5bc20174299312556ec4e266872bd6. >>> >>> Signed-off-by: Lukasz Majewski >> >> This patch lacks any and all explanation why this is being reverted. >> The pa

Re: [RFT PATCH v1 2/5] usb: Handle XACTERR error in DATA phase of USB storage

2020-03-23 Thread Marek Vasut
On 3/23/20 8:00 AM, Lukasz Majewski wrote: > Hi Marek, > >> On 3/22/20 2:00 PM, Lukasz Majewski wrote: >>> This change brings support for handling XACTERR error during DATA >>> phase of USB BBB (bulk) transmission. >>> >>> The fix is to clear stall'ed endpoint and reset recovery on the USB >>> mas

Re: [RFT PATCH v1 4/5] usb: Provide code to handle spinup of USB usb devices (mostly HDDs)

2020-03-23 Thread Marek Vasut
On 3/23/20 8:53 AM, Lukasz Majewski wrote: > Hi Marek, Hi, >> On 3/22/20 2:00 PM, Lukasz Majewski wrote: >> [...] >>> diff --git a/common/usb_storage.c b/common/usb_storage.c >>> index 92e1e54d1c..3c2324fa1a 100644 >>> --- a/common/usb_storage.c >>> +++ b/common/usb_storage.c >>> @@ -729,6 +729,7

Re: [RFT PATCH v1 5/5] usb: Handle QT_TOKEN_STATUS_XACTERR error when sending data

2020-03-23 Thread Marek Vasut
On 3/23/20 8:18 AM, Lukasz Majewski wrote: > Hi Marek, Hi, >> On 3/22/20 2:00 PM, Lukasz Majewski wrote: >>> This code adds check if QT_TOKEN_STATUS_XACTERR error occurred. >>> When it is detected the token is reconfigured and transmission is >>> retried. >>> >>> This code is the port to newest U

Re: [RFT PATCH v1 3/5] usb: Add some delay to wait for slow USB devices to be operational

2020-03-23 Thread Marek Vasut
On 3/23/20 8:04 AM, Lukasz Majewski wrote: > Hi Marek, > >> On 3/22/20 2:00 PM, Lukasz Majewski wrote: >>> This change provides some extra time for some slow (or degraded) >>> USB devices to become fully operational. >>> >>> This code is the port to newest U-Boot of the fix from - "rayvt" >>> (fro

Re: [RFC PATCH 0/4] qemu: arm64: Add support for uefi firmware management protocol routines

2020-03-23 Thread Heinrich Schuchardt
On 3/23/20 8:11 AM, Sughosh Ganu wrote: > This series is based on the capsule update rfc series sent by Takahiro > Akashi[1]. > > These routines have been tested on the qemu arm64 platform for > updating the u-boot firmware through the capsule-on-disk functionality > of the uefi spec. A sub-command

[PATCH v2] net: eth-uclass: Fix message if mac is coming from DT or ROM

2020-03-23 Thread Michal Simek
When local-mac-address DT property is specified it is reported the same way as address read from eeprom/ROM. Show properly if mac address is coming from DT or ROM. Signed-off-by: Michal Simek --- Changes in v2: - Also update source when mac addresses from variable and ROM/DT failed to make cle

Re: [PATCH 6/6] net: dwc_eth_qos: Prevent DMA from writing updated RX DMA descriptor

2020-03-23 Thread Ramon Fried
On Mon, Mar 23, 2020 at 2:00 PM Marek Vasut wrote: > > On 3/23/20 8:09 AM, Ramon Fried wrote: > > On Mon, Mar 23, 2020 at 3:45 AM Marek Vasut wrote: > >> > >> The DMA may attempt to write a DMA descriptor in the ring while it is > >> being updated. By writing the DMA descriptor buffer address to

Re: [PATCH 6/6] net: dwc_eth_qos: Prevent DMA from writing updated RX DMA descriptor

2020-03-23 Thread Ramon Fried
On Mon, Mar 23, 2020 at 3:45 AM Marek Vasut wrote: > > The DMA may attempt to write a DMA descriptor in the ring while it is > being updated. By writing the DMA descriptor buffer address to 0, it > is assured the DMA will not use such a buffer and the buffer can be > updated without any interferen

Re: [PATCH 6/6] net: dwc_eth_qos: Prevent DMA from writing updated RX DMA descriptor

2020-03-23 Thread Marek Vasut
On 3/23/20 1:19 PM, Ramon Fried wrote: > On Mon, Mar 23, 2020 at 2:00 PM Marek Vasut wrote: >> >> On 3/23/20 8:09 AM, Ramon Fried wrote: >>> On Mon, Mar 23, 2020 at 3:45 AM Marek Vasut wrote: The DMA may attempt to write a DMA descriptor in the ring while it is being updated. By wr

Re: [RFT PATCH v1 1/5] Revert "usb: ehci-hcd: Keep async schedule running"

2020-03-23 Thread Lukasz Majewski
Hi Marek, > On 3/23/20 7:57 AM, Lukasz Majewski wrote: > > Hi Marek, > > Hi, > > >> On 3/22/20 2:00 PM, Lukasz Majewski wrote: > >>> This reverts commit 02b0e1a36c5bc20174299312556ec4e266872bd6. > >>> > >>> Signed-off-by: Lukasz Majewski > >> > >> This patch lacks any and all explanatio

Re: [PATCH 6/6] net: dwc_eth_qos: Prevent DMA from writing updated RX DMA descriptor

2020-03-23 Thread Ramon Fried
On Mon, Mar 23, 2020 at 2:22 PM Marek Vasut wrote: > > On 3/23/20 1:19 PM, Ramon Fried wrote: > > On Mon, Mar 23, 2020 at 2:00 PM Marek Vasut wrote: > >> > >> On 3/23/20 8:09 AM, Ramon Fried wrote: > >>> On Mon, Mar 23, 2020 at 3:45 AM Marek Vasut wrote: > > The DMA may attempt to writ

Re: [RFT PATCH v1 4/5] usb: Provide code to handle spinup of USB usb devices (mostly HDDs)

2020-03-23 Thread Lukasz Majewski
Hi Marek, > On 3/23/20 8:53 AM, Lukasz Majewski wrote: > > Hi Marek, > > Hi, > > >> On 3/22/20 2:00 PM, Lukasz Majewski wrote: > >> [...] > >>> diff --git a/common/usb_storage.c b/common/usb_storage.c > >>> index 92e1e54d1c..3c2324fa1a 100644 > >>> --- a/common/usb_storage.c > >>> +++ b/comm

Re: [RFT PATCH v1 5/5] usb: Handle QT_TOKEN_STATUS_XACTERR error when sending data

2020-03-23 Thread Lukasz Majewski
Hi Marek, > On 3/23/20 8:18 AM, Lukasz Majewski wrote: > > Hi Marek, > > Hi, > > >> On 3/22/20 2:00 PM, Lukasz Majewski wrote: > >>> This code adds check if QT_TOKEN_STATUS_XACTERR error occurred. > >>> When it is detected the token is reconfigured and transmission is > >>> retried. > >>> >

Re: [RFT PATCH v1 2/5] usb: Handle XACTERR error in DATA phase of USB storage

2020-03-23 Thread Lukasz Majewski
Hi Marek, > On 3/23/20 8:00 AM, Lukasz Majewski wrote: > > Hi Marek, > > > >> On 3/22/20 2:00 PM, Lukasz Majewski wrote: > >>> This change brings support for handling XACTERR error during DATA > >>> phase of USB BBB (bulk) transmission. > >>> > >>> The fix is to clear stall'ed endpoint and re

adding support for locking on macronix flashes

2020-03-23 Thread Rasmus Villemoes
I need to add support for locking on macronix flashes. They don't quite fit into the existing stm_*() functions, so I suppose I will have to create a new family (mx_*lock*). They do have the same SR_BP{0,1,2} bits, but also a fourth SR_BP3. Moreover, they also support bottom protect, but the bit f

Re: [PATCH v3 10/23] travis: Don't copy files into .bm-work/

2020-03-23 Thread Tom Rini
On Wed, Mar 18, 2020 at 09:42:48AM -0600, Simon Glass wrote: > At present if TEST_PY_BD is empty the script copies various files into a > directory, to no purpose. This happens because UBOOT_TRAVIS_BUILD_DIR is > set before TEST_PY_BD is tested. > > Move the 'if' to fix this. > > Signed-off-by:

Re: [PATCH v3 02/23] main: Drop show_boot_progress() prototype

2020-03-23 Thread Tom Rini
On Wed, Mar 18, 2020 at 09:42:40AM -0600, Simon Glass wrote: > This is defined in bootstage.h and is not called in this file anyway. Drop > it. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

Re: [PATCH v3 12/23] gitlab/azure: Use the -w option for sandbox_spl

2020-03-23 Thread Tom Rini
On Wed, Mar 18, 2020 at 09:42:50AM -0600, Simon Glass wrote: > Avoid needing to know about the internal .bm-work directory, by passing > the -w flag to buildman. > > This does not affect travis since the previous commit already used the -w > flag. > > Signed-off-by: Simon Glass Reviewed-by: To

Re: [PATCH v3 06/23] buildman: Allow ignoring warnings in the return code

2020-03-23 Thread Tom Rini
On Wed, Mar 18, 2020 at 09:42:44AM -0600, Simon Glass wrote: > Sometimes we don't want buildman to return failure if it seems warnings. > Add a -W option to support this. If buildman detects warnings (and no > errors) it will return an exit code of 0 (success). > > Note that the definition of 'wa

Re: [PATCH v3 11/23] travis: Split the building into two parts

2020-03-23 Thread Tom Rini
On Wed, Mar 18, 2020 at 09:42:49AM -0600, Simon Glass wrote: > Buildman is used in two ways: > > - to build a selection of boards (with no testing) > - to build a single board (and run pytest) > > The gitlab and azure scrips do this in separate places, but travis does > not. To aid the refactori

Re: [PATCH v3 13/23] travis/gitlab/azure: Use --board buildman flag with test.py

2020-03-23 Thread Tom Rini
On Wed, Mar 18, 2020 at 09:42:51AM -0600, Simon Glass wrote: > The current method of selecting the board to build with test.py is a bit > error-prone, e.g. with "^sandbox$" it actually builds 5 boards (all of > those in the sandbox architecture). > > Use the (newish) --board flag instead, to get

Re: [PATCH v3 12/23] gitlab/azure: Use the -w option for sandbox_spl

2020-03-23 Thread Tom Rini
On Wed, Mar 18, 2020 at 09:42:50AM -0600, Simon Glass wrote: > Avoid needing to know about the internal .bm-work directory, by passing > the -w flag to buildman. > > This does not affect travis since the previous commit already used the -w > flag. > > Signed-off-by: Simon Glass Reviewed-by: To

Re: [PATCH v3 15/23] travis/gitlab/azure: Drop the buildman -d flag

2020-03-23 Thread Tom Rini
On Wed, Mar 18, 2020 at 09:42:53AM -0600, Simon Glass wrote: > This has no effect since -S is not given also. Drop it. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

Re: [PATCH v3 09/23] buildman: Drop the -a option

2020-03-23 Thread Tom Rini
On Wed, Mar 18, 2020 at 09:42:47AM -0600, Simon Glass wrote: > There is no point in setting the ARCH environment variable since the > U-Boot build system no-longer uses it. > > It seems safe to drop this feature since it was only recently added. > > Signed-off-by: Simon Glass Reviewed-by: Tom

Re: [PATCH v3 16/23] gitlab/azure: Drop unnecessary if..fi when using test.py

2020-03-23 Thread Tom Rini
On Wed, Mar 18, 2020 at 09:42:54AM -0600, Simon Glass wrote: > Since TEST_PY_BD is always defined we can drop this check. > > This does not affect travis since it has a single, unified script. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signa

Re: [PATCH v3 17/23] gitlab/azure: Use -w flag for all test.py builds

2020-03-23 Thread Tom Rini
On Wed, Mar 18, 2020 at 09:42:55AM -0600, Simon Glass wrote: > Avoid needing to know about the internal .bm-work directory, by passing > the -w flag to buildman. > > This is not needed on travis since the -w flag is already used (from a > previous patch). > > Drop the -P flag since this has no e

Re: [PATCH v3 20/23] travis/gitlab/azure: Enable test_handoff

2020-03-23 Thread Tom Rini
On Wed, Mar 18, 2020 at 09:42:58AM -0600, Simon Glass wrote: > Ensure that this SPL test runs on gitlab. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

Re: [PATCH v3 19/23] travis/gitlab/azure: Use -W to avoid warnings check

2020-03-23 Thread Tom Rini
On Wed, Mar 18, 2020 at 09:42:57AM -0600, Simon Glass wrote: > We can use the -W flag to tell buildman to ignore warnings. Since we also > have -E defined, compiler warnings are promoted to errors, so they will > still cause a failure. But migration warnings of the form: > > =

Re: [PATCH v3 22/23] travis/gitlab/azure: Drop repeated buildman call with test.py

2020-03-23 Thread Tom Rini
On Wed, Mar 18, 2020 at 09:43:00AM -0600, Simon Glass wrote: > It does not seem to be necessary to run buildman again to show errors, > since any errors can be shown by the first invocation and there is only > a single board being built. Update this to simplify the code, using the > -e flag to mak

Re: [PATCH v3 14/23] travis/gitlab/azure: Drop BUILDMAN variable with test.py

2020-03-23 Thread Tom Rini
On Wed, Mar 18, 2020 at 09:42:52AM -0600, Simon Glass wrote: > This is not needed in the test.py part of the config, now since we use the > same name as the pytests. > > Drop BUILDMAN, retaining it only for the 'build' parts of the config, i.e. > where we build multiple boards and don't run any t

Re: [PATCH v3 18/23] travis/gitlab/azure: Use bash to avoid a_test_which_does_not_exist

2020-03-23 Thread Tom Rini
On Wed, Mar 18, 2020 at 09:42:56AM -0600, Simon Glass wrote: > Bash allows for variables to expand only if non-empty: > > $ var=test > $ echo ${var:+"$var"} > test > $ echo ${var:+"-k $var"} > -k test > $ var= > $ echo ${var:+"-k $var"} > > Use this feat

Re: [PATCH v3 21/23] travis/gitlab/azure: Simplify the exit code for test.py

2020-03-23 Thread Tom Rini
On Wed, Mar 18, 2020 at 09:42:59AM -0600, Simon Glass wrote: > It seems unnecessary to read the exit code and then check it again. Drop > this and just let the test.py provide the exit code directly. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP

Re: [PATCH v3 23/23] test/py: Allow using buildman to build U-Boot

2020-03-23 Thread Tom Rini
On Wed, Mar 18, 2020 at 09:43:01AM -0600, Simon Glass wrote: > It is a pain to have to set the CROSS_COMPILE environment variable when > using test.py's --build option. It is possible to get this using the -A > option from buildman. But it seems better to just use buildman to do the > build when i

Re: [RFC] Sandbox reset

2020-03-23 Thread Simon Glass
Hi Heinrich, On Mon, 23 Mar 2020 at 00:40, Heinrich Schuchardt wrote: > > Hello Simon, > > currently the reset command on the sandbox exits the program. Is there > any requirement for this behavior in our current testing landscape? For > testing the UEFI sub-system I would prefer that the reset c

Re: [PATCH 6/6] net: dwc_eth_qos: Prevent DMA from writing updated RX DMA descriptor

2020-03-23 Thread Marek Vasut
On 3/23/20 1:50 PM, Ramon Fried wrote: > On Mon, Mar 23, 2020 at 2:22 PM Marek Vasut wrote: >> >> On 3/23/20 1:19 PM, Ramon Fried wrote: >>> On Mon, Mar 23, 2020 at 2:00 PM Marek Vasut wrote: On 3/23/20 8:09 AM, Ramon Fried wrote: > On Mon, Mar 23, 2020 at 3:45 AM Marek Vasut wrote

[PATCH 1/3] firmware: zynqmp: Enable IPI code calling also in EL3

2020-03-23 Thread Michal Simek
U-Boot proper can still run in EL3 without using firmware interface wired via ATF. For supporting this use case there is a need to check EL level where U-Boot runs and based on that choose the way how to talk to firmware. Signed-off-by: Michal Simek --- drivers/firmware/firmware-zynqmp.c | 2 +-

[PATCH 0/3] arm64: zynqmp: Add support for running U-Boot in EL3 again

2020-03-23 Thread Michal Simek
Hi, in past without PMU fw it was possible to run U-Boot in EL3. Firmware changes made ATF required that's why generation was done like this. But some recent changes (especially passing PMUFW object to PMU from SPL) introduce the whole infrastructure for talking to PMU via IPI interface. That's wh

[PATCH 2/3] arm64: zynqmp: Reorder parameters for zynqmp_mmio_write()

2020-03-23 Thread Michal Simek
Parameter order is not correct based on zynqmp_mmio_write() declaration. Fixes: be52372ff1bb ("arm64: zynqmp: Use zynqmp_mmio_read/write functions") Signed-off-by: Michal Simek --- board/xilinx/zynqmp/zynqmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/xilinx/zynq

[PATCH 3/3] arm64: zynqmp: Add support for u-boot.itb generation without ATF

2020-03-23 Thread Michal Simek
If ATF doesn't exist generate u-boot.itb without it and let U-Boot run in EL3. Still keep warning to let user know that ATF/BL31 is missing. Signed-off-by: Michal Simek --- arch/arm/mach-zynqmp/mkimage_fit_atf.sh | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --gi

Re: [RFC PATCH 6/9] mkimage_fit_atf.sh: produce working binaries by default

2020-03-23 Thread Michal Simek
On 21. 03. 20 16:19, Petr Štetiar wrote: > Michal Simek [2020-03-20 11:20:17]: > >> I think instead of fixing it on several places we should merge things >> together and fix this issue there. > > What do you mean exactly? Checking for the deps one layer up, like this for > example in sunxi? > >

Re: [PATCH v1 1/8] doc: Fix typo in FIT documentation

2020-03-23 Thread Tom Rini
On Sun, Mar 22, 2020 at 02:52:59AM +0100, Marek Vasut wrote: > On 3/5/20 8:19 PM, Sean Anderson wrote: > > u_boot should be u-boot > > > > Signed-off-by: Sean Anderson > > Reviewed-by: Bin Meng > > --- > > > > doc/uImage.FIT/source_file_format.txt | 2 +- > > 1 file changed, 1 insertion(+), 1

Re: [PATCH] arm: dts: bcm283x: Allow UARTs to work before relocation

2020-03-23 Thread Tom Rini
On Sun, Mar 22, 2020 at 07:54:25PM -0600, Simon Glass wrote: > Hi Tom, > > On Thu, 2 Jan 2020 at 20:59, Tom Rini wrote: > > > > On Thu, Jan 02, 2020 at 07:28:50PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Thu, 2 Jan 2020 at 19:27, Simon Glass wrote: > > > > > > > > Hi Tom, > > > > >

[PATCH 1/3] Kconfig: add config options for automatic builds

2020-03-23 Thread Petr Štetiar
Currently its not possible to distinguish between normal builds and builds performed by the build bots/CI, thus leading to a workarounds like for example in commit 4c78028737c3 ("mksunxi_fit_atf.sh: Allow for this to complete when bl31.bin is missing"), where producing unusable binaries is preferre

[PATCH 3/3] sunxi: replace .its file generator with Dust template

2020-03-23 Thread Petr Štetiar
Replace current .its file based generator with generic Dust template based approach, including the proper .its file dependency tracking, so working images are produced by default. bl31.bin file is mandatory for functional, usable and bootable binaries, and currently missing bl31.bin is not hard er

[PATCH 0/3] sunxi: produce working binaries by default

2020-03-23 Thread Petr Štetiar
Hi, currently its not possible to distinguish between normal builds and builds performed by the build bots/CI, thus leading to a workarounds like for example in commit 4c78028737c3 ("mksunxi_fit_atf.sh: Allow for this to complete when bl31.bin is missing"), where producing unusable binaries is pre

[PATCH 2/3] tools: add Dust based .its file templating

2020-03-23 Thread Petr Štetiar
Currently boards with more complex image requirements can provide .its generator script, which lead to a bunch of similar shell scripts, thus duplication of a lot of similar code. This patch adds a posibility to use a template based approach, where one just writes .its Dust template which is then

Re: [u-boot][PATCH 2/2] spi: atmel-quadspi: Add verbose debug facilities to monitor register accesses

2020-03-23 Thread Tudor.Ambarus
On Friday, March 20, 2020 11:37:59 AM EET tudor.amba...@microchip.com wrote: > From: Tudor Ambarus > > This feature should not be enabled in release but can be useful for > developers who need to monitor register accesses at some specific places. > > Helped me identify a bug in u-boot, by compar

Re: [PATCH 0/3] sunxi: produce working binaries by default

2020-03-23 Thread Peter Robinson
Hi Petr, > currently its not possible to distinguish between normal builds and > builds performed by the build bots/CI, thus leading to a workarounds > like for example in commit 4c78028737c3 ("mksunxi_fit_atf.sh: Allow for > this to complete when bl31.bin is missing"), where producing unusable >

[PATCH] arm64: versal: Disable DDR cache mapping if DDR is not enabled

2020-03-23 Thread Michal Simek
Similar change was done in past by commit 3b644a3c2f69 ("arm64: zynqmp: Provide a config to not map DDR region in MMU table"). Signed-off-by: Michal Simek --- arch/arm/mach-versal/Kconfig | 6 ++ arch/arm/mach-versal/cpu.c | 9 + 2 files changed, 15 insertions(+) diff --git a/arc

[PATCH] arm64: xilinx: Never touch DDR if system has no DDR

2020-03-23 Thread Michal Simek
If DDR is not mapped do not touch it. Default XILINX_OF_BOARD_DTB_ADDR is pointing to DDR. Signed-off-by: Michal Simek --- Depends on https://lists.denx.de/pipermail/u-boot/2020-March/403953.html --- board/xilinx/common/board.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --

[PATCH v2] watchdog: versal: Add support for Xilinx window watchdog

2020-03-23 Thread Michal Simek
From: Ashok Reddy Soma Add support for Xilinx window watchdog, which can be found on Versal platforms. Signed-off-by: Ashok Reddy Soma Signed-off-by: Michal Simek --- Changes in v2: - Reverse subject prefixes - Convert to regmap as was asked - Rename WWDT_XILINX to WDT_XILINX MAINTAINERS

Re: [RFC] Sandbox reset

2020-03-23 Thread Heinrich Schuchardt
On 3/23/20 2:18 PM, Simon Glass wrote: > Hi Heinrich, > > On Mon, 23 Mar 2020 at 00:40, Heinrich Schuchardt wrote: >> >> Hello Simon, >> >> currently the reset command on the sandbox exits the program. Is there >> any requirement for this behavior in our current testing landscape? For >> testing t

Re: [PATCH v2 02/10] test: dm: add test item for ofnode_get_child_count()

2020-03-23 Thread Simon Glass
On Sat, 21 Mar 2020 at 02:52, Chunfeng Yun wrote: > > Add a test item for ofnode_get_child_count() > > Signed-off-by: Chunfeng Yun > --- > v2: > a new patch to test ofnode_get_child_count() suggested by Simon > --- > test/dm/ofnode.c | 21 + > 1 file changed, 21 insertion

  1   2   3   >