Re: [U-Boot] switching to single .config configuration issues

2015-04-30 Thread Yehuda Yitschak
Hey Masahiro > -Original Message- > From: Masahiro Yamada [mailto:yamada.masah...@socionext.com] > Sent: Thursday, April 30, 2015 4:46 > To: Yehuda Yitschak > Cc: Simon Glass; Hanna Hawa; u-boot@lists.denx.de > Subject: Re: [U-Boot] switching to single .config configuration issues > > Hi

Re: [U-Boot] [PATCH] ARM: cache-cp15: Make sure EAE is not enabled

2015-04-30 Thread Sjoerd Simons
+Albert, +Marek, On Tue, 2015-04-28 at 14:21 +0200, Tomeu Vizoso wrote: > This could happen if we are being chainloaded by Coreboot with LPAE > enabled, as is the case on the Tegra-based Chromebooks. > > Signed-off-by: Tomeu Vizoso >From the documentation of recent ARM cores it looks like 0 is

Re: [U-Boot] [PATCH v2 1/2] linux/bitops.h: Add BIT macro

2015-04-30 Thread Masahiro Yamada
Hi. 2015-04-29 21:05 GMT+09:00 Jagannadha Sutradharudu Teki : > Replace (1 << nr) to BIT(nr) where nr = 0, 1, 2 31 I assume this patch was generated by a simple sed script or something. I am opposed to do this globally by script. See below. > diff --git a/arch/arm/mach-uniphier/inclu

Re: [U-Boot] Add spi nand support in u-boot

2015-04-30 Thread Jagan Teki
On 30 April 2015 at 12:16, Peter Pan 潘栋 (peterpandong) wrote: > Hi All, > > > > I’d like to add spi nand support in u-boot. But I don’t know where should > > the spi nand drivers put in and how to define the architecture. > > > > I find that currently spi_flash in u-boot means spi nor flash. Shoul

[U-Boot] [PATCH] ARM: at91: trival: fix typo for the nand partition name

2015-04-30 Thread Josh Wu
We should use 'env' to present environment instead of 'evn' Signed-off-by: Josh Wu --- include/configs/at91-sama5_common.h | 2 +- include/configs/at91sam9rlek.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/configs/at91-sama5_common.h b/include/configs/at

[U-Boot] [PATCH] x86: Remove DECLARE_GLOBAL_DATA_PTR in board files

2015-04-30 Thread Bin Meng
gd is not referenced in those board files so DECLARE_GLOBAL_DATA_PTR should be removed. Signed-off-by: Bin Meng --- board/intel/crownbay/crownbay.c | 2 -- board/intel/galileo/galileo.c | 2 -- board/intel/minnowmax/minnowmax.c | 2 -- 3 files changed, 6 deletions(-) diff --git a/board/i

[U-Boot] loading environment from SATA

2015-04-30 Thread Ben Hewson
booting from SATA works very well on my iMX6 based board, however if I do #define CONFIG_ENV_IS_IN_FAT #if defined(CONFIG_ENV_IS_IN_FAT) #define CONFIG_FAT_WRITE #define FAT_ENV_INTERFACE "sata" #define FAT_ENV_DEVICE_AND_PART "0:1" #define FAT_ENV_FILE

[U-Boot] Query on weak function for board specific initialisation

2015-04-30 Thread maitysanchayan
Hello, I am trying to use a weak function in able to provide a board specific initialisation. To be more specific, I am trying to use the __weak board_ehci_hcd_init function in the usb driver code which is called in ehci_hcd_init, the strong function being defined in the board file. This is on lin

Re: [U-Boot] [PATCH v2 1/2] linux/bitops.h: Add BIT macro

2015-04-30 Thread Tom Rini
On Wed, Apr 29, 2015 at 06:33:41PM -0600, Simon Glass wrote: > Hi Jagan, > > On 29 April 2015 at 08:58, Jagan Teki wrote: > > Hi Simon, > > > > On 29 April 2015 at 20:12, Simon Glass wrote: > >> Hi Tom, > >> > >> On 29 April 2015 at 07:08, Tom Rini wrote: > >>> On Wed, Apr 29, 2015 at 05:35:05P

[U-Boot] [PATCH 2/8] dm: usb: Use controller_dev in dm ehci code

2015-04-30 Thread Hans de Goede
Use the controller_dev pointer in the ehci hcd code rather then going up the tree till we find the first UCLASS_USB device. Signed-off-by: Hans de Goede --- drivers/usb/host/ehci-hcd.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/usb/host/ehci-hcd.c b/drive

[U-Boot] [PATCH 0/8] usb: driver-model fixes and dm support sunxi-ehci.c

2015-04-30 Thread Hans de Goede
Hi Simon and Marek, This series completes my work on converting the sunxi usb/ehci code to the driver model. With this series everything works as it did before, and all the issues I've been seeing when switching to the driver model are resolved. Please review / merge. I think it would be best to

[U-Boot] [PATCH 6/8] dm: usb: Prefix ehci interrupt-queue functions with _ehci_

2015-04-30 Thread Hans de Goede
This is a preparation patch for adding interrupt-queue support to the ehci dm code. Signed-off-by: Hans de Goede --- drivers/usb/host/ehci-hcd.c | 31 +-- 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehc

[U-Boot] [PATCH 1/8] dm: usb: Copy over usb_device values from usb_scan_device() to final usb_device

2015-04-30 Thread Hans de Goede
Currently we copy over a number of usb_device values stored in the on stack struct usb_device probed in usb_scan_device() to the final driver-model managed struct usb_device in usb_child_pre_probe() through usb_device_platdata, and then call usb_select_config() to fill in the rest. There are 2 pro

[U-Boot] [PATCH 4/8] dm: usb: Set desc_before_addr from ehci dm code

2015-04-30 Thread Hans de Goede
Without this usb-1 device descriptors do not get read properly. Signed-off-by: Hans de Goede --- drivers/usb/host/ehci-hcd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c index 00c038c..9fc1e33 100644 --- a/drivers/usb/host/ehci-

[U-Boot] [PATCH 7/8] dm: usb: Add support for interrupt queues to the dm ehci code

2015-04-30 Thread Hans de Goede
Add support for interrupt queues to the dm ehci code. Signed-off-by: Hans de Goede --- drivers/usb/host/ehci-hcd.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c index 12145ed..9e8bacb 100644 --- a/drivers

[U-Boot] [PATCH 5/8] dm: usb: Add support for interrupt queues to the dm usb code

2015-04-30 Thread Hans de Goede
Interrupt endpoints typically are polled for a long time by the usb controller before they return anything, so calls to submit_int_msg() can take a long time to complete this. To avoid this the u-boot code has the an interrupt queue mechanism / API, add support for this to the driver-model usb cod

[U-Boot] [PATCH 8/8] sunxi: ehci: Convert to the driver-model

2015-04-30 Thread Hans de Goede
Convert sunxi-boards which use the sunxi-ehci code to the driver-model. Signed-off-by: Hans de Goede --- board/sunxi/Kconfig | 3 ++ drivers/usb/host/ehci-sunxi.c | 95 ++- 2 files changed, 69 insertions(+), 29 deletions(-) diff --git a/board/s

[U-Boot] [PATCH 3/8] dm: usb: Store usb_device parent pointer in usb_device

2015-04-30 Thread Hans de Goede
When calling into the hcd code in usb_scan_device() we do not yet have the actual udevice for the device we are scanning, so we temporarily set usb_device.dev to the parent. This means that we cannot use usb_device.dev to accurately determine our place in the usb topology when reading descriptors,

Re: [U-Boot] [PATCH 0/8] usb: driver-model fixes and dm support sunxi-ehci.c

2015-04-30 Thread Hans de Goede
Hi, On 30-04-15 16:35, Hans de Goede wrote: Hi Simon and Marek, This series completes my work on converting the sunxi usb/ehci code to the driver model. With this series everything works as it did before, and all the issues I've been seeing when switching to the driver model are resolved. Plea

Re: [U-Boot] [PATCH 0/8] usb: driver-model fixes and dm support sunxi-ehci.c

2015-04-30 Thread Simon Glass
Hi Hans, On 30 April 2015 at 08:35, Hans de Goede wrote: > Hi Simon and Marek, > > This series completes my work on converting the sunxi usb/ehci code to > the driver model. With this series everything works as it did before, > and all the issues I've been seeing when switching to the driver mode

Re: [U-Boot] loading environment from SATA

2015-04-30 Thread Tom Rini
On Thu, Apr 30, 2015 at 01:57:58PM +0100, Ben Hewson wrote: > booting from SATA works very well on my iMX6 based board, however if I do > > > #define CONFIG_ENV_IS_IN_FAT > > #if defined(CONFIG_ENV_IS_IN_FAT) > #define CONFIG_FAT_WRITE > #define FAT_ENV_INTERFACE "sata" >

Re: [U-Boot] [PATCH v2 1/2] linux/bitops.h: Add BIT macro

2015-04-30 Thread Simon Glass
Hi Tom, On 30 April 2015 at 07:30, Tom Rini wrote: > On Wed, Apr 29, 2015 at 06:33:41PM -0600, Simon Glass wrote: >> Hi Jagan, >> >> On 29 April 2015 at 08:58, Jagan Teki wrote: >> > Hi Simon, >> > >> > On 29 April 2015 at 20:12, Simon Glass wrote: >> >> Hi Tom, >> >> >> >> On 29 April 2015 at

Re: [U-Boot] [PATCH] x86: Remove DECLARE_GLOBAL_DATA_PTR in board files

2015-04-30 Thread Simon Glass
On 30 April 2015 at 05:05, Bin Meng wrote: > gd is not referenced in those board files so DECLARE_GLOBAL_DATA_PTR > should be removed. > > Signed-off-by: Bin Meng > --- > > board/intel/crownbay/crownbay.c | 2 -- > board/intel/galileo/galileo.c | 2 -- > board/intel/minnowmax/minnowmax.c |

Re: [U-Boot] [PATCH v3 0/5] x86: Add CPU uclass and multi-core support for Minnowboard MAX

2015-04-30 Thread Simon Glass
Hi Bin, On 30 April 2015 at 00:16, Bin Meng wrote: > Hi Simon, > > On Thu, Apr 30, 2015 at 1:11 PM, Simon Glass wrote: >> Hi Bin, >> >> On 29 Apr 2015 10:26 pm, "Simon Glass" wrote: >>> >>> This series adds a new CPU uclass which is intended to be useful on any >>> architecture. So far it has a

Re: [U-Boot] Upgrading U-Boot stops Linux booting.

2015-04-30 Thread Simon Glass
Hi Ben, On 30 April 2015 at 00:27, Ben Hewson wrote: > Hi Simon, > > Thanks for the suggestion. > I actually sorted it out late yesterday. A stupid error I suppose, but one > that I completely over looked. > > I turned on CONFIG_DEBUG_LL in the kernel, tried again and it complained about > the ma

Re: [U-Boot] [PATCH 0/8] usb: driver-model fixes and dm support sunxi-ehci.c

2015-04-30 Thread Hans de Goede
Hi, On 30-04-15 16:48, Simon Glass wrote: Hi Hans, On 30 April 2015 at 08:35, Hans de Goede wrote: Hi Simon and Marek, This series completes my work on converting the sunxi usb/ehci code to the driver model. With this series everything works as it did before, and all the issues I've been see

[U-Boot] [PATCH v2] sandbox: Don't try distro_bootcmd by default

2015-04-30 Thread Sjoerd Simons
For the distro_bootcmds to succeed on the sandbox a bit of setup is required (e.g. network configured or host image bound), so running them by default isn't that useful. Add a -b/--boot command to the sandbox binary, which triggers the distro_bootcmds to run after the other command-line commands.

Re: [U-Boot] [PATCH 1/4] mx6cuboxi: Add HDMI output support

2015-04-30 Thread Vagrant Cascadian
On 2015-04-29, Fabio Estevam wrote: > On Wed, Apr 29, 2015 at 5:02 PM, Vagrant Cascadian > wrote: > >> I wasn't able to test this as the HDMI TV I'm using doesn't support this >> resolution (it is admittedly ~9 years old, the closest resolution it >> does support is 1280x720@60). How complicated

Re: [U-Boot] [PATCH v2 2/4] mx6cuboxi: Add USB host support

2015-04-30 Thread Vagrant Cascadian
On 2015-04-29, Fabio Estevam wrote: > Enable USB Host1 port. > > Signed-off-by: Rabeeh Khoury > Signed-off-by: Fabio Estevam > --- > Changes since v1: > - Remove USB ether options as suggested by Tom Removing those options broke network boot. With this patch, u-boot reports: Net: Phy 0 not

Re: [U-Boot] [PATCH 1/4] mx6cuboxi: Add HDMI output support

2015-04-30 Thread Fabio Estevam
On Thu, Apr 30, 2015 at 6:20 PM, Vagrant Cascadian wrote: > No luck. The TV does support 640x480 when plugged into my laptop, > > I did manage to verify with a display that supported 1024x768 and that > worked fine. Thanks for testing. Could you send us your Tested-by tag? Regards, Fabio Este

Re: [U-Boot] [PATCH v2 3/4] mx6cuboxi: Allow HDMI and USB keyboard to be stdout/stdin

2015-04-30 Thread Vagrant Cascadian
On 2015-04-29, Fabio Estevam wrote: > From: Fabio Estevam > > There are users of Cuboxi and Hummingboard that use these boards without > connecting them to a USB/serial adapter. > > Allow such usage by allowing the HDMI port to act as stdout and USB keyboard > as stdin. > > The serial console stil

Re: [U-Boot] [PATCH v2 1/4] mx6cuboxi: Add HDMI output support

2015-04-30 Thread Vagrant Cascadian
On 2015-04-29, Fabio Estevam wrote: > From: Fabio Estevam > > Add HDMI output using PLL5 as the source for the IPU clocks, > and accurate VESA timings. > > These settings are based on the patch from Soeren Moch > submitted for the tbs2910 mx6 based board. > > It allows the display to work properl

Re: [U-Boot] [PATCH v2 2/4] mx6cuboxi: Add USB host support

2015-04-30 Thread Fabio Estevam
On Thu, Apr 30, 2015 at 6:26 PM, Vagrant Cascadian wrote: > Removing those options broke network boot. With this patch, u-boot > reports: > > Net: Phy 0 not found > > And the dhcp command fails to get an ip address. > > With both CONFIG_USB_HOST_ETHER and CONFIG_USB_ETHER_ASIX defined in > m

Re: [U-Boot] [PATCH 0/8] usb: driver-model fixes and dm support sunxi-ehci.c

2015-04-30 Thread Simon Glass
Hi Hans, On 30 April 2015 at 13:38, Hans de Goede wrote: > Hi, > > > On 30-04-15 16:48, Simon Glass wrote: >> >> Hi Hans, >> >> On 30 April 2015 at 08:35, Hans de Goede wrote: >>> >>> Hi Simon and Marek, >>> >>> This series completes my work on converting the sunxi usb/ehci code to >>> the drive

Re: [U-Boot] [PATCH v2] sandbox: Don't try distro_bootcmd by default

2015-04-30 Thread Simon Glass
On 30 April 2015 at 14:16, Sjoerd Simons wrote: > For the distro_bootcmds to succeed on the sandbox a bit of setup is > required (e.g. network configured or host image bound), so running them > by default isn't that useful. > > Add a -b/--boot command to the sandbox binary, which triggers the > di

[U-Boot] Sandbox dm tests leave sandbox in a bad state

2015-04-30 Thread Joe Hershberger
Hi Simon, I tracked a segfault down to the entire DM being left torn down after the last test. This means anything that wants to use the DM is hosed. I'm seeing a segfault in the sandbox related to a driver name being NULL when running "dm tree". I also noticed that the USB test dm_test_usb_flash

Re: [U-Boot] Sandbox dm tests leave sandbox in a bad state

2015-04-30 Thread Simon Glass
Hi Joe, On 30 April 2015 at 16:08, Joe Hershberger wrote: > Hi Simon, > > I tracked a segfault down to the entire DM being left torn down after > the last test. This means anything that wants to use the DM is hosed. > I'm seeing a segfault in the sandbox related to a driver name being > NULL when

Re: [U-Boot] [PATCH v2 2/4] mx6cuboxi: Add USB host support

2015-04-30 Thread Vagrant Cascadian
On 2015-04-30, Fabio Estevam wrote: > On Thu, Apr 30, 2015 at 6:26 PM, Vagrant Cascadian > wrote: > >> Removing those options broke network boot. With this patch, u-boot >> reports: >> >> Net: Phy 0 not found >> >> And the dhcp command fails to get an ip address. >> >> With both CONFIG_USB_H

Re: [U-Boot] [PATCH v2 2/4] mx6cuboxi: Add USB host support

2015-04-30 Thread Vagrant Cascadian
On 2015-04-29, Fabio Estevam wrote: > From: Fabio Estevam > > Enable USB Host1 port. > > Signed-off-by: Rabeeh Khoury > Signed-off-by: Fabio Estevam > --- > Changes since v1: > - Remove USB ether options as suggested by Tom USB keyboard, USB hub and two USB sticks all worked. Tested-By: Vagran

Re: [U-Boot] [PATCH v2 2/4] mx6cuboxi: Add USB host support

2015-04-30 Thread Vagrant Cascadian
So network works fine on the hummingboard i1 and i2ex, but the cubox i4pro is still inconsistant: Net: Phy 0 not found PHY reset timed out FEC It definitely worked at some point before. I used the same SD card on all three boards. live well, vagrant signature.asc Description: PGP sig

Re: [U-Boot] [PATCH v3 3/5] x86: Allow CPUs to be set up after relocation

2015-04-30 Thread Simon Glass
On 30 April 2015 at 00:14, Bin Meng wrote: > On Thu, Apr 30, 2015 at 12:26 PM, Simon Glass wrote: >> This permits init of additional CPU cores after relocation and when driver >> model is ready. >> >> Signed-off-by: Simon Glass >> --- >> >> Changes in v3: None >> Changes in v2: >> - Correct 'I2C

Re: [U-Boot] [PATCH v3 2/5] x86: Add functions to set and clear bits on MSRs

2015-04-30 Thread Simon Glass
On 30 April 2015 at 00:11, Bin Meng wrote: > On Thu, Apr 30, 2015 at 12:26 PM, Simon Glass wrote: >> Since we do these sorts of operations a lot, it is useful to have a simpler >> API, similar to clrsetbits_le32(). >> >> Signed-off-by: Simon Glass >> --- >> >> Changes in v3: >> - Add msr_clrbits

Re: [U-Boot] [PATCH v3 4/5] x86: Add a CPU driver for baytrail

2015-04-30 Thread Simon Glass
On 30 April 2015 at 00:26, Bin Meng wrote: > On Thu, Apr 30, 2015 at 12:26 PM, Simon Glass wrote: >> This driver supports multi-core init and sets up the CPU frequencies >> correctly. >> >> Signed-off-by: Simon Glass >> --- >> >> Changes in v3: >> - Collect all new MSRs into msr-index.h >> - Spe

Re: [U-Boot] [PATCH v3 5/5] x86: Enable multi-core init for Minnowboard MAX

2015-04-30 Thread Simon Glass
On 29 April 2015 at 22:26, Simon Glass wrote: > Enable the CPU uclass and Simple Firmware interface for Minnowbaord MAX. This > enables multi-core support in Linux. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng Applied to u-boot-x86. > --- > > Changes in v3: None > Changes in v2: None

Re: [U-Boot] [PATCH v3 1/5] x86: Add multi-processor init

2015-04-30 Thread Simon Glass
On 30 April 2015 at 00:09, Bin Meng wrote: > On Thu, Apr 30, 2015 at 12:25 PM, Simon Glass wrote: >> Most modern x86 CPUs include more than one CPU core. The OS normally requires >> that these 'Application Processors' (APs) be brought up by the boot loader. >> Add the required support to U-Boot t

Re: [U-Boot] [PATCH] dm: usb: Fix divide by 0 errors in host drivers caused by not setting maxpsize

2015-04-30 Thread Simon Glass
On 29 April 2015 at 03:40, Hans de Goede wrote: > usb_child_pre_probe() initializes the final struct usb_device by redoingthe > usb_select_config() done by usb_scan_device() but not the usb_prepare_device() > call, this leads to a call into the hcd to get the device descriptors without > ep0's max

Re: [U-Boot] [PATCH] dm: core: Fix regression caused by c1d6f91

2015-04-30 Thread Simon Glass
Hi Joe, On 29 April 2015 at 10:17, Joe Hershberger wrote: > Hi Simon, > > On Wed, Apr 29, 2015 at 8:30 AM, Simon Glass wrote: >> Hi Joe, >> >> On 28 April 2015 at 22:14, Joe Hershberger wrote: >>> The change to refactor these functions created a regression. >>> >>> commit c1d6f91952d0761f61b0f0

Re: [U-Boot] [PATCH v1 1/2] cmd_sf: Add command "sf info" to show current device info

2015-04-30 Thread Simon Glass
Hi, On 29 April 2015 at 04:40, Haikun Wang wrote: > Add command "sf info" to show the information of the current SPI flash device. > > Signed-off-by: Haikun Wang > --- > In current sf driver, we show the debug information during the flash probe > period. > > In case of without DM SPI, we need to

Re: [U-Boot] [PATCH v1 2/2] dm: sf: Update default name of spi flash in structure udevice

2015-04-30 Thread Simon Glass
Hi, On 29 April 2015 at 04:42, Haikun Wang wrote: > Default name of spi flash like this "0:0", update it to "spi_flash@0:0". > > Signed-off-by: Haikun Wang > --- > drivers/mtd/spi/sf-uclass.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/spi/sf-uclass.c b

Re: [U-Boot] [PATCH v2 2/4] mx6cuboxi: Add USB host support

2015-04-30 Thread Fabio Estevam
Hi Vagrant, On Thu, Apr 30, 2015 at 8:50 PM, Vagrant Cascadian wrote: > So network works fine on the hummingboard i1 and i2ex, but the cubox > i4pro is still inconsistant: > > Net: Phy 0 not found > PHY reset timed out > FEC When you see this error: does U-boot warn you about the MAC add

Re: [U-Boot] [PATCH v2 13/19] test: dm: Don't bail on all tests if one test fails

2015-04-30 Thread Simon Glass
On 28 April 2015 at 23:51, Joe Hershberger wrote: > There's not much point in having a failure count if we always give up on > the first failure. Also stop clearing the entire state between tests. > > Make sure that any failures are still passed out to the command line. > > Signed-off-by: Joe Hers

Re: [U-Boot] [PATCH v2 16/19] test: env: Add test for verifying env attrs

2015-04-30 Thread Simon Glass
Hi Joe, On 28 April 2015 at 23:51, Joe Hershberger wrote: > Add a test of the env_attr_lookup() function. > > Signed-off-by: Joe Hershberger > --- > > Changes in v2: > -New for version 2 > > test/env/Makefile | 1 + > test/env/attr.c | 62 > ++

Re: [U-Boot] [PATCH v2 14/19] test: Return values from the asserts compatible with cmds

2015-04-30 Thread Simon Glass
On 28 April 2015 at 23:51, Joe Hershberger wrote: > The asserts are sometimes called from the context of the test command > itself so make sure that a return that happens as a result of a failure > is compatible with that command return. When called within a test, the > return value is ignored. >

Re: [U-Boot] [PATCH v2 15/19] test: env: Add test framework for env

2015-04-30 Thread Simon Glass
On 28 April 2015 at 23:51, Joe Hershberger wrote: > Add a new "test" subcommand to the env command. > > This will run unit tests on the env code. This should be targetable to > any device that supports the env features needed for the tests. > > Signed-off-by: Joe Hershberger > --- > > Changes in

Re: [U-Boot] [PATCH v2 17/19] test: env: Add a test of the new regex behavior for attrs

2015-04-30 Thread Simon Glass
On 28 April 2015 at 23:51, Joe Hershberger wrote: > The behavior of the env attrs depends on CONFIG_REGEX. Add an additional > test if that variable is set. > > Signed-off-by: Joe Hershberger > --- > > Changes in v2: > -New for version 2 > > test/env/attr.c | 27 +++ > 1

Re: [U-Boot] [PATCH v2 12/19] test: Generalize the unit test framework

2015-04-30 Thread Simon Glass
On 28 April 2015 at 23:50, Joe Hershberger wrote: > Separate the ability to define tests and assert status of test functions > from the dm tests so they can be used more consistenly throughout all > tests. > > Signed-off-by: Joe Hershberger > --- > > Changes in v2: > -New for version 2 > > inclu

Re: [U-Boot] [PATCH v2 19/19] sandbox: Enable env unit tests

2015-04-30 Thread Simon Glass
On 28 April 2015 at 23:51, Joe Hershberger wrote: > Enable the new env unit tests on sandbox. > > Signed-off-by: Joe Hershberger > --- > > Changes in v2: > -New for version 2 > > configs/sandbox_defconfig | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Simon Glass > > diff --git a/config

Re: [U-Boot] [PATCH v2 18/19] sandbox: Cleanup order and extra defines in defconfig

2015-04-30 Thread Simon Glass
On 28 April 2015 at 23:51, Joe Hershberger wrote: > The defconfigs should not be edited directly. They should be generated > by editing the .config (through menuconfig or whatever) and then run > make savedefconfig to have the Kconfig system generate a clean defconfig > > I did this for sandbox he

Re: [U-Boot] [PATCH 3/8] dm: usb: Store usb_device parent pointer in usb_device

2015-04-30 Thread Simon Glass
Hi Hans, On 30 April 2015 at 08:35, Hans de Goede wrote: > When calling into the hcd code in usb_scan_device() we do not yet have > the actual udevice for the device we are scanning, so we temporarily set > usb_device.dev to the parent. > > This means that we cannot use usb_device.dev to accurate

Re: [U-Boot] [PATCH 2/8] dm: usb: Use controller_dev in dm ehci code

2015-04-30 Thread Simon Glass
Hi Hans, On 30 April 2015 at 08:35, Hans de Goede wrote: > Use the controller_dev pointer in the ehci hcd code rather then going up > the tree till we find the first UCLASS_USB device. > > Signed-off-by: Hans de Goede > --- > drivers/usb/host/ehci-hcd.c | 9 + > 1 file changed, 1 insert

Re: [U-Boot] [PATCH 4/8] dm: usb: Set desc_before_addr from ehci dm code

2015-04-30 Thread Simon Glass
On 30 April 2015 at 08:35, Hans de Goede wrote: > Without this usb-1 device descriptors do not get read properly. > > Signed-off-by: Hans de Goede > --- > drivers/usb/host/ehci-hcd.c | 3 +++ > 1 file changed, 3 insertions(+) Acked-by: Simon Glass > > diff --git a/drivers/usb/host/ehci-hcd.c

Re: [U-Boot] [PATCH 1/8] dm: usb: Copy over usb_device values from usb_scan_device() to final usb_device

2015-04-30 Thread Simon Glass
Hi Hans, On 30 April 2015 at 08:35, Hans de Goede wrote: > Currently we copy over a number of usb_device values stored in the on stack > struct usb_device probed in usb_scan_device() to the final driver-model > managed > struct usb_device in usb_child_pre_probe() through usb_device_platdata, and

Re: [U-Boot] [PATCH 6/8] dm: usb: Prefix ehci interrupt-queue functions with _ehci_

2015-04-30 Thread Simon Glass
On 30 April 2015 at 08:35, Hans de Goede wrote: > This is a preparation patch for adding interrupt-queue support to the > ehci dm code. > > Signed-off-by: Hans de Goede > --- > drivers/usb/host/ehci-hcd.c | 31 +-- > 1 file changed, 25 insertions(+), 6 deletions(-) A

Re: [U-Boot] [PATCH 8/8] sunxi: ehci: Convert to the driver-model

2015-04-30 Thread Simon Glass
Hi Hans, On 30 April 2015 at 08:35, Hans de Goede wrote: > Convert sunxi-boards which use the sunxi-ehci code to the driver-model. > > Signed-off-by: Hans de Goede > --- > board/sunxi/Kconfig | 3 ++ > drivers/usb/host/ehci-sunxi.c | 95 > ++-

Re: [U-Boot] [PATCH 7/8] dm: usb: Add support for interrupt queues to the dm ehci code

2015-04-30 Thread Simon Glass
On 30 April 2015 at 08:35, Hans de Goede wrote: > Add support for interrupt queues to the dm ehci code. > > Signed-off-by: Hans de Goede > --- > drivers/usb/host/ehci-hcd.c | 26 ++ > 1 file changed, 26 insertions(+) Acked-by: Simon Glass ___

Re: [U-Boot] [PATCH 5/8] dm: usb: Add support for interrupt queues to the dm usb code

2015-04-30 Thread Simon Glass
On 30 April 2015 at 08:35, Hans de Goede wrote: > Interrupt endpoints typically are polled for a long time by the usb > controller before they return anything, so calls to submit_int_msg() can > take a long time to complete this. > > To avoid this the u-boot code has the an interrupt queue mechani

Re: [U-Boot] [PATCH v2 2/4] mx6cuboxi: Add USB host support

2015-04-30 Thread Vagrant Cascadian
>> FEC > > When you see this error: does U-boot warn you about the MAC address > stored in the environment does not match the one read by the fuses? No such warning. Rather than keep you guessing, here's the output on boot: U-Boot 2015.04+dfsg1-2~20150430~5 (Apr 30 2015 -