[U-Boot] FDT: Question about embedded fdt enable

2012-05-23 Thread Donghwa Lee
Dear, Simon Glass I am preparing device tree in Exynos SoC and had already tested by using CONFIG_OF_SEPARATE. But, I couldn't test by using CONFIG_OF_EMBED because it has a compiler problem to make a binary in the dts/Makefile. When I had used configuration as seaboard that I had changed config

Re: [U-Boot] [PATCH 2/2] zfs: Add ZFS filesystem support

2012-05-23 Thread Wolfgang Denk
Dear Jorgen Lundman, In message <4fbc5578.5000...@lundman.net> you wrote: > > I didn't even notice it was sorted. Of course this leave the issue of: > > COBJS-$(CONFIG_YAFFS2) += cmd_yaffs2.o > COBJS-$(CONFIG_CMD_ZFS) += cmd_zfs.o > COBJS-$(CONFIG_CMD_SPL) += cmd_spl.o > > Not sure if I was sup

Re: [U-Boot] [PATCH v2 0/2] zfs: Add filesystem ZFS support

2012-05-23 Thread Wolfgang Denk
Dear Jorgen Lundman, In message <1337744719-27487-1-git-send-email-lund...@lundman.net> you wrote: > ZFS filesystem support from GRUB. Adding 'zfsload' and 'zfsls' commands > for filesystem access. ZFS pool notation syntax is in the format > '/POOLNAME/@/directory/directory/file', also explained i

Re: [U-Boot] [PATCH v2 1/2] ZFS header files

2012-05-23 Thread Wolfgang Denk
Dear Jorgen Lundman, In message <1337744719-27487-2-git-send-email-lund...@lundman.net> you wrote: > Signed-off-by: Jorgen Lundman > --- Please provide a useful commit message. Also, this being a V2 patch, you are supposed to provide a history of changes. Please see http://www.denx.de/wiki/view

Re: [U-Boot] Nand flash R/W,saveenv issue..

2012-05-23 Thread Wolfgang Denk
Dear Manukumar, In message <1337752596.2378.37.camel@Manukumar> you wrote: > > u-boot version: u-boot-2010.12 This is ancient code. Please update and use current code, then try again. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 16

Re: [U-Boot] [PATCH v2 1/2] ZFS header files

2012-05-23 Thread Jorgen Lundman
In message<1337744719-27487-2-git-send-email-lund...@lundman.net> you wrote: Signed-off-by: Jorgen Lundman --- Please provide a useful commit message. Graeme has been schooling me on this and I believe I know what to do in V3. He also recommend I wait a day or so, so that others can't have

Re: [U-Boot] Nand flash R/W,saveenv issue..

2012-05-23 Thread Manukumar
Hello, when we get rference board(P1020RDB) we got the u-boot-2010.12 source. by using above source we have modified according to custom boards requirement. can you please provide the link to get updated u-boot source that support P1012 with nand flash samsung(K95608U0D) or please provide me the

Re: [U-Boot] [PATCH 2/2] exynos: smdk5250: Enable the pinmux setup

2012-05-23 Thread Rajeshwari Birje
Hi Chander, Thank you for comments On Wed, May 23, 2012 at 11:35 AM, Chander Kashyap wrote: > Hi, > > On 4 May 2012 12:26, Rajeshwari Shinde wrote: >> Use the pinmux configuration function for SMDK5250. >> >> Signed-off-by: Abhilash Kesavan >> Signed-off-by: Rajeshwari Shinde >> --- >>  arch/

[U-Boot] [PATCH 1/2 V2] EXYNOS5: PINMUX: Added default pinumx settings

2012-05-23 Thread Rajeshwari Shinde
This patch performs the pinmux configuration in a common file. As of now only EXYNOS5 pinmux for SDMMC, UART and Ethernet is supported. Signed-off-by: Abhilash Kesavan Signed-off-by: Che-Liang Chiou Signed-off-by: Rajeshwari Shinde --- changes in V2: - Adding pinmux.c to Makefile moved

[U-Boot] [PATCH 2/2 V2] EXYNOS: SMDK5250: Enable the pinmux setup

2012-05-23 Thread Rajeshwari Shinde
Use the pinmux configuration function for SMDK5250. Signed-off-by: Abhilash Kesavan Signed-off-by: Rajeshwari Shinde --- changes in V2: - Removed exynos5_gpio_part1 *gpio1 global variable as initialised in pinmux.c board/samsung/smdk5250/smdk5250.c | 163 ++-

[U-Boot] [PATCH 1/2 V2] PMIC: MAX77686: Add support for MAX77686

2012-05-23 Thread Rajeshwari Shinde
This patch adds driver and register definitions for PMIC chip MAX77686. Signed-off-by: Rajeshwari Shinde --- changes for V2: - using the generic PMIC framework instead of writing separate driver. drivers/misc/Makefile|1 + drivers/misc/pmic_max77686.c | 42 +++ incl

[U-Boot] [PATCH 2/2 V2] PMIC: SMDK5250: Enable MAX77686 pmic chip

2012-05-23 Thread Rajeshwari Shinde
This patch enables MAX77686 pmic chip for SMDK5250. Signed-off-by: Rajeshwari Shinde --- This patch is based on: "EXYNOS: SMDK5250: Enable the pinmux setup" and "CONFIG: SMDK5250: I2C: Enable I2C" board/samsung/smdk5250/smdk5250.c |4 include/configs/smdk5250.h|

Re: [U-Boot] [PATCH 1/2 V2] PMIC: MAX77686: Add support for MAX77686

2012-05-23 Thread Rajeshwari Birje
ccing Lukasz Majewski. On Wed, May 23, 2012 at 2:27 PM, Rajeshwari Shinde wrote: > This patch adds driver and register definitions for PMIC chip > MAX77686. > > Signed-off-by: Rajeshwari Shinde > --- > changes for V2: >        - using the generic PMIC framework instead of writing separate driver

Re: [U-Boot] [PATCH 2/2 V2] PMIC: SMDK5250: Enable MAX77686 pmic chip

2012-05-23 Thread Rajeshwari Birje
ccing Lukasz Majewski. On Wed, May 23, 2012 at 2:27 PM, Rajeshwari Shinde wrote: > This patch enables MAX77686 pmic chip for SMDK5250. > > Signed-off-by: Rajeshwari Shinde > --- > This patch is based on: >        "EXYNOS: SMDK5250: Enable the pinmux setup" and >        "CONFIG: SMDK5250: I2C: En

Re: [U-Boot] [PATCH 1/3] MX28: Add u-boot.mx28.sd and u-boot.mx28.nand make targets

2012-05-23 Thread Wolfgang Denk
Dear Marek Vasut, In message <1337729574-30475-1-git-send-email-ma...@denx.de> you wrote: > These targets allow for easy invocation of mxstool, for generating > the u-boot images bootable in mx28 CPU. Thanks. > +$(obj)u-boot.mx28.sd: $(obj)u-boot.sb > + $(obj)tools/mxsboot sd $(obj)

Re: [U-Boot] [PATCH 1/3] MX28: Add u-boot.mx28.sd and u-boot.mx28.nand make targets

2012-05-23 Thread Marek Vasut
Dear Wolfgang Denk, > Dear Marek Vasut, > > In message <1337729574-30475-1-git-send-email-ma...@denx.de> you wrote: > > These targets allow for easy invocation of mxstool, for generating > > the u-boot images bootable in mx28 CPU. > > Thanks. > > > +$(obj)u-boot.mx28.sd: $(obj)u-boot.sb > > +

Re: [U-Boot] [PATCH 1/2 V2] EXYNOS5: PINMUX: Added default pinumx settings

2012-05-23 Thread Chander Kashyap
Dear Rajeshwari, On 23 May 2012 14:24, Rajeshwari Shinde wrote: > This patch performs the pinmux configuration in a common file. > As of now only EXYNOS5 pinmux for SDMMC, UART and Ethernet is > supported. > > Signed-off-by: Abhilash Kesavan > Signed-off-by: Che-Liang Chiou > Signed-off-by: Raj

Re: [U-Boot] [PATCH 2/2 V2] EXYNOS: SMDK5250: Enable the pinmux setup

2012-05-23 Thread Chander Kashyap
Dear Rajeshwari, On 23 May 2012 14:24, Rajeshwari Shinde wrote: > Use the pinmux configuration function for SMDK5250. > > Signed-off-by: Abhilash Kesavan > Signed-off-by: Rajeshwari Shinde > --- > changes in V2: >- Removed exynos5_gpio_part1 *gpio1 global variable as initialised in >

Re: [U-Boot] [PATCH 1/3] MX28: Add u-boot.mx28.sd and u-boot.mx28.nand make targets

2012-05-23 Thread Marek Vasut
Dear Wolfgang Denk, > > Dear Marek Vasut, > > > > In message <1337729574-30475-1-git-send-email-ma...@denx.de> you wrote: > > > These targets allow for easy invocation of mxstool, for generating > > > the u-boot images bootable in mx28 CPU. > > > > Thanks. > > > > > +$(obj)u-boot.mx28.sd: $(ob

[U-Boot] Missing mtd device

2012-05-23 Thread Michael Moller
Hi u-booters I'm at my wit's end. I really hope you can help. I have tried updating the u-boot on a Davinci DM365 based board using various versions of u-boot, including the latest from the git repository. After setting CROSS_COMPILE and configuring with "make davinci_dm365evm_config", everythi

Re: [U-Boot] [PATCH 3/3] M28: Disable USB power on boot

2012-05-23 Thread Wolfgang Denk
Dear Marek Vasut, In message <1337729574-30475-3-git-send-email-ma...@denx.de> you wrote: > This is a precaution to prevent some USB flash drives > from misbehaving in early boot stage. Tested on M28EVK; sorry, but this commit doesn't change behaviour: the LED on the stick is still blinking after

Re: [U-Boot] [PATCH 1/3] MX28: Add u-boot.mx28.sd and u-boot.mx28.nand make targets

2012-05-23 Thread Wolfgang Denk
Dear Marek Vasut, In message <201205231127.51935.ma...@denx.de> you wrote: > > Because there'd then be no way to tell apart u-boot.bin.sd for another target > but mx28. So what? We also use "u-boot.bin" for all targets. What's the difference? > > Would it not be useful to automatically build

Re: [U-Boot] [PATCH 1/3] MX28: Add u-boot.mx28.sd and u-boot.mx28.nand make targets

2012-05-23 Thread Wolfgang Denk
Dear Marek Vasut, In message <201205231144.04272.ma...@denx.de> you wrote: > > > Because there'd then be no way to tell apart u-boot.bin.sd for another > > target but mx28. > > Maybe add some switch statement based on CONFIG_MX28 or another within the > target? I can't parse this sentence - an

Re: [U-Boot] Missing mtd device

2012-05-23 Thread Wolfgang Denk
Dear Michael Moller, In message <1337767068.7635.38.camel@mmoller-desktop> you wrote: > > Everything boots up fine, except for access to the /dev/mtd? devices. > Also /proc/mtd exists but is empty of devices - it should show the > partitions of the flash chip. Further investigation reveals that t

Re: [U-Boot] [PATCH 1/3] MX28: Add u-boot.mx28.sd and u-boot.mx28.nand make targets

2012-05-23 Thread Marek Vasut
Dear Wolfgang Denk, > Dear Marek Vasut, > > In message <201205231144.04272.ma...@denx.de> you wrote: > > > Because there'd then be no way to tell apart u-boot.bin.sd for another > > > target but mx28. > > > > Maybe add some switch statement based on CONFIG_MX28 or another within > > the target?

Re: [U-Boot] [PATCH 1/3] MX28: Add u-boot.mx28.sd and u-boot.mx28.nand make targets

2012-05-23 Thread Wolfgang Denk
Dear Marek Vasut, In message <201205231334.53948.ma...@denx.de> you wrote: > > > > Maybe add some switch statement based on CONFIG_MX28 or another within > > > the target? > > > > I can't parse this sentence - and I don't understand why you think > > any specific name would be needed or useful.

Re: [U-Boot] [PATCH 3/3] M28: Disable USB power on boot

2012-05-23 Thread Marek Vasut
Dear Wolfgang Denk, > Dear Marek Vasut, > > In message <1337729574-30475-3-git-send-email-ma...@denx.de> you wrote: > > This is a precaution to prevent some USB flash drives > > from misbehaving in early boot stage. > > Tested on M28EVK; sorry, but this commit doesn't change behaviour: > the LED

Re: [U-Boot] Missing mtd device

2012-05-23 Thread Gary Thomas
On 2012-05-23 03:57, Michael Moller wrote: Hi u-booters I'm at my wit's end. I really hope you can help. I have tried updating the u-boot on a Davinci DM365 based board using various versions of u-boot, including the latest from the git repository. After setting CROSS_COMPILE and configuring

Re: [U-Boot] [PATCH] tegra: paz00: add device tree support

2012-05-23 Thread Marc Dietrich
Am Dienstag, 22. Mai 2012, 16:30:29 schrieb Stephen Warren: > On 05/22/2012 03:15 PM, Marc Dietrich wrote: > > On Tuesday 22 May 2012 10:58:37 Stephen Warren wrote: > >> On 05/22/2012 10:14 AM, Stephen Warren wrote: > >>> On 05/22/2012 02:04 AM, Marc Dietrich wrote: > Hi Stephen, > > >>>

Re: [U-Boot] [PATCH 1/3] MX28: Add u-boot.mx28.sd and u-boot.mx28.nand make targets

2012-05-23 Thread Marek Vasut
Dear Wolfgang Denk, > Dear Marek Vasut, > > In message <201205231334.53948.ma...@denx.de> you wrote: > > > > Maybe add some switch statement based on CONFIG_MX28 or another > > > > within the target? > > > > > > I can't parse this sentence - and I don't understand why you think > > > any specifi

Re: [U-Boot] [PATCH 5/7] OMAP5: EMIF: Add support for DDR3 device

2012-05-23 Thread R, Sricharan
Hi Tom, >> >>  ah, this is what is there on OMAP5. >>    3 for DDR3 >>    4 for LPDDR2-S4, >>    5 for LPDDR2-S2 > > > 4/5 are listed as reserved here :( http://www.ti.com/lit/pdf/spruh73 > > >> Atleast DDR3 encoding is same. So we can differentiate bw DDR3 and 2 >> in same way. >> Is the reset val

Re: [U-Boot] [PATCH 3/3] M28: Disable USB power on boot

2012-05-23 Thread Fabio Estevam
On Wed, May 23, 2012 at 8:53 AM, Marek Vasut wrote: > Dang, this must be related to bootrom somehow then. Fabio, can you confirm the > following: > > If you turn off the mx28 board, connect usb flashdisc, turn it on -- do you > see > the flashdisc led blinking? Any idea what might cause it? This

Re: [U-Boot] [PATCH 3/3] M28: Disable USB power on boot

2012-05-23 Thread Marek Vasut
Dear Fabio Estevam, > On Tue, May 22, 2012 at 8:32 PM, Marek Vasut wrote: > > void board_init_ll(void) > > { > > + /* Powerdown the USB */ > > + mxs_iomux_setup_pad(MX28_PAD_SSP2_SS1__USB1_OVERCURRENT); > > + mxs_iomux_setup_pad(MX28_PAD_AUART3_TX__GPIO_3_13 | > > +

Re: [U-Boot] [PATCH 3/3] M28: Disable USB power on boot

2012-05-23 Thread Fabio Estevam
On Tue, May 22, 2012 at 8:32 PM, Marek Vasut wrote: >  void board_init_ll(void) >  { > +       /* Powerdown the USB */ > +       mxs_iomux_setup_pad(MX28_PAD_SSP2_SS1__USB1_OVERCURRENT); > +       mxs_iomux_setup_pad(MX28_PAD_AUART3_TX__GPIO_3_13 | > +                       MXS_PAD_12MA | MXS_PAD

Re: [U-Boot] [PATCH 3/3] M28: Disable USB power on boot

2012-05-23 Thread Marek Vasut
Dear Fabio Estevam, > On Wed, May 23, 2012 at 8:53 AM, Marek Vasut wrote: > > Dang, this must be related to bootrom somehow then. Fabio, can you > > confirm the following: > > > > If you turn off the mx28 board, connect usb flashdisc, turn it on -- do > > you see the flashdisc led blinking? Any

Re: [U-Boot] [PATCH 3/3] M28: Disable USB power on boot

2012-05-23 Thread Fabio Estevam
On Wed, May 23, 2012 at 10:08 AM, Marek Vasut wrote: > Well, what can it be caused by? I disabled the VBUS, so how come it can still > be > on. The usb circuitry maybe then? I cannot comment on that, as I never looked at the m28evk schematics. Please use a mx28evk for comparison. _

Re: [U-Boot] [PATCH 3/3] M28: Disable USB power on boot

2012-05-23 Thread Fabio Estevam
On Wed, May 23, 2012 at 10:07 AM, Marek Vasut wrote: > This is correct, it should be inverted. So where in your code you powerup the USB? There should be a: gpio_direction_output(MX28_PAD_AUART3_TX__GPIO_3_13, 0); ,somewhere in order to power your USB on then.

Re: [U-Boot] [PATCH 3/3] M28: Disable USB power on boot

2012-05-23 Thread Marek Vasut
Dear Fabio Estevam, > On Wed, May 23, 2012 at 10:07 AM, Marek Vasut wrote: > > This is correct, it should be inverted. > > So where in your code you powerup the USB? > > There should be a: > > gpio_direction_output(MX28_PAD_AUART3_TX__GPIO_3_13, 0); > > ,somewhere in order to power your USB o

Re: [U-Boot] [PATCH v4 4/6] armv7: Use -march=armv7-a and thereby enable Thumb-2

2012-05-23 Thread Thierry Reding
* Aneesh V wrote: > Enable -march=armv7-a for armv7 platforms if the tool-chain > supports it. This in turn results in Thumb-2 code generated > for these platforms if CONFIG_SYS_THUMB_BUILD is enabled. > > Signed-off-by: Aneesh V > --- > I believe armv7-a is fine for all the SoCs except Tegra2 >

Re: [U-Boot] [PATCH v4 4/6] armv7: Use -march=armv7-a and thereby enable Thumb-2

2012-05-23 Thread Stephen Warren
On 05/23/2012 09:01 AM, Thierry Reding wrote: > * Aneesh V wrote: >> Enable -march=armv7-a for armv7 platforms if the tool-chain >> supports it. This in turn results in Thumb-2 code generated for >> these platforms if CONFIG_SYS_THUMB_BUILD is enabled. >> >> Signed-off-by: Aneesh V --- I believe

Re: [U-Boot] Nand flash R/W,saveenv issue..

2012-05-23 Thread Scott Wood
On 05/23/2012 03:30 AM, Manukumar wrote: > Hello, > when we get rference board(P1020RDB) we got the u-boot-2010.12 source. That board is supported by current mainline U-Boot as well -- no patch needed. > by using above source we have modified according to custom boards > requirement. > can you p

Re: [U-Boot] [PATCH v5 1/5] lib: add rand() function

2012-05-23 Thread Michael Walle
Am Samstag 12 Mai 2012, 00:50:45 schrieb Michael Walle: > It's a PRNG using the simple and fast xorshift method. > > Signed-off-by: Michael Walle > Cc: Wolfgang Denk Hi Wolfgang, can you ack this patch? In that case i could add the acked-by line in the next version of this patch series to ea

Re: [U-Boot] [PATCH 5/7] OMAP5: EMIF: Add support for DDR3 device

2012-05-23 Thread Tom Rini
On 05/23/2012 05:22 AM, R, Sricharan wrote: Hi Tom, ah, this is what is there on OMAP5. 3 for DDR3 4 for LPDDR2-S4, 5 for LPDDR2-S2 4/5 are listed as reserved here :( http://www.ti.com/lit/pdf/spruh73 Atleast DDR3 encoding is same. So we can differentiate bw DDR3 and 2 in sa

[U-Boot] [PATCH] tegra: remove CONFIG_USB_ETHER_SMSC95XX from boards without it

2012-05-23 Thread Stephen Warren
From: Stephen Warren The SMSC95xx series may exist either directly on a main board, or as a USB to Ethernet dongle. However, dongles containing these chips are very rare. Hence, remove this config option, except on Harmony where such a chip is actually present on the board. The asix option remai

[U-Boot] [PATCH] tegra: ventana: add own device tree, enable USB

2012-05-23 Thread Stephen Warren
From: Stephen Warren Add a device tree for Ventana; the Seaboard file no longer represents the HW present on Ventana. Enable USB on Ventana. Signed-off-by: Stephen Warren --- board/nvidia/dts/tegra2-ventana.dts | 57 +++ include/configs/ventana.h |

[U-Boot] [PATCH v3 01/21] net: Remove CMD_PING where there's no CMD_NET

2012-05-23 Thread Joe Hershberger
Some boards claim to need ping, but don't support net. That makes no sense, and causes problems now that ping is in a separate file. Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Separated from "Move PING out of net.c" include/configs/am3517_crane.h |2 +- inc

[U-Boot] [PATCH v3 18/21] net: cosmetic: Rename OPT_SIZE to OPT_FIELD_SIZE

2012-05-23 Thread Joe Hershberger
Clearer constant name. Also remove related BOOTP_SIZE which was unused and doesn't take into account VLAN packets. Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split from "Improve variable names and code readability" Changes for v3: net/bootp.c | 10 +-

[U-Boot] [PATCH v3 15/21] net: cosmetic: Add a more explicit comment about 802.2

2012-05-23 Thread Joe Hershberger
Make the comment more accurate about the header including SNAP Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split from "Improve variable names and code readability" - Fixed comment indention Changes for v3: - Added a short commit message include/net.h |

[U-Boot] [PATCH v3 02/21] net: Move MAC-seeded rand out of bootp.c

2012-05-23 Thread Joe Hershberger
Make the MAC-seeded random number generator available to /net in general. MAC-seeded rand will be needed by link-local as well, so give it an interface. Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v3: - Lowercase hex - Add blank line - Always include header, even wh

[U-Boot] [PATCH v3 20/21] net: cosmetic: Rename tmp to reply_ip_addr in arp.c

2012-05-23 Thread Joe Hershberger
Renamed for clarity Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split from "Improve variable names and code readability" Changes for v3: net/arp.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/net/arp.c b/net/arp.c index 5b16de7..

[U-Boot] [PATCH v3 05/21] net: Move ARP out of net.c

2012-05-23 Thread Joe Hershberger
Separate this functionality out of the net.c behemoth Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: Changes for v3: - Added a short commit message include/net.h |3 +- net/Makefile |1 + net/arp.c | 213 +

[U-Boot] [PATCH v3 17/21] net: cosmetic: Rename CDPHandler to cdp_receive

2012-05-23 Thread Joe Hershberger
This is not called as a handler, so don't name it that way Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split from "Improve variable names and code readability" Changes for v3: - Added a function comment - Renamed CDPReceive to cdp_receive net/cdp.c |3

[U-Boot] [PATCH v3 07/21] net: Move RARP receive logic out of net.c

2012-05-23 Thread Joe Hershberger
Separate this functionality out of the net.c behemoth Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Moved void to the same line as function - Eliminate CamelCase in new function name Changes for v3: - Removed extra spaces - Added a function comment - Add

[U-Boot] [PATCH v3 14/21] net: cosmetic: Rename parameter len to payload_len

2012-05-23 Thread Joe Hershberger
This name more explicitly claims that it does not include the header size Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split from "Improve variable names and code readability" Changes for v3: - Documented arguments to NetSendUDPPacket() include/net.h | 12 ++

[U-Boot] [PATCH v3 12/21] net: cosmetic: Un-typedef ARP_t

2012-05-23 Thread Joe Hershberger
Remove typedef and lower-case letters Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split apart from "Un-typedef variables in net" - Renamed structs from *_t to *_hdr since they are nolonger types Changes for v3: - Renamed ARP_hdr to arp_hdr include/net.h |

[U-Boot] [PATCH v3 09/21] net: cosmetic: Split struct ip_udp_hdr into ip_hdr

2012-05-23 Thread Joe Hershberger
Add a structure that only contains IP header fields to be used by functions that don't need UDP Rename IP_HDR_SIZE_NO_UDP to IP_HDR_SIZE Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split apart from "Un-typedef variables in net" - Created a new IP_UDP_hdr struct

[U-Boot] [PATCH v3 21/21] net: cosmetic: Replace magic numbers in arp.c with constants

2012-05-23 Thread Joe Hershberger
Use field names and sizes when accessing ARP packets Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split from "Improve variable names and code readability" Changes for v3: include/net.h |6 ++ net/arp.c | 34 +- 2 file

[U-Boot] [PATCH v3 08/21] net: cosmetic: Un-typedef IP_t

2012-05-23 Thread Joe Hershberger
Rename IP header related things to IP_UDP. The existing definition of IP_t includes UDP header, so name it to accurately describe the structure. Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split apart from "Un-typedef variables in net" - Created a new IP_UDP_hd

[U-Boot] [PATCH v3 19/21] net: cosmetic: Alphabetize includes in net.c

2012-05-23 Thread Joe Hershberger
Easier to find when alphabetized Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split from "Improve variable names and code readability" Changes for v3: - Slight adjustment to order as recommended by Simon net/net.c | 24 1 files chang

[U-Boot] [PATCH v3 10/21] net: cosmetic: Un-typedef Ethernet_t

2012-05-23 Thread Joe Hershberger
Separate the Ethernet header from the 802 header. Base the size constants on the structs. Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split apart from "Un-typedef variables in net" - Created a new E802_hdr struct and removed 802 members from Ethernet_hdr - R

[U-Boot] [PATCH v3 06/21] net: Move PING out of net.c

2012-05-23 Thread Joe Hershberger
Separate this functionality out of the net.c behemoth Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Moved config fixes to a separate patch - Pushed #ifdef CONFIG_CMD_PING into header - Eliminated CamelCase Changes for v3: - Added function comments - Adde

[U-Boot] [PATCH v3 13/21] net: cosmetic: Un-typedef ICMP_t

2012-05-23 Thread Joe Hershberger
Remove typedef and lower-case name Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split apart from "Un-typedef variables in net" - Renamed structs from *_t to *_hdr since they are nolonger types Changes for v3: - Renamed ICMP_hdr to icmp_hdr - Removed extra

[U-Boot] [PATCH v3 11/21] net: cosmetic: Un-typedef VLAN_Ethernet_t

2012-05-23 Thread Joe Hershberger
Eliminate the typedef and remove capital letters Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split apart from "Un-typedef variables in net" - Renamed structs from *_t to *_hdr since they are nolonger types Changes for v3: - Renamed VLAN_Ethernet_hdr to vlan_

[U-Boot] [PATCH v3 00/21] Network stack cosmetic improvements

2012-05-23 Thread Joe Hershberger
This patch-series reorganizes some of the net code to make it easier to navigate and easier to leverage common functionality while encapsulating private implementation details. It also makes simple readability clean-ups. This is dependant on the "Network stack checkpatch.pl compliance" patch-seri

[U-Boot] [PATCH v3 04/21] net: Encapsulate CDP packet identification

2012-05-23 Thread Joe Hershberger
Checking for CDP packets should be encapsulated, not copied code. Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split from patch "Move CDP out of net.c" - Changed to static inline Changes for v3: - Added a function comment - Added a blank line arch/powerp

[U-Boot] [PATCH v3 03/21] net: Move CDP out of net.c

2012-05-23 Thread Joe Hershberger
Separate this functionality out of the net.c behemoth Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Moved is_cdp_packet to a separate patch - Fixed blank newline at the end of cdp.h - Pushed #ifdef CONFIG_CMD_CDP into header Changes for v3: - Fix comment st

[U-Boot] [PATCH v3 16/21] net: cosmetic: Rename "x" to "eth_proto"

2012-05-23 Thread Joe Hershberger
x is a poor variable name Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split from "Improve variable names and code readability" Changes for v3: net/net.c | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/net/net.c b

[U-Boot] [PATCH v3 03/18] net: Refactor packet length computations

2012-05-23 Thread Joe Hershberger
Save the length when it is computed instead of forgetting it and subtracting pointers to figure it out again. Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: Changes for v3: - Rebased onto other changed patches net/arp.c | 13 - net/ping.c |7 --

[U-Boot] [PATCH v3 07/18] net: Refactor to use NetSendPacket instead of eth_send directly

2012-05-23 Thread Joe Hershberger
Use this entry-point consistently across the net/ code Use a static inline function to preserve code size Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Change NetSendPacket into a static inline Changes for v3: - Rebased onto other changed patches include/net.h

[U-Boot] [PATCH v3 05/18] net: Move debug trace to point of action

2012-05-23 Thread Joe Hershberger
Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split from "Refactor bootp packet length computations" Changes for v3: - Rebased onto other changed patches net/bootp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/bootp.c b/net/boot

[U-Boot] [PATCH v3 11/18] net: Don't write the "serverip" env var if configured not to

2012-05-23 Thread Joe Hershberger
Before this patch, bootp would not overwrite the value, but the value was still clobbered in the env Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Added a comment Changes for v3: - Rebased onto other changed patches - Fixed comment style common/cmd_net.c |

[U-Boot] [PATCH v3 00/18] Network stack refactoring

2012-05-23 Thread Joe Hershberger
This patch-series fixes a number of bugs in the network stack as well as improve the readability and maintainability of the network stack by eliminating duplicated code. These are more substantial changes than those in the "Network stack cosmetic improvements" series. This is dependant on the "Ne

[U-Boot] [PATCH v3 02/18] net: Refactor NetSendUDPPacket to share more code

2012-05-23 Thread Joe Hershberger
Share more of the code that is common between ARP vs not. Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: Changes for v3: - Rebased onto other changed patches net/net.c | 44 +--- 1 files changed, 25 insertions(+), 19 deletion

[U-Boot] [PATCH v3 09/18] net: Refactor to separate the UDP handler from the ARP handler

2012-05-23 Thread Joe Hershberger
Call a built-in dummy if none is registered... don't require protocols to register a handler (eliminating dummies) NetConsole now uses the ARP handler when waiting on arp (instead of needing a #define hack in arp.c) Clear handlers at the end of net loop Signed-off-by: Joe Hershberger Cc: Joe Hers

[U-Boot] [PATCH v3 01/18] net: Refactor IP, UPD, and ICMP header writing functions

2012-05-23 Thread Joe Hershberger
ICMP (ping) was reimplementing IP header code... it now shares code. Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Eliminate CamelCase in new functions Changes for v3: - Rebased onto other changed patches include/net.h |4 +++- net/bootp.c |8

[U-Boot] [PATCH v3 06/18] net: Refactor ping receive handler

2012-05-23 Thread Joe Hershberger
There is no need to call through the handler... inline it Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: Changes for v3: - Rebased onto other changed patches net/ping.c | 18 ++ 1 files changed, 2 insertions(+), 16 deletions(-) diff --git a/net/pin

[U-Boot] [PATCH v3 10/18] net: Add net_update_ether() to handle ARP and Ping replies

2012-05-23 Thread Joe Hershberger
When the network is VLAN or SNAP, net_update_ether() will preserve the original Ethernet packet header and simply replace the src and dest MACs and the protocol Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: Changes for v3: - Rebased onto other changed patches includ

[U-Boot] [PATCH v3 12/18] net: Fix unused variable compile warning

2012-05-23 Thread Joe Hershberger
If CONFIG_BOOTP_SERVERIP is not defined, unused variable warning is reported. This was fixed upstream using a compiler feature instead of a simple reorder of the statements. Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: Changes for v3: - Rebased onto other changed pa

[U-Boot] [PATCH v3 13/18] net: Add option CONFIG_BOOTP_MAY_FAIL

2012-05-23 Thread Joe Hershberger
This is useful if you want to look for a DHCP server, but try some other settings if not available. Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Renamed to CONFIG_BOOTP_MAY_FAIL Changes for v3: - Rebased onto other changed patches README |7 +++ n

[U-Boot] [PATCH v3 04/18] net: Refactor bootp packet length computations

2012-05-23 Thread Joe Hershberger
Eliminate pointer subtraction that recovers values computed earlier Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split debug message move to a separate commit Changes for v3: - Rebased onto other changed patches net/bootp.c | 24 +--- 1 f

[U-Boot] [PATCH v3 14/18] net: Remove static allocation for MAC address in PingSend()

2012-05-23 Thread Joe Hershberger
Don't force ARP clients to return the MAC address if they don't care (such as ping) Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: Changes for v3: - Rebased onto other changed patches net/arp.c |9 + net/ping.c | 10 +++--- 2 files changed, 8 inser

[U-Boot] [PATCH v3 16/18] net: Fix net buffer initialization

2012-05-23 Thread Joe Hershberger
A new non-static function net_init() will initialize buffers and read from the environment. Only update from the env on each entry to NetLoop(). Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Unadded explicit parameter name in net.h for NetLoop - Eliminate CamelC

[U-Boot] [PATCH v3 15/18] net: Remove unused parameter from NetInitLoop()

2012-05-23 Thread Joe Hershberger
Noone uses it. Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split from "Fix net buffer initialization" Changes for v3: - Rebased onto other changed patches - Added a short commit message net/net.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-

[U-Boot] [PATCH v3 08/18] net: Refactor to protect access to the NetState variable

2012-05-23 Thread Joe Hershberger
Changes to NetState now go through an accessor function called net_set_state() Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - net_set_state changed to static inline - States changed to an enum - Eliminate CamelCase in new functions. Changes for v3: - Rebased

[U-Boot] [PATCH v3 18/18] net: Don't copy every packet that waits for an ARP

2012-05-23 Thread Joe Hershberger
Use the NetArpTxPacket for the ARP packet, not to hold what used to be in NetTxPacket. This saves a copy and makes the code easier to understand. Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: Changes for v3: - Rebased onto other changed patches - Fixed comment styl

[U-Boot] [PATCH v3 17/18] net: Make sure NetLoop is initialized when using NetConsole

2012-05-23 Thread Joe Hershberger
Fix NetConsole bug that causes first packet header to claim a source IP address of 0.0.0.0 Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: Changes for v3: - Rebased onto other changed patches - Fix comment style drivers/net/netconsole.c |6 ++ 1 files chang

[U-Boot] [PATCH v3 0/3] Add link-local addressing support

2012-05-23 Thread Joe Hershberger
Link-local support allows the bootloader to get a usable network address regardless of network environment. Given that bootloaders may not always have access to a DHCP server, this functionality makes accessing it in those environments easier. It is also referred to as zero-configuration IP. Tes

[U-Boot] [PATCH v3 1/3] net: Separate ArpRequest() into lower-level func

2012-05-23 Thread Joe Hershberger
Link-local support will need to send ARP packets, but needs more fine-grained control over the contents. Split the implementation into 2 parts so link-local can share the code. Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Split from "Add link-local addressing supp

[U-Boot] [PATCH v3 2/3] net: Add link-local addressing support

2012-05-23 Thread Joe Hershberger
Code based on networking/zcip.c in busybox commit 8531d76a15890c2c535908ce888b2e2aed35b172 Signed-off-by: Joe Hershberger Cc: Joe Hershberger --- Changes for v2: - Omitted unrelated whitespace changes - Made do_link_local() static - Pushed #ifdef CONFIG_CMD_LINK_LOCAL into header Change

[U-Boot] [PATCH v3 3/3] net: Work-around for brain-damaged Cisco equipment with arp-proxy

2012-05-23 Thread Joe Hershberger
Cisco's arp-proxy feature fails to ignore the link-local address range This means that a link-local device on a network with this Cisco equipment will reply to ARP requests for our device (in addition to our reply). If we happen to reply first, the requester's ARP table will be populated with our M

[U-Boot] [PATCH v3] net: Allow filtering on debug traces in the net subsystem

2012-05-23 Thread Joe Hershberger
Add several levels of DEBUG prints so that you can limit the noise to the severety of your problem. DEBUG_LL_STATE = Link local state machine changes DEBUG_DEV_PKT = Packets or info directed to the device DEBUG_NET_PKT = Packets on info on the network at large DEBUG_INT_STATE = Internal network st

[U-Boot] [PATCH 0/2] patman: Various fixes

2012-05-23 Thread Vikram Narayanan
This fixes the location of patman config file from ~/.config/patman to ~/.patman. Also addresses the creation of new config file when it isn't present. Cc: Simon Glass Cc: Wolfgang Denk Vikram Narayanan (2): patman: Change the location of patman config file patman: Handle creation of patma

[U-Boot] [PATCH 1/2] patman: Change the location of patman config file

2012-05-23 Thread Vikram Narayanan
Move the config file from ~/.config/patman to ~/.patman as it is more appropriate to have it there. Update the same in the README. Signed-off-by: Vikram Narayanan Cc: Simon Glass Cc: Wolfgang Denk --- tools/patman/README |2 +- tools/patman/settings.py |2 +- 2 files changed, 2 i

[U-Boot] [PATCH 2/2] patman: Handle creation of patman config file

2012-05-23 Thread Vikram Narayanan
patman shouts when it couldn't find a $(HOME)/.patman file. Handle it in a sane way by creating a new one for the user. It looks for a user.name and user.email in the global .gitconfig file, waits for the user input if it can't find there. Update the same in the README Signed-off-by: Vikram Naraya

[U-Boot] Pull request: u-boot-net.git master

2012-05-23 Thread Joe Hershberger
Hi Wolfgang, This should include fixes for all the warnings from db288a96027fa1cb3f8a53f330724f864224a56c "net: Remove volatile from net API" The following changes since commit b86a475c1a602c6ee44f4469d933df8792418a7a: Joe Hershberger (1): MAKEALL: Report boards with errors vs warnings

Re: [U-Boot] [PATCH] drivers/net/xilinx_emaclite.c: Fix compile warning

2012-05-23 Thread Joe Hershberger
On Tue, May 22, 2012 at 5:18 PM, Stephan Linz wrote: > Fix this: > xilinx_emaclite.c: In function 'xilinx_emaclite_initialize': > xilinx_emaclite.c:371: warning: assignment from incompatible pointer type > > Signed-off-by: Stephan Linz Applied, thanks. -Joe _

Re: [U-Boot] [PATCH] drivers/net/xilinx_axi_emac.c: Fix compile warning

2012-05-23 Thread Joe Hershberger
On Tue, May 22, 2012 at 5:18 PM, Stephan Linz wrote: > Fix this: > xilinx_axi_emac.c: In function 'xilinx_axiemac_initialize': > xilinx_axi_emac.c:646: warning: assignment from incompatible pointer type > > Signed-off-by: Stephan Linz Applied, thanks. -Joe __

Re: [U-Boot] [PATCH] drivers/net/xilinx_ll_temac.c: Fix compile warning

2012-05-23 Thread Joe Hershberger
On Tue, May 22, 2012 at 5:18 PM, Stephan Linz wrote: > Fix this: > xilinx_ll_temac.c: In function 'xilinx_ll_temac_initialize': > xilinx_ll_temac.c:332: warning: assignment from incompatible pointer type > xilinx_ll_temac.c:340: warning: assignment from incompatible pointer type > > Signed-off-by:

Re: [U-Boot] [PATCH] net: sh_eth: Add support SH7734 Ethernet device

2012-05-23 Thread Joe Hershberger
Hi Nobuhiro Iwamatsu, On Fri, Feb 3, 2012 at 1:28 AM, Nobuhiro Iwamatsu wrote: > SH7734 has one channel ethernet device. > This support 10/100/1000Base, and RMII/MII/GMII. > And this has the same structure as SH7763. > > Signed-off-by: Nobuhiro Iwamatsu In the future, please run tools/checkpatc

Re: [U-Boot] [PATCH v2] net: sh-eth: Add support Gigabit of SH7734

2012-05-23 Thread Joe Hershberger
Hi Nobuhiro Iwamatsu, On Tue, May 15, 2012 at 8:49 PM, Nobuhiro Iwamatsu wrote: > SH7734 support GMII. This add register infomation and the function > which enable GMII. > > Signed-off-by: Nobuhiro Iwamatsu Applied, thanks. -Joe ___ U-Boot mailing li

  1   2   >