Dear Jorgen Lundman, In message <1337744719-27487-2-git-send-email-lund...@lundman.net> you wrote: > Signed-off-by: Jorgen Lundman <lund...@lundman.net> > ---
Please provide a useful commit message. Also, this being a V2 patch, you are supposed to provide a history of changes. Please see http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions Finally, it makes little sense to add the headers separately. Please squash both patches into on. And please add information where _exactly_ the code has been copied from; for an example how to do this please see http://www.denx.de/wiki/view/U-Boot/Patches#Attributing_Code_Copyrights_Sign i. e. pleaseinclude information about download resp. reposity URL plus exact version that was used as base for this work. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The most difficult thing in the world is to know how to do a thing and to watch someone else doing it wrong, without commenting. -- T.H. White _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
