Re: [U-Boot] [PATCH v2] wandboard: Add board revision detection support

2015-06-07 Thread Stefano Babic
Hi Fabio, On 22/05/2015 00:24, Fabio Estevam wrote: > From: Fabio Estevam > > There are two revisions of wandboard: version B1 and C1. > > Add the revision detection support, so that the correct dtb file can > be automatically loaded. > > Based on the patch from Richard Hu . > > Signed-off-by

Re: [U-Boot] [PATCH v2] wandboard: Add board revision detection support

2015-05-26 Thread Fabio Estevam
On Tue, May 26, 2015 at 3:55 PM, Alexander Holler wrote: > Besides that I don't really care what a maintainer said to some previous > similiar problem. Maintainers are humans too, maybe he just had forgotten > about the gpio-command. The gpio command is now available in Stefano's tree after Pete

Re: [U-Boot] [PATCH v2] wandboard: Add board revision detection support

2015-05-26 Thread Alexander Holler
Am 25.05.2015 um 11:41 schrieb Wolfgang Denk: Dear Fabio, In message you wrote: "If the gpio command would be enabled, it would even be possible to reset the BRCM- WLAN and Bluetooth modules by just adding some stuff to uEnv.txt." This sounds like a real hack for me, sorry. Consider it as

Re: [U-Boot] [PATCH v2] wandboard: Add board revision detection support

2015-05-25 Thread Fabio Estevam
Hi Wolfgang, On Mon, May 25, 2015 at 6:41 AM, Wolfgang Denk wrote: > Consider it as an example for being able to do many different things > that have not even been thought of at the time of implementations. to > try out things. Maybe we decide later to implement the features a C > code, but for

Re: [U-Boot] [PATCH v2] wandboard: Add board revision detection support

2015-05-25 Thread Wolfgang Denk
Dear Fabio, In message you wrote: > > "If the gpio command would be enabled, it would even be possible to reset the > BRCM- WLAN and Bluetooth modules by just adding some stuff to uEnv.txt." > > This sounds like a real hack for me, sorry. Consider it as an example for being able to do many di

Re: [U-Boot] [PATCH v2] wandboard: Add board revision detection support

2015-05-24 Thread Fabio Estevam
On Sun, May 24, 2015 at 7:22 PM, Alexander Holler wrote: > I've not said that I want such a hack in u-boot. Well, you wrote: "If the gpio command would be enabled, it would even be possible to reset the BRCM- WLAN and Bluetooth modules by just adding some stuff to uEnv.txt." This sounds like a

Re: [U-Boot] [PATCH v2] wandboard: Add board revision detection support

2015-05-24 Thread Alexander Holler
Am 24.05.2015 um 20:47 schrieb Fabio Estevam: > On Sun, May 24, 2015 at 3:03 PM, Alexander Holler > wrote: > >> Hmm, just one comment more. >> >> If the gpio command would be enabled, it would even be possible to reset the >> BRCM- WLAN and Bluetooth modules by just adding some stuff to uEnv.txt

Re: [U-Boot] [PATCH v2] wandboard: Add board revision detection support

2015-05-24 Thread Tom Rini
On Sun, May 24, 2015 at 08:03:12PM +0200, Alexander Holler wrote: > Am 24.05.2015 um 19:29 schrieb Alexander Holler: > >Am 24.05.2015 um 16:27 schrieb Fabio Estevam: > >>Hi Stefano and Alexander, > >> > >>On Sun, May 24, 2015 at 4:43 AM, Stefano Babic wrote: > >> > Wouldn't it be better to jus

Re: [U-Boot] [PATCH v2] wandboard: Add board revision detection support

2015-05-24 Thread Fabio Estevam
On Sun, May 24, 2015 at 3:03 PM, Alexander Holler wrote: > Hmm, just one comment more. > > If the gpio command would be enabled, it would even be possible to reset the > BRCM- WLAN and Bluetooth modules by just adding some stuff to uEnv.txt. So > at least WLAN would reliable work even after a reb

Re: [U-Boot] [PATCH v2] wandboard: Add board revision detection support

2015-05-24 Thread Fabio Estevam
On Sun, May 24, 2015 at 2:29 PM, Alexander Holler wrote: > I would suggest to change the stuff for mx6cuboxi to use the gpio command > too instead of taking the same (imho wrong) approach. mx6cuboxi uses two GPIOs for distinguishing between the various revisions of hummingboard and cuboxi. Hand

Re: [U-Boot] [PATCH v2] wandboard: Add board revision detection support

2015-05-24 Thread Alexander Holler
Am 24.05.2015 um 19:29 schrieb Alexander Holler: Am 24.05.2015 um 16:27 schrieb Fabio Estevam: Hi Stefano and Alexander, On Sun, May 24, 2015 at 4:43 AM, Stefano Babic wrote: Wouldn't it be better to just enable CONFIG_CMD_GPIO and then change the boot-script in the config to something like

Re: [U-Boot] [PATCH v2] wandboard: Add board revision detection support

2015-05-24 Thread Alexander Holler
Am 24.05.2015 um 16:27 schrieb Fabio Estevam: Hi Stefano and Alexander, On Sun, May 24, 2015 at 4:43 AM, Stefano Babic wrote: Wouldn't it be better to just enable CONFIG_CMD_GPIO and then change the boot-script in the config to something like "if gpio ..." instead of adding something special?

Re: [U-Boot] [PATCH v2] wandboard: Add board revision detection support

2015-05-24 Thread Stefano Babic
Hi Fabio, On 24/05/2015 16:27, Fabio Estevam wrote: > > I think the idea is good, thanks. > > I wanted to keep consistency with the mx6cuboxi implementation (which > was based on TI's implementation suggested by Tom during the review of > the mx6cuboxi patches). > > Also, the gpio script idea w

Re: [U-Boot] [PATCH v2] wandboard: Add board revision detection support

2015-05-24 Thread Fabio Estevam
Hi Stefano and Alexander, On Sun, May 24, 2015 at 4:43 AM, Stefano Babic wrote: >> Wouldn't it be better to just enable CONFIG_CMD_GPIO and then change the >> boot-script in the config to something like "if gpio ..." instead of >> adding something special? >> >> Assuming the gpio command works o

Re: [U-Boot] [PATCH v2] wandboard: Add board revision detection support

2015-05-24 Thread Stefano Babic
Hi Fabio, Alexander, On 23/05/2015 18:27, Alexander Holler wrote: > Am 23.05.2015 um 02:38 schrieb Vagrant Cascadian: >> On 2015-05-21, Fabio Estevam wrote: >>> From: Fabio Estevam >>> >>> There are two revisions of wandboard: version B1 and C1. >>> >>> Add the revision detection support, so that

Re: [U-Boot] [PATCH v2] wandboard: Add board revision detection support

2015-05-23 Thread Alexander Holler
Am 23.05.2015 um 02:38 schrieb Vagrant Cascadian: On 2015-05-21, Fabio Estevam wrote: From: Fabio Estevam There are two revisions of wandboard: version B1 and C1. Add the revision detection support, so that the correct dtb file can be automatically loaded. Based on the patch from Richard Hu

Re: [U-Boot] [PATCH v2] wandboard: Add board revision detection support

2015-05-22 Thread Vagrant Cascadian
On 2015-05-21, Fabio Estevam wrote: > From: Fabio Estevam > > There are two revisions of wandboard: version B1 and C1. > > Add the revision detection support, so that the correct dtb file can > be automatically loaded. > > Based on the patch from Richard Hu . > > Signed-off-by: Fabio Estevam Tes

Re: [U-Boot] [PATCH v2] wandboard: Add board revision detection support

2015-05-22 Thread Stefano Babic
Hi Fabio, On 22/05/2015 00:24, Fabio Estevam wrote: > From: Fabio Estevam > > There are two revisions of wandboard: version B1 and C1. > > Add the revision detection support, so that the correct dtb file can > be automatically loaded. > > Based on the patch from Richard Hu . > > Signed-off-by

[U-Boot] [PATCH v2] wandboard: Add board revision detection support

2015-05-21 Thread Fabio Estevam
From: Fabio Estevam There are two revisions of wandboard: version B1 and C1. Add the revision detection support, so that the correct dtb file can be automatically loaded. Based on the patch from Richard Hu . Signed-off-by: Fabio Estevam --- Changes since v1: - Fixed commit log to 'automatica