Re: [U-Boot] [PATCH 1/3] imx-common: fix iomux settings

2015-09-21 Thread Peng Fan
Hi Stefano, Benoit, On Mon, Sep 21, 2015 at 10:13:42PM +0200, Stefano Babic wrote: >Hi Benoit, Peng, > >On 21/09/2015 20:41, Benoît Thébaudeau wrote: >> Hi Peng, >> >> On Mon, Sep 21, 2015 at 3:05 AM, Peng Fan wrote: >>> On Sun, Sep 20, 2015 at 05:02:58PM +0200, Benoît Thébaudeau wrote: On

Re: [U-Boot] [PATCH 1/3] imx-common: fix iomux settings

2015-09-21 Thread Stefano Babic
Hi Benoit, Peng, On 21/09/2015 20:41, Benoît Thébaudeau wrote: > Hi Peng, > > On Mon, Sep 21, 2015 at 3:05 AM, Peng Fan wrote: >> On Sun, Sep 20, 2015 at 05:02:58PM +0200, Benoît Thébaudeau wrote: >>> On Sun, Sep 20, 2015 at 3:02 PM, Peng Fan wrote: On Sun, Sep 20, 2015 at 01:33:20PM +0200

Re: [U-Boot] [PATCH 1/3] imx-common: fix iomux settings

2015-09-21 Thread Benoît Thébaudeau
Hi Peng, On Mon, Sep 21, 2015 at 3:05 AM, Peng Fan wrote: > On Sun, Sep 20, 2015 at 05:02:58PM +0200, Benoît Thébaudeau wrote: >>On Sun, Sep 20, 2015 at 3:02 PM, Peng Fan wrote: >>> On Sun, Sep 20, 2015 at 01:33:20PM +0200, Benoît Thébaudeau wrote: >> Also If still checking mux_ctrl_ofs, we

Re: [U-Boot] [PATCH 1/3] imx-common: fix iomux settings

2015-09-20 Thread Peng Fan
On Sun, Sep 20, 2015 at 05:02:58PM +0200, Benoît Thébaudeau wrote: >Hi Peng, > >On Sun, Sep 20, 2015 at 3:02 PM, Peng Fan wrote: >> On Sun, Sep 20, 2015 at 01:33:20PM +0200, Benoît Thébaudeau wrote: >>>Hi Stefano, Peng, Fabio, all, >>> >>>Sorry for seeing this only now, but... >>> >>>On Sun, Sep 2

Re: [U-Boot] [PATCH 1/3] imx-common: fix iomux settings

2015-09-20 Thread Benoît Thébaudeau
Hi Peng, On Sun, Sep 20, 2015 at 3:02 PM, Peng Fan wrote: > On Sun, Sep 20, 2015 at 01:33:20PM +0200, Benoît Thébaudeau wrote: >>Hi Stefano, Peng, Fabio, all, >> >>Sorry for seeing this only now, but... >> >>On Sun, Sep 20, 2015 at 9:43 AM, Stefano Babic wrote: >>> >>> >>> On 14/09/2015 07:34, P

Re: [U-Boot] [PATCH 1/3] imx-common: fix iomux settings

2015-09-20 Thread Stefano Babic
Hi Peng, On 20/09/2015 15:02, Peng Fan wrote: > On Sun, Sep 20, 2015 at 01:33:20PM +0200, Benoît Thébaudeau wrote: >> Hi Stefano, Peng, Fabio, all, >> >> Sorry for seeing this only now, but... >> >> On Sun, Sep 20, 2015 at 9:43 AM, Stefano Babic wrote: >>> >>> >>> On 14/09/2015 07:34, Peng Fan wr

Re: [U-Boot] [PATCH 1/3] imx-common: fix iomux settings

2015-09-20 Thread Peng Fan
On Sun, Sep 20, 2015 at 01:33:20PM +0200, Benoît Thébaudeau wrote: >Hi Stefano, Peng, Fabio, all, > >Sorry for seeing this only now, but... > >On Sun, Sep 20, 2015 at 9:43 AM, Stefano Babic wrote: >> >> >> On 14/09/2015 07:34, Peng Fan wrote: >>> When setting iomux for a pin mux, there is no need

Re: [U-Boot] [PATCH 1/3] imx-common: fix iomux settings

2015-09-20 Thread Benoît Thébaudeau
Hi Stefano, Peng, Fabio, all, Sorry for seeing this only now, but... On Sun, Sep 20, 2015 at 9:43 AM, Stefano Babic wrote: > > > On 14/09/2015 07:34, Peng Fan wrote: >> When setting iomux for a pin mux, there is no need to check mux_ctrl_ofs. This assumption is wrong. This check was there for a

Re: [U-Boot] [PATCH 1/3] imx-common: fix iomux settings

2015-09-20 Thread Stefano Babic
On 14/09/2015 07:34, Peng Fan wrote: > When setting iomux for a pin mux, there is no need to check mux_ctrl_ofs. > Also If still checking mux_ctrl_ofs, we have no chance to set iomux > for i.MX7D IOMUXC_LPSR_SW_MUX_CTL_PAD_GPIO1_IO00, because the mux_ctrl_ofs > for this register is 0. > > Signed

Re: [U-Boot] [PATCH 1/3] imx-common: fix iomux settings

2015-09-14 Thread Fabio Estevam
On Mon, Sep 14, 2015 at 2:34 AM, Peng Fan wrote: > When setting iomux for a pin mux, there is no need to check mux_ctrl_ofs. > Also If still checking mux_ctrl_ofs, we have no chance to set iomux > for i.MX7D IOMUXC_LPSR_SW_MUX_CTL_PAD_GPIO1_IO00, because the mux_ctrl_ofs > for this register is 0.

[U-Boot] [PATCH 1/3] imx-common: fix iomux settings

2015-09-13 Thread Peng Fan
When setting iomux for a pin mux, there is no need to check mux_ctrl_ofs. Also If still checking mux_ctrl_ofs, we have no chance to set iomux for i.MX7D IOMUXC_LPSR_SW_MUX_CTL_PAD_GPIO1_IO00, because the mux_ctrl_ofs for this register is 0. Signed-off-by: Peng Fan Cc: Stefano Babic Cc: Fabio Est