Re: [PATCH 00/14] pinctrl: rockchip: fix editing const struct + constify rockchip_pin_ctrl

2025-01-30 Thread Quentin Schulz
Hi Jonas, On 1/29/25 3:20 PM, Jonas Karlman wrote: Hi Quentin, On 2025-01-29 13:42, Quentin Schulz wrote: While testing some WIP work done by Ilias Apalodimas on guaranteeing read-only memory areas truly are handled as read-only[1], my RK3588 Tiger couldn't reach U-Boot CLI anymore becau

Re: [PATCH 2/3] image: Add support for starting TFA BL31 as fitImage loadables

2025-01-29 Thread Quentin Schulz
On 1/29/25 6:38 PM, Marek Vasut wrote: On 1/29/25 6:10 PM, Quentin Schulz wrote: Hi Marek, Hi, On 1/12/25 11:36 PM, Marek Vasut wrote: Add support for starting TFA from U-Boot running in EL3 as part of fitImage boot, so the user can start U-Boot in the highest privilege level on the

Re: [PATCH v3 3/9] ARM: renesas: Simplify board Makefiles

2025-01-29 Thread Quentin Schulz
. Signed-off-by: Marek Vasut Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH v3 2/9] ARM: renesas: Drop R8A779A0 V3U Falcon SPL Makefile entry

2025-01-29 Thread Quentin Schulz
Hi Marek, On 1/29/25 6:04 PM, Marek Vasut wrote: The SPL on R-Car V3U Falcon is never built, remove the Makefile entry. Signed-off-by: Marek Vasut Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH 3/3] arm64: renesas: Add TFA BL31 handoff support

2025-01-29 Thread Quentin Schulz
On 1/29/25 6:00 PM, Marek Vasut wrote: On 1/29/25 5:02 PM, Quentin Schulz wrote: +void armv8_switch_to_el2_prep(u64 args, u64 mach_nr, u64 fdt_addr, +  u64 arg4, u64 entry_point, u64 es_flag) +{ +    typedef void __noreturn (*image_entry_noargs_t)(void

Re: [PATCH 2/3] image: Add support for starting TFA BL31 as fitImage loadables

2025-01-29 Thread Quentin Schulz
Hi Marek, On 1/12/25 11:36 PM, Marek Vasut wrote: Add support for starting TFA from U-Boot running in EL3 as part of fitImage boot, so the user can start U-Boot in the highest privilege level on the platform, bundle TFA, Linux, DT into a single fitImage and boot such a bundle as a whole. There

Re: [PATCH v2 2/8] ARM: renesas: Simplify board Makefiles

2025-01-29 Thread Quentin Schulz
Hi Marek, On 1/29/25 5:42 PM, Marek Vasut wrote: On 1/29/25 3:54 PM, Quentin Schulz wrote: Hi Marek, Hi, On 1/18/25 12:15 PM, Marek Vasut wrote: Introduce board/renesas/common/Makefile and remove the multiple duplicate copies of obj := ../common/*.o from board Makefiles. Let the build

Re: [PATCH 3/3] arm64: renesas: Add TFA BL31 handoff support

2025-01-29 Thread Quentin Schulz
On 1/29/25 5:02 PM, Quentin Schulz wrote: Hi Marek, On 1/12/25 11:36 PM, Marek Vasut wrote: Implement custom U_BOOT_FIT_LOADABLE_HANDLER and armv8_switch_to_el2_prep() handling in case the TFA was loaded. The loadables handler sets up custom handoff structure used by Renesas TFA fork in

Re: [PATCH 3/3] arm64: renesas: Add TFA BL31 handoff support

2025-01-29 Thread Quentin Schulz
Hi Marek, On 1/12/25 11:36 PM, Marek Vasut wrote: Implement custom U_BOOT_FIT_LOADABLE_HANDLER and armv8_switch_to_el2_prep() handling in case the TFA was loaded. The loadables handler sets up custom handoff structure used by Renesas TFA fork in fixed location in DRAM and indicates the TFA has b

[PATCH] rockchip: theobroma-systems: use HAVE_VENDOR_COMMON_LIB to simplify Makefile

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz The build system uses HAVE_VENDOR_COMMON_LIB to automatically include board/$(VENDOR)/common/Makefile, therefore let's use that to implicitly include board/theobroma-systems/common/Makefile and compile the common.c file when building proper. Signed-off-by: Quentin S

Re: [PATCH v2 8/8] arm64: renesas: Deduplicate R-Car Gen3 and Gen4 SPL

2025-01-29 Thread Quentin Schulz
Hi Marek, On 1/18/25 12:15 PM, Marek Vasut wrote: Move R-Car Gen3 and Gen4 jump_to_image_no_args() into dedicated rcar64-spl.c file. The implementation of jump_to_image_no_args() is identical. No functional change. Signed-off-by: Marek Vasut Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH v2 7/8] arm64: renesas: Deduplicate board_early_init_f()

2025-01-29 Thread Quentin Schulz
function is empty. Signed-off-by: Marek Vasut Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH v2 3/8] ARM: renesas: Rename common/common.c to common/rcar64-common.c

2025-01-29 Thread Quentin Schulz
common/rcar64-common.c @@ -18,8 +18,6 @@ #include #include -#ifdef CONFIG_RCAR_64 - This file was already made rcar_64 specific in the previous patch, so you could have made that change in the previous commit. Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH v2 2/8] ARM: renesas: Simplify board Makefiles

2025-01-29 Thread Quentin Schulz
Hi Marek, On 1/18/25 12:15 PM, Marek Vasut wrote: Introduce board/renesas/common/Makefile and remove the multiple duplicate copies of obj := ../common/*.o from board Makefiles. Let the build system include the common Makefile using the HAVE_VENDOR_COMMON_LIB and build the common objects that are

Re: [PATCH v2 1/8] ARM: renesas: Rename board/renesas/rcar-common to board/renesas/common

2025-01-29 Thread Quentin Schulz
/common/Makefile to be extended with actual content later in this series. This is a preparatory patch for board Makefile simplification. No functional change so far. Signed-off-by: Marek Vasut Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH 1/3] rockchip: Fix TPL link error

2025-01-29 Thread Quentin Schulz
Hi Naoki, On 1/29/25 2:25 PM, FUKAUMI Naoki wrote: Rockchip RK3399 targets build TPL. If CONFIG_SPL_USB_DWC3_GENERIC and CONFIG_SPL_USB_GADGET are enabled, linking u-boot-tpl will fail. LD tpl/u-boot-tpl ld.bfd: drivers/usb/dwc3/dwc3-generic.o: in function `dwc3_glue_bind_common': /home

[PATCH 01/14] pinctrl: rockchip: remove unused base_pin bank member

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz Each bank has a base_pin member that is only set in the core and never used, so it can be removed. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rockchip-core.c | 1 - drivers/pinctrl/rockchip/pinctrl-rockchip.h | 2 -- 2 files changed, 3

[PATCH 04/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3036

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rk3036.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH 14/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RV1108

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rv1108.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH 13/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3399

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rk3399.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH 11/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3328

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rk3328.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH 10/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3308

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rk3308.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH 12/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3368

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rk3368.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH 09/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3288

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rk3288.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH 08/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3228

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rk322x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH 06/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3128

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rk3128.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH 07/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3188

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rk3188.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH 03/14] pinctrl: rockchip: constify rockchip_pin_ctrl for PX30

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-px30.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockchip/pi

[PATCH 05/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3066

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz There's no need to modify private data from the controller, so let's make that struct const. Signed-off-by: Quentin Schulz --- drivers/pinctrl/rockchip/pinctrl-rk3066.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/rockch

[PATCH 02/14] pinctrl: rockchip: remove unused nr_pins controller member

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz Each controller has an nr_pins member that is set either through the rockchip_pin_ctrl struct or from the core (or both). This is an issue because on RK3568, RK3588 and RV1126, the struct is const, this means it shouldn't be modified at all. This will trigger a CPU

[PATCH 00/14] pinctrl: rockchip: fix editing const struct + constify rockchip_pin_ctrl

2025-01-29 Thread Quentin Schulz
e constify done on top of Ilias branch[1], my PX30 Ringneck, RK3399 Puma and RK3588 Tiger all reach U-Boot CLI. No further test (like booting into Linux userspace) was done. [1] https://source.denx.de/u-boot/custodians/u-boot-tpm/-/tree/fix_memory_permissions Signed-off-by: Quentin Schulz -

[PATCH next 3/3] rockchip: ringneck-px30: enable DT overlay support

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz Haikou carrierboard allows multiple adapter boards to be connected, for now there exists the following adapter boards compatible with PX30 Ringneck: - Haikou Video Demo on the Video Connector, - Haikou LVDS 9904379 on the Video Connector, So support DT overlays so we can

[PATCH next 2/3] rockchip: px30: add fdtoverlay_addr_r default value to support FDTO

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz In order to be able to use Device Tree Overlays, the fdtoverlay_addr_r needs to be specified. Follow what's been done for other Rockchip SoCs and leave 1MiB for the base DTB before the address for the overlay. Signed-off-by: Quentin Schulz --- include/co

[PATCH next 1/3] rockchip: px30: enable RNG for all boards

2025-01-29 Thread Quentin Schulz
From: Quentin Schulz I don't see a reason why this should only be enabled on a per-board basis. The rng IP is inside the SoC and doesn't seem to rely on anything external to it, therefore let's enable it on the SoC DTSI and remove the now empty px30-evb-u-boot.dtsi. Signed-

[PATCH next 0/3] rockchip: px30: enable RNG globally + DT overlay support for PX30 Ringneck

2025-01-29 Thread Quentin Schulz
ys on PX30 Ringneck, for that to work the fdtoverlay_addr_r env variable needs to be set and the OF_LIBFDT_OVERLAY symbol to be enabled. Signed-off-by: Quentin Schulz --- Quentin Schulz (3): rockchip: px30: enable RNG for all boards rockchip: px30: add fdtoverlay_addr_r default value to su

[PATCH v4] image: apply FDTOs on FDT image node without a load property

2025-01-22 Thread Quentin Schulz
From: Quentin Schulz A FIT image which is NOT using -E when created by mkimage - that is with image data within the FIT - will fail to apply FDTO if the base FDT image node does not specify a load property (which points to an address in DRAM). This is because we check that the FDT address we

Re: [PATCH v3] image: apply FDTOs on FDT image node without a load property

2025-01-22 Thread Quentin Schulz
Hi Marek, On 1/22/25 3:32 PM, Marek Vasut wrote: On 1/22/25 3:21 PM, Quentin Schulz wrote: [...] @@ -2395,17 +2395,18 @@ int boot_get_fdt_fit(struct bootm_headers *images, ulong addr,   /* we need to apply overlays */   #ifdef CONFIG_OF_LIBFDT_OVERLAY -    image_start = addr

Re: [PATCH v3] image: apply FDTOs on FDT image node without a load property

2025-01-22 Thread Quentin Schulz
Hi all, On 1/22/25 2:57 PM, Quentin Schulz wrote: From: Quentin Schulz A FIT image which is NOT using -E when created by mkimage - that is with image data within the FIT - will fail to apply FDTO if the base FDT image node does not specify a load property (which points to an address in DRAM

[PATCH v3] image: apply FDTOs on FDT image node without a load property

2025-01-22 Thread Quentin Schulz
From: Quentin Schulz A FIT image which is NOT using -E when created by mkimage - that is with image data within the FIT - will fail to apply FDTO if the base FDT image node does not specify a load property (which points to an address in DRAM). This is because we check that the FDT address we

Re: [PATCH RFC v2] image: apply FDTOs on FDT image node without a load property

2025-01-21 Thread Quentin Schulz
Hi Marek, On 1/21/25 12:55 AM, Marek Vasut wrote: On 1/16/25 12:46 PM, Quentin Schulz wrote: From: Quentin Schulz A FIT image which is NOT using -E when created by mkimage - that is with image data within the FIT - will fail to apply FDTO if the base FDT image node does not specify a load

Re: [RFC] Adding bootsource and reset-source* to /chosen

2025-01-17 Thread Quentin Schulz
Hi Rob, On 1/14/25 9:36 PM, Rob Herring wrote: On Fri, Dec 13, 2024 at 12:08 PM Quentin Schulz wrote: Hi all, In U-Boot, there are multiple stages which can be loaded from different media each. On Rockchip SoCs, it mostly goes this way, SoC BootROM loads from a medium (storage or over USB

Re: [PATCH v3 1/4] debug_uart: Replace debug functions with dummies if CONFIG_DEBUG_UART is not set

2025-01-17 Thread Quentin Schulz
Hi Łukasz, Kever, On 11/27/24 11:21 PM, Łukasz Czechowski wrote: Hi Kever, On 2024/11/27 03:42 Kever Yang wrote: Hi Lukasz, I got a new error base on patch [1], see full log here [2]. Looking at the file efi_stub.c that is used in the failing configuration it looks to me that some f

Re: [PATCH next RFC 0/5] rockchip: panic() when DRAM init fails

2025-01-17 Thread Quentin Schulz
Hi Kever, On 11/5/24 6:21 PM, Quentin Schulz wrote: I am the unfortunate owner of an RK3399 Puma that is failing DRAM init every now and then with the following cryptic error message: """ pctl_start: Failed to init pctl channel 0 """ When it fails, the current

[PATCH RFC v2] image: apply FDTOs on FDT image node without a load property

2025-01-16 Thread Quentin Schulz
From: Quentin Schulz A FIT image which is NOT using -E when created by mkimage - that is with image data within the FIT - will fail to apply FDTO if the base FDT image node does not specify a load property (which points to an address in DRAM). This is because we check that the FDT address we

Re: 回复: [PATCH] linker_lists: Update the alignment using CONFIG_LINKER_LIST_ALIGN

2025-01-16 Thread Quentin Schulz
Hi, On 1/16/25 1:24 AM, 黄利亚 wrote: Sorry for the confusion and disruption.  I haven't submitted patches this way before,  and my English is not very good.  I was conducted according to the steps  in the https://docs.u-boot.org/en/latest/develop/patman.html operation. The patch is fine, it is

Re: [PATCH 6/6] block: Remove "select BLK" from non-block drivers

2025-01-16 Thread Quentin Schulz
Hi Tom, On 1/15/25 9:20 PM, Tom Rini wrote: On Wed, Jan 15, 2025 at 06:49:45PM +0100, Quentin Schulz wrote: Hi Tom, On 1/14/25 5:59 PM, Tom Rini wrote: On Tue, Jan 14, 2025 at 02:53:48PM +0100, Quentin Schulz wrote: Hi Tom, On 12/20/24 11:22 PM, Tom Rini wrote: Now that block drivers are

Re: [PATCHv2 4/6] blk: Make block subsystems select BLK

2025-01-15 Thread Quentin Schulz
ms. As just replied on v1, I would have liked an explicit mention that yes, this diff doesn't include a change to PVBLOCK symbol, because it already does the right thing. Signed-off-by: Tom Rini Reviewed-by: Peter Robinson Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH 6/6] block: Remove "select BLK" from non-block drivers

2025-01-15 Thread Quentin Schulz
Hi Tom, On 1/14/25 5:59 PM, Tom Rini wrote: On Tue, Jan 14, 2025 at 02:53:48PM +0100, Quentin Schulz wrote: Hi Tom, On 12/20/24 11:22 PM, Tom Rini wrote: Now that block drivers are all selecting the BLK symbol, there's no need for other options to be select'ing BLK so that othe

Re: [PATCH 4/6] blk: Make block subsystems select BLK

2025-01-15 Thread Quentin Schulz
Hi Tom, On 1/14/25 5:58 PM, Tom Rini wrote: On Tue, Jan 14, 2025 at 02:45:25PM +0100, Quentin Schulz wrote: Hi Tom, On 12/20/24 11:22 PM, Tom Rini wrote: The BLK symbol has a few meanings, one of which is that it controls the driver model portion of a "block device". Rather than h

Re: Simon Glass's future with Das U-Boot project?

2025-01-15 Thread Quentin Schulz
Hi Tom, On 1/2/25 5:13 PM, Tom Rini wrote: Hey all, While I had hoped that the quiet of the last week or so had meant that things would perhaps return to how they had been before, Simon's large patch series and then comments on the TPM+bloblist patch have shown otherwise. I would appreciate

Re: [PATCH] arm: Remove redundant loading of image copy start offset.Because the beginning is already computed

2025-01-15 Thread Quentin Schulz
Hi Liya, On 1/15/25 2:56 AM, 1425075...@qq.com wrote: [You don't often get email from 1425075...@qq.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] From: Liya Huang <1425075...@qq.com> Please have some commit log in there justifying the change. There seem

Re: [PATCH 3/5] pxe_utils: Allow the FDT to be missing

2025-01-15 Thread Quentin Schulz
Hi Simon, On 1/15/25 2:16 AM, Simon Glass wrote: Hi Quentin, On Tue, 14 Jan 2025 at 08:13, Quentin Schulz wrote: Hi Simon, On 12/20/24 5:01 AM, Simon Glass wrote: The devicetree file may not be provided, so avoid a failure in that case. Can you provide a bit more information on when

Re: [PATCH 2/3] image: Add support for starting TFA BL31 as fitImage loadables

2025-01-15 Thread Quentin Schulz
Hi Marek, Biju, On 1/13/25 2:31 PM, Biju Das wrote: Hi Marex, -Original Message- From: Marek Vasut Sent: 13 January 2025 12:40 Subject: Re: [PATCH 2/3] image: Add support for starting TFA BL31 as fitImage loadables On 1/13/25 1:15 PM, Biju Das wrote: Hi Marex, Thanks for the patch

Re: [PATCH 0/7] board: rockchip: add FriendlyElec NanoPi R3S

2025-01-15 Thread Quentin Schulz
Hi Tianling, On 1/14/25 5:14 PM, Tianling Shen wrote: Hi Quentin, On 2025/1/14 23:21, Quentin Schulz wrote: Hi Tianling, On 1/14/25 3:49 PM, Tianling Shen wrote: Hi Quentin, On 2025/1/14 22:39, Quentin Schulz wrote: Hi Tianling, On 12/26/24 10:20 AM, Tianling Shen wrote: The NanoPi R3S

Re: [PATCH] linker_lists: Update the alignment using CONFIG_LINKER_LIST_ALIGN

2025-01-15 Thread Quentin Schulz
Hi Liya, On 1/14/25 8:09 AM, 1425075...@qq.com wrote: [You don't often get email from 1425075...@qq.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] From: Liya Huang <1425075...@qq.com> This patch updates the alignment of linker lists to use the CONFIG_LINKE

Re: [PATCH 2/3] video: rockchip: rk3328: filter unsupported modes

2025-01-15 Thread Quentin Schulz
Hi Vasily, On 1/14/25 6:24 AM, Vasily Khoruzhick wrote: While RK3328 is capable of 4K resolution, dw-hdmi driver in u-boot seems to have some issue with 4K. 1440p or lower works fine. Limit max resolution by 2560x1440x60Hz, by filtering the modes with pixel clock > 297MHz Fixes: f3ea872970d603

Re: [PATCH] Makefile: Make sure all linker input objects exist

2025-01-15 Thread Quentin Schulz
" which allows me to use HAVE_VENDOR_COMMON_LIB mechanism with an empty Makefile for TPL/SPL build stage, so: Tested-by: Quentin Schulz Looking forward to being able to use HAVE_VENDOR_COMMON_LIB! Though I could actually always include the file and just ifdef CONFIG_XPL_BUILD in common.o, but let

Re: [PATCH 8/8] arm64: renesas: Deduplicate R-Car Gen3 and Gen4 SPL

2025-01-15 Thread Quentin Schulz
, Reviewed-by: Quentin Schulz --- Cc: Adam Ford Cc: Biju Das Cc: Lad Prabhakar Cc: Nobuhiro Iwamatsu Cc: Paul Barker Cc: Simon Glass Cc: Tom Rini Cc: u-boot@lists.denx.de --- board/renesas/common/Makefile | 4 +++- board/renesas/common/gen3-spl.c | 21

Re: [PATCH 3/8] ARM: renesas: Rename common/common.c to common/rcar64-common.c

2025-01-15 Thread Quentin Schulz
Hi Marek, On 1/12/25 11:34 PM, Marek Vasut wrote: The common.c content is specific to 64-bit R-Car SoCs, rename the file to rcar64-common.c and remove R-Car 64-bit ifdeffery in the file. No functional change. Signed-off-by: Marek Vasut Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH 2/8] ARM: renesas: Simplify board Makefiles

2025-01-15 Thread Quentin Schulz
This honestly was a bit difficult to review and felt like more than one change was made at once. The #if !IS_ENABLED(CONFIG_XPL_BUILD) changes could have been made in a separate commit I believe. In any case, makes sense to me: Reviewed-by: Quentin Schulz Would have liked a link to h

Re: [PATCH 1/8] ARM: renesas: Rename board/renesas/rcar-common to board/renesas/common

2025-01-15 Thread Quentin Schulz
something like that. a preparatory patch for board Makefile simplification. No functional change so far. Signed-off-by: Marek Vasut The change is fine, but please make the commit log a bit less confusing around the use of HAVE_VENDOR_COMMON_LIB in this commit. Reviewed-by: Quentin Schulz

Re: [PATCH] doc: coolpi: Fix the defconfig name

2025-01-15 Thread Quentin Schulz
Hi Andy, On 1/13/25 11:56 AM, Andy Yan wrote: The defconfig name should be: coolpi-cm5-genbook-rk3588_defconfig Signed-off-by: Andy Yan Reviewed-by: Quentin Schulz --- doc/board/coolpi/genbook_cm5_rk3588.rst | 2 +- What about renaming every file that are inconsistent in naming

Re: [PATCH] rockchip: nanopi-r3s-rk3566: disable unneeded CONFIG_NVME_PCI

2025-01-15 Thread Quentin Schulz
Hi Tianling, On 1/15/25 6:37 AM, Tianling Shen wrote: > This board does not have any NVMe slot, so disable unneeded > CONFIG_NVME_PCI option. > > Fixes: bf4a33e725ae ("board: rockchip: add FriendlyElec NanoPi R3S") > Signed-off-by: Tianling Shen Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH 09/20] rockchip: mkimage: Add rk3576 support

2025-01-14 Thread Quentin Schulz
Hi Kever, On 1/10/25 1:54 AM, Kever Yang wrote: Hi Quentin, On 2024/11/27 00:53, Quentin Schulz wrote: Hi Heiko, On 11/21/24 3:27 PM, Heiko Stuebner wrote: From: Xuhui Lin Add support for rk3576 package header in mkimage tool. Signed-off-by: Heiko Stuebner ---   tools/rkcommon.c | 1

Re: [PATCH 0/7] board: rockchip: add FriendlyElec NanoPi R3S

2025-01-14 Thread Quentin Schulz
Hi Tianling, On 1/14/25 3:49 PM, Tianling Shen wrote: Hi Quentin, On 2025/1/14 22:39, Quentin Schulz wrote: Hi Tianling, On 12/26/24 10:20 AM, Tianling Shen wrote: The NanoPi R3S(as "R3S") is an open source platform with dual-Gbps Ethernet ports designed and developed by Friend

Re: [PATCH 3/5] pxe_utils: Allow the FDT to be missing

2025-01-14 Thread Quentin Schulz
Hi Simon, On 12/20/24 5:01 AM, Simon Glass wrote: The devicetree file may not be provided, so avoid a failure in that case. Can you provide a bit more information on when/why this shouldn't be a failure? I assume likely x86? or Aarch64 with ACPI instead of OF? Cheers, Quentin

Re: [PATCH 7/7] board: rockchip: add FriendlyElec NanoPi R3S

2025-01-14 Thread Quentin Schulz
Hi Tianling, On 12/26/24 10:20 AM, Tianling Shen wrote: The NanoPi R3S(as "R3S") is an open source platform with dual-Gbps Ethernet ports designed and developed by FriendlyElec for IoT applications. Specification: - Rockchip RK3566 - 2GB LPDDR4X RAM - optional 32GB eMMC module - SD card slot -

Re: [PATCH 0/7] board: rockchip: add FriendlyElec NanoPi R3S

2025-01-14 Thread Quentin Schulz
Hi Tianling, On 12/26/24 10:20 AM, Tianling Shen wrote: The NanoPi R3S(as "R3S") is an open source platform with dual-Gbps Ethernet ports designed and developed by FriendlyElec for IoT applications. Tianling Shen (7): arm64: dts: rockchip: Add FriendlyARM NanoPi R3S board arm64: dts: rock

Re: rpi: Compute Module 5 doesn't autoboot without debug UART

2025-01-14 Thread Quentin Schulz
Hi Gijs, On 1/2/25 3:07 PM, Gijs Peskens wrote: [You don't often get email from gijs.pesk...@munisense.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] On 12/31/24 15:53, Peter Robinson wrote: On Tue, 24 Dec 2024 at 14:00, Gijs Peskens wrote:     I'm wor

Re: [PATCH 6/6] block: Remove "select BLK" from non-block drivers

2025-01-14 Thread Quentin Schulz
Hi Tom, On 12/20/24 11:22 PM, Tom Rini wrote: Now that block drivers are all selecting the BLK symbol, there's no need for other options to be select'ing BLK so that other required functionality can be enabled. Remove these places. We have multiple commands depending on the BLK symbol. BOOTS

Re: [PATCH 5/6] mtd: Correct dependency of BLK

2025-01-14 Thread Quentin Schulz
sense to me, Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH 4/6] blk: Make block subsystems select BLK

2025-01-14 Thread Quentin Schulz
Hi Tom, On 12/20/24 11:22 PM, Tom Rini wrote: The BLK symbol has a few meanings, one of which is that it controls the driver model portion of a "block device". Rather than having this hidden symbol be "default y if ..." it should be select'd by the various block subsystems. Signed-off-by: Tom R

Re: [PATCH 2/6] drivers/mmc/Kconfig: Make DM_MMC a hidden symbol

2025-01-14 Thread Quentin Schulz
Hi Tom, On 12/20/24 11:22 PM, Tom Rini wrote: At this point in time, DM is always enabled. So if MMC is enabled, it should select DM_MMC. No drivers need to depend on DM_MMC being enabled now, so remove that from dependency lists. This now means that a number of platforms which select'd DM_MMC n

Re: [PATCH 1/6] drivers/mmc/Kconfig: Remove extraneous BLK dependencies

2025-01-14 Thread Quentin Schulz
in time, BLK defaults to enabled when MMC is enabled, so we do not With that, Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH 1/1] doc: move licenses to doc/

2025-01-14 Thread Quentin Schulz
Hi Heinrich, On 1/1/25 12:19 PM, Heinrich Schuchardt wrote: * Move all license texts to doc/ * Convert README to restructured text and rename to index.rst * Replace '+' suffix by '-or-later' suffix * The eCos-2.0 license is OSI approved. When one lists things done in a commit, it usually high

Re: [PATCH 3/3] common: fdt: hand over original fdt bootargs into board chosen handler

2025-01-14 Thread Quentin Schulz
1,14 @@ int board_rng_seed(struct abuf *buf); /** * board_fdt_chosen_bootargs() - arbitrarily amend fdt kernel command line * + * @fdt_ba: FDT chosen/bootargs from the kernel image if available + * Missing leading / /chosen/bootargs +property to highlight what this path refers to. Makes sense to me otherwise! With those changes, Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH RFC] image: apply FDTOs on FDT image node without a load property

2025-01-14 Thread Quentin Schulz
Hi Marek, On 12/19/24 7:26 PM, Marek Vasut wrote: On 12/19/24 4:03 PM, Quentin Schulz wrote: From: Quentin Schulz A FIT image which is NOT using -E when created by mkimage - that is with image data within the FIT - will fail to apply FDTO if the base FDT image node does not specify a load

[PATCH RFC] image: apply FDTOs on FDT image node without a load property

2024-12-19 Thread Quentin Schulz
From: Quentin Schulz A FIT image which is NOT using -E when created by mkimage - that is with image data within the FIT - will fail to apply FDTO if the base FDT image node does not specify a load property (which points to an address in DRAM). This is because we check that the FDT address we

Re: [PATCH v2 2/5] board_init_f(): use static calls

2024-12-18 Thread Quentin Schulz
Hi Jerome, On 12/18/24 6:38 PM, Jerome Forissier wrote: Hi Quentin, On 12/18/24 18:27, Quentin Schulz wrote: Hi Jerome, On 12/18/24 4:53 PM, Jerome Forissier wrote: Make static calls instead of iterating over the init_sequence_f arrays. Tested on a KV260 board (xilinx_zynqmp_kria_defconfig

Re: [PATCH v2 2/5] board_init_f(): use static calls

2024-12-18 Thread Quentin Schulz
Hi Jerome, On 12/18/24 4:53 PM, Jerome Forissier wrote: Make static calls instead of iterating over the init_sequence_f arrays. Tested on a KV260 board (xilinx_zynqmp_kria_defconfig). - With LTO enabled, the code size reported by bloat-o-meter is 1200 bytes less (-0.11%) - With LTO disabled,

Re: [PATCH 2/2] gitlab: Add samus_tpl to the sjg lab

2024-12-18 Thread Quentin Schulz
On 12/18/24 4:30 PM, Tom Rini wrote: On Wed, Dec 18, 2024 at 08:08:02AM -0700, Simon Glass wrote: This board has two variants, one of which boots with tpl. Labgrid gets upset when they both try to claim the same hardware, so we might need to see if we can handle that cleanly, e.g. by making t

Re: [PATCH v3 5/5] rockchip: Add support for Radxa ROCK 5C

2024-12-16 Thread Quentin Schulz
Hi Naoki, On 12/16/24 2:25 PM, FUKAUMI Naoki wrote: Hi Quentin, On 12/16/24 21:47, Quentin Schulz wrote: Hi Naoki, On 12/16/24 1:39 PM, FUKAUMI Naoki wrote: Hi Quentin, On 12/16/24 18:57, Quentin Schulz wrote: Hi Naoki, On 12/15/24 2:37 AM, FUKAUMI Naoki wrote: Hi Quentin, Thank you

Re: [PATCH v3 5/5] rockchip: Add support for Radxa ROCK 5C

2024-12-16 Thread Quentin Schulz
Hi Naoki, On 12/16/24 1:39 PM, FUKAUMI Naoki wrote: Hi Quentin, On 12/16/24 18:57, Quentin Schulz wrote: Hi Naoki, On 12/15/24 2:37 AM, FUKAUMI Naoki wrote: Hi Quentin, Thank you very much for your review! On 12/13/24 22:11, Quentin Schulz wrote: Hi Naoki, On 12/11/24 4:39 AM, FUKAUMI

Re: [PATCH v3 5/5] rockchip: Add support for Radxa ROCK 5C

2024-12-16 Thread Quentin Schulz
Hi Naoki, On 12/15/24 2:37 AM, FUKAUMI Naoki wrote: Hi Quentin, Thank you very much for your review! On 12/13/24 22:11, Quentin Schulz wrote: Hi Naoki, On 12/11/24 4:39 AM, FUKAUMI Naoki wrote: Radxa ROCK 5C[1] is a Rockchip RK3588S2 based single board computer. [1] https://eur02

[RFC] Adding bootsource and reset-source* to /chosen

2024-12-13 Thread Quentin Schulz
Hi all, In U-Boot, there are multiple stages which can be loaded from different media each. On Rockchip SoCs, it mostly goes this way, SoC BootROM loads from a medium (storage or over USB) and executes the TPL (or SPL if no TPL supported), the TPL goes back to BootROM and reads the SPL from th

Re: [PATCH 1/2] rockchip: Add initial RK3582 support

2024-12-13 Thread Quentin Schulz
Hi Jonas, On 12/13/24 4:20 PM, Jonas Karlman wrote: Hi Quentin, On 2024-12-13 14:43, Quentin Schulz wrote: Hi Jonas, On 12/10/24 11:23 PM, Jonas Karlman wrote: The RK3582 SoC is a variant of the RK3588S with some IP blocks disabled. What blocks are disabled/non-working is indicated by ip

Re: [PATCH 06/12] rockchip: rk3399-gru: Include binman generated FIT in u-boot.rom image

2024-12-13 Thread Quentin Schulz
Hi Jonas, On 12/13/24 12:57 AM, Jonas Karlman wrote: The u-boot.rom image contain u-boot.img FIT instead of the FIT generated by binman for the u-boot-rockchip.bin image. Change to include the binman generated FIT for the u-boot.rom image. This change result in TF-A being included and the use

Re: [PATCH 2/2] rockchip: rk3588-generic: Enable support for RK3582

2024-12-13 Thread Quentin Schulz
Hi Jonas, On 12/10/24 11:23 PM, Jonas Karlman wrote: Add Kconfig option OF_SYSTEM_SETUP=y to support booting boards with a RK3582 SoC. CPU and GPU cores are failed based on ip-state and policy. Tested on a ROCK 5C Lite v1.1: cpu-code: 35 82 ip-state: 10 00 00 fail gpu fail cpu cpu@

Re: [PATCH 1/2] rockchip: Add initial RK3582 support

2024-12-13 Thread Quentin Schulz
Hi Jonas, On 12/10/24 11:23 PM, Jonas Karlman wrote: The RK3582 SoC is a variant of the RK3588S with some IP blocks disabled. What blocks are disabled/non-working is indicated by ip-state in OTP. This add initial support for RK3582 by using ft_system_setup() to mark any cpu and/or gpu node with

Re: [PATCH v3 5/5] rockchip: Add support for Radxa ROCK 5C

2024-12-13 Thread Quentin Schulz
Hi Naoki, On 12/11/24 4:39 AM, FUKAUMI Naoki wrote: Radxa ROCK 5C[1] is a Rockchip RK3588S2 based single board computer. [1] https://radxa.com/products/rock5/5c Signed-off-by: FUKAUMI Naoki --- Changes in v3: - fix compile error Changes in v2: - arch/arm/dts/rk3588s-rock-5-u-boot.dtsi: remove

Re: [PATCH] boot: Use correct PHASE_ variable for expo

2024-12-09 Thread Quentin Schulz
Hi Simon, On 12/7/24 3:52 PM, Simon Glass wrote: This patch was written before the XPL change-over. Update the Makefile condition to the new way. Signed-off-by: Simon Glass Fixes: ae3b5928d61 ("x86: coreboot: Allow building an expo for...") Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH v2] board: rockchip: add Khadas Edge2 RK3588 board

2024-12-06 Thread Quentin Schulz
Hi Jacobe, On 12/4/24 10:45 AM, Jacobe Zang wrote: [You don't often get email from jacobe.z...@wesion.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] Khadas Edge2 is a Rockchip RK3588S based SBC (Single Board Computer) by Khadas. There are tree variants dep

Re: [PATCH] rockchip: rk3308-rock-s0: Fix SD-card boot on v1.1 hw revision

2024-12-06 Thread Quentin Schulz
/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v6.14-armsoc/dts64&id=b89a4235eb8cdf1b4bd2f9e4ed096d8adf8994e7 Looks good otherwise, Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH v2 2/4] net: phy: ksz90x1: Handle ksz9131 LED errata

2024-12-06 Thread Quentin Schulz
Hi Paul, On 12/5/24 7:58 PM, Paul Barker wrote: Hi Marek, Quentin, On 01/12/2024 18:57, Marek Vasut wrote: On 11/25/24 6:23 PM, Quentin Schulz wrote: [...] @@ -446,6 +474,10 @@ static int ksz9131_config(struct phy_device *phydev)   return ret;   } +    ret

Re: [PATCH v2 2/2] power: regulator: replace dev_dbg() by dev_err() in regulator_post_bind()

2024-12-03 Thread Quentin Schulz
Hi Patrice, On 12/3/24 11:06 AM, Patrice Chotard wrote: To ease debugging, use dev_err() instead of dev_dbg() for alerting when regulator has nonunique value. Signed-off-by: Patrice Chotard Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH v2 1/2] power: regulator: replace some debug() by dev_dbg()

2024-12-03 Thread Quentin Schulz
Hi Patrice, On 12/3/24 11:06 AM, Patrice Chotard wrote: Replace some debug() by dev_dbg() when dev variable is available/valid. Signed-off-by: Patrice Chotard Reviewed-by: Quentin Schulz Thanks! Quentin

[PATCH] doc: board: theobroma-systems: fix feature list in introductions

2024-12-02 Thread Quentin Schulz
From: Quentin Schulz Board introductions have a feature list which isn't formatted properly according to rST and is thus rendered incorrectly. Fix this by adding the missing newlines in the appropriate places. Signed-off-by: Quentin Schulz --- doc/board/theobroma-systems/puma_rk3399.rst

Re: [PATCH] doc: coolpi: Fix document style

2024-12-02 Thread Quentin Schulz
Hi Andy, On 12/2/24 1:03 PM, Andy Yan wrote: Add a blank line after title "Specification:" to make it render correctly html. And also remove the useless > in bash code block. Signed-off-by: Andy Yan Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH] power: regulator: replace some debug() by dev_dbg/err()

2024-12-02 Thread Quentin Schulz
two commits, one for migratin to dev_dbg and one for migrating to dev_err so we can revert one or the other and the change is explicit. (I've done a mixed find-replace a few releases ago that made some people unhappy and it would have been easier to revert just the commit that was problematic than patching things up manually :) ). The change itself is fine otherwise, so Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH] lwip: wget: Fix incorrect rebase of 5907c81 on top of 5907c81

2024-11-28 Thread Quentin Schulz
Hi Adriano, You may want to check that your commit title is appropriate here as it seems odd to me to say "rebase of commit A on top of commit A". I don't have anything else to say on that patch otherwise :) Cheers, Quentin On 11/28/24 3:37 PM, Adriano Cordova wrote: Commit 5907c81 ("net

  1   2   3   4   5   6   7   8   9   10   >