Re: [PATCH] ram: Move Kconfig options into their own menu entry

2025-06-02 Thread Quentin Schulz
.config, which is hard to read. Let's create a menu entry for these drivers. Fixes: 6c51df6859f ("dm: Add support for RAM drivers") Signed-off-by: Yao Zi Reviewed-by: Quentin Schulz --- drivers/ram/Kconfig | 4 1 file changed, 4 insertions(+) diff --git a/driver

Re: [PATCH] Revert "booti/bootm: riscv: Verify image arch type"

2025-06-02 Thread Quentin Schulz
Hi Mayuresh, On 5/29/25 5:30 AM, Mayuresh Chitale wrote: This reverts commit 37b0b22d8b7bbed6aa95b6daed06dcbf4a66f211 as discussed in [1]. [1] https://lists.denx.de/pipermail/u-boot/2025-May/590841.html I would recommend to add a little bit of context instead of simply pointing at some mail

Re: [PATCH 0/2] arm: armv7: fix a bug that prevents CONFIG_BLOBLIST and CONFIG_POSITION_INDEPENDENT to be enabled together

2025-06-02 Thread Quentin Schulz
+Cc Mikko Rapeli who's attempting to patch this in OpenEmbedded-Core On 5/31/25 3:10 PM, Yang Xiwen via B4 Relay wrote: [You don't often get email from devnull+forbidden405.outlook@kernel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] This patchset also

Re: [PATCH 1/2] dm: core: use u32 instead of int for dev_read_u32_default

2025-05-28 Thread Quentin Schulz
Hi Simon, On 5/28/25 4:32 PM, Simon Glass wrote: Hi Quentin, On Wed, 28 May 2025 at 14:06, Quentin Schulz wrote: From: Quentin Schulz dev_read_u32_default is for getting a u32 from a Device Tree property and allows to take a default value if that property is missing. Considering it calls

[PATCH 2/2] dm: core: use s32 instead of int for dev_read_s32_default

2025-05-28 Thread Quentin Schulz
From: Quentin Schulz dev_read_s32_default is for getting an s32 from a Device Tree property and allows to take a default value if that property is missing. Considering it calls ofnode_read_u32_default which takes a u32 and returns a u32, it should do the same instead of using an int, especially

[PATCH 1/2] dm: core: use u32 instead of int for dev_read_u32_default

2025-05-28 Thread Quentin Schulz
From: Quentin Schulz dev_read_u32_default is for getting a u32 from a Device Tree property and allows to take a default value if that property is missing. Considering it calls ofnode_read_u32_default which takes a u32 and returns a u32, it should do the same instead of using an int, especially

[PATCH 0/2] dm: core: use {s,u}32 instead of int for dev_read_{s,u}32_default

2025-05-28 Thread Quentin Schulz
sake, let's have them use the expected type. Note that I have not tested this, just stumbled upon that inconsistency by chance. Signed-off-by: Quentin Schulz --- Quentin Schulz (2): dm: core: use u32 instead of int for dev_read_u32_default dm: core: use s32 instead

[PATCH] power: rk8xx: fix swapped mask and value in init registers for RK806

2025-05-28 Thread Quentin Schulz
From: Quentin Schulz The val (the bits to set) is the second member of the reg_data structure and mask the third one. We obviously want to clear bits 6 and 7 in order to only set bit 7 in there instead of only clearing bit 7 in order to write bits 6 and 7 (which makes no sense). Fortunately

[PATCH] rockchip: px30: Implement checkboard() to print SoC variant

2025-05-28 Thread Quentin Schulz
From: Quentin Schulz This implements checkboard() to print the current SoC model used by a board, e.g. one of: SoC: PX30 SoC: PX30K when U-Boot proper is running. The information is read from the OTP. There's no public information as far as I know about the layout and stored informatio

Re: [PATCH] bootstd: Use -c flag with bootdev order

2025-05-26 Thread Quentin Schulz
Hi Simon, On 5/26/25 10:35 AM, Simon Glass wrote: Hi Quentin, On Mon, 26 May 2025 at 08:48, Quentin Schulz wrote: Hi Simon, On 5/24/25 7:42 AM, Simon Glass wrote: Update this command to use a -c flag rather than a special 'clear' argument. I don't see the commit which

Re: [PATCH] bootstd: Use -c flag with bootdev order

2025-05-26 Thread Quentin Schulz
Hi Simon, On 5/24/25 7:42 AM, Simon Glass wrote: Update this command to use a -c flag rather than a special 'clear' argument. I don't see the commit which adds the clear command to either master or next branch, so maybe just fix that in the original commit before sending a pull request inst

Re: [RFC v1 7/7] usb: onboard-hub: Add conditional compilation for I2C initialization

2025-05-21 Thread Quentin Schulz
Hi Michal, On 5/21/25 4:34 PM, Michal Simek wrote: On 5/12/25 09:06, Quentin Schulz wrote: Hi Anand, On 5/9/25 7:45 PM, Anand Moon wrote: Hi Quentin, On Fri, 9 May 2025 at 17:21, Quentin Schulz wrote: Hi Neil, Anand, On 5/9/25 9:57 AM, Neil Armstrong wrote: On 09/05/2025 09:02

Re: [PATCH v4 1/5] efi: stub: Define debug uart functions only if CONFIG_DEBUG_UART is enabled

2025-05-19 Thread Quentin Schulz
On 5/19/25 5:43 PM, Tom Rini wrote: On Mon, May 19, 2025 at 05:09:07PM +0200, Quentin Schulz wrote: Hi Tom, On 5/19/25 4:48 PM, Tom Rini wrote: On Thu, May 15, 2025 at 05:55:44PM +0200, Lukasz Czechowski wrote: Initialize the debug uart only in case CONFIG_DEBUG_UART is enabled. The

Re: [PATCH v4 1/5] efi: stub: Define debug uart functions only if CONFIG_DEBUG_UART is enabled

2025-05-19 Thread Quentin Schulz
Hi Tom, On 5/19/25 4:48 PM, Tom Rini wrote: On Thu, May 15, 2025 at 05:55:44PM +0200, Lukasz Czechowski wrote: Initialize the debug uart only in case CONFIG_DEBUG_UART is enabled. The _debug_uart_putc is used internally by debug uart functions, so it must be also included inside #ifdef block, o

Re: [PATCH 1/4] usb: onboard-hub: Use the ofnode to check if the peer-hub was probed

2025-05-19 Thread Quentin Schulz
Hi Anand, On 5/19/25 2:42 PM, Anand Moon wrote: Hi Lukasz, On Fri, 25 Apr 2025 at 16:32, Lukasz Czechowski wrote: Currently the check in usb_onboard_hub_bind is relying on specific compatible string for the Michrochip USB5744. Replace this with more generic approach that will allow to add ne

Re: [PATCH v4 1/1] Initial support for Wiznet W5500

2025-05-19 Thread Quentin Schulz
Hi Jean-Marie, On 5/19/25 11:05 AM, Verdun, Jean-Marie wrote: Fair enough. You could have the same ternary operator to better match what's in the kernel. Can you also reuse the macros that are in the kernel already? W5500_SPI_BLOCK_SELECT, W5500_SPI_READ_CONTROL and W5500_SPI_WRITE_CONTROL se

Re: [PATCH v4 1/1] Initial support for Wiznet W5500

2025-05-19 Thread Quentin Schulz
Hi Jean-Marie, On 5/15/25 4:01 PM, Verdun, Jean-Marie wrote: This is dangerous too. How do I know if the returned data is an error code or actual data? Right now, xfer returns 0 if successful, -1 otherwise. I would suggest return ret only if it is < 0. Or even better, propagate the erro

Re: [RFC PATCH 1/2 v2] tools: binman: control.py: Propagate bootph-* properties to supernodes

2025-05-19 Thread Quentin Schulz
Hi Moteen, On 5/19/25 11:33 AM, Moteen Shah wrote: Hey Simon and Quentin, Should I send one RFC for this for folks not using binman? If you already have code for it, sure. Otherwise, I guess whoever encounter a similar issues as yours for their boards can fix that themselves if you don't f

Re: [PATCH v4 2/5] debug_uart: Replace debug functions with dummies if CONFIG_DEBUG_UART is not set

2025-05-19 Thread Quentin Schulz
Hi Lukasz, On 5/19/25 12:32 PM, Łukasz Czechowski wrote: Hi Quentin, pt., 16 maj 2025 o 17:27 Quentin Schulz napisał(a): Hi Lukasz, On 5/15/25 5:55 PM, Lukasz Czechowski wrote: In case DEBUG UART is not used, define dummy macros replacing the actual function implementations that will not

Re: [PATCH v2] fdt: Allow expanding the devicetree during relocation

2025-05-19 Thread Quentin Schulz
Hi Simon, On 5/16/25 4:12 PM, Simon Glass wrote: Some boards set fdt_high to -1 which means that the FDT is not relocated in boot_relocate_fdt(). A comment in that function says that we assume there is space after the existing fdt to use for padding, with the padding size set to CONFIG_SYS_FDT_

Re: [PATCH] tools: fix handle leak in ifdtool.c

2025-05-19 Thread Quentin Schulz
close(new_fd) before return in write_image() if write() fails. - No close needed if open() fails (fd == -1 is invalid). Signed-off-by: Anton Moryakov Looks fine to me Reviewed-by: Quentin Schulz I believe there are a few others in that file? inject_region returns without closing, same for writ

Re: [PATCH v4 3/5] ram: rockchip: Fix dependency of RAM_ROCKCHIP_DEBUG

2025-05-16 Thread Quentin Schulz
but I do if I checkout 1/5 or 3/5). Looks good to me otherwise: Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH v4 2/5] debug_uart: Replace debug functions with dummies if CONFIG_DEBUG_UART is not set

2025-05-16 Thread Quentin Schulz
Hi Lukasz, On 5/15/25 5:55 PM, Lukasz Czechowski wrote: In case DEBUG UART is not used, define dummy macros replacing the actual function implementations that will not be available. This allows to compile code and avoid linker errors. Redefine the DEBUG_UART_FUNCS macro if DEBUG UART is not avai

Re: [PATCH v4 1/5] efi: stub: Define debug uart functions only if CONFIG_DEBUG_UART is enabled

2025-05-16 Thread Quentin Schulz
-off-by: Lukasz Czechowski Suggested-by: Quentin Schulz Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH 4/4] usb: onboard-hub: Add support for Cypress HX3 family

2025-05-16 Thread Quentin Schulz
ypress,hx3.yaml bindings. [1] https://www.infineon.com/dgdl/Infineon-HX3_USB_3_0_Hub_Consumer_Industrial-DataSheet-v22_00-EN.pdf?fileId=8ac78c8c7d0d8da4017d0ecb53f644b8 Signed-off-by: Lukasz Czechowski This matches what was recently merged in Linux, so: Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH 3/4] usb: onboard-hub: Add support for multiple power supplies

2025-05-16 Thread Quentin Schulz
Hi Lukasz, On 4/25/25 12:56 PM, Lukasz Czechowski wrote: Some of the onboard hubs require multiple power supplies, so extend the driver to support them. The implementation is inspired by the kernel driver, as introduced by commit [1] in the v6.10 kernel. [1] https://github.com/torvalds/linux/c

Re: [PATCH 2/4] usb: onboard-hub: Set the reset gpio pin before freeing

2025-05-16 Thread Quentin Schulz
udevice *dev) struct onboard_hub *hub = dev_get_priv(dev); int ret; - if (hub->reset_gpio) + if (hub->reset_gpio) { + ret = dm_gpio_set_value(hub->reset_gpio, 1); We should probably dev_err here if ret is non-0? With that done: Reviewed-by: Quentin

Re: [PATCH 1/4] usb: onboard-hub: Use the ofnode to check if the peer-hub was probed

2025-05-16 Thread Quentin Schulz
ce_find_global_by_ofnode(phandle.node, &peerdev); Wondering if uclass_find_device_by_ofnode(UCLASS_USB_HUB, phandle.node, &peerdev) wouldn't be faster/more appropriate here? Looks good in any case so: Reviewed-by: Quentin Schulz Just for general information (I assume specifically

Re: [PATCH RFC 0/4] fit: print conf node compatibles + use property string constants

2025-05-16 Thread Quentin Schulz
Hi all, On 4/9/25 5:10 PM, Quentin Schulz wrote: This does a bit of "cleanup" by reusing constants for some FIT properties instead of having the same string in multiple places. Additionally, this adds a new constant for the compatible property in FIT configuration nodes[1] which is

Re: [PATCH 1/2 v2] tools: binman: control.py: Propagate bootph-all/bootph-some-ram properties to supernodes

2025-05-16 Thread Quentin Schulz
Glass Reviewed-by: Simon Glass Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH v2 2/3] sunxi: add "fake" FEL pin support

2025-05-15 Thread Quentin Schulz
Hi Andre, On 5/12/25 2:39 PM, Andre Przywara wrote: On Tue, 22 Apr 2025 16:30:04 +0200 Quentin Schulz wrote: Hi Quentin, just found this in my draft folder. It's not really related to this patch anymore, but you seemed to be interested, and I am happy to explain some of the specialitie

Re: [PATCH RFC] fit: allow to specify RSAPSS padding salt length magic value

2025-05-15 Thread Quentin Schulz
Hi all, Gentle ping, anything to say/suggest? Cheers, Quentin On 4/11/25 6:32 PM, Quentin Schulz wrote: From: Quentin Schulz Before commit 1b99c15d73c1 ("lib: rsa: Set conventional salt length RSA-PSS parameter"), the salt length for PSS padding was openSSL's default. Prior

Re: [RFC PATCH 1/3] spl: Kconfig: allow to enable SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR for i.MX8M

2025-05-15 Thread Quentin Schulz
On 5/15/25 4:30 PM, Tom Rini wrote: On Thu, May 15, 2025 at 03:26:18PM +0200, Quentin Schulz wrote: Hi Dario, On 5/15/25 3:12 PM, Dario Binacchi wrote: Commit 2a00d73d081a ("spl: mmc: Try to clean up raw-mode options") breaks the boot of the BSH SMM S2 board. As stated in the com

Re: [PATCH v2 2/2] arm: imx: imx8m: soc: replace ifdef by IS_ENABLED()

2025-05-15 Thread Quentin Schulz
d checking that the output is bit to bit identical (you may need to change the SOURCE_DATE_EPOCH to guarantee that though? Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [RFC PATCH 1/3] spl: Kconfig: allow to enable SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR for i.MX8M

2025-05-15 Thread Quentin Schulz
Hi Dario, On 5/15/25 3:12 PM, Dario Binacchi wrote: Commit 2a00d73d081a ("spl: mmc: Try to clean up raw-mode options") breaks the boot of the BSH SMM S2 board. As stated in the commit itself, "Some boards use this value even though MMC is not enabled in SPL, for example imx8mn_bsh_smm_s2". The s

Re: [PATCH 1/2] tools: binman: control.py: Propagate bootph-* properties to supernodes

2025-05-15 Thread Quentin Schulz
Hi Moteen, On 5/15/25 11:01 AM, Moteen Shah wrote: Hey Quentin, On 14/05/25 21:42, Quentin Schulz wrote: Hi Moteen, On 5/14/25 8:05 AM, Moteen Shah wrote: Hey Quentin, Thanks for the review. On 13/05/25 16:10, Quentin Schulz wrote: Hi Moteen, On 5/12/25 1:50 PM, Moteen Shah wrote: Add a

Re: [PATCH] arm: imx: imx8m: soc: fix the macro name

2025-05-15 Thread Quentin Schulz
) -#ifdef SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION +#ifdef CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION Maybe a good opportunity to switch to #if IS_ENABLED(CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION) ? Reviewed-by: Quentin Schulz I had a random idea but I'm wondering if there's a way

Re: [PATCH 1/1] tools: mkimage: validate image references in FIT configurations

2025-05-15 Thread Quentin Schulz
Hi Simon, On 5/14/25 9:44 PM, Simon Glass wrote: Hi, On Tue, 13 May 2025 at 17:28, Quentin Schulz wrote: Hi Aristo, On 5/5/25 12:08 PM, Aristo Chen wrote: When parsing a FIT image source (ITS), mkimage does not currently check whether the image names referenced in the /configurations

[PATCH 3/4] configs: tiger-rk3588: enable exFAT support

2025-05-14 Thread Quentin Schulz
From: Quentin Schulz Our upcoming Mass Flasher solution will be storing boot artifacts on an exFAT partition so enable its support. Signed-off-by: Quentin Schulz --- configs/tiger-rk3588_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/tiger-rk3588_defconfig b/configs

[PATCH 2/4] configs: jaguar-rk3588: enable exFAT support

2025-05-14 Thread Quentin Schulz
From: Quentin Schulz Our upcoming Mass Flasher solution will be storing boot artifacts on an exFAT partition so enable its support. Signed-off-by: Quentin Schulz --- configs/jaguar-rk3588_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/jaguar-rk3588_defconfig b/configs

[PATCH 4/4] configs: puma-rk3399: enable exFAT support

2025-05-14 Thread Quentin Schulz
From: Quentin Schulz Our upcoming Mass Flasher solution will be storing boot artifacts on an exFAT partition so enable its support. Signed-off-by: Quentin Schulz --- configs/puma-rk3399_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/puma-rk3399_defconfig b/configs/puma

[PATCH 0/4] rockchip: enable exFAT support for Theobroma products

2025-05-14 Thread Quentin Schulz
Our upcoming Mass Production Flasher solution will be storing boot artifacts on an exFAT partition so enable its support for all our products. Signed-off-by: Quentin Schulz --- Quentin Schulz (4): configs: ringneck-px30: enable exFAT support configs: jaguar-rk3588: enable exFAT

[PATCH 1/4] configs: ringneck-px30: enable exFAT support

2025-05-14 Thread Quentin Schulz
From: Quentin Schulz Our upcoming Mass Flasher solution will be storing boot artifacts on an exFAT partition so enable its support. Signed-off-by: Quentin Schulz --- configs/ringneck-px30_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/ringneck-px30_defconfig b/configs

Re: [PATCH 1/2] tools: binman: control.py: Propagate bootph-* properties to supernodes

2025-05-14 Thread Quentin Schulz
Hi Moteen, On 5/14/25 8:05 AM, Moteen Shah wrote: Hey Quentin, Thanks for the review. On 13/05/25 16:10, Quentin Schulz wrote: Hi Moteen, On 5/12/25 1:50 PM, Moteen Shah wrote: Add a function to scan through all the nodes in the device-tree for bootph-* property. If found, propagate it to

Re: [RFC v1 7/7] usb: onboard-hub: Add conditional compilation for I2C initialization

2025-05-13 Thread Quentin Schulz
Hi Anand, On 5/13/25 6:14 PM, Anand Moon wrote: Hi All, On Mon, 12 May 2025 at 13:51, Anand Moon via groups.io wrote: Hi Quentin, On Mon, 12 May 2025 at 12:36, Quentin Schulz wrote: Hi Anand, On 5/9/25 7:45 PM, Anand Moon wrote: Hi Quentin, On Fri, 9 May 2025 at 17:21, Quentin Schulz

Re: [PATCH 1/1] tools: mkimage: validate image references in FIT configurations

2025-05-13 Thread Quentin Schulz
Hi Aristo, On 5/5/25 12:08 PM, Aristo Chen wrote: When parsing a FIT image source (ITS), mkimage does not currently check whether the image names referenced in the /configurations section (e.g. "kernel", "fdt", "ramdisk", "loadables") actually exist in the /images node. This patch introduces a

Re: [PATCH 1/2] tools: binman: control.py: Propagate bootph-* properties to supernodes

2025-05-13 Thread Quentin Schulz
Hi Moteen, On 5/12/25 1:50 PM, Moteen Shah wrote: Add a function to scan through all the nodes in the device-tree for bootph-* property. If found, propagate it to all of its parent It's not scanning for bootph-* properties. It's scanning for two specific bootph properties, so try to update th

Re: [PATCH 2/2] tools: binman: ftest.py: Add testcase for bootph-* propagation

2025-05-13 Thread Quentin Schulz
Hi Moteen, On 5/12/25 1:50 PM, Moteen Shah wrote: Add a testcase to ensure that scan_and_prop_bootph() actually propagates bootph-* properties to supernodes. Signed-off-by: Moteen Shah Signed-off-by: Simon Glass --- tools/binman/ftest.py | 22 ++ tools/b

Re: [PATCH] doc: pytest: Use globing for test files

2025-05-13 Thread Quentin Schulz
Hi Tom, On 5/12/25 11:54 PM, Tom Rini wrote: After the original series was merged, Quentin noted that we could handle adding additional tests more easily by using the glob feature. Do so. Suggested-by: Quentin Schulz Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH] ARM: Align image end to 8 bytes to fit DT alignment

2025-05-12 Thread Quentin Schulz
Hi Marek, On 5/12/25 6:10 PM, Marek Vasut wrote: Align U-Boot image end to 8 bytes to make sure DT alignment requirement is fulfilled. This fixes a possible failure in fdt_find_separate() in case the U-Boot image is aligned to 4 Bytes and DT is appended at the end at already 8 Byte aligned offse

Re: [PATCH v2 3/6] arm64: dts: allwinner: a100: Add CPU Operating Performance Points table

2025-05-12 Thread Quentin Schulz
Hi Andre, On 5/12/25 12:46 PM, Andre Przywara wrote: On Mon, 12 May 2025 11:24:07 +0200 Quentin Schulz wrote: Hi Andre, On 5/11/25 3:10 AM, Andre Przywara wrote: Add an Operating Performance Points table for the CPU cores to enable Dynamic Voltage & Frequency Scaling on the A100. Si

Re: [PATCH v2 2/4] doc: pytest: Framework for documenting tests and document test_000_version

2025-05-12 Thread Quentin Schulz
Hi Tom, On 5/12/25 4:07 PM, Tom Rini wrote: On Mon, May 12, 2025 at 11:12:50AM +0200, Quentin Schulz wrote: Hi Tom, On 5/8/25 12:08 AM, Tom Rini wrote: In order to easily document pytests, we need to include the autodoc extension. We also need to make sure that for building the docs, CI

Re: [PATCH] doc: document test command

2025-05-12 Thread Quentin Schulz
Hi Rasmus, On 5/12/25 11:31 AM, Rasmus Villemoes wrote: On Mon, May 12 2025, Quentin Schulz wrote: Hi Rasmus, Hi Quentin Thanks for the review. On 5/6/25 10:54 PM, Rasmus Villemoes wrote: + +Numbers +~~~ + +The number comparison operators ``-lt``, ``-le``, ``-gt``, ``-gt``, +``-eq

Re: [PATCH v4 1/1] Initial support for Wiznet W5500

2025-05-12 Thread Quentin Schulz
Hi Neil, Jean-Marie, On 5/12/25 10:10 AM, neil.armstr...@linaro.org wrote: Hi, Thanks for fixing it ! On 11/05/2025 20:02, ver...@hpe.com wrote: From: Jean-Marie Verdun Add support for the Wiznet W5500 spi to ethernet controller Signed-off-by: Jean-Marie Verdun ---   drivers/net/Kconfig 

Re: [PATCH v2 3/6] arm64: dts: allwinner: a100: Add CPU Operating Performance Points table

2025-05-12 Thread Quentin Schulz
Hi Andre, On 5/11/25 3:10 AM, Andre Przywara wrote: Add an Operating Performance Points table for the CPU cores to enable Dynamic Voltage & Frequency Scaling on the A100. Signed-off-by: Shuosheng Huang [masterr3c0rd@epochal.quest: fix typos in -cpu-opp, use compatible] Signed-off-by: Cody Eksa

Re: [PATCH v2 1/6] sunxi: A133: add DRAM init code

2025-05-12 Thread Quentin Schulz
Hi Andre, On 5/11/25 3:09 AM, Andre Przywara wrote: From: Cody Eksal This adds preliminary support for the DRAM controller in the Allwinner A100/A133 SoCs. This is work in progress, and has rough edges, but works on at least three different boards. It contains support for DDR4 and LPDDR4. [An

Re: [PATCH v2 2/4] doc: pytest: Framework for documenting tests and document test_000_version

2025-05-12 Thread Quentin Schulz
Hi Tom, On 5/8/25 12:08 AM, Tom Rini wrote: In order to easily document pytests, we need to include the autodoc extension. We also need to make sure that for building the docs, CI includes pytest and that we have PYTHONPATH configured such that it will find all of the tests and related files. Fi

Re: [PATCH] doc: document test command

2025-05-12 Thread Quentin Schulz
Hi Rasmus, On 5/6/25 10:54 PM, Rasmus Villemoes wrote: Add documentation for the test command, including the newly added =~ operator and some gotchas wrt. the numeric comparisons. Signed-off-by: Rasmus Villemoes --- This should be considered on top of https://lore.kernel.org/u-boot/2025050614

Re: [RFC v1 7/7] usb: onboard-hub: Add conditional compilation for I2C initialization

2025-05-12 Thread Quentin Schulz
Hi Anand, On 5/9/25 7:45 PM, Anand Moon wrote: Hi Quentin, On Fri, 9 May 2025 at 17:21, Quentin Schulz wrote: Hi Neil, Anand, On 5/9/25 9:57 AM, Neil Armstrong wrote: On 09/05/2025 09:02, Anand Moon wrote: Add conditional compilation for the usb5744_i2c_init() function based on the

Re: [PATCH 09/10] dts: upstream: arm: st: add STM32H747 discovery board

2025-05-09 Thread Quentin Schulz
Hi Johannes, On 5/8/25 11:24 PM, Johannes Krottmayer wrote: Add initial device tree for the STM32H747 discovery board. Copied from the STM32H743 discovery board and modified for the STM32H747 discovery board. Signed-off-by: Johannes Krottmayer Cc: Patrick Delaunay Cc: Patrice Chotard --- d

Re: [RFC v1 7/7] usb: onboard-hub: Add conditional compilation for I2C initialization

2025-05-09 Thread Quentin Schulz
Hi Neil, Anand, On 5/9/25 9:57 AM, Neil Armstrong wrote: On 09/05/2025 09:02, Anand Moon wrote: Add conditional compilation for the usb5744_i2c_init() function based on the CONFIG_DM_I2C configuration, to avoid compilation failure.    CC  net/net-common.o    AR  net/built-in.o    LDS  

Re: [PATCH 1/1] doc: correct link to QEMU

2025-05-09 Thread Quentin Schulz
Hi Heinrich, On 5/9/25 8:39 AM, Heinrich Schuchardt wrote: %s/hhttps:/https:/ Signed-off-by: Heinrich Schuchardt Reviewed-by: Quentin Schulz Thanks! Quentin

Re: Adding Device Tree Overlays for MIPI-CSI2 Camera and libcamera to u-boot in a buildroot or Yocto Build

2025-05-08 Thread Quentin Schulz
Hi Will, On 5/7/25 6:30 PM, u-b...@cairnwater.com wrote: [You don't often get email from u-b...@cairnwater.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] Hi, Does anyone have any advice on how to add DTOs needed by libcamera to a u-boot in a buildroot or Y

[PATCH v2] Add 'bootsource' /chosen property

2025-05-05 Thread Quentin Schulz
From: Quentin Schulz Bootloaders typically can be loaded from different storage media, such as eMMC, SD card, SPI flash, EEPROM, but also from non-persistent media such as USB (via proprietary protocols loading directly into SRAM, or fastboot, DFU, etc..), JTAG, ... This information is usually

[PATCH v3 2/2] rockchip: rk3288: do not generate u-boot.rom anymore

2025-05-05 Thread Quentin Schulz
From: Quentin Schulz This was only used on RK3288 Chromebooks and the EVB. If it follows the same pattern as for RK3399 Chromebooks where their maintainer (Simon) agreed[1] to removal of u-boot.rom on the basis that the generic u-boot-rockchip-spi.bin is now enough, let's do the same for R

[PATCH v3 1/2] rockchip: rk3399: do not generate u-boot.rom anymore

2025-05-05 Thread Quentin Schulz
From: Quentin Schulz This was only used on RK3399 Gru Chromebooks and their maintainer (Simon) agreed[1] to its removal on the basis that the generic u-boot-rockchip-spi.bin is now enough, so let's do that. At the same time, remove HAS_ROM symbol from the Gru Chromebooks config since they

[PATCH v3 0/2] rockchip: remove u-boot.rom generation

2025-05-05 Thread Quentin Schulz
st. [1] https://lore.kernel.org/u-boot/caflszth-sewfod8deof3+e-wce1qff0cyxxr8cbqwy3brw3...@mail.gmail.com Signed-off-by: Quentin Schulz --- Changes in v3: - removed patch 3 as it's now handled by fit templates, in another series about to be merged, (https://lore.kernel.org/u-boot/20250413195949.4327

Re: [PATCH v2 00/13] pinctrl: rockchip: fix editing const struct + constify rockchip_pin_ctrl

2025-05-05 Thread Quentin Schulz
Hi Kever, On 1/31/25 11:31 AM, Quentin Schulz wrote: While testing some WIP work done by Ilias Apalodimas on guaranteeing read-only memory areas truly are handled as read-only[1], my RK3588 Tiger couldn't reach U-Boot CLI anymore because of the pinctrl driver modifying a const s

Re: [PATCH v3 1/4] debug_uart: Replace debug functions with dummies if CONFIG_DEBUG_UART is not set

2025-05-05 Thread Quentin Schulz
Hi Łukasz, On 1/17/25 5:18 PM, Quentin Schulz wrote: Hi Łukasz, Kever, On 11/27/24 11:21 PM, Łukasz Czechowski wrote: Hi Kever, On 2024/11/27 03:42 Kever Yang wrote: Hi Lukasz,   I got a new error base on patch [1], see full log here [2]. Looking at the file efi_stub.c that is used

Re: [PATCH next RFC 0/5] rockchip: panic() when DRAM init fails

2025-05-05 Thread Quentin Schulz
Hi Kever, On 11/5/24 6:21 PM, Quentin Schulz wrote: I am the unfortunate owner of an RK3399 Puma that is failing DRAM init every now and then with the following cryptic error message: """ pctl_start: Failed to init pctl channel 0 """ When it fails, the current

Re: [PATCH v2 15/18] bootstd: Provide a command to select the bootdev order

2025-05-05 Thread Quentin Schulz
Hi Simon, On 5/1/25 3:37 PM, Simon Glass wrote: [...] diff --git a/boot/bootstd-uclass.c b/boot/bootstd-uclass.c index 9bee73ead58..294865feb64 100644 --- a/boot/bootstd-uclass.c +++ b/boot/bootstd-uclass.c @@ -6,6 +6,8 @@ * Written by Simon Glass */ +#define LOG_CATEGORY UCLASS_BOOTST

Re: [PATCH 1/2] mmc: rockchip_dw_mmc: Enable by default for all supported SoCs

2025-04-29 Thread Quentin Schulz
Hi Chen-Yu, On 4/29/25 7:34 PM, Chen-Yu Tsai wrote: On Wed, Apr 30, 2025 at 12:30 AM Quentin Schulz wrote: Hi Chen-Yu, On 4/29/25 5:44 PM, Chen-Yu Tsai wrote: From: Chen-Yu Tsai The rockchip_dw_mmc driver supports the MMC controller found in Rockchip SoCs. This controller is used for the

Re: [PATCH 2/2] mmc: rockchip_sdhci: Enable by default for all supported SoCs

2025-04-29 Thread Quentin Schulz
Hi Chen-Yu, On 4/29/25 5:44 PM, Chen-Yu Tsai wrote: From: Chen-Yu Tsai The rockchip_sdhci driver supports the alternative MMC controller found in newer Rockchip SoCs. This controller is used for eMMC. Almost all defconfigs for Rockchip platforms with this controller have it enabled. Enable it

Re: [PATCH 1/2] mmc: rockchip_dw_mmc: Enable by default for all supported SoCs

2025-04-29 Thread Quentin Schulz
Hi Chen-Yu, On 4/29/25 5:44 PM, Chen-Yu Tsai wrote: From: Chen-Yu Tsai The rockchip_dw_mmc driver supports the MMC controller found in Rockchip SoCs. This controller is used for the SD card on all SoCs and eMMC on older SoCs. Almost all defconfigs for Rockchip platforms have this enabled. Ena

Re: [PATCH 2/2] tools: Update the license specifiers

2025-04-29 Thread Quentin Schulz
Hi Tom, On 4/29/25 3:52 PM, Tom Rini wrote: On Tue, Apr 29, 2025 at 03:28:35PM +0200, Quentin Schulz wrote: Hi Simon, On 4/29/25 3:15 PM, Simon Glass wrote: Recent versions of Python complain about the license being in the I believe this isn't related to Python but rather setup

Re: [PATCH 1/2] tools/make_pip.sh: Use debian packages instead of pip

2025-04-29 Thread Quentin Schulz
Hi Simon, On 4/29/25 3:15 PM, Simon Glass wrote: Recent distros complain about using 'pip install'. Adjust the script to use 'apt get' instead where possible/required (e.g. with Ubuntu 24.04). I believe this should already be handled by 9d3f1ebaf875 ("tools/make_pip: Use venv when invoking p

Re: [PATCH 2/2] tools: Update the license specifiers

2025-04-29 Thread Quentin Schulz
Hi Simon, On 4/29/25 3:15 PM, Simon Glass wrote: Recent versions of Python complain about the license being in the I believe this isn't related to Python but rather setuptools. setuptools 77.0.3 and later support PEP-639 which recommends to ditch the License :: classifier for a license prope

Re: [PATCH] doc: fix typo

2025-04-24 Thread Quentin Schulz
Hi Aristo, On 4/24/25 11:14 AM, Aristo Chen wrote: Fix typo from "to" to "do" Signed-off-by: Aristo Chen Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH v2 2/2] binman: etype: u_boot_spl_pubkey_dtb: provide more explicit error for key-name-hint with path

2025-04-24 Thread Quentin Schulz
Hi Simon, On 4/23/25 2:27 PM, Simon Glass wrote: Hi Quentin, On Tue, 22 Apr 2025 at 02:53, Quentin Schulz wrote: Hi Simon, On 4/18/25 7:19 PM, Simon Glass wrote: On Fri, 18 Apr 2025 at 05:26, Quentin Schulz wrote: From: Quentin Schulz key-name-hint property in u-boot-spl-pubkey-dtb

Re: Wiznet w5500 support

2025-04-24 Thread Quentin Schulz
Hi Jean-Marie, On 4/23/25 4:37 PM, Verdun, Jean-Marie wrote: You don't often get email from ver...@hpe.com. Learn why this is important Hi Quentin, I was looking for example like the one in pmic. I will refactor my code to take it into considerat

Re: Wiznet w5500 support

2025-04-23 Thread Quentin Schulz
Hi Jean-Marie, On 4/22/25 8:36 PM, Verdun, Jean-Marie wrote: [You don't often get email from ver...@hpe.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] Hi, I have written a small patch for the wiznet W5500 adapter. (https://docs.wiznet.io/Product/iEthernet

Re: [PATCH v2 2/3] sunxi: add "fake" FEL pin support

2025-04-22 Thread Quentin Schulz
Hi Andre, On 4/22/25 2:11 PM, Andre Przywara wrote: On Tue, 22 Apr 2025 12:49:40 +0200 Quentin Schulz wrote: Hi, Hi Andre and Yixun Lan, On 4/21/25 11:29 PM, Andre Przywara wrote: On Fri, 18 Apr 2025 13:28:23 +0200 Quentin Schulz wrote: Hi Quentin, thanks for having a look! Hi

Re: [PATCH v2 2/3] sunxi: add "fake" FEL pin support

2025-04-22 Thread Quentin Schulz
Hi Andre and Yixun Lan, On 4/21/25 11:29 PM, Andre Przywara wrote: On Fri, 18 Apr 2025 13:28:23 +0200 Quentin Schulz wrote: Hi Quentin, thanks for having a look! Hi Andre, On 4/17/25 2:05 AM, Andre Przywara wrote: Some boards with Allwinner SoCs feature a "FEL" key, some

Re: [PATCH] doc: remove duplicated "commands"

2025-04-22 Thread Quentin Schulz
Hi Aristo, On 4/20/25 4:39 PM, Aristo Chen wrote: [You don't often get email from jj251510319...@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] The "commands" are duplicated, so remove one of them Signed-off-by: Aristo Chen Revie

Re: [PATCH v2 2/2] binman: etype: u_boot_spl_pubkey_dtb: provide more explicit error for key-name-hint with path

2025-04-22 Thread Quentin Schulz
Hi Simon, On 4/18/25 7:19 PM, Simon Glass wrote: On Fri, 18 Apr 2025 at 05:26, Quentin Schulz wrote: From: Quentin Schulz key-name-hint property in u-boot-spl-pubkey-dtb binman entry may contain a path instead of a filename due to user mistake. Because we currently assume it is a filename

Re: [PATCH] tools: Fix memory and descriptor leak

2025-04-18 Thread Quentin Schulz
Hi, On 4/18/25 10:19 AM, ant.v.morya...@gmail.com wrote: From: Maks Mishin Signed-off-by: Maks Mishin Same remark as for the first patch in this series, are you Maks? If no, we need your Signed-off-by too. --- tools/zynqmpbif.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(

Re: [PATCH v2 1/3] buildman: allow specifying configuration fragments

2025-04-18 Thread Quentin Schulz
Hi Heinrich, On 4/18/25 4:17 PM, Heinrich Schuchardt wrote: Quentin Schulz schrieb am Fr., 18. Apr. 2025, 15:52: Hi Simon, On 4/18/25 1:39 PM, Simon Glass wrote: Hi Quentin, On Fri, 18 Apr 2025 at 05:27, Quentin Schulz wrote: Hi Heinrich, On 4/17/25 12:40 AM, Heinrich Schuchardt

Re: [PATCH] tools: Fix potential memory leak in aisimage.c

2025-04-18 Thread Quentin Schulz
Hi, On 4/18/25 10:19 AM, ant.v.morya...@gmail.com wrote: From: Maks Mishin We don't really like empty commit logs, could you please provide some information on what this fixes and how? e.g. here you could say something along the lines of: line gets realloc'ed in getline() so we need to f

Re: [PATCH] tools: image-host: Fix potential memory leak

2025-04-18 Thread Quentin Schulz
Hi, On 4/18/25 10:30 AM, ant.v.morya...@gmail.com wrote: From: Maks Mishin Signed-off-by: Maks Mishin --- tools/image-host.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/image-host.c b/tools/image-host.c index 4a24dee8..453cd38f 100644 --- a/tools/image-

Re: [PATCH v2 1/3] buildman: allow specifying configuration fragments

2025-04-18 Thread Quentin Schulz
Hi Simon, On 4/18/25 1:39 PM, Simon Glass wrote: Hi Quentin, On Fri, 18 Apr 2025 at 05:27, Quentin Schulz wrote: Hi Heinrich, On 4/17/25 12:40 AM, Heinrich Schuchardt wrote: Currently we are no able to build with configuration fragments in our CI. With this patch buildman gets a new

Re: [PATCH] tools: image-host: Fix potential memory leak

2025-04-18 Thread Quentin Schulz
Hi, On 4/18/25 10:19 AM, ant.v.morya...@gmail.com wrote: From: Maks Mishin Signed-off-by: Maks Mishin --- tools/image-host.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/image-host.c b/tools/image-host.c index 4a24dee8..6b17b810 100644 --- a/tools/image-

Re: [PATCH] scripts: Fix potential null-deref

2025-04-18 Thread Quentin Schulz
Hi Maks(?) On 4/18/25 10:19 AM, ant.v.morya...@gmail.com wrote: From: Maks Mishin Signed-off-by: Maks Mishin This seems to differ from the sender. Are you Maks? If not, you need to add your Signed-off-by to fulfill the DCO requirements. --- scripts/kconfig/menu.c | 6 -- 1 file c

Re: [PATCH v2 1/3] buildman: allow specifying configuration fragments

2025-04-18 Thread Quentin Schulz
Hi Heinrich, On 4/17/25 12:40 AM, Heinrich Schuchardt wrote: Currently we are no able to build with configuration fragments in our CI. With this patch buildman gets a new argument --fragments for passing a comma separated list of configuration fragments to add to the board defconfigs, e.g.

[PATCH v2 2/2] binman: etype: u_boot_spl_pubkey_dtb: provide more explicit error for key-name-hint with path

2025-04-18 Thread Quentin Schulz
From: Quentin Schulz key-name-hint property in u-boot-spl-pubkey-dtb binman entry may contain a path instead of a filename due to user mistake. Because we currently assume it is a filename instead of a path, binman will find the full path to the key based on that path, and return the dirname of

Re: [PATCH] clk: fixed-rate: Use "clock-output-names" to name fixed clocks

2025-04-18 Thread Quentin Schulz
Hi Fabio, On 4/17/25 2:31 PM, Fabio Estevam wrote: From: Fabio Estevam Currently, fixed-rate clocks in U-Boot are named based on their devicetree node names. For example, given the following node: osc_24m: clock-osc-24m { compatible = "fixed-clock"; #clock-cells = <0>;

Re: [PATCH v2 2/3] sunxi: add "fake" FEL pin support

2025-04-18 Thread Quentin Schulz
Hi Andre, On 4/17/25 2:05 AM, Andre Przywara wrote: Some boards with Allwinner SoCs feature a "FEL" key, sometimes also labelled "uboot", which triggers the BootROM FEL mode, when pressed upon power-on or reset. This allows to access the SoC's memory via USB OTG, and to upload and execute code.

[PATCH v2 1/2] binman: etype: fit: raise ValueError if key-name-hint is a path

2025-04-18 Thread Quentin Schulz
From: Quentin Schulz mkimage doesn't fail if it cannot find the public key but it prints to stderr. Considering that btool.run() discards stderr, it means binman happily returns an unsigned FIT and doesn't tell you something went wrong. Binman will actually find the file if there&#

[PATCH v2 0/2] binman: properly error out if path provided to key-name-hint in signature nodes

2025-04-18 Thread Quentin Schulz
it isn't found but we can have a better error message. Signed-off-by: Quentin Schulz --- Changes in v2: - added tests, - fixed typo in docstring, - synced both error messages, - Link to v1: https://lore.kernel.org/r/20250414-binman-pubkey-dir-v1-0-0784d54ac...@cherry.de --- Quentin Schu

Re: [PATCH v2] tools/make_pip: Use venv when invoking pip

2025-04-16 Thread Quentin Schulz
Hi Mattijs, On 4/16/25 5:06 PM, Mattijs Korpershoek wrote: On mer., avril 16, 2025 at 16:26, Quentin Schulz wrote: Hi Mattijs, On 4/16/25 4:21 PM, Mattijs Korpershoek wrote: Hi Quentin, Thank you for the review. On mer., avril 16, 2025 at 14:47, Quentin Schulz wrote: Hi Mattijs, On

Re: [PATCH v2] tools/make_pip: Use venv when invoking pip

2025-04-16 Thread Quentin Schulz
Hi Mattijs, On 4/16/25 4:21 PM, Mattijs Korpershoek wrote: Hi Quentin, Thank you for the review. On mer., avril 16, 2025 at 14:47, Quentin Schulz wrote: Hi Mattijs, On 4/16/25 2:36 PM, Mattijs Korpershoek wrote: Recent Ubuntu versions (24.04+) disallow pip by default when installing

  1   2   3   4   5   6   7   8   9   10   >