Hi, On 4/18/25 10:19 AM, [email protected] wrote:
From: Maks Mishin <[email protected]>
We don't really like empty commit logs, could you please provide some information on what this fixes and how?
e.g. here you could say something along the lines of: line gets realloc'ed in getline() so we need to free it.
Signed-off-by: Maks Mishin <[email protected]>
Same remark as other patches in this series, are you Maks? If no, we need an additional Signed-off-by, yours.
--- tools/aisimage.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/aisimage.c b/tools/aisimage.c index b8b3ee32..6091c8d5 100644 --- a/tools/aisimage.c +++ b/tools/aisimage.c @@ -346,6 +346,7 @@ static int aisimage_generate(struct image_tool_params *params, }}+ free(line); fclose(fd);aishdr = ais_copy_image(params, aishdr);
The change seems fine to me though. Cheers, Quentin
