Hi Simon,
On 4/18/25 7:19 PM, Simon Glass wrote:
On Fri, 18 Apr 2025 at 05:26, Quentin Schulz <foss+ub...@0leil.net> wrote:
From: Quentin Schulz <quentin.sch...@cherry.de>
key-name-hint property in u-boot-spl-pubkey-dtb binman entry may contain
a path instead of a filename due to user mistake.
Because we currently assume it is a filename instead of a path, binman
will find the full path to the key based on that path, and return the
dirname of the full path but keeps the path in key-name-hint instead of
stripping the directories from it.
This means mkimage will fail with the following error message if we have
key-name-hint set to keys/dev:
binman: Error 1 running 'fdt_add_pubkey -a sha256,rsa2048 -k
/home/qschulz/work/upstream/u-boot/keys -n keys/dev -r conf
/home/qschulz/work/upstream/u-boot/build/ringneck/u-boot-spl-dtbdhsfx3mf':
Couldn't open RSA certificate:
'/home/qschulz/work/upstream/u-boot/keys/keys/dev.crt': No such file or
directory
Let's make it a bit more obvious what the error is by erroring out in
binman if a path is provided in key-name-hint (it is named key-name-hint
and not key-path-hint after all).
Fixes: 5609843b57a4 ("binman: etype: Add u-boot-spl-pubkey-dtb etype")
Signed-off-by: Quentin Schulz <quentin.sch...@cherry.de>
---
tools/binman/etype/u_boot_spl_pubkey_dtb.py | 2 ++
tools/binman/ftest.py | 7 +++++++
.../binman/test/348_key_name_hint_dir_spl_pubkey_dtb.dts | 16 ++++++++++++++++
3 files changed, 25 insertions(+)
Reviewed-by: Simon Glass <s...@chromium.org>
The change log seems to be missing?
The change log?
Between v1 and v2? It's in the cover letter of the series, this is how
b4 handles it, not per-patch change log.
Or are you talking about another change log I am currently unaware of?
Cheers,
Quentin
