Hi Dario,

On 5/15/25 3:12 PM, Dario Binacchi wrote:
Commit 2a00d73d081a ("spl: mmc: Try to clean up raw-mode options") breaks
the boot of the BSH SMM S2 board. As stated in the commit itself, "Some
boards use this value even though MMC is not enabled in SPL, for example
imx8mn_bsh_smm_s2". The same commit makes SPL_SYS_MMCSD_RAW_MODE depend
on SPL_DM_MMC || SPL_MMC. With SPL_SYS_MMCSD_RAW_MODE unset, it is not
possible to enable SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR, thus breaking
the board's boot process.

The patch once again allows SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR to be
selected also for boards that do not use MMC, in this case on the i.MX8M
platform.


Why would you use SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR if you don't have any MMC? Shouldn't we rather fix the incorrect usage of this variable to be something else (or better guarded?).

Cheers,
Quentin

Reply via email to