Hello Heiko,
On 6/28/19 3:43 PM, Heiko Schocher wrote:
>
> I fixed that, also this and patch 1/2 has some style issues:
>
> ERROR: Please use git commit description style 'commit <12+ chars of
> sha1> ("")' - ie: 'commit fatal: mehrd ("1': unbekannter
> Commit oder Pfad existiert nicht")'
> #127
Hi,
On 6/28/19 3:08 PM, Melin Tomas wrote:
> Prior to starting a new transfer, conditionally wait for bus to not
> be busy.
>
> Reinitialise controller as otherwise operation is not stable.
> For reference, see linux kernel commit: 9656eeebf3f1 ("i2c: Revert
> "i2c: x
Prior to starting a new transfer, conditionally wait for bus to not
be busy.
Reinitialise controller as otherwise operation is not stable.
For reference, see linux kernel commit: 9656eeebf3f1 ("i2c: Revert
"i2c: xiic: Do not reset controller before every transfer"")
Signed-off-by: Tomas Melin
--
Comparison should be against the actual message length, not loop index.
len is used for stopping while loop, pos is position in message.
stop should be sent when entire message is sent, not when
len and pos meet.
Signed-off-by: Tomas Melin
---
Changes in v2:
- Added reasoning to commit message
Hi,
+ Richard, Ben
On 6/27/19 3:05 PM, Heiko Schocher wrote:
> Hi Marek, Tomas,
>
> Am 27.06.2019 um 13:32 schrieb Marek Vasut:
>> On 6/27/19 7:53 AM, Melin Tomas wrote:
>>>
>>> On 6/27/19 4:41 AM, Marek Vasut wrote:
>>>> On 6/26/19 8:17 PM, Melin
On 6/27/19 4:41 AM, Marek Vasut wrote:
> On 6/26/19 8:17 PM, Melin Tomas wrote:
>> On 6/26/19 4:36 PM, Marek Vasut wrote:
>>> On 6/26/19 3:19 PM, Melin Tomas wrote:
>>>> On 6/26/19 3:48 PM, Marek Vasut wrote:
>>>>> On 6/26/19 2:45 PM, Melin Tomas
On 6/26/19 4:36 PM, Marek Vasut wrote:
> On 6/26/19 3:19 PM, Melin Tomas wrote:
>> On 6/26/19 3:48 PM, Marek Vasut wrote:
>>> On 6/26/19 2:45 PM, Melin Tomas wrote:
>>>> On 6/26/19 3:26 PM, Marek Vasut wrote:
>>>>> On 6/26/19 2:19 PM, Melin Tomas
On 6/26/19 3:48 PM, Marek Vasut wrote:
> On 6/26/19 2:45 PM, Melin Tomas wrote:
>> On 6/26/19 3:26 PM, Marek Vasut wrote:
>>> On 6/26/19 2:19 PM, Melin Tomas wrote:
>>>> On 6/26/19 2:49 PM, Marek Vasut wrote:
>>>>> On 6/26/19 1:25 PM, Melin Tomas
On 6/26/19 3:26 PM, Marek Vasut wrote:
> On 6/26/19 2:19 PM, Melin Tomas wrote:
>> On 6/26/19 2:49 PM, Marek Vasut wrote:
>>> On 6/26/19 1:25 PM, Melin Tomas wrote:
>>>> On 6/26/19 1:47 PM, Marek Vasut wrote:
>>>>
>>>>> On 6/26/19 12:39 PM,
On 6/26/19 2:49 PM, Marek Vasut wrote:
> On 6/26/19 1:25 PM, Melin Tomas wrote:
>> On 6/26/19 1:47 PM, Marek Vasut wrote:
>>
>>> On 6/26/19 12:39 PM, Melin Tomas wrote:
>>>
>>>> As such, it's probably a good idea to keep the same delay values here
On 6/26/19 1:47 PM, Marek Vasut wrote:
> On 6/26/19 12:39 PM, Melin Tomas wrote:
>
>> As such, it's probably a good idea to keep the same delay values here as
>> in the original driver unless good reason to use something else.
>>
>> As what goes for the ori
On 6/26/19 1:26 PM, Marek Vasut wrote:
> On 6/26/19 12:12 PM, Melin Tomas wrote:
>> On 6/26/19 12:46 PM, Marek Vasut wrote:
>>
>>> On 6/26/19 7:30 AM, Melin Tomas wrote:
>>>> On 6/25/19 6:15 PM, Marek Vasut wrote:
>>>>
>>>>> On 6/2
On 6/26/19 12:46 PM, Marek Vasut wrote:
> On 6/26/19 7:30 AM, Melin Tomas wrote:
>> On 6/25/19 6:15 PM, Marek Vasut wrote:
>>
>>> On 6/25/19 3:30 PM, Melin Tomas wrote:
>>>> Prior to starting a new transfer, conditionally wait for bus to not
>>>&g
On 6/25/19 6:15 PM, Marek Vasut wrote:
> On 6/25/19 3:30 PM, Melin Tomas wrote:
>> Prior to starting a new transfer, conditionally wait for bus to not
>> be busy.
>>
>> Reinitialise controller as otherwise operation is not stable.
>> For reference, see linux
Prior to starting a new transfer, conditionally wait for bus to not
be busy.
Reinitialise controller as otherwise operation is not stable.
For reference, see linux kernel commit: 9656eeebf3f1 ("i2c: Revert
"i2c: xiic: Do not reset controller before every transfer"")
Signed-off-by: Tomas Melin
--
Comparison should be against the actual message length, not loop index.
len is used for stopping while loop, pos is position in message.
stop should be sent when entire message is sent, not when
len and pos meet.
Signed-off-by: Tomas Melin
---
Changes in v2:
- Added reasoning to commit message
On 6/25/19 2:33 PM, Marek Vasut wrote:
>> +ret = wait_for_bit_8(priv->base + XIIC_SR_REG_OFFSET,
>> + XIIC_SR_BUS_BUSY_MASK, false, 3000, true);
> Why 3 seconds wait ?
Right, seems kernel driver uses as small as 3ms timeout here. I'll
change to that and verify.
thank
Prior to starting a new transfer, conditionally wait for bus to not
be busy.
Reinitialise controller as otherwise operation is not stable.
For reference, see linux kernel commit: 9656eeebf3f1dd05376c4c923797369746d9a618
Signed-off-by: Tomas Melin
---
drivers/i2c/xilinx_xiic.c | 9 +
1 f
Comparison should be against the actual message length, not loop index.
Signed-off-by: Tomas Melin
---
drivers/i2c/xilinx_xiic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/xilinx_xiic.c b/drivers/i2c/xilinx_xiic.c
index 83114ed510..e4ca0ab936 100644
--- a/dri
Update EXTRA_ENV_SETTINGS and related commands to use 'setenv'
instead of short name 'set' in commands.
E.g. in case command setexpr is enabled the short form does not work
properly as the name becomes ambigous.
Fixes error messages like:
U-Boot> set
Unknown command 'set' - try 'help'
S
Hi,
On 3/29/19 6:17 PM, Jonas Mark (BT-FIR/ENG1) wrote:
> Gentle ping^2. Ready to apply?
I was kindof hoping on some follow up on concerns raised during v3, see
below.
On 2/8/19 2:21 PM, Tomas Melin wrote:
>> - node_offset = fit_image_get_node(fit_header, location->name);
>> + /* Get t
Hi,
On 2/8/19 11:51 AM, Mark Jonas wrote:
> diff --git a/common/splash_source.c b/common/splash_source.c
> index 62763b9..e1e73db 100644
> --- a/common/splash_source.c
> +++ b/common/splash_source.c
> @@ -303,6 +303,7 @@ static int splash_load_fit(struct splash_location
> *location, u32 bmp_load_
Hi Mark,
On 2/6/19 5:42 PM, Jonas Mark (BT-FIR/ENG1) wrote:
>> If I understand the original issue you had correctly, could it also have
>> been fixed by renaming splash node in FIT image?
> Yes, that's we actually started with. But once we started adding more
> files to that FIT image we saw the p
On 2/5/19 5:29 PM, Mark Jonas wrote:
> From: Leo Ruan
>
> The splash image could be loaded from different sources (e.g. sf, mmc)
> with different formats (e.g. raw, file-system). These sources are
> structured by a board dependent object 'splash_location'. To decide
> where is the splash image lo
Hi Mark,
On 2/6/19 4:30 PM, Jonas Mark (BT-FIR/ENG1) wrote:
>
>> So my initial question still stands, could existing implementation be kept
>> as fallback?
>>
>> +if (!splash_file)
>> +splash_file = location->name;
>>
>> location->name has worked fine for those cases, so it would b
Hi Mark,
>> Could fallback here instead be "location->name" as before, keeping
>> compability with the current implementation? I.e.
>>
>> +if (!splash_file)
>> +splash_file = location->name;
> Can you point me to the 3 upstream boards which are relying on this?
>
> Is it compulab/c
Hi,
On 2/5/19 5:29 PM, Mark Jonas wrote:
> From: Leo Ruan
>
>
> common/splash_source.c | 10 --
> doc/README.splashprepare | 9 ++---
> 2 files changed, 14 insertions(+), 5 deletions(-)
>
> diff --git a/common/splash_source.c b/common/splash_source.c
> index 62763b9..e1e73db 10
27 matches
Mail list logo
