Hi,
On 2/8/19 11:51 AM, Mark Jonas wrote:
> diff --git a/common/splash_source.c b/common/splash_source.c
> index 62763b9..e1e73db 100644
> --- a/common/splash_source.c
> +++ b/common/splash_source.c
> @@ -303,6 +303,7 @@ static int splash_load_fit(struct splash_location
> *location, u32 bmp_load_addr)
> {
> int res;
> int node_offset;
> + const char *splash_file;
> int splash_offset;
> int splash_size;
> struct image_header *img_header;
> @@ -335,10 +336,15 @@ static int splash_load_fit(struct splash_location
> *location, u32 bmp_load_addr)
> return -EINVAL;
> }
>
> - node_offset = fit_image_get_node(fit_header, location->name);
> + /* Get the splash image node */
> + splash_file = env_get("splashfile");
> + if (!splash_file)
> + splash_file = SPLASH_SOURCE_DEFAULT_FILE_NAME;
As mentioned during latest review round, this default name should really
IMO be something else than a file name since it's not a file, it's a FIT
node. splash_file should also probably be splash_node or so.
I'm not even sure is this patch really needed, selecting an appropriate
name for the splash_location.name, matching the splash image node should
work equally.
BR,
Tomas
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
