Re: [PATCH v2 5/7] pinctrl: at91: Bind GPIO driver to the pinctrl DT node

2025-01-31 Thread Eugen Hristev
On 1/30/25 05:51, Manikandan Muralidharan wrote: > In Linux DT,the pinctrl node acts as parent nodes with all other > gpio banks as child nodes and a single driver in Linux handles both > pinctrl settings and gpio requests.Current U-Boot DT maintains both > pinctrl and gpio nodes as separate nod

Re: [PATCH v2 2/7] ARM: dts: at91: sam9x60: Define pinctrl node with its label

2025-01-30 Thread Eugen Hristev
On 1/30/25 05:51, Manikandan Muralidharan wrote: > From: Balamanikandan Gunasundar > > Define the pinctrl nodes with its label to align with the Linux DT. > Without this change the pinmux nodes are grouped under an additional > 'pinctrl' child node which is not identified by the pinctrl driver

Re: [PATCH 0/7] [U-Boot] spi: atmel-quadspi: Refresh and add classic mode support

2025-01-30 Thread Eugen Hristev
On 1/30/25 16:49, Tom Rini wrote: > On Thu, Jan 30, 2025 at 04:07:27PM +0200, Eugen Hristev wrote: >> >> >> On 1/23/25 14:12, Alexander Dahl wrote: >>> Hello everyone, >>> >>> this patch series is for U-Boot, although Linux might be affected. >

Re: [PATCH 0/7] [U-Boot] spi: atmel-quadspi: Refresh and add classic mode support

2025-01-30 Thread Eugen Hristev
On 1/23/25 14:12, Alexander Dahl wrote: > Hello everyone, > > this patch series is for U-Boot, although Linux might be affected. > > The quadspi controller on microchip (former atmel) sama5d2, sam9x60 and > other soc variants of the at91 family is usually used in hardware > accelerated spi-mem

Re: [PATCH 6/7] spi: atmel-quadspi: Add support for classic SPI mode

2025-01-30 Thread Eugen Hristev
Hello Alex, On 1/23/25 14:12, Alexander Dahl wrote: > The qspi controller on sama5d2 and sam9x60 supports "classic" SPI mode > without spi-mem enhancements and accelerations, very similar to the old > SPI controller on sam9g20 or the modern flexcom controllers of the same > SoC family. > > Regist

Re: [PATCH 4/7] ARM: dts: at91: sam9x60: Add missing pinctrl node properties

2025-01-28 Thread Eugen Hristev
On 1/27/25 12:09, Manikandan Muralidharan wrote: > Add the missing properties for the pinctrl node and for its > corresponding GPIO bank nodes to align with the Linux DT. > > Signed-off-by: Manikandan Muralidharan > --- > arch/arm/dts/sam9x60.dtsi | 23 ++- > 1 file change

Re: [PATCH 2/7] ARM: dts: at91: sam9x60: Define pinctrl node with its label

2025-01-28 Thread Eugen Hristev
On 1/27/25 12:09, Manikandan Muralidharan wrote: > From: Balamanikandan Gunasundar > > Define the pinctrl nodes with its label and sort its child node > alphabetically to align wit the Linux DT.Without this change Typo: wit > those pinctrl nodes are grouped under an additional 'pinctrl' chil

Re: [PATCH 1/7] ARM: dts: at91: sam9x60: Add AIC node

2025-01-28 Thread Eugen Hristev
On 1/27/25 12:09, Manikandan Muralidharan wrote: > Add Advanced Interrupt Controller node and define it as interrupt > parent in sam9x60 SoC DT. > > Signed-off-by: Manikandan Muralidharan > --- > arch/arm/dts/sam9x60.dtsi | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/arch

[PULL next] u-boot-at91-2025.04-a

2024-11-29 Thread Eugen Hristev
Hello Tom, Please pull tag u-boot-at91-2025.04-a , the first set of features and fixes for the next 2025.04 cycle. This feature set includes the at91 gpio driver function alternate mode for pins, and some fixes. Thanks, Eugen The following changes since commit 62224280d9e89648ae90346c0aede76f9

Re: [PATCH 0/5] collected fallout of porting an ATSAMA5D2 based board

2024-11-19 Thread Eugen Hristev
On 11/12/24 15:45, Eugen Hristev wrote: > > > On 10/18/24 11:30, Benedikt Spranger wrote: >> Hi, >> >> while porting an ATSAMA5D2 based board (booting from NAND flash with UBI) >> I stumbled over generic, NAND- and UBI related asperity: >> >> 1.

Re: [PATCH v2 1/3] gpio: at91: Implement GPIOF_FUNC in get_function()

2024-11-19 Thread Eugen Hristev
Applied patches to u-boot-at91/next, thanks ! Eugen On 11/13/24 12:10, Zixun LI wrote: > This patch adds support for determining whether a gpio pin is mapped as > peripheral function. > > Signed-off-by: Zixun LI > --- > Changes in v2: > - Rename function > --- > drivers/gpio/at91_gpio.c | 13 +

Re: [PATCH 1/3] gpio: at91: Implement GPIOF_FUNC in get_function()

2024-11-12 Thread Eugen Hristev
On 11/12/24 18:17, Zixun LI wrote: > On Tue, Nov 12, 2024 at 4:59 PM Eugen Hristev > wrote: >> >> >> >> On 11/12/24 17:57, Zixun LI wrote: >>> Hello, >>> >>> >>> On Tue, Nov 12, 2024 at 2:13 PM Eugen Hristev >>

Re: [PATCH 1/3] gpio: at91: Implement GPIOF_FUNC in get_function()

2024-11-12 Thread Eugen Hristev
On 11/12/24 17:57, Zixun LI wrote: > Hello, > > > On Tue, Nov 12, 2024 at 2:13 PM Eugen Hristev > wrote: >> >> >>> +static bool at91_get_port_pio(struct at91_port *at91_port, int offset) >> >> The name get_port_pio is a bit confusing, can you

Re: [PATCH 4/5] mtd: nand: Update NAND manufacturer Ids

2024-11-12 Thread Eugen Hristev
On 11/12/24 15:57, Benedikt Spranger wrote: > On Tue, 12 Nov 2024 15:39:23 +0200 > Eugen Hristev wrote: > > Hi Eugen, >> On 10/18/24 11:30, Benedikt Spranger wrote: >>> Align manufacturer Ids with the Id list from Linux kernel v6.11. >>> While at it, so

Re: [PATCH 0/5] collected fallout of porting an ATSAMA5D2 based board

2024-11-12 Thread Eugen Hristev
On 10/18/24 11:30, Benedikt Spranger wrote: > Hi, > > while porting an ATSAMA5D2 based board (booting from NAND flash with UBI) > I stumbled over generic, NAND- and UBI related asperity: > > 1. tiny-printf does not handle NULL arguments to '%s' in a proper way > 2. vtbl_check() has an useless

Re: [PATCH 4/5] mtd: nand: Update NAND manufacturer Ids

2024-11-12 Thread Eugen Hristev
Hi Benedikt , On 10/18/24 11:30, Benedikt Spranger wrote: > Align manufacturer Ids with the Id list from Linux kernel v6.11. > While at it, sort the entries in alphabetical order. > > Signed-off-by: Benedikt Spranger > Reviewed-by: John Ogness > --- > drivers/mtd/nand/raw/nand_ids.c | 22 +

Re: [PATCH 2/3] gpio: at91: Implement ops set_flags

2024-11-12 Thread Eugen Hristev
Hello, On 10/18/24 23:27, Zixun LI wrote: > Support GPIO configuration with following flags: > - in, out, out_active > - open_drain, pull_up > > Signed-off-by: Zixun LI > --- > drivers/gpio/at91_gpio.c | 41 > 1 file changed, 41 insertions(+) > > diff -

Re: [PATCH v2 3/3] gpio: at91: Implement ops get_flags

2024-11-12 Thread Eugen Hristev
On 10/19/24 00:57, Zixun LI wrote: > Add ops get_dir_flags() to read status from GPIO registers. > > Signed-off-by: Zixun LI > > --- > Changes in v2: > - Fix pullup read polarity > --- > drivers/gpio/at91_gpio.c | 45 > 1 file changed, 45 insertions(+

Re: [PATCH 1/3] gpio: at91: Implement GPIOF_FUNC in get_function()

2024-11-12 Thread Eugen Hristev
Hello, On 10/18/24 23:27, Zixun LI wrote: > This patch adds support for determining whether a gpio pin is mapped as > peripheral function. > > Signed-off-by: Zixun LI > --- > drivers/gpio/at91_gpio.c | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/drivers

Re: [PATCH v1 1/1] rockchip: rock5b-rk3588: Enable automatic PCI enumeration

2024-10-31 Thread Eugen Hristev
Hello Sebastian, On 10/31/24 20:01, Sebastian Reichel wrote: PCI enumeration is required to detect the onboard Ethernet device. Signed-off-by: Sebastian Reichel --- configs/rock5b-rk3588_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/rock5b-rk3588_defconfig b/configs/

Re: [PATCH v3] rockchip: add support for Radxa ROCK 5A with SPI NOR flash module

2024-10-30 Thread Eugen Hristev
On 10/30/24 08:30, Kever Yang wrote: Hi Naoki, On 2024/10/30 14:07, FUKAUMI Naoki wrote: on Radxa ROCK 5A, sdhci(eMMC) and fspim0(SPI NOR flash) share pins (i.e. eMMC and SPI NOR flash are exclusive), new defconfig and dts specifically for SPI NOR flash is required. Signed-off-by: FUKAUMI N

Re: [PATCH 0/5] collected fallout of porting an ATSAMA5D27 based board

2024-10-21 Thread Eugen Hristev
Yeah, been there. Wanted at91bootstrap to boot from SPI-NOR which is _not_ Quad-SPI, and the feature request was closed with "if you wanna do it by yourself, ask our support for help". :-/ iirc at91bootstrap can boot from raw spi-nor (yes, not UBI) Speaking of at91bootstrap 3.x and late

Re: [PATCH 0/5] collected fallout of porting an ATSAMA5D27 based board

2024-10-21 Thread Eugen Hristev
On 10/21/24 15:30, Benedikt Spranger wrote: On Mon, 21 Oct 2024 10:17:54 +0300 Eugen Hristev wrote: Hi, Do you use at91bootstrap as 2nd level bootloader like me or something else? I use the U-Boot SPL. There is no UBI support in at91boostrap. There were some attemps, but... No

Re: [PATCH 0/5] collected fallout of porting an ATSAMA5D27 based board

2024-10-21 Thread Eugen Hristev
Hello, On 10/21/24 09:03, Alexander Dahl wrote: Hello Benedikt, Am Fri, Oct 18, 2024 at 04:19:08PM +0200 schrieb Benedikt Spranger: On Fri, 18 Oct 2024 15:11:20 +0200 Alexander Dahl wrote: Hello Alexander, Am Fri, Oct 18, 2024 at 10:30:00AM +0200 schrieb Benedikt Spranger: OK, you might s

[PULL] u-boot-at91-fixes-2025.01-a

2024-10-18 Thread Eugen Hristev
: Add missing include of asm/io.h Eugen Hristev (1): .mailmap: update e-mail address for Eugen Hristev .mailmap | 3 ++- arch/arm/mach-at91/include/mach/clk.h | 1 + doc/git-mailrc| 2 +- 3 files changed, 4 insertions(+), 2 deletions(-)

Re: [PATCH 1/1] Fixed sama5d3 dts file so PIO sections are inside pinctrl as in kernel dts

2024-10-18 Thread Eugen Hristev
Hello Alexey, Please fix the subject to adhere to the rules ARM: dts: etc, if you are unsure, please follow previous commits that touched this file. On 10/17/24 11:51, manikanda...@microchip.com wrote: Hi Alexey, On 15/10/24 8:23 pm, Alexey Tsirlin wrote: This allows setting the GPIO par

[PATCH] .mailmap: update e-mail address for Eugen Hristev

2024-10-16 Thread Eugen Hristev
Update e-mail address. Signed-off-by: Eugen Hristev --- .mailmap | 3 ++- doc/git-mailrc | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.mailmap b/.mailmap index 952e1dac4b20..4d48349f0e9f 100644 --- a/.mailmap +++ b/.mailmap @@ -38,7 +38,8 @@ Boris Brezillon

Re: [PATCH v3 3/3] mtd: nand: raw: atmel: Fix pulse read timing for certain NAND flashes

2024-10-08 Thread Eugen Hristev
On 9/30/24 11:07, Alexander Dahl wrote: > Hello, > > Am Tue, May 28, 2024 at 12:32:44PM +0200 schrieb Alexander Dahl: >> Hei hei, >> >> Am Mon, Apr 15, 2024 at 09:57:55AM +0200 schrieb Alexander Dahl: >>> From reading the S34ML02G1 and the SAM9X60 datasheets again, it seems >>> like we have to wai

Re: [PATCH] arm: Remove ethernut5 board

2024-09-08 Thread Eugen Hristev
Signed-off-by: Tom Rini > --- > Cc: Harald Kipp > Cc: Eugen Hristev CC: Alexandre Belloni, Nicolas Ferre > --- > arch/arm/dts/Makefile | 2 - > arch/arm/dts/at91sam9xe.dtsi | 60 > arch/arm/dts/ethernut5.dts

Re: [PATCH v2] mtd: nand: raw: atmel: Use ONFI ECC params if available

2024-07-29 Thread Eugen Hristev
On 7/25/24 12:41, Michael Nazzareno Trimarchi wrote: > Hi > > On Thu, Jul 25, 2024 at 11:36 AM > wrote: >> >> Acked-by: Balamanikandan Gunasundar >> >> >> On 22/07/24 3:15 am, Zixun LI wrote: >>> [Some people who received this message don't often get email from >>> ad...@hifiphile.com. Learn wh

Re: [PATCH] arm: move _end to linker symbols

2024-05-27 Thread Eugen Hristev
On 5/28/24 09:18, Ilias Apalodimas wrote: > commit 6e2228fb052b ("Merge patch series "Clean up arm linker scripts") > was cleaning up linker scripts for armv7 and v8 but was leaving > _end and __secure_stack_start/end. > > commit d0b5d9da5de2 ("arm: make _end compiler-generated") > was moving _end

Re: [PATCH 1/2] rockchip: rk3588: Add support for ATAG parsing

2024-03-27 Thread Eugen Hristev
On 3/27/24 15:32, Chris Morgan wrote: > On Wed, Mar 27, 2024 at 06:32:06PM +0800, Kever Yang wrote: >> Hi Chris, >> >>     The ATAGS is used for passing parameter from bootloader to kernel at >> first, which has been replaced by DTB now for ARM platform. >> >>     And Rockchip using ATAGs for passi

[PULL next] u-boot-at91-2024.07-a

2024-03-25 Thread Eugen Hristev
Hello Tom, Please pull tag u-boot-at91-2024.07-a , the first set of at91 features for the next cycle 2024.07 . This feature set includes a new board named sama7g54 Curiosity. Thanks, Eugen The following changes since commit 20a0ce574d6642e0dfe651467159039fac48cc4f: Merge tag 'v2024.04-rc4'

Re: [RFC PATCH 0/3] mtd: nand: raw: atmel: Using dm driver for older sam9 SoCs

2024-03-18 Thread Eugen Hristev
On 3/11/24 17:23, Alexander Dahl wrote: > Hello raw NAND fans, > Hello Alexander, Thank you for your efforts > today I thought it would be interesting to have all that automatic NAND > flash timings setting usable with an old board featuring a at91sam9g20 > SoC, which would pave the way to get

Re: [PATCH 4/4] mtd: nand: raw: atmel: Introduce optional debug commands

2024-03-18 Thread Eugen Hristev
On 3/18/24 10:09, mihai.s...@microchip.com wrote: > On 3/7/24 11:10, Alexander Dahl wrote: >> For now adds one new command 'hsmc' with a single subcommand 'decode' >> to read and display the content of the registers of the Static Memory >> Controllers (SMC/HSMC) found in different at91 SoCs. Nee

Re: [PATCH v2 0/4] Add initial support for Microchip SAMA7G54 Curiosity board

2024-03-14 Thread Eugen Hristev
On 2/27/24 15:43, Mihai Sain wrote: > This patch series adds initial support for Microchip SAMA7G54 Curiosity board. > > Changes in v2: > -- > > * Update flexcom 10 node in order to match previous flexcom definitions. > * Sort in alphabetical order all nodes and pinctrl. > * Remove st

Re: [PATCH 4/4] mtd: nand: raw: atmel: Introduce optional debug commands

2024-03-07 Thread Eugen Hristev
On 3/7/24 11:10, Alexander Dahl wrote: > For now adds one new command 'hsmc' with a single subcommand 'decode' to > read and display the content of the registers of the Static Memory > Controllers (SMC/HSMC) found in different at91 SoCs. Needed to get a > better picture on what raw nand core and a

Re: [PATCH] configs: rockchip: rock5a: enable environment

2024-03-04 Thread Eugen Hristev
On 3/5/24 04:10, Trevor Woerner wrote: > Following the pattern of other Rockchip devices, enable the U-Boot > environment to be stored in MMC. This patch specifically assumes the > environment will be stored on the SDcard. > > Signed-off-by: Trevor Woerner > --- > configs/rock5a-rk3588s_defconfi

Re: [RFC] rockchip: Reset to bootrom download mode on hang

2024-02-05 Thread Eugen Hristev
Hello Jonas, On 2/5/24 14:34, Jonas Karlman wrote: > Hi Quentin, > > On 2024-02-05 11:49, Quentin Schulz wrote: >> Hi Jonas, >> >> On 2/2/24 01:12, Jonas Karlman wrote: >>> Add support to reset to bootrom download mode on hang in U-Boot SPL and >>> proper. ROCKCHIP_HANG_TO_BROM can be used to ena

[PULL] u-boot-at91-2024.04-a

2024-01-31 Thread Eugen Hristev
Hello Tom, Please pull tag u-boot-at91-2024.04-a , the first set of at91 features for 2024.04 cycle. This set includes some DT alignments and solves a compile issue for custom nand defconfigs. Thanks, Eugen The following changes since commit 3c04fcf3137d5f694d52b8f355373e4baabe5f78: Merge pa

Re: [PATCH 6/7] rockchip: rk3588: Add default u-boot,spl-boot-order prop

2024-01-26 Thread Eugen Hristev
On 1/27/24 00:14, Jonas Karlman wrote: > Add a default u-boot,spl-boot-order prop to rk3588s-u-boot.dtsi and > remove the prop from board u-boot.dtsi files using the default value. > > Signed-off-by: Jonas Karlman Reviewed-by: Eugen Hristev > --- > arch/arm/dts/rk3588-nan

Re: [PATCH 1/3] rockchip: rk35xx: Remove use of eMMC DDR52 mode

2024-01-26 Thread Eugen Hristev
Hi Jonas, On 1/27/24 01:26, Jonas Karlman wrote: > Writing to eMMC using DDR52 mode does not work reliably or at all on > RK356x and RK3588 boards. > This is related to the old issue I encountered last year with mmc write? Thanks, Eugen > Fix this by removing the mmc-ddr-1_8v prop from sdhci

Re: [PATCH 0/4] Facilitate new atmel raw nand driver for SAMA5D2

2024-01-23 Thread Eugen Hristev
+CONFIG_DM_NAND_ATMEL=y > CONFIG_SYS_NAND_ONFI_DETECTION=y > CONFIG_PHY_SMSC=y > CONFIG_MACB=y > > Hope the changes are acceptable nevertheless. The last patch has a > trivial fix for the new atmel raw nand driver which I came up with while > working on this. > &g

Re: [PATCH 4/4] mtd: nand: raw: atmel: Remove duplicate definitions

2024-01-23 Thread Eugen Hristev
On 12/19/23 18:39, Alexander Dahl wrote: > Hello Eugen, > > Am Tue, Dec 19, 2023 at 04:32:07PM +0200 schrieb Eugen Hristev: >> On 12/12/23 18:04, Alexander Dahl wrote: >>> These removed definitions were specific to some sam9 SoCs, but not >>> generic over all at9

Re: [PATCH 4/4] mtd: nand: raw: atmel: Remove duplicate definitions

2023-12-19 Thread Eugen Hristev
On 12/12/23 18:04, Alexander Dahl wrote: > These removed definitions were specific to some sam9 SoCs, but not > generic over all at91 SoCs. The correct SoC specific definitions for > ATMEL_BASE_PMECC are spread over different header files in > arch/arm/mach-at91/include/mach directory. > > Fixes

Re: eMMC errors on RK3588 (rock5b)

2023-11-23 Thread Eugen Hristev
On 11/23/23 07:22, Tom Fitzhenry wrote: I am able to reproduce this on RK3588 QuartzPro64. I cannot reproduce on the vendor u-boot, used on stock RK3588 QuartzPro64. That works fine. I thought "[PATCH v2 RESEND] mmc: dw_mmc: reset controller after data error"[0] might fix this, but after applyi

Re: [PATCH] arm: Enable SYS_THUMB_BUILD on AT91

2023-11-17 Thread Eugen Hristev
On 11/17/23 15:46, Tom Rini wrote: On Fri, Nov 17, 2023 at 03:45:02PM +0200, Eugen Hristev wrote: On 11/17/23 15:40, Tom Rini wrote: On Sat, 04 Nov 2023 22:27:42 -0400, Sean Anderson wrote: Several AT91 boards are quite close to their SPL size limit. For example, sama5d27_wlsom1_ek_mmc is

Re: [PATCH] arm: Enable SYS_THUMB_BUILD on AT91

2023-11-17 Thread Eugen Hristev
On 11/17/23 15:40, Tom Rini wrote: On Sat, 04 Nov 2023 22:27:42 -0400, Sean Anderson wrote: Several AT91 boards are quite close to their SPL size limit. For example, sama5d27_wlsom1_ek_mmc is just 173 bytes short of its limit and doesn't even fit with older GCCs. All AT91 processors should hav

Re: [PATCH] arm: Enable SYS_THUMB_BUILD on AT91

2023-11-17 Thread Eugen Hristev
On 11/17/23 11:15, mihai.s...@microchip.com wrote: Hi Eugen, I built new binaries with CONFIG_SYS_THUMB_BUILD=y for sam9x60_curiosity, sama5d29_curiosity, sama7g5ek and new sam9x75_curiosity board. I used the latest u-boot/master branch for this test. I noticed that the file size of the binarie

Re: [PATCH] arm: Enable SYS_THUMB_BUILD on AT91

2023-11-16 Thread Eugen Hristev
On 11/16/23 20:47, Tom Rini wrote: On Sat, Nov 04, 2023 at 10:27:42PM -0400, Sean Anderson wrote: Several AT91 boards are quite close to their SPL size limit. For example, sama5d27_wlsom1_ek_mmc is just 173 bytes short of its limit and doesn't even fit with older GCCs. All AT91 processors shou

Re: [PATCH 3/3] treewide: use linux/time.h for time conversion defines

2023-11-10 Thread Eugen Hristev
| 3 +-- fs/ubifs/ubifs.h | 1 - 28 files changed, 32 insertions(+), 62 deletions(-) Reviewed-by: Eugen Hristev #at91

Re: [PATCH 0/4] Add support for sam9x60 curiosity

2023-10-25 Thread Eugen Hristev
On 9/26/23 09:13, durai.manicka...@microchip.com wrote: On 22/09/23 12:30, Alexander Dahl wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe Hello Durai, Am Thu, Sep 21, 2023 at 10:36:27PM +0530 schrieb Durai Manickam KR: This patch series adds

[PULL] u-boot-at91-2024.01-b

2023-10-23 Thread Eugen Hristev
Hello Tom, Please pull tag u-boot-at91-2024.01-b , the second set of at91 features for 2024.01 cycle. This feature set a new board named Conclusive KSTR sama5d27 with some small prerequisites patches. Thanks, Eugen The following changes since commit 9a3a58396b78b1f9d0c14580dc03f81d29207dd

Re: [PATCH v5 0/4] Conclusive KSTR-SAMA5D27 support

2023-10-23 Thread Eugen Hristev
On 10/18/23 17:00, Artur Rojek wrote: Hi all, this is v5 of the Conclusive KSTR-SAMA5D27 support series. Patches [1/4], [2/4] and [3/4] remain unchanged. In patch [4/4], a new dtsi file has been added in order to keep U-Boot specific properties separate from the main dts. As such, MAINTAINERS

Re: [PATCH v2] usb: xhci: Workaround to fix the USB halted endpoint issues

2023-10-17 Thread Eugen Hristev
On 10/16/23 22:30, Tom Rini wrote: On Mon, Oct 16, 2023 at 08:34:16AM +0200, Michal Simek wrote: On 10/13/23 17:15, Tom Rini wrote: On Fri, Oct 13, 2023 at 11:11:04AM -0400, Da Xue wrote: On Fri, Oct 13, 2023 at 7:47 AM Marek Vasut wrote: On 10/13/23 06:53, Venkatesh Yadav Abbarapu wrote:

Re: [PATCH v4 4/4] board: Add support for Conclusive KSTR-SAMA5D27

2023-10-10 Thread Eugen Hristev
Hello Artur, On 10/9/23 17:41, Artur Rojek wrote: Introduce support for Conclusive KSTR-SAMA5D27 Single Board Computer. Co-developed-by: Jakub Klama Signed-off-by: Jakub Klama Co-developed-by: Marcin Jabrzyk Signed-off-by: Marcin Jabrzyk Signed-off-by: Artur Rojek --- v4: - utilize EVT_SE

[PULL] u-boot-at91-fixes-2023.10-b

2023-09-29 Thread Eugen Hristev
Hello Tom, Please pull tag u-boot-at91-fixes-2023.10-b , the second set of fixes for 2023.10 cycle. This comes late, but I hope you can merge it before the release, it's only two small fixes , one for an array not initialized and the second one fixes an error case when a DT property is mis

Re: [PATCH] clk: at91: Fix initializing arrays

2023-09-29 Thread Eugen Hristev
On 9/24/23 12:58, Francois Berder wrote: Arrays are not cleared entirely because ARRAY_SIZE returns the number of elements in an array, not the size in bytes. This commit fixes the calls to memset by providing the array size in bytes instead of the number of elements in the array. Signed-off-by:

Re: [PATCH v2 1/1] mtd: nand: raw: atmel: Add error handling when rb-gpios missing

2023-09-27 Thread Eugen Hristev
On 9/23/23 19:50, Michael Nazzareno Trimarchi wrote: On Fri, Sep 22, 2023 at 11:40 AM Eugen Hristev wrote: On 9/22/23 12:08, Alexander Dahl wrote: Adapt behaviour to Linux kernel driver. The return value of gpio_request_by_name_nodev() was not checked before, and thus in case 'rb-gpios

Re: [PATCH 2/2] board: Add support for Conclusive KSTR-SAMA5D27

2023-09-27 Thread Eugen Hristev
On 9/25/23 22:31, Artur Rojek wrote: Hey Eugen, thanks for the review. Hello, Thank you for your patch, On 9/21/23 18:37, Artur Rojek wrote: Introduce support for Conclusive KSTR-SAMA5D27 Single Board Computer. Co-developed-by: Jakub Klama Signed-off-by: Jakub Klama Co-developed-by: Marci

Re: Enable thumb on AT91?

2023-09-27 Thread Eugen Hristev
On 9/27/23 01:15, Sean Anderson wrote: Hi Eugen, I noticed that several AT91 boards are quite close to their SPL size limit. For example, sama5d27_wlsom1_ek_mmc is just 173 bytes short of its limit and doesn't even git with older GCCs. I looked at the datasheet for that processor, and noticed th

Re: [PATCH v2 00/10] rockchip: rk3588: add support for DFU in SPL

2023-09-22 Thread Eugen Hristev
On 9/22/23 03:48, Kever Yang wrote: On 2023/9/21 22:47, Eugen Hristev wrote: On 8/1/23 10:28, Eugen Hristev wrote: This series adds support for DFU in SPL for rockchip rk3588 on rock5b board. Namely, when SPL is loaded via rockusb (thus via USB), having the `same-as-spl` boot order item

Re: [PATCH v2 1/1] mtd: nand: raw: atmel: Add error handling when rb-gpios missing

2023-09-22 Thread Eugen Hristev
ution is used. Fixes: 6a8dfd57220d ("nand: atmel: Add DM based NAND driver") Signed-off-by: Alexander Dahl --- Reviewed-by: Eugen Hristev Notes: v1 -> v2: - Only issue error message if error is not ENOENT. If the node just is missing, move on without err

Re: [PATCH 2/2] board: Add support for Conclusive KSTR-SAMA5D27

2023-09-21 Thread Eugen Hristev
Hello, Thank you for your patch, On 9/21/23 18:37, Artur Rojek wrote: Introduce support for Conclusive KSTR-SAMA5D27 Single Board Computer. Co-developed-by: Jakub Klama Signed-off-by: Jakub Klama Co-developed-by: Marcin Jabrzyk Signed-off-by: Marcin Jabrzyk Signed-off-by: Artur Rojek ---

Re: [PATCH v2 RESEND] mmc: dw_mmc: reset controller after data error

2023-09-21 Thread Eugen Hristev
On 6/19/23 13:33, Eugen Hristev wrote: From: Ziyuan Xu Per dw_mmc databook, it's recommended to reset the host controller if some data-related error occurred. Implement a reset mechanism. Signed-off-by: Ziyuan Xu Co-developed-by: Jason Zhu Signed-off-by: Jason Zhu [eugen

Re: [PATCH] clk: fix count parameter type for clk_release_all

2023-09-21 Thread Eugen Hristev
On 6/19/23 13:47, Eugen Hristev wrote: The second parameter for clk_release_all is used as an unsigned (which makes sense) but the function prototype declares it as an int. This causes warnings/error like such below: include/clk.h:422:48: error: conversion to ‘int’ from ‘unsigned int’ may

Re: [PATCH v2 00/10] rockchip: rk3588: add support for DFU in SPL

2023-09-21 Thread Eugen Hristev
On 8/1/23 10:28, Eugen Hristev wrote: This series adds support for DFU in SPL for rockchip rk3588 on rock5b board. Namely, when SPL is loaded via rockusb (thus via USB), having the `same-as-spl` boot order item, after having detected that it was loaded from USB, it will lookup the gadget USB

[PULL next] u-boot-at91-2023.10-a

2023-08-30 Thread Eugen Hristev
Hello Tom, Please pull tag u-boot-at91-2023.10-a , the first set of at91 features for the next cycle 2023.10 . This feature set includes a new board sama5d29 Curiosity, and various fixes and alignments for sam9x60 and sam9x60 curiosity board. Thanks, Eugen The following changes since commi

Re: [PATCH v2 0/5] at91: sam9x60-curiosity: Misc improvements

2023-08-30 Thread Eugen Hristev
On 8/23/23 16:58, Alexander Dahl wrote: Hei hei, while working with the sam9x60-curiosity board I noticed some things still have rough edges on U-Boot shell for that device. With these patches (and some more config options enabled), the following commands now work as expected: reset, led, butto

Re: [PATCH RESEND v3] fpga: add inline stub for fpga_load

2023-08-28 Thread Eugen Hristev
On 8/28/23 13:53, Michal Simek wrote: Hi Eugen, + Chanho, On 8/8/23 12:22, Eugen Hristev wrote: In case CC_OPTIMIZE_FOR_DEBUG is set, unused code will not be optimized out, hence the reference to fpga_load will be compiled. if DM_FPGA and SPL_FPGA are not set, the build will fail with

Re: [PATCH] fpga: define dummy fpga_load function for debug build

2023-08-28 Thread Eugen Hristev
On 8/28/23 03:21, Chanho Park wrote: Hi, -Original Message- From: Michal Simek Sent: Friday, August 25, 2023 4:23 PM To: Chanho Park ; u-boot@lists.denx.de Subject: Re: [PATCH] fpga: define dummy fpga_load function for debug build Hi, On 8/16/23 08:54, Chanho Park wrote: This fixes

Re: [PATCH RESEND v3] fpga: add inline stub for fpga_load

2023-08-25 Thread Eugen Hristev
On 8/25/23 10:21, Michal Simek wrote: Hi, On 8/8/23 12:22, Eugen Hristev wrote: In case CC_OPTIMIZE_FOR_DEBUG is set, unused code will not be optimized out, hence the reference to fpga_load will be compiled. if DM_FPGA and SPL_FPGA are not set, the build will fail with : aarch64-none-linux

Re: [PATCH 1/2] mtd: nand: raw: atmel: Remove duplicate line

2023-08-23 Thread Eugen Hristev
On 8/8/23 16:48, Michael Nazzareno Trimarchi wrote: Hi On Tue, Aug 8, 2023 at 3:03 PM Alexander Dahl wrote: Signed-off-by: Alexander Dahl Reviewed-by: Michael Trimarchi Applied this one patch to u-boot-at91/next , thanks !

Re: [PATCH 2/2] mtd: nand: raw: atmel: Add error handling when rb-gpios missing

2023-08-23 Thread Eugen Hristev
On 8/23/23 09:54, Michael Nazzareno Trimarchi wrote: Hi On Wed, Aug 23, 2023 at 8:28 AM Eugen Hristev wrote: Hi, On 8/8/23 18:03, Alexander Dahl wrote: Hello Michael, Am Tue, Aug 08, 2023 at 03:49:45PM +0200 schrieb Michael Nazzareno Trimarchi: Hi On Tue, Aug 8, 2023 at 3:03 PM

Re: [PATCH 2/2] mtd: nand: raw: atmel: Add error handling when rb-gpios missing

2023-08-22 Thread Eugen Hristev
Hi, On 8/8/23 18:03, Alexander Dahl wrote: Hello Michael, Am Tue, Aug 08, 2023 at 03:49:45PM +0200 schrieb Michael Nazzareno Trimarchi: Hi On Tue, Aug 8, 2023 at 3:03 PM Alexander Dahl wrote: Adapt behaviour to Linux kernel driver. The return value of gpio_request_by_name_nodev() was not

Re: [PATCH 2/3] board: rockchip: rk35xx: Add device tree files to MAINTAINERS

2023-08-17 Thread Eugen Hristev
deletions(-) For rock5, Acked-by: Eugen Hristev

Re: [PATCH 3/3] board: rockchip: rk35xx: Add myself as reviewer to MAINTAINERS

2023-08-17 Thread Eugen Hristev
/MAINTAINERS | 1 + board/rockchip/evb_rk3568/MAINTAINERS | 4 3 files changed, 6 insertions(+) For rock5, Acked-by: Eugen Hristev

Re: [PATCH 2/4] configs: at91: sam9x60: Switch to new reset driver

2023-08-16 Thread Eugen Hristev
On 8/16/23 16:42, Alexander Dahl wrote: Hei hei, Am Wed, Aug 16, 2023 at 03:48:25PM +0300 schrieb Eugen Hristev: Hi Alexander, On 8/9/23 17:16, Alexander Dahl wrote: Since commit 61040097a9d1 ("reset: at91: Add reset driver for basic assert/deassert operations") the compatible

Re: [PATCH 4/4] ARM: dts: at91: sam9x60-curiosity: Add user button support

2023-08-16 Thread Eugen Hristev
Hi Alexander, On 8/9/23 17:16, Alexander Dahl wrote: Copied as is from Linux Kernel. Works out of the box if the following config options are enabled: CONFIG_BUTTON, CONFIG_BUTTON_GPIO, CONFIG_CMD_BUTTON, CONFIG_DM_GPIO. Can you please indicate the Linux commit which was picked, thanks ! Eug

Re: [PATCH 3/4] at91: sam9x60-curiosity: Add proper LED support

2023-08-16 Thread Eugen Hristev
Hi Alexander, On 8/9/23 17:16, Alexander Dahl wrote: Copied dts pieces from Linux Kernel. Support is optional for now, to make it work the following options have to be enabled: CONFIG_LED, CONFIG_LED_GPIO, CONFIG_CMD_LED. Signed-off-by: Alexander Dahl --- .../dts/at91-sam9x60_curiosity-u-bo

Re: [PATCH 2/4] configs: at91: sam9x60: Switch to new reset driver

2023-08-16 Thread Eugen Hristev
Hi Alexander, On 8/9/23 17:16, Alexander Dahl wrote: Since commit 61040097a9d1 ("reset: at91: Add reset driver for basic assert/deassert operations") the compatible "microchip,sam9x60-rstc" for the sam9x60 reset controller in sam9x60.dtsi is not handled by CONFIG_SYSRESET_AT91 anymore, but by

Re: [PATCH 1/4] configs: at91: sam9x60_curiosity: Sync both defconfig variants

2023-08-16 Thread Eugen Hristev
Hi Alexander, On 8/9/23 17:16, Alexander Dahl wrote: The board has two SD card slots and we have two defconfigs for booting from either the first (micro SD) named 'sam9x60_curiosity_mmc_defconfig' or the second (full size SD) named 'sam9x60_curiosity_mmc1_defconfig'. For comparable Microchip boa

Re: [PATCH v2 06/10] ARM: dts: rockchip: rk3588-rock-5b-u-boot: add bootph-all to gadget nodes

2023-08-13 Thread Eugen Hristev
On 8/12/23 05:53, Kever Yang wrote: Hi Eugen, On 2023/8/1 15:28, Eugen Hristev wrote: Add bootph-all to gadget nodes to have the gadget available in SPL. Does this gadget available on both USB2 and USB3? I think only USB2 is enough? Hi Kever, This board has one USB type C that is

Re: [PATCH 0/2] mtd: nand: raw: atmel: R/B gpio on sam9x60

2023-08-08 Thread Eugen Hristev
Added Mihai who tested this a lot at some point in time Eugen On 8/8/23 16:02, Alexander Dahl wrote: Hello everyone, this is a patch series wtih some real fixes _and_ a question or some kind of support request in the cover letter. I would be happy if anyone could read the cover letter careful

Re: [PATCH v2] board: rockchip: Add Bananapi R2Pro Board

2023-08-08 Thread Eugen Hristev
Hi Frank, On 8/8/23 11:09, Frank Wunderlich wrote: From: Frank Wunderlich Add Bananapi R2 Pro board. Signed-off-by: Frank Wunderlich --- because iodomain is different to evb and now iodomain driver is sent as patch we need to separate between EVB and R2Pro else board can be bricked. --- v2:

[PATCH RESEND v3] fpga: add inline stub for fpga_load

2023-08-08 Thread Eugen Hristev
ommon/spl/spl_fit.c:595: undefined reference to `fpga_load' To solve this, added an inline empty stub in the header if CC_OPTIMIZE_FOR_DEBUG is set such that the build will succeed. Signed-off-by: Eugen Hristev --- Changes in v3: - return -ENOSYS Changes in v2: - this is a rework as suggested b

Re: [PATCH 4/7] net: dwc_eth_qos: Add glue driver for GMAC on Rockchip RK3568

2023-08-07 Thread Eugen Hristev
Hi Jonas, Thank you for your work, On 8/7/23 03:08, Jonas Karlman wrote: Add a new glue driver for Rockchip SoCs, i.e RK3568, with a GMAC based on Synopsys DWC Ethernet QoS IP. rk_gmac_ops was ported from linux commit: 3bb3d6b1c195 ("net: stmmac: Add RK3566/RK3568 SoC support") Signed-off-by:

Re: [PATCH v2] board: at91: sama5d29_curiosity: add initial support for sama5d29_curiosity

2023-08-07 Thread Eugen Hristev
On 7/24/23 14:35, Mihai Sain wrote: Add initial support for sama5d29_curiosity board. Hardware: SoC: SAMA5D29 500 MHz DRAM: LPDDR2 512 MiB PMIC: MCP16502 Debug: UART0 Flash: QSPI NOR 8 MiB RGB LCD connector Mikrobus connectors x 2 SD-Card connectors x 2 USB 2.0 x 2 Changes in v2: The version

[PATCH] MAINTAINERS: add DT/bindings files to at91 entry

2023-08-07 Thread Eugen Hristev
With this change the DT and binding files are under the at91 tree maintainer, and get_maintainer.pl correctly reports the entry. Signed-off-by: Eugen Hristev --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 47581cf6fbb8..23d1d232a415

Re: [PATCH 3/5] clk: rockchip: rk3568: Include UART clocks in SPL

2023-08-04 Thread Eugen Hristev
this, but the result was just that the 'clock not found' message was removed. I am happy that you found some time to do these changes Reviewed-by: Eugen Hristev

Re: [PATCH 0/5] ARM: dts: at91: Improve sam9x60-curiosity

2023-08-02 Thread Eugen Hristev
On 7/5/23 23:16, Alexander Dahl wrote: Hello everyone, currently I have the Microchip SAM9X60-Curiosity board on my desk and for evaluation purposes I'm trying to get it booting from NAND flash without SD card. This series contains a collection of patches I made on that journey. It's probably

Re: Data abort when starting DFU on SAMA5D2

2023-08-02 Thread Eugen Hristev
Hi Alexis, On 8/1/23 10:09, Alexis Lothoré wrote: Hi, I am currently using an ATSAMA5D27-WLSOM1-EK1. This boards embeds an ATSAMA5D27-WLSOM1, which in turns holds an ATSAMA5D27 and a 8MB QSPI flash. I have been wanting to program u-boot in the QSPI flash thanks to DFU, since the board is able to

[PATCH v2 10/10] configs: rockchip: rock5b-rk3588: enable DFU and related configs

2023-08-01 Thread Eugen Hristev
Enable DFU and related configs, expand stack and buffers to hold downloaded image. Signed-off-by: Eugen Hristev --- Changes in v2: - added # CONFIG_SPL_BINMAN_UBOOT_SYMBOLS is not set because with the configs enabled here, this is automatically set as =y and this causes a build failure

[PATCH v2 09/10] rockchip: rk3588: prepare env for DFU

2023-08-01 Thread Eugen Hristev
Prepare env variables for DFU Signed-off-by: Eugen Hristev --- include/configs/rk3588_common.h | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/include/configs/rk3588_common.h b/include/configs/rk3588_common.h index 46389d087d29..48414fe946a0 100644 --- a/include

[PATCH v2 08/10] ARM: mach-rockchip: rk3588: add gadget device to the boot order

2023-08-01 Thread Eugen Hristev
In case SPL was booted from USB, add the gadget as the boot device for the 'same-as-spl' boot order next device. Signed-off-by: Eugen Hristev --- arch/arm/mach-rockchip/rk3588/rk3588.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-rockchip/rk3588/rk3588.c b/arc

[PATCH v2 07/10] ARM: mach-rockchip: spl-boot-order: add possibility to DFU

2023-08-01 Thread Eugen Hristev
Add DFU as a possible SPL boot media if the boot device is a gadget device. Signed-off-by: Eugen Hristev --- arch/arm/mach-rockchip/spl-boot-order.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/mach-rockchip/spl-boot-order.c b/arch/arm/mach-rockchip/spl-boot-order.c index

[PATCH v2 05/10] usb: dwc3: Increase DWC3 controller halt timeout

2023-08-01 Thread Eugen Hristev
: Wesley Cheng Link: https://lore.kernel.org/r/20220901193625.8727-4-quic_wch...@quicinc.com Cherry-picked from Linux: 461ee467507c ("usb: dwc3: Increase DWC3 controller halt timeout") Signed-off-by: Eugen Hristev --- Not to be merged, I know Marek does not apply any patches to DWC3. driver

[PATCH v2 06/10] ARM: dts: rockchip: rk3588-rock-5b-u-boot: add bootph-all to gadget nodes

2023-08-01 Thread Eugen Hristev
Add bootph-all to gadget nodes to have the gadget available in SPL. Signed-off-by: Eugen Hristev --- arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi b/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi index

[PATCH v2 04/10] usb: dwc3: core: Only handle soft-reset in DCTL

2023-08-01 Thread Eugen Hristev
From: Venkatesh Yadav Abbarapu [ Nguyen/Greg: Ported from Linux kernel commit f4fd84ae0765a ("usb: dwc3: core: Only handle soft-reset in DCTL") ] Make sure not to set run_stop bit or link state change request while initiating soft-reset. Register read-modify-write operation may unintenti

[PATCH v2 03/10] usb: dwc3: gadget: Don't send unintended link state change

2023-08-01 Thread Eugen Hristev
From: Venkatesh Yadav Abbarapu [ Nguyen/Felipe/Greg: Ported from Linux kernel commit 5b738211fb59 ("usb: dwc3: gadget: Don't send unintended link state change") ] DCTL.ULSTCHNGREQ is a write-only field. When doing a read-modify-write to DCTL, the driver mu

  1   2   3   4   5   6   7   >