Re: [PATCH v2 2/8] arm: at91: wdt: Remove unused at91_wdt struct

[Eugen Hristev]

On 4/17/25 12:09, Zixun LI wrote:
> at91_wdt struct is not used by anyone, let's remove it.
> 
> Signed-off-by: Zixun LI <ad...@hifiphile.com>
> ---
>  arch/arm/mach-at91/include/mach/at91_wdt.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/arch/arm/mach-at91/include/mach/at91_wdt.h 
> b/arch/arm/mach-at91/include/mach/at91_wdt.h
> index 
> 8ef8e007d7767308a5b46be46b02c51073723a41..78ad0453fd9eb3e42674d10cb11ce3da820cdc6a
>  100644
> --- a/arch/arm/mach-at91/include/mach/at91_wdt.h
> +++ b/arch/arm/mach-at91/include/mach/at91_wdt.h
> @@ -19,12 +19,6 @@
>  
>  #else
>  
> -typedef struct at91_wdt {
> -     u32     cr;
> -     u32     mr;
> -     u32     sr;
> -} at91_wdt_t;
> -
>  struct at91_wdt_priv {
>       void __iomem *regs;
>       u32 regval;
> 

I would merge patch 1 with patch 2 (this one).
Removing references to a struct and removing the struct itself is a
single logical step. Having just patch 1 in the tree would leave out a
state where a non-used struct exists.