On 4/25/25 16:50, Zixun LI wrote:
> On Fri, Apr 25, 2025 at 12:51 PM Eugen Hristev <eugen.hris...@linaro.org>
> wrote:
>>
>> This 'timeout-sec' property is not in Linux DT. Any reason for adding it
>> ? is the default different in U-boot ?
>>
>
> The timeout initialization is different in Linux, where the driver's
> default value (16s) is taken during probing. On U-Boot without
> <timeout-sec> the timeout is set to default value of 60s.
You could change the default to match Linux, or, move the timeout-sec=16
to sam9x60-u-boot.dtsi file
>
> Since at91_wdt's maximum timeout is 16s, any higher value will be clamped
> to 16s in the driver. I think it will make some confusion if the logs says
> watchdog has 60s timeout but reset happens earlier:
>
> WDT: Started watchdog@ffffff80 with servicing every 1000ms (60s timeout)
>
> What do you think, should we add a warning for the actual timeout ?
No, one of the options above is better I think
>
>> I would add the support for sam9x60 as a single patch, this one and
>> previous (patch 5) which adds the registers definition.
>
> Which prefix should I use, arm:at91:wdt or watchdog: at91sam9_wdt ?
This would be driver support so I think watchdog: at91sam9_wdt
