Hello Eugen,
thanks for looking at this. My remarks below.
Am Thu, Jan 30, 2025 at 11:49:30AM +0200 schrieb Eugen Hristev:
> Hello Alex,
>
> On 1/23/25 14:12, Alexander Dahl wrote:
> > The qspi controller on sama5d2 and sam9x60 supports "classic" SPI mode
> > w
_SECURE)
> -int do_fpga_loads(struct cmd_tbl *cmdtp, int flag, int argc, char *const
> argv[])
> +static int do_fpga_loads(struct cmd_tbl *cmdtp, int flag, int argc,
> + char *const argv[])
> {
> size_t data_size = 0;
> long fpga_data, dev;
Reviewed-by: Alexander Dahl
Build tested for our custom boards.
Greets
Alex
scan(const struct
> ubifs_info *c, int lnum,
> void ubifs_end_scan(const struct ubifs_info *c, struct ubifs_scan_leb *sleb,
> int lnum, int offs)
> {
> - lnum = lnum;
> dbg_scan("stop scanning LEB %d at offset %d", lnum, offs);
> ubifs_assert(offs % c->min_io_size == 0);
Wow, these are old, both date back to 2009 in U-Boot.
Reviewed-by: Alexander Dahl
Greets
Alex
Hello Floyd,
Am Thu, Jan 23, 2025 at 02:04:03PM -0500 schrieb Floyd Brown:
> When I run the same file against both utilities, they do not produce
> the same CRC.
>
> The CRC of fw_setenv matches what uboot has when the environment is
> created inside the image.
fw_setenv is Linux userland to wri
Report spi clk speed and make use of `log_ret()`.
Signed-off-by: Alexander Dahl
---
drivers/spi/atmel-quadspi.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c
index a2faac5a505..8aa7a83aef4 100644
e only one
hardware controlled CS line is supported. Some fields are missing, some
are in different registers, but in principal it works similar. So code
is very much inspired by the old atmel-spi driver.
Tested on sam9x60 with a non-mainline driver to configure an FPGA.
Signed-off-by: Alex
zero warning").
Reduces differences between linux and u-boot driver.
Cc: Tudor Ambarus
Cc: Yoshitaka Ikeda
Signed-off-by: Alexander Dahl
---
drivers/spi/atmel-quadspi.c | 27 ++-
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/drivers/spi/atmel-quadspi.c
out switching to
Serial Memory Mode to function")
Cc: Csókás Bence
Signed-off-by: Alexander Dahl
---
drivers/spi/atmel-quadspi.c | 96 -
1 file changed, 51 insertions(+), 45 deletions(-)
diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atm
Switching between Serial Memory Mode (SMM) and (classic) SPI mode is a
preparation for implementing .xfer() in the future.
Signed-off-by: Alexander Dahl
---
drivers/spi/atmel-quadspi.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/drivers/spi/atmel
ribed in another thread. But there are almost no
changes related to at91 socs, boards, and drivers in the last months
here, so it should be comparable.
Greets
Alex
(Cc-ing the contributors of the Linux fixes here.)
Cc: Tudor Ambarus
Cc: Yoshitaka Ikeda
Cc: Csókás Bence
Alexander Dahl (7):
sp
value in a future
implementation of .xfer() which needs to disable SMM.
Signed-off-by: Alexander Dahl
---
drivers/spi/atmel-quadspi.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c
index 9e596b7448c..467f29c01ca 100644
--- a/drivers
ts_op'
make[1]: *** [/mnt/data/adahl/src/u-boot/Makefile:1821: u-boot] Error 1
Signed-off-by: Alexander Dahl
---
drivers/spi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 96ea033082b..d55fc49f637 100644
--- a/d
ts_op'
make[1]: *** [/mnt/data/adahl/src/u-boot/Makefile:1821: u-boot] Error 1
Signed-off-by: Alexander Dahl
---
drivers/spi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 6555142a41e..a916b711ba8 100644
--- a/d
This is inside of an 'if DM_SPI' block, and thus always true.
Signed-off-by: Alexander Dahl
---
drivers/spi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 96ea033082b..6555142a41e 100644
--- a/drivers/spi/Kco
Hello,
Am Tue, Jan 21, 2025 at 05:22:12PM +0100 schrieb Alexander Dahl:
> Fixes annoying warnings of the following type when built with W=1 (for
> each file including fpga.h):
>
> CC drivers/fpga/fpga.o
> In file included from /mnt/data/adahl/src/u-boot/inc
cast cleanup on that fpga_desc type file at it.
Link:
https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wignored-qualifiers
Signed-off-by: Alexander Dahl
---
drivers/fpga/fpga.c | 14 +++---
include/fpga.h | 6 +++---
2 files changed, 10 insertions(+), 10 deletions
Hello,
Am Mon, Jan 20, 2025 at 02:40:38PM +0530 schrieb Sughosh Ganu:
> On Fri, 17 Jan 2025 at 16:40, Alexander Dahl wrote:
[…]
> > This changeset breaks build with CONFIG_CC_OPTIMIZE_FOR_DEBUG=y for
> > me. In a usual non-debug build, everything is fine. However in a
> &
Hello,
Am Fri, Jan 17, 2025 at 11:25:51AM + schrieb Ibai Erkiaga:
> @@ -1192,7 +1198,7 @@ config CMD_FPGA_LOADMK
> config CMD_FPGA_LOAD_SECURE
> bool "fpga loads - loads secure bitstreams"
> depends on CMD_FPGA
> - select FPGA_LOAD_SECURE
> + select FPGA_LOAD_SECURE && FPG
; -" loadb\t[dev] [address] [size]\t"
> - "Load device from bitstream buffer (Xilinx only)\n"
> + "fpga loadb Load device from bitstream
> buffer\n"
> + "(Xilinx only)\n"
I would have aligned the second line
Hei hei,
Am Tue, Oct 15, 2024 at 09:07:07PM +0530 schrieb Sughosh Ganu:
> In U-Boot, LMB and EFI are two primary modules who provide memory
> allocation and reservation API's. Both these modules operate with the
> same regions of memory for allocations. Use the LMB memory map update
> event to not
This reverts commit af6266c1c27add8beac7f3365c00b3525a9012c4.
Signed-off-by: Alexander Dahl
---
Cc: Mathew McBride
Cc: Pratyush Yadav
Cc: Priyanka Jain
Cc: Sean Anderson
Cc: Jagan Teki
include/spi-mem.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/spi-mem.h b/include/spi-mem.h
index 3c8e
;spi: atmel: Drop atmel_spi.h")
Signed-off-by: Alexander Dahl
---
Notes:
Build tested for all upstream atmel boards. This is no complete build
coverage, but should be safe to remove, because it is not included
anywhere.
drivers/spi/atmel_spi.h | 86 -
patch 2/2
Cc: Tom Rini
Cc: Jagan Teki
Alexander Dahl (2):
spi: atmel: Really drop atmel_spi.h
Revert "mem: spi-mem: add declaration for spi_mem_default_supports_op"
drivers/spi/atmel_spi.h | 86 -
include/spi-mem.h | 3 --
2 files c
> */
> - now = timer_get_us();
> + now = get_timer_us(0);
Acked-by: Alexander Dahl
Greets
Alex
> if (time_after_eq64(now, cyclic->next_call)) {
> /* Call cyclic function and account it's cpu-time */
> cyclic->next_call = now + cyclic->delay_us;
> --
> 2.25.1
>
Hello,
Am Wed, Jan 08, 2025 at 02:03:50PM + schrieb Ibai Erkiaga:
> The current implementation generates some alignment issues as well as
> some overlapping when all the fpga command options are enabled. The fix
> is intended to improve readability of the usage info.
Alignment could indeed im
Hello Michael,
Am Tue, Oct 08, 2024 at 02:12:38PM +0200 schrieb Michael Nazzareno Trimarchi:
> Hi
>
> On Tue, Oct 8, 2024 at 1:41 PM Eugen Hristev
> wrote:
> >
> > On 9/30/24 11:07, Alexander Dahl wrote:
> > > Hello,
> > >
> > > Am Tue, May
Hello Bala,
Am Wed, Oct 09, 2024 at 04:45:02AM + schrieb
balamanikandan.gunasun...@microchip.com:
> On 30/09/24 1:37 pm, Alexander Dahl wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> > content is safe
> >
> > Hello,
>
;spi: atmel: Drop atmel_spi.h")
Signed-off-by: Alexander Dahl
---
Notes:
Build tested for all upstream atmel boards. This is no complete build
coverage, but should be safe to remove, because it is not included
anywhere.
drivers/spi/atmel_spi.h | 86 -
Hello Lothar,
Am Wed, Dec 04, 2024 at 06:33:13PM + schrieb Lothar Rubusch:
> Fix some typos and duplicate words in gdb.rst.
>
> Signed-off-by: Lothar Rubusch
> Acked-by: Alexander Dahl
> ---
> doc/develop/gdb.rst | 10 +-
> 1 file changed, 5 insertions(+), 5 d
$1 = 0x27f7a000
>
> In the GDB shell discard the previously loaded symbol file and add it once
> -again with the relocation address like this:
> +again, with the relocation address like this:
>
> .. code-block:: console
Acked-by: Alexander Dahl
Greets
Alex
t; native speaker). Please, could you clarify the following?
What about mentioning the tool in the commit message then?
>
> On Wed, Nov 20, 2024 at 8:15 AM Alexander Dahl wrote:
> >
> > Hello Lothar,
> >
> > Am Tue, Nov 19, 2024 at 10:28:36PM + schrieb Lothar Ru
Hello Lothar,
Am Tue, Nov 19, 2024 at 10:28:36PM + schrieb Lothar Rubusch:
> Fix some typos and duplicate words in gdb.rst.
>
> Signed-off-by: Lothar Rubusch
> ---
> doc/develop/gdb.rst | 14 +++---
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/doc/develop/gdb.
Hello,
Am Tue, Oct 22, 2024 at 04:23:07PM +0300 schrieb Andy Shevchenko:
> On Mon, Oct 21, 2024 at 06:32:21PM +0200, Simon Glass wrote:
> > On Mon, 21 Oct 2024 at 16:27, Andy Shevchenko
> > wrote:
> > >
> > > looking at the redness of the output of `make W=1` here is the question:
> > > isn't it
Hello Benedikt,
Am Mon, Oct 21, 2024 at 12:20:17PM +0200 schrieb Benedikt Spranger:
> The SPL sits in the first Page in NAND flash. It does it's magic and
> then load the U-Boot payload from an UBI volume (Or directly load a
> kernel). Then it "starts" the payload.
>
> > Did you try reading/writi
Hello Eugen,
Am Mon, Oct 21, 2024 at 10:17:54AM +0300 schrieb Eugen Hristev:
> Hello,
>
> On 10/21/24 09:03, Alexander Dahl wrote:
> > Hello Benedikt,
> >
> > Am Fri, Oct 18, 2024 at 04:19:08PM +0200 schrieb Benedikt Spranger:
> > > On Fri, 18 Oct 2024 15:11:
Hello Benedikt,
Am Fri, Oct 18, 2024 at 04:19:08PM +0200 schrieb Benedikt Spranger:
> On Fri, 18 Oct 2024 15:11:20 +0200
> Alexander Dahl wrote:
>
> Hello Alexander,
>
> > Am Fri, Oct 18, 2024 at 10:30:00AM +0200 schrieb Benedikt Spranger:
> > > OK, you might say
Hello Benedikt,
Am Fri, Oct 18, 2024 at 10:30:00AM +0200 schrieb Benedikt Spranger:
> Hi,
>
> while porting an ATSAMA5D2 based board (booting from NAND flash with UBI)
> I stumbled over generic, NAND- and UBI related asperity:
>
> 1. tiny-printf does not handle NULL arguments to '%s' in a proper
some messages that are clearly not on
> the error path.
>
> Note that there's one pr_debug in there, because it is followed by
> pr_cont so it made sense to reuse the same family of functions.
>
> Reported-by: Alexander Dahl
> Fixes: 6afdb1585112 ("dm: core: mig
Hello Quentin,
thanks for you quick reply, see my remarks below.
Am Wed, Oct 02, 2024 at 11:25:38AM +0200 schrieb Quentin Schulz:
> Hi Alexander,
>
> On 10/2/24 10:37 AM, Alexander Dahl wrote:
> > Hello Quentin,
> >
> > sorry for being late to the party, but I j
Hello Quentin,
sorry for being late to the party, but I just tested v2024.10-rc6 and
my console output looks like this now:
ofnode_read_bool: bootph-all: true
ofnode_read_u32_array: ranges: ofnode_read_bool: bootph-all: false
ofnode_read_bool: bootph-some-ram: false
ofnode_read_bo
[-Wimplicit-function-declaration]
Fixes: 927b901b47a6 ("ARM: atmel: add sama5d4ek board support")
Signed-off-by: Alexander Dahl
---
Notes:
based on next
arch/arm/mach-at91/include/mach/clk.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-at91/include/mach/clk.h
b/a
Hello,
Am Tue, May 28, 2024 at 12:32:44PM +0200 schrieb Alexander Dahl:
> Hei hei,
>
> Am Mon, Apr 15, 2024 at 09:57:55AM +0200 schrieb Alexander Dahl:
> > From reading the S34ML02G1 and the SAM9X60 datasheets again, it seems
> > like we have to wait tREA after rising RE
ionally, some exception handler code may be copied to the low 8 kB
> +of DRAM (0x ... 0x1fff).
> +
> +So a typical memory configuration with 16 MB of DRAM could look like
> +this::
> +
> + 0x Exception Vector code
> + :
> + 0x 1fff
> + 0x0000 2000 Free
Hello Dinesh,
Am Thu, Sep 19, 2024 at 11:54:53AM +0800 schrieb dinesh.mani...@intel.com:
> From: Dinesh Maniyam
>
> This patchset add Cadence NAND driver support for
> Intel Agilex5 devices.
>
> The NAND driver is leveraged from the cadence-nand-controller.c
> from Linux. U-Boot will support re
Hello Marcus,
Am Fri, Aug 09, 2024 at 02:15:43PM +0200 schrieb Marcus Folkesson:
> The condition 'ret' is always true as it is never set to other than
> -EIO.
Technically, you're right.
I quickly compared with the same driver in Linux. That has some
additional lines for DMA transfers which prob
Hello Christian,
Am Wed, Aug 07, 2024 at 09:54:12PM +0200 schrieb Christian Marangi:
> Introduce simple led.rst documentation to document all the additional
> Kconfig and the current limitation of LED_BLINK and GPIO software blink.
This is a good idea. An overview of all the LED possibilities in
command line with various combinations of commands,
no crashes, so …
Tested-by: Alexander Dahl
Greets
Alex
> ---
> fs/ubifs/ubifs.c | 9 ++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/fs/ubifs/ubifs.c b/fs/ubifs/ubifs.c
> index 048730db7f..6acd
Hei Eden,
Am Wed, Aug 07, 2024 at 07:59:39AM -0600 schrieb Simon Glass:
> Hi Eden,
>
> I don't see it on the mailing list yet[1].
FWIW in case you did not notice, there's a patch series for
barebox currently worked on implementing ecdsa support for fit image
verification. Maybe that can be help
Hello,
Am Mon, Aug 05, 2024 at 07:28:19AM +0200 schrieb Heiko Schocher:
> Hello Ravi,
>
> On 01.08.24 21:39, Ravi Minnikanti wrote:
> > Hi Heiko, Alexander,
> >
> > On 7/31/24 23:54, Heiko Schocher wrote:
> > > Hello Alexander, On 01. 08. 24 08: 50, Alexan
Hei,
Am Thu, Jul 04, 2024 at 10:18:55AM +0200 schrieb Alexander Dahl:
> Hello Heiko,
>
> Am Thu, Jul 04, 2024 at 06:28:31AM +0200 schrieb Heiko Schocher:
> > Hello Alexander,
> >
> > On 03.07.24 12:12, Alexander Dahl wrote:
> > > Hei hei,
> > >
>
tp, int flag, int argc,
> char *const argv[])
> return 0;
> }
>
> -#ifdef CONFIG_LED_BLINK
> +#if defined(CONFIG_LED_BLINK) || defined(CONFIG_LED_SW_BLINK)
This looks fine.
Acked-by: Alexander Dahl
Greets
Alex
> #define BLINK "|blink [blink-freq in ms]"
> #else
> #define BLINK ""
> --
> 2.39.2
>
Hello,
Am Tue, Jul 09, 2024 at 10:28:12PM + schrieb Zixun Li:
> When ECC parameters are not specified in DT, first try ONFI ECC parameters
> before fallback to maximum strength. To be inline with kernel driver behavior.
>
> Signed-off-by: Zixun LI
> ---
> drivers/mtd/nand/raw/atmel/nand-con
Hello Heiko,
Am Thu, Jul 04, 2024 at 06:28:31AM +0200 schrieb Heiko Schocher:
> Hello Alexander,
>
> On 03.07.24 12:12, Alexander Dahl wrote:
> > Hei hei,
> >
> > filesystem handling is different in U-Boot and beyond that UBI/UBIFS is
> > different from other fi
functions, but you never know?!
Signed-off-by: Alexander Dahl
---
fs/ubifs/ubifs.c | 20
1 file changed, 20 insertions(+)
diff --git a/fs/ubifs/ubifs.c b/fs/ubifs/ubifs.c
index 506e29958c3..9722cc440ab 100644
--- a/fs/ubifs/ubifs.c
+++ b/fs/ubifs/ubifs.c
@@ -573,6 +573,11 @@ int
Although kfree() is in fact only a slim wrapper to free() in U-Boot, use
kfree() here, because those structs where allocated with kalloc() or
kzalloc().
Signed-off-by: Alexander Dahl
---
fs/ubifs/super.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ubifs/super.c b
size(), and ubifs_read() we can be
sure the volume is opened and the necessary struct pointer in sb is
valid, so it is not needed to open volume again.
Fixes: 9eefe2a2b37 ("UBIFS: Implement read-only UBIFS support in U-Boot")
Fixes: 29cc5bcadfc ("ubifs: Add functions for generic fs use
tly after the free() to make it easier to understand.)
Signed-off-by: Alexander Dahl
---
fs/ubifs/super.c | 4
fs/ubifs/ubifs.c | 1 -
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index 788f88f0495..321c9b9351e 100644
--- a/fs/ubifs/super.c
m/rauc/rauc/blob/master/contrib/uboot.sh
Alexander Dahl (4):
fs: ubifs: Fix memleak and double free in u-boot wrapper functions
fs: ubifs: Set pointers to NULL after free
fs: ubifs: Make k(z)alloc/kfree symmetric
fs: ubifs: Add volume mounted check
fs/ubifs/supe
/view/DULG/DebuggingUBoot
Link:
https://web.archive.org/web/20141206064148/http://www.denx.de/wiki/view/DULG/GDBScripts1
Suggested-by: Marek Vasut
Signed-off-by: Alexander Dahl
---
doc/develop/gdb.rst | 154 ++
doc/develop/index.rst | 1 +
2 files
Hello Arseniy,
Am Sun, Jun 02, 2024 at 11:08:34PM +0300 schrieb Arseniy Krasnov:
> Based on Linux kernel:
> commit f922bd798bb9 ("mtd: rawnand: add an option to specify NAND chip as a
> boot device")
>
> Allow to define a NAND chip as a boot device. This can be helpful
> for the selection of the
Fixes: fc3283314539 ("doc: Explain briefly how to write new tests")
Signed-off-by: Alexander Dahl
---
doc/develop/testing.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/develop/testing.rst b/doc/develop/testing.rst
index 056bdfd2b69..9114d11ad26 100644
This should have been adapted directly with or after
v2021.01-693-gca6583d4e08 ("doc: move test/README to HTML
documentation") or v2021.01-694-g0157619d5c8 ("doc: move
test/py/README.md to HTML documentation") already.
Signed-off-by: Alexander Dahl
---
doc/develop/testin
Found some more broken reference links when reading the documentation.
Greets
Alex
Alexander Dahl (2):
doc: develop: testing: Fix broken reference to pytest suite help
doc: develop: testing: Fix reference to test writing section
doc/develop/testing.rst | 4 ++--
1 file changed, 2
ameters for FIT image type
This is especially unfortunate if LEGACY_IMAGE_FORMAT is disabled as
recommended.
Listing the script configuration in a "sign-images" subnode instead,
would have added even more complexity to the already complex auto fit
generation code.
Signed-off-by: Alex
Fixes: ad29e08b79fd ("doc: Bring in FIT signature files")
Signed-off-by: Alexander Dahl
---
doc/usage/fit/signature.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/usage/fit/signature.rst b/doc/usage/fit/signature.rst
index 03a71b5192d..b868dcbf9fd 100644
Hei hei,
Am Mon, Apr 15, 2024 at 09:57:55AM +0200 schrieb Alexander Dahl:
> From reading the S34ML02G1 and the SAM9X60 datasheets again, it seems
> like we have to wait tREA after rising RE# before sampling the data.
> Thus pulse time must be at least tREA.
>
> Without this f
The function returns the rate of the parent clock, the previous text
made no sense at all.
Fixes: 4aa78300a025 ("dm: clk: Define clk_get_parent_rate() for clk operations")
Signed-off-by: Alexander Dahl
Reviewed-by: Sean Anderson
---
Notes:
v2:
- Collected tags
include/clk.h
ied over from at91bootstrap, and
has been successfully tested in at91bootstrap, U-Boot and Linux.
Link: https://github.com/linux4sam/at91bootstrap/issues/174
Cc: Li Bin
Signed-off-by: Alexander Dahl
---
Notes:
v3:
- initial patch version (not present in v1 and v2)
drivers/mtd/nand/raw/at
Override the ONFI timing mode at runtime.
Signed-off-by: Alexander Dahl
---
Notes:
v3:
- no changes to this patch
v2:
- initial patch version (not present in v1)
cmd/Kconfig | 10 ++
cmd/nand.c | 61
(15 ns), hold: 2 (10 ns), cycle: 7 (35
ns)
Standard read applied
TDF optimization enabled
TDF cycles: 15 (75 ns)
Data Bus Width: 8-bit bus
NWAIT Mode: 0
Write operation controlled by NWE signal
Read operation controlled by NRD signal
Signed-off-by: Alexander Dahl
Tested-by:
: https://lore.kernel.org/u-boot/20240307091014.39796-1-...@thorsis.com/
See per patch changes in patches for more detailed changes.
Alexander Dahl (3):
mtd: nand: raw: atmel: Introduce optional debug commands
cmd: nand: Add new optional sub-command 'onfi'
mtd: nand: raw: atmel:
Hello Dario,
Am Sun, Apr 14, 2024 at 03:41:38PM +0200 schrieb Dario Binacchi:
> Hi Alexander,
>
> On Wed, Mar 20, 2024 at 10:02 AM Alexander Dahl wrote:
> >
> > Hello everyone,
> >
> > while working on NAND flash support for a custom board based on the at91
>
@@ out:
> static void __maybe_unused fat2rtc(u16 date, u16 time, struct rtc_time *tm)
> {
> tm->tm_mday = date & 0x1f;
> - tm->tm_mon = (date & 0x1e0) >> 4;
> + tm->tm_mon = (date & 0x1e0) >> 5;
> tm->tm_year = (date >> 9) + 1980;
>
> tm->tm_sec = (time & 0x1f) << 1;
Reviewed-by: Alexander Dahl
Greets
Alex
Hello Michael,
Am Fri, Mar 22, 2024 at 12:54:27PM +0100 schrieb Michael Nazzareno Trimarchi:
> HI
>
> On Fri, Mar 22, 2024 at 12:46 PM Alexander Dahl wrote:
> >
> > Hello Mihai,
> >
> > Am Fri, Mar 22, 2024 at 10:02:29AM + schrieb mihai.s..
Hello Mihai,
Am Fri, Mar 22, 2024 at 10:02:29AM + schrieb mihai.s...@microchip.com:
> Hi Michael,
>
> ---
>
> I think this command can be really useful.
> Let try to have more testing on more boards
>
>
ainline Linux
kernel commit 1c60e027ffde ("mtd: nand: raw: atmel: Fix comment in
timings preparation").
Link:
https://lore.kernel.org/linux-mtd/20240307172835.3453880-1-miquel.ray...@bootlin.com/T/#t
Signed-off-by: Alexander Dahl
---
Notes:
v2:
- initial patch version (not pre
(15 ns), hold: 2 (10 ns), cycle: 7 (35
ns)
Standard read applied
TDF optimization enabled
TDF cycles: 15 (75 ns)
Data Bus Width: 8-bit bus
NWAIT Mode: 0
Write operation controlled by NWE signal
Read operation controlled by NRD signal
Signed-off-by: Alexander Dahl
Tested-by:
Override the ONFI timing mode at runtime.
Signed-off-by: Alexander Dahl
---
Notes:
v2:
- initial patch version (not present in v1)
cmd/Kconfig | 10 ++
cmd/nand.c | 61
drivers/mtd/nand/raw/nand_base.c
the
other definitions with the same help text it has in Linux.
Code actually using this has not been ported over to raw nand base yet.
Signed-off-by: Alexander Dahl
Reviewed-by: Michael Trimarchi
---
Notes:
v1:
- initial patch version
v2:
- collected tags
drivers/mtd/nand/raw/
In every other place in this file the macro is used, make it consistent.
Fixes: 9d1806fadc24 ("mtd: nand: Get rid of mtd variable in function calls")
Signed-off-by: Alexander Dahl
Reviewed-by: Michael Trimarchi
---
Notes:
v1:
- initial patch version
v2:
- coll
letter
See per patch changes in patches for more detailed changes.
Alexander Dahl (6):
mtd: nand: raw: Use macro nand_to_mtd() where appropriate
mtd: nand: raw: Port another option flag from Linux
mtd: nand: raw: Fix (most) Kconfig indentation
mtd: nand: raw: atmel: Introduce optional debug
One tab in general. One tab plus two spaces for help text.
Signed-off-by: Alexander Dahl
Reviewed-by: Michael Trimarchi
---
Notes:
v1:
- initial patch version
v2:
- collected tags
drivers/mtd/nand/raw/Kconfig | 106 +--
1 file changed, 53
Hello everyone,
Am Mon, Mar 18, 2024 at 11:15:18AM + schrieb mihai.s...@microchip.com:
>
> > The command is very useful.
> > I would like to have also the ONFI timing mode printed for nand-flash
> > 😊
>
> As far as I can see the ac
Hello Mihai,
adding the raw nand maintainers to Cc, maybe cmd/nand.c should be
added to MAINTAINERS file section raw nand? See my comments below.
Am Mon, Mar 18, 2024 at 02:26:47PM +0200 schrieb Mihai Sain:
> Add support to nand info for printing the manufacturer,model and size.
>
> U-Boot> nan
he
original commit message of the patch attached to that ticket not easy
to understand however, so I wrote what I think is the problem. Could
you please test the patch attached to this mail which does the same
thing and should apply to U-Boot cleanly? I tested that on sam9x60
and sama5, but have no ot
Hello Mihai,
Am Mon, Mar 18, 2024 at 09:07:09AM + schrieb mihai.s...@microchip.com:
> > U-Boot> nand info
> >
> > Device 0: nand0, sector size 256 KiB
> > Manufacturer MACRONIX
> > Model MX30LF4G28AD
> > Device size512 MiB
> > Page size 4096 b
> > OOB size
Hello Mihai,
Am Mon, Mar 18, 2024 at 09:15:29AM + schrieb mihai.s...@microchip.com:
> > Hi Alexander,
> >
> > I tested your work on sama7g54-curiosity board:
> >
> > U-Boot> nand info
> >
> > Device 0: nand0, sector size 256 KiB
> > Manufacturer MACRONIX
> > Model MX30LF4G28AD
> >
Hello Mihai,
Am Mon, Mar 18, 2024 at 08:09:00AM + schrieb mihai.s...@microchip.com:
> On 3/7/24 11:10, Alexander Dahl wrote:
> > For now adds one new command 'hsmc' with a single subcommand 'decode'
> > to read and display the content of the registers of
Required for using the new dm enabled nand-controller driver on sam9260
family based boards. Ported from Linux v6.8. Node for old NAND driver
binding kept in place for now, so we can change nan controller driver
board by board.
Signed-off-by: Alexander Dahl
---
arch/arm/dts/at91sam9260.dtsi
uite
a bit) to work with U-Boot, but maybe some aspects of U-Boot driver
model where not considered correctly?
The attached patches are what I have so far, marked them as RFC because
my actual goal of using the new dm based driver for the old SoC was not
completed.
Greets
Alex
P.S.: Patch sta
moved to, is sufficient to probe the pmecc.
Signed-off-by: Alexander Dahl
---
drivers/mtd/nand/raw/atmel/nand-controller.c | 7 ---
drivers/mtd/nand/raw/atmel/pmecc.c | 1 +
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c
b
Required for using the new dm enabled nand controller driver on old
boards like the at91sam9g20-ek.
Signed-off-by: Alexander Dahl
---
drivers/memory/atmel_ebi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/memory/atmel_ebi.c b/drivers/memory/atmel_ebi.c
index 4739eef1b75
Hello Chuck,
Am Wed, Mar 06, 2024 at 11:48:39AM -0500 schrieb Chuck Meade:
> Hello,
>
> In looking through the source, I'm not yet seeing logic that allows U-Boot
> to actually use MTD partition information found in the device tree. Does
> this logic exist and I'm just missing it? Or do I need
In every other place in this file the macro is used, make it consistent.
Fixes: 9d1806fadc24 ("mtd: nand: Get rid of mtd variable in function calls")
Signed-off-by: Alexander Dahl
---
drivers/mtd/nand/raw/nand_base.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
di
a
lot when investigating issues.
Series is based on upstream next branch, but should also apply to master
cleanly.
Greets
Alex
Alexander Dahl (4):
mtd: nand: raw: Use macro nand_to_mtd() where appropriate
mtd: nand: raw: Port another option flag from Linux
mtd: nand: raw: Fix (most) Kconfig
the
other definitions with the same help text it has in Linux.
Code actually using this has not been ported over to raw nand base yet.
Signed-off-by: Alexander Dahl
---
drivers/mtd/nand/raw/atmel/nand-controller.c | 2 --
include/linux/mtd/rawnand.h | 7 +++
2 files changed, 7
3 (15 ns), hold: 2 (10 ns), cycle: 7 (35
ns)
Standard read is applied.
TDF optimization enabled
TDF cycles: 15 (75 ns)
Data Bus Width: 8-bit bus
NWAIT Mode: 0
Write operation controlled by NWE signal
Read operation controlled by NRD signal
Signed-off-by: Alexander Dahl
One tab in general. One tab plus two spaces for help text.
Signed-off-by: Alexander Dahl
---
drivers/mtd/nand/raw/Kconfig | 106 +--
1 file changed, 53 insertions(+), 53 deletions(-)
diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
index
Fixes: 3d9640f55cb2 ("doc: expand README.commands")
Signed-off-by: Alexander Dahl
---
doc/develop/commands.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/develop/commands.rst b/doc/develop/commands.rst
index ede880d248c..5ad4e59c838 100644
--- a/doc/develop/
The function returns the rate of the parent clock, the previous text
made no sense at all.
Fixes: 4aa78300a025 ("dm: clk: Define clk_get_parent_rate() for clk operations")
Signed-off-by: Alexander Dahl
---
include/clk.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
1 - 100 of 272 matches
Mail list logo
