[PATCH 1/1] sandbox: fix sandbox_hub_submit_control_msg()

2023-03-31 Thread Heinrich Schuchardt
Avoid incorrect fall through: A USB_RT_HUB request should not be treated as USB_RT_PORT. Simplify the coding: Avoid duplicate debug() statements. This fixes all -Wimplicit-fallthrough warnings. Signed-off-by: Heinrich Schuchardt --- drivers/usb/emul/sandbox_hub.c | 30 +

Re: [RFC PATCH v7 15/23] cli: add hush 2021 as parser for run_command*()

2023-03-31 Thread Simon Glass
Hi Francis, On Fri, 31 Mar 2023 at 08:49, Francis Laniel wrote: > > Enables using, in code, hush 2021 as parser for run_command function family. > It also enables the command run to be used by CLI user of hush 2021. > > Signed-off-by: Francis Laniel > --- > common/cli.c | 63 +

Re: [RFC PATCH v7 12/23] cli: Enables using hush 2021 parser as command line parser

2023-03-31 Thread Simon Glass
On Fri, 31 Mar 2023 at 08:49, Francis Laniel wrote: > > If one defines HUSH_2021_PARSER, it is then possible to use 2021 parser with: > => parser get > old > => parser set 2021 > 2021> parser get > 2021 > > Signed-off-by: Francis Laniel > --- > cmd/parser.c | 7 - > com

Re: [PATCH 4/8] tools: prelink-riscv: Unmap the ELF image when done

2023-03-31 Thread Simon Glass
On Fri, 31 Mar 2023 at 01:37, Bin Meng wrote: > > The codes forget to call munmap() to unmap the ELF image that was > mapped by previous mmap(). > > Signed-off-by: Bin Meng > --- > > tools/prelink-riscv.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Simon Glass

Re: WIP: Signing TI x509 certificates using binman

2023-03-31 Thread Simon Glass
Hi Neha, On Sat, 1 Apr 2023 at 00:14, Neha Malcom Francis wrote: > > Hi Simon > > On 31/03/23 02:01, Simon Glass wrote: > > Hi Neha, > > > > On Fri, 24 Mar 2023 at 22:28, Neha Malcom Francis wrote: > >> > >> Hi Simon, > >> > >> Before I roll out the entire series that works for packaging K3 > >>

Re: [PATCH 29/33] doc: boards: amlogic: update documentation for WeTek Core2

2023-03-31 Thread Simon Glass
Hi Christian, On Tue, 21 Mar 2023 at 18:11, Christian Hewitt wrote: > > > > On 20 Mar 2023, at 10:40 pm, Simon Glass wrote: > > > > Hi Christian, > > > > On Tue, 21 Mar 2023 at 06:05, Christian Hewitt > > wrote: > >> > >> Improve documentation. > >> > >> Signed-off-by: Christian Hewitt > >> --

Re: [RFC PATCH v7 11/23] cmd: Add new parser command

2023-03-31 Thread Simon Glass
Hi Francis, On Fri, 31 Mar 2023 at 08:49, Francis Laniel wrote: > > This command can be used to print the current parser with 'parser print'. > It can also be used to set the current parser with 'parser set'. > For the moment, only one value is valid for set: old. > > Signed-off-by: Francis Lanie

Re: [RFC PATCH v7 21/23] test: hush: Fix loop tests for hush 2021

2023-03-31 Thread Simon Glass
On Fri, 31 Mar 2023 at 08:50, Francis Laniel wrote: > > Modifies return code got from while loop as hush 2021 always returns 0 from > while loop. > > Signed-off-by: Francis Laniel > --- > test/hush/loop.c | 34 ++ > 1 file changed, 30 insertions(+), 4 deletions(-)

Re: [RFC PATCH v7 17/23] test: hush: Fix variable expansion tests for hush 2021

2023-03-31 Thread Simon Glass
On Fri, 31 Mar 2023 at 08:50, Francis Laniel wrote: > > Modifies the expected result for hush 2021. > Indeed, there were bugs in actual U-Boot hush which were fixed in upstream > Busybox. > As hush 2021 is based on upstream Busybox, these bugs no longer exist. > > Signed-off-by: Francis Laniel >

Re: [RFC PATCH v7 16/23] test: hush: Fix instructions list tests for hush 2021

2023-03-31 Thread Simon Glass
On Fri, 31 Mar 2023 at 08:49, Francis Laniel wrote: > > Modifies the expected result for hush 2021. > Indeed, there were bugs in actual U-Boot hush which were fixed in upstream > Busybox. > As hush 2021 is based on upstream Busybox, these bugs no longer exist. > > Signed-off-by: Francis Laniel >

Re: [PATCH 1/3] net: support being a TCP server to unblock TCP fastboot

2023-03-31 Thread Simon Glass
On Wed, 29 Mar 2023 at 09:31, Dmitrii Merkurev wrote: > > Make following changes to unblock TCP fastboot support: > > 1. Implement being a TCP server support > 2. Introduce dedicated TCP traffic handler (get rid of UDP signature) > 3. Ensure seq_num and ack_num are respected in net_send_tcp_packet

Re: [PATCH 2/6] virtio: pci: Tear down VQs in virtio_pci_reset()

2023-03-31 Thread Simon Glass
On Thu, 30 Mar 2023 at 03:26, Ying-Chun Liu (PaulLiu) wrote: > > From: Will Deacon > > The pages backing the virtqueues for virtio PCI devices are not freed > on reset, despite the virtqueue structure being freed as part of the > driver '->priv_auto' destruction at ->remove() time. > > Call virti

Re: [PATCH v4] test_vboot.py: include test of fdt_add_pubkey tool

2023-03-31 Thread Simon Glass
On Mon, 20 Mar 2023 at 13:28, Ivan Mikhaylov wrote: > > From: Roman Kopytin > > Add test_fdt_add_pubkey test which provides simple functionality test > which contains such steps: > create DTB and FIT files > add keys with fdt_add_pubkey to DTB > sign FIT image > check with fit_check_sign that

Re: [PATCH 3/3] net: share fastboot boot handle logic between transports

2023-03-31 Thread Simon Glass
On Wed, 29 Mar 2023 at 09:31, Dmitrii Merkurev wrote: > > Introduce reboot, boot and continue commands support to > TCP fastboot by moving existing UDP logic into the common module. > > Cc: Ying-Chun Liu (PaulLiu) > Cc: Simon Glass > Сс: Joe Hershberger > Сс: Ramon Fried > Signed-off-by: Dmitr

Re: [RFC PATCH v7 09/23] cli: Add menu for hush parser

2023-03-31 Thread Simon Glass
On Fri, 31 Mar 2023 at 08:48, Francis Laniel wrote: > > For the moment, the menu contains only entry: HUSH_OLD_PARSER which is the > default. It seems to contain both with this patch? > The goal is to prepare the field to add a new hush parser which guarantees > actual behavior is still correct.

Re: [PATCH 5/6] virtio: Allocate bounce buffers for devices with VIRTIO_F_IOMMU_PLATFORM

2023-03-31 Thread Simon Glass
On Thu, 30 Mar 2023 at 03:27, Ying-Chun Liu (PaulLiu) wrote: > > From: Will Deacon > > In preparation for bouncing virtio data for devices advertising the > VIRTIO_F_IOMMU_PLATFORM feature, allocate an array of bounce buffer > structures in the vring, one per descriptor. > > Signed-off-by: Will D

Re: [PATCH v3 8/9] rockchip: Move to standard boot

2023-03-31 Thread Simon Glass
Hi Jonas, On Mon, 20 Mar 2023 at 20:54, Jonas Karlman wrote: > > Hi Simon, > On 2023-03-20 06:48, Simon Glass wrote: > > Drop the distro-boot scripts and use standard boot instead. > > > > Signed-off-by: Simon Glass > > --- > > > > Changes in v3: > > - Update rk3588 boards too > > > > Changes in

Re: [PATCH 6/6] virtio: Use bounce buffers when VIRTIO_F_IOMMU_PLATFORM is set

2023-03-31 Thread Simon Glass
On Thu, 30 Mar 2023 at 03:27, Ying-Chun Liu (PaulLiu) wrote: > > From: Will Deacon > > Devices advertising the VIRTIO_F_IOMMU_PLATFORM feature require > platform-specific handling to configure their DMA transactions. > > When handling virtio descriptors for such a device, use bounce > buffers to

Re: [PATCH 2/3] net: add fastboot TCP support

2023-03-31 Thread Simon Glass
Hi Dmitrii, On Wed, 29 Mar 2023 at 09:31, Dmitrii Merkurev wrote: > > Known limitations are > 1. fastboot reboot doesn't work (answering OK but not rebooting) > 2. flashing isn't supported (TCP transport only limitation) > > The command syntax is > fastboot tcp > > Signed-off-by: Dmitrii Merkurev

Re: [RFC PATCH v7 10/23] global_data.h: add GD_FLG_HUSH_OLD_PARSER flag

2023-03-31 Thread Simon Glass
On Fri, 31 Mar 2023 at 08:49, Francis Laniel wrote: > > This flag is used to indicate we are using the hush parser. > > Signed-off-by: Francis Laniel > --- > common/cli.c | 2 ++ > include/asm-generic/global_data.h | 4 > 2 files changed, 6 insertions(+) Reviewed-by: S

Re: [RFC PATCH v7 04/23] test: hush: Test hush variable expansion

2023-03-31 Thread Simon Glass
Hi Francis, On Fri, 31 Mar 2023 at 08:48, Francis Laniel wrote: > > Verifies shell variables are replaced by their values. > > Signed-off-by: Francis Laniel > --- > test/hush/Makefile | 1 + > test/hush/dollar.c | 167 +++ > test/py/tests/test_

Re: Newer U-Boot version throwing "Bootstage space exhasuted" with FIT image

2023-03-31 Thread Simon Glass
Hi, On Sat, 1 Apr 2023 at 02:57, wrote: > > Hi, > > I changed from v2020.10 to v2022.10 and suddenly I get a bunch of "Bootstage > space exhasuted" messages during bootm. > > reloc pc : [] is memcpy() > > It evens triggers a reset. Older version works just fine: > > Sign value: unavailabl

Re: [PATCH 4/6] virtio: Add helper functions to attach/detach vring descriptors

2023-03-31 Thread Simon Glass
On Thu, 30 Mar 2023 at 03:26, Ying-Chun Liu (PaulLiu) wrote: > > From: Will Deacon > > Move the attach and detach logic for manipulating vring descriptors > out into their own functions so that we can later extend these to > bounce the data for devices with VIRTIO_F_IOMMU_PLATFORM set. > > Signed

Re: [PATCH 1/6] virtio: Expose VIRTIO_F_IOMMU_PLATFORM in device features

2023-03-31 Thread Simon Glass
On Thu, 30 Mar 2023 at 03:25, Ying-Chun Liu (PaulLiu) wrote: > > From: Will Deacon > > If we detect the VIRTIO_F_IOMMU_PLATFORM transport feature for a device, > then expose it in the device features. > > Signed-off-by: Will Deacon > [ Paul: pick from the Android tree. Rebase to the upstream ] >

Re: [PATCH 3/6] virtio: Allocate virtqueue in page-size units

2023-03-31 Thread Simon Glass
On Thu, 30 Mar 2023 at 03:26, Ying-Chun Liu (PaulLiu) wrote: > > From: Will Deacon > > In preparation for explicit bouncing of virtqueue pages for devices > advertising the VIRTIO_F_IOMMU_PLATFORM feature, introduce a couple > of wrappers around virtqueue allocation and freeing operations, > ensu

Re: [v4 0/7] Fix Rockchip RK3399 bootstd migration

2023-03-31 Thread Simon Glass
Hi Peter, On Fri, 31 Mar 2023 at 21:40, Peter Robinson wrote: > > Hi Simon, > > > > > > > > I took a look at Simon's v3 series to fix the rk3399 bootstd > > > > > > > migration, > > > > > > > and it changed too much for everything else. I took about half of > > > > > > > that > > > > > > > seri

Re: [PATCH v5 8/8] bootstd: Enable BOOTSTD_DEFAULTS by default

2023-03-31 Thread Simon Glass
Hi Tom, On Sat, 1 Apr 2023 at 07:00, Tom Rini wrote: > > On Fri, Mar 31, 2023 at 10:26:01AM +1300, Simon Glass wrote: > > > This is needed to enable the boot command used to start standard boot. > > Enable it by default. This brings in quite a few features, mostly in > > common with DISTRO_DEFAUL

Re: [PATCH 18/38] efi: Show all known UUIDs with CONFIG_CMD_EFIDEBUG

2023-03-31 Thread Simon Glass
Hi Heinrich, On Fri, 31 Mar 2023 at 19:46, Heinrich Schuchardt wrote: > > > > Am 31. März 2023 03:16:06 MESZ schrieb Simon Glass : > >Hi Heinrich, > > > >On Fri, 31 Mar 2023 at 13:27, Heinrich Schuchardt wrote: > >> > >> > >> > >> Am 31. März 2023 01:48:57 MESZ schrieb Simon Glass : > >> >Hi Hei

Re: [PATCH v5 3/8] bootstd: Support booting EFI where multiple options exist

2023-03-31 Thread Simon Glass
Hi Tom, On Sat, 1 Apr 2023 at 07:02, Tom Rini wrote: > > On Fri, Mar 31, 2023 at 10:25:56AM +1300, Simon Glass wrote: > > > The current EFI implementation has a strange quirk where it watches > > loaded files and uses the last-loaded file to determine the device that > > is being booted from. > >

Re: RISC-V FIT image type

2023-03-31 Thread Simon Glass
Hi Bin, On Fri, 31 Mar 2023 at 19:22, Bin Meng wrote: > > On Fri, Mar 31, 2023 at 5:36 AM Simon Glass wrote: > > > > Hi, > > > > I notice that in image.h we have IH_ARCH_RISCV but no mention of > > IH_ARCH_RISCV64. Should we not have two separate image types, as we do > > with ARM and x86? Other

[PATCH v2 0/1] meson: Demonstration of using binman to produce the image

2023-03-31 Thread Simon Glass
The Odroid-C2 is quite a complicated image with many steps. It is an ideal example for how Binman can be used. Add a binman description and update the instructions accordingly. Changes in v2: - Rebase to -next Simon Glass (1): RFC: Move Odroid-C2 to use binman to produce the image arch/arm/d

Re: [PATCH] common: cli_hush: Restore clear local variable support

2023-03-31 Thread Simon Glass
Hi Stefan, On Sat, 1 Apr 2023 at 03:43, Stefan Herbrechtsmeier wrote: > > From: Stefan Herbrechtsmeier > > The u-boot hush shell doesn’t support the unset command to clear a > variable and therefore an empty value ("c=") should be a valid value > for the set_local_var function to clear the varia

[PATCH 1/1] sandbox: fix fall through in sandbox_flash_bulk()

2023-03-31 Thread Heinrich Schuchardt
Handling of SANDBOX_FLASH_EP_OUT should never fall through to SANDBOX_FLASH_EP_IN. This addresses a warning shown when compiling with -Wimplicit-fallthrough. Signed-off-by: Heinrich Schuchardt --- drivers/usb/emul/sandbox_flash.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/e

[PATCH 1/1] lib: missing fallthrough comment in vsnprintf_internal()

2023-03-31 Thread Heinrich Schuchardt
When a case statement intentionally falls through we should add a comment. Cf. -Wimplicit-fallthrough Signed-off-by: Heinrich Schuchardt --- lib/vsprintf.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/vsprintf.c b/lib/vsprintf.c index 2d13e68b57..8af6310651 100644 --- a/lib/vsprin

[PATCH 1/1] tools: avoid implicit fallthrough in fdt_add_pubkey

2023-03-31 Thread Heinrich Schuchardt
When building with -Wimplicit-fallthrough we get a warning tools/fdt_add_pubkey.c:52:25: warning: this statement may fall through [-Wimplicit-fallthrough=] 52 | print_help(); | Explicitly declare which functions don't return. Fixes: 30238e99619c (

Re: [PATCH v2] sysreset: gpio: fix gpio_reboot_request return value

2023-03-31 Thread Simon Glass
It should return -EINPROGRESS if successful otherwise sysreset-uclass will continue to the next sysreset device. Signed-off-by: Jonathan Liu Reviewed-by: Simon Glass --- drivers/sysreset/sysreset_gpio.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) Applied to u-boot-dm, thanks!

Re: [PATCH] buildman: Correct overwriting of settings file

2023-03-31 Thread Simon Glass
The toolchain test causes the settings file to be overwritten, which is annoying for local development. Fix it by passing None as the filename. Signed-off-by: Simon Glass --- tools/buildman/toolchain.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied to u-boot-dm, thanks!

[PATCH 1/1] efi_loader: remove duplicate assignment

2023-03-31 Thread Heinrich Schuchardt
Assigning the value of a variable to itself should be avoided. Addresses-Coverity-ID: 451089 ("Evaluation order violation") Fixes: 180b7118bed8 ("efi_loader: fix device-path for USB devices") Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_device_path.c | 2 +- 1 file changed, 1 insert

Re: [RFC PATCH v7 23/23] DO NOT MERGE: only to make CI happy

2023-03-31 Thread Tony Dinh
Hi Francis, On Thu, Mar 30, 2023 at 3:14 PM Francis Laniel wrote: > > Hi. > > Le jeudi 30 mars 2023, 21:17:33 WEST Tony Dinh a écrit : > > Hi Francis, > > > > On Thu, Mar 30, 2023 at 12:50 PM Francis Laniel > > > > wrote: > > > This commit set CONFIG_HUSH_PARSER_2021 as the default to trigger th

Re: Pull request: please pull u-boot-imx/next

2023-03-31 Thread Tom Rini
; > Merge tag 'u-boot-at91-2023.07-a' of > https://source.denx.de/u-boot/custodians/u-boot-at91 into next (2023-03-28 > 11:21:29 -0400) > > are available in the Git repository at: > > https://gitlab.denx.de/u-boot/custodians/u-boot-imx.git > tags/u-

Re: [PATCH] doc: ti: Add switch setting for boot modes on AM62 SK

2023-03-31 Thread Tom Rini
On Fri, Mar 31, 2023 at 03:36:15PM -0500, Judith Mendez wrote: > List some common boot modes and their corresponding switch > settings for AM62 SK. > > Signed-off-by: Judith Mendez Thanks for reworking. Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

[PATCH] doc: ti: Add switch setting for boot modes on AM62 SK

2023-03-31 Thread Judith Mendez
List some common boot modes and their corresponding switch settings for AM62 SK. Signed-off-by: Judith Mendez --- Changes from v1: Change table format from ascii-art to list-table doc/board/ti/am62x_sk.rst | 36 1 file changed, 36 insertions(+) diff --git

Re: [PATCH] include: configs: Change dtb names in fitImage to match oe-core

2023-03-31 Thread Tom Rini
On Fri, Mar 31, 2023 at 01:52:44PM -0500, Andrew Davis wrote: > On 3/31/23 1:36 PM, Tom Rini wrote: > > On Fri, Mar 31, 2023 at 01:23:23PM -0500, Andrew Davis wrote: > > > On 3/31/23 1:11 PM, Tom Rini wrote: > > > > On Fri, Mar 31, 2023 at 12:19:14PM -0500, Andrew Davis wrote: > > > > > On 3/31/23

Re: [PATCH] include: configs: Change dtb names in fitImage to match oe-core

2023-03-31 Thread Andrew Davis
On 3/31/23 1:36 PM, Tom Rini wrote: On Fri, Mar 31, 2023 at 01:23:23PM -0500, Andrew Davis wrote: On 3/31/23 1:11 PM, Tom Rini wrote: On Fri, Mar 31, 2023 at 12:19:14PM -0500, Andrew Davis wrote: On 3/31/23 12:04 PM, Nishanth Menon wrote: On 16:06-20230330, Ryan Eatmon wrote: The oe-core cla

Re: [PATCH] include: configs: Change dtb names in fitImage to match oe-core

2023-03-31 Thread Tom Rini
On Fri, Mar 31, 2023 at 01:23:23PM -0500, Andrew Davis wrote: > On 3/31/23 1:11 PM, Tom Rini wrote: > > On Fri, Mar 31, 2023 at 12:19:14PM -0500, Andrew Davis wrote: > > > On 3/31/23 12:04 PM, Nishanth Menon wrote: > > > > On 16:06-20230330, Ryan Eatmon wrote: > > > > > The oe-core class for assemb

Re: [PATCH] include: configs: Change dtb names in fitImage to match oe-core

2023-03-31 Thread Andrew Davis
On 3/31/23 1:11 PM, Tom Rini wrote: On Fri, Mar 31, 2023 at 12:19:14PM -0500, Andrew Davis wrote: On 3/31/23 12:04 PM, Nishanth Menon wrote: On 16:06-20230330, Ryan Eatmon wrote: The oe-core class for assembling the fitImage includes the vendor sub-directory (with the / changed to _) in the co

Re: [PATCH] include: configs: Change dtb names in fitImage to match oe-core

2023-03-31 Thread Tom Rini
On Fri, Mar 31, 2023 at 12:19:14PM -0500, Andrew Davis wrote: > On 3/31/23 12:04 PM, Nishanth Menon wrote: > > On 16:06-20230330, Ryan Eatmon wrote: > > > The oe-core class for assembling the fitImage includes the vendor > > > sub-directory (with the / changed to _) in the config sections of > > >

Re: [PATCH v5 3/8] bootstd: Support booting EFI where multiple options exist

2023-03-31 Thread Tom Rini
On Fri, Mar 31, 2023 at 10:25:56AM +1300, Simon Glass wrote: > The current EFI implementation has a strange quirk where it watches > loaded files and uses the last-loaded file to determine the device that > is being booted from. > > This is confusing with bootstd, where multiple options may exist

Re: [PATCH v5 8/8] bootstd: Enable BOOTSTD_DEFAULTS by default

2023-03-31 Thread Tom Rini
On Fri, Mar 31, 2023 at 10:26:01AM +1300, Simon Glass wrote: > This is needed to enable the boot command used to start standard boot. > Enable it by default. This brings in quite a few features, mostly in > common with DISTRO_DEFAULTS > > Exclude boards which have what looks like a custom boot co

Re: [v4 0/7] Fix Rockchip RK3399 bootstd migration

2023-03-31 Thread Tom Rini
On Fri, Mar 31, 2023 at 09:39:53AM +0100, Peter Robinson wrote: > Hi Simon, > > > > > > > > I took a look at Simon's v3 series to fix the rk3399 bootstd > > > > > > > migration, > > > > > > > and it changed too much for everything else. I took about half of > > > > > > > that > > > > > > > serie

Re: [PATCH] include: configs: Change dtb names in fitImage to match oe-core

2023-03-31 Thread Andrew Davis
On 3/31/23 12:04 PM, Nishanth Menon wrote: On 16:06-20230330, Ryan Eatmon wrote: The oe-core class for assembling the fitImage includes the vendor sub-directory (with the / changed to _) in the config sections of the fitImage. Our env var settings for chosing which section to boot from needs to

Re: [PATCH] include: configs: Change dtb names in fitImage to match oe-core

2023-03-31 Thread Nishanth Menon
On 16:06-20230330, Ryan Eatmon wrote: > The oe-core class for assembling the fitImage includes the vendor > sub-directory (with the / changed to _) in the config sections of > the fitImage. Our env var settings for chosing which section to > boot from needs to be updated to agree with the fitImage

Re: Please pull u-boot-dm

2023-03-31 Thread Tom Rini
On Fri, Mar 31, 2023 at 10:29:39AM +1300, Simon Glass wrote: > Hi Tom, > > https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/15825 > > > The following changes since commit 565681e596381b5b6db59cf06931e698f2d829e5: > > imx6sx-udoo-neo-basic: Introduce the u-boot.dtsi (2023-03-28

[PATCH] Revert "spi: zynq_qspi: Use dummy buswidth in dummy byte calculation"

2023-03-31 Thread Stefan Herbrechtsmeier
From: Stefan Herbrechtsmeier This reverts commit e09784728689de7949d4cdd559a9590e0bfcc702. The commit wrongly divides the dummy bytes by dummy bus width to calculate the dummy bytes. The framework already converts the dummy cycles to the number of bytes and the controller use the SPI flash comman

[PATCH] common: cli_hush: Restore clear local variable support

2023-03-31 Thread Stefan Herbrechtsmeier
From: Stefan Herbrechtsmeier The u-boot hush shell doesn’t support the unset command to clear a variable and therefore an empty value ("c=") should be a valid value for the set_local_var function to clear the variable. This partial reverts commit aa722529635c ("common: cli_hush: avoid dead code")

[PATCH v3] imx: imx8mm: Add suppoer for Mettler-Toledo snowflake board.

2023-03-31 Thread Sebastian Andrzej Siewior
From: Manuel Traut The board is similar to "Kontron SL i.MX8M Mini" SoM. There are two variants. Snowflake_v2 has an external SDCard Interface. LEIG is the same, but without display and without external SDCard Interface. Both variants support only 1GiB of main memory. [ bigeasy: porting and a bi

Re: [PATCH v2 1/1] input: button_kbd: make driver complementary to gpio buttons

2023-03-31 Thread Tom Rini
On Mon, Mar 20, 2023 at 09:06:30PM +0200, Svyatoslav Ryhel wrote: > Remove need of dts binding for button keyboard since it reuses > gpio-keys binding. Select gpio-keys driver if button keyboard > is selected since button keyboard can not operate on its own. > > Tested-by: Svyatoslav Ryhel # HTC

Re: [PATCH v4 1/1] cmd: ums: abort mounting by pressing any key

2023-03-31 Thread Tom Rini
On Mon, Mar 20, 2023 at 09:01:43PM +0200, Svyatoslav Ryhel wrote: > This patch introduses config which allows interrupt run of usb > mass storage with any key. This is especially useful on devices > with limited input capabilities like tablets and smatphones which > have only gpio keys in direct a

Re: [PATCH v2] disk: Use a helper function to reduce duplication

2023-03-31 Thread Tom Rini
On Mon, Mar 20, 2023 at 08:29:57AM +1300, Simon Glass wrote: > Reduce the duplicated code slightly by using a helper function to handle > the common code. > > This reduces the code size very slightly. > > Signed-off-by: Simon Glass Applied to u-boot/next, thanks! -- Tom signature.asc Descr

Re: [PATCH] lib: Fix SYS_TIMER_COUNTS_DOWN description in Kconfig

2023-03-31 Thread Tom Rini
On Sun, Mar 19, 2023 at 04:13:02AM +0100, Marek Vasut wrote: > The SYS_TIMER_COUNTS_DOWN description contains a typo, > s@rathe@&r@ , fix it. > > Signed-off-by: Marek Vasut Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] gpio: allow passing NULL to gpio_request_by_line_name() to search all gpio controllers

2023-03-31 Thread Tom Rini
On Fri, Mar 17, 2023 at 09:12:22PM +0100, Rasmus Villemoes wrote: > The API is more convenient to use if one doesn't have to know upfront > which gpio controller has a line with the name one is searching for, > and arrange to look that device up somehow. Or implement this loop > oneself. > > Sign

Re: [PATCH] image: Fix potentially uninitialized data variable

2023-03-31 Thread Tom Rini
On Mon, Feb 27, 2023 at 08:56:31PM +0100, Marek Vasut wrote: > In case fitImage support is disabled, and image_locate_script() is > passed a fitImage, then the 'data' variable is used uninitialized. > Drop into the default: branch of the switch-case statement and do > not return the uninitialized

Re: [PATCH v2 3/3] test: Add test for new command pci_mps

2023-03-31 Thread Tom Rini
On Fri, Mar 10, 2023 at 11:07:15AM -0800, stcar...@linux.microsoft.com wrote: > From: Stephen Carlson > > Adds a test for the new pci_mps command to ensure that it can set the > Maximum Payload Size (MPS) of all devices to 256 bytes in the sandbox > environment. Enables the pci_mps command in th

Re: [PATCH v2 2/3] drivers: pci: sandbox: Add stub sandbox PCI MPS support

2023-03-31 Thread Tom Rini
On Fri, Mar 10, 2023 at 11:07:14AM -0800, stcar...@linux.microsoft.com wrote: > From: Stephen Carlson > > Reports the sandbox swapcase PCI Express device to support a 256 byte > Maximum Payload Size for MPS tuning tests. > > Signed-off-by: Stephen Carlson > Reviewed-by: Simon Glass Applied t

Re: [PATCH v2 1/3] cmd: pci: Add command to set MPS of all PCIe devices

2023-03-31 Thread Tom Rini
On Fri, Mar 10, 2023 at 11:07:13AM -0800, stcar...@linux.microsoft.com wrote: > From: Stephen Carlson > > Enable tuning of the PCI Express MPS (Maximum Payload Size) of > each device. The Maximum Read Request Size is not altered. > > The SAFE method uses the largest MPS value supported by all d

Re: [PATCH] sysinfo: gpio: fix loop over DT "revisions" array

2023-03-31 Thread Tom Rini
On Fri, Mar 10, 2023 at 11:58:03AM +0100, Rasmus Villemoes wrote: > There can certainly be a lot more elements in the "revisions" (and > "names") arrays than there are gpios used to form the trinary number > we're searching for; we simply don't know the array size up-front. > > Nor do we need to,

Re: [PATCH] nvedit: simplify do_env_indirect()

2023-03-31 Thread Tom Rini
On Mon, Mar 06, 2023 at 02:27:21PM +0100, Rasmus Villemoes wrote: > Instead of calling env_get(from) up to three times, just do it once, > computing the value we will put into 'to' and error out if that is > NULL (i.e. no 'from' variable and no default provided). > > No functional change. > > Si

Re: [PATCH] test: fs: Check fat short file name

2023-03-31 Thread Tom Rini
On Wed, Mar 22, 2023 at 09:46:02AM +0100, Stefan Herbrechtsmeier wrote: > From: Stefan Herbrechtsmeier > > Ensure that a freshly written fat file with a lower case filename which > fits into the upper case 8.3 short filename is not mangeled with a tilde > and number. > > Signed-off-by: Stefan H

Re: [PATCH v2 4/4] test: exit: fix run_commandf() warnings

2023-03-31 Thread Tom Rini
On Mon, Mar 20, 2023 at 11:23:14AM +0300, Evgeny Bachinin wrote: > Fix warnings after adding printf-like attribute format for > run_commandf(): > warning: too many arguments for format [-Wformat-extra-args] > > Signed-off-by: Evgeny Bachinin > Reviewed-by: Simon Glass > Reviewed-by: Simon Glass

Re: [PATCH v2 3/4] test: fdt: fix run_commandf() warnings

2023-03-31 Thread Tom Rini
On Mon, Mar 20, 2023 at 11:23:13AM +0300, Evgeny Bachinin wrote: > Fix warnings both for 32bit and 64bit architecture after adding > printf-like attribute format for run_commandf(): > warning: format ‘%x’ expects argument of type ‘unsigned int’, but > argument 2 has type ‘ulong {aka long unsigne

Re: [PATCH 1/1] api: move API related config options into submenu

2023-03-31 Thread Tom Rini
On Fri, Mar 03, 2023 at 11:31:22PM +0100, Heinrich Schuchardt wrote: > Kconfig settings that are related to the API for standalone applications > should be in the API sub-menu and not on the top level. > > CONFIG_STANDALONE_LOAD_ADDR is only relevant if standalone example > applications are built

Re: [PATCH] Kconfig: Sort the BUILD_TARGET list

2023-03-31 Thread Tom Rini
On Tue, Feb 28, 2023 at 07:22:21AM +0100, Marek Vasut wrote: > Sort the defaults list in BUILD_TARGET Kconfig option. No functional change. > > Signed-off-by: Marek Vasut > Reviewed-by: Simon Glass Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] powerpc/mpc85xx: disable legacy format booting

2023-03-31 Thread Tom Rini
On Thu, Feb 23, 2023 at 07:03:47AM +0100, Heiko Schocher wrote: > disable CONFIG_LEGACY_IMAGE_FORMAT so prevent of booting > not signed fitimages. > > Signed-off-by: Heiko Schocher Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] fs: ext4: fix files seen as symlink during deletion

2023-03-31 Thread Tom Rini
On Fri, Mar 17, 2023 at 01:15:12PM +0100, Corentin GUILLEVIC wrote: > The deletion process handles special case for symlinks whose target are > small enough that it fits in struct ext2_inode.b.symlink. So no block had > been allocated. But the check of file type wrongly considered regular > files

Re: [PATCH v2 2/4] unit-test: cover run_commandf() by test-cases

2023-03-31 Thread Tom Rini
On Mon, Mar 20, 2023 at 11:23:12AM +0300, Evgeny Bachinin wrote: > As run_commandf() is variadic version of run_command() and just a wrapper, > hence apply similar run_command's test-cases. > > Let's avoid warning about empty string passing: > warning: zero-length gnu_printf format string [-Wform

Re: [PATCH] fs: fat: do not mangle short filenames

2023-03-31 Thread Tom Rini
On Fri, Mar 17, 2023 at 01:04:13PM +0100, Stefan Herbrechtsmeier wrote: > From: Stefan Herbrechtsmeier > > Do not mangle lower or mixed case filenames which fit into the upper > case 8.3 short filename. This ensures FAT standard compatible short > filenames (SFN) to support systems without long

Re: [PATCH v2 1/4] cli: run_commandf(): small fixups

2023-03-31 Thread Tom Rini
On Mon, Mar 20, 2023 at 11:23:11AM +0300, Evgeny Bachinin wrote: > * vsnprintf() can truncate cmd, hence it makes no sense to launch such > command (it's broken). Moreover, it's better to signalize to the caller > about such case (for facilitating debugging or bug hunting). > > * Fix kernel-doc w

Re: [PATCH v2 2/2] drivers: rtc: add max313xx series rtc driver

2023-03-31 Thread Tom Rini
On Mon, Mar 20, 2023 at 10:23:44AM +1300, Chris Packham wrote: > Adding support for Analog Devices MAX313XX series RTCs. > > This is ported from the Linux driver and adapted for use in u-boot. > Notable differences are > - handling of tm_year and tm_mon differ > - clock source support is omitted

Re: [PATCH v2 1/2] include: kernel.h: port find_closest() from Linux

2023-03-31 Thread Tom Rini
On Mon, Mar 20, 2023 at 10:23:43AM +1300, Chris Packham wrote: > The find_closest() macro can be used to find an element in a sorted > array that is closest to an input value. Bring in this macro from > Linux v6.3-rc1-2-g8ca09d5fa354. > > Signed-off-by: Chris Packham > Reviewed-by: Simon Glass

Re: [PATCH] rtc: m41t62: implements read8/write8 operations

2023-03-31 Thread Tom Rini
On Fri, Mar 17, 2023 at 03:22:41PM +0100, thomas.per...@bootlin.com wrote: > From: Thomas Perrot > > These operations are required by dm_rtc_read and > dm_bootcount_get helpers. > > Signed-off-by: Thomas Perrot > Reviewed-by: Simon Glass Applied to u-boot/next, thanks! -- Tom signature.a

Re: [PATCH] imx: imx8mm: Add suppoer for Mettler-Toledo snowflake board.

2023-03-31 Thread Sebastian Andrzej Siewior
On 2023-03-16 11:33:47 [+0100], Frieder Schrempf wrote: > > diff --git a/arch/arm/dts/imx8mm-mt-snowflake-v2.dts > > b/arch/arm/dts/imx8mm-mt-snowflake-v2.dts > > new file mode 100644 > > index 0..49761b22afcf0 > > --- /dev/null > > +++ b/arch/arm/dts/imx8mm-mt-snowflake-v2.dts > > @@

Newer U-Boot version throwing "Bootstage space exhasuted" with FIT image

2023-03-31 Thread deffo
Hi, I changed from v2020.10 to v2022.10 and suddenly I get a bunch of "Bootstage space exhasuted" messages during bootm. reloc pc : [] is memcpy() It evens triggers a reset. Older version works just fine: Sign value: unavailable Timestamp:unavailable Verifying Hash Integrity

Re: [PATCH v3 1/3] starfive: pci: Add StarFive JH7110 pcie driver

2023-03-31 Thread Pali Rohár
On Friday 31 March 2023 18:35:00 Minda Chen wrote: > On 2023/3/30 1:27, Pali Rohár wrote: > > Hello! > > > > On Wednesday 29 March 2023 18:01:41 Minda Chen wrote: > >> + /* PCIe PCI Standard Configuration Identification Settings. */ > >> + value = (PCI_CLASS_BRIDGE_PCI_NORMAL << IDS_CLASS_CODE_S

Re: [PATCH 3/5] arm: dts: add DMA and CPSW nodes for uboot

2023-03-31 Thread Ravi Gunasekaran
Hi Bryan, On 28/03/23 12:10 am, Bryan Brattlof wrote: > Update the uboot dtsi to enable DMA and CPSW at the uboot level > > Signed-off-by: Bryan Brattlof > --- > arch/arm/dts/k3-am62a7-r5-sk.dts | 8 > arch/arm/dts/k3-am62a7-sk-u-boot.dtsi | 26 +- > 2 fil

[PATCH] watchdog: arm_smc_wdt: add watchdog support

2023-03-31 Thread Lionel Debieve
Implement a ARM SMCCC based driver that allow to use a secure watchdog on the platform. Signed-off-by: Lionel Debieve --- drivers/watchdog/Kconfig | 8 +++ drivers/watchdog/Makefile | 1 + drivers/watchdog/arm_smc_wdt.c | 116 + 3 files changed, 12

[PATCH] Modify the print log when adma is not supported

2023-03-31 Thread Zhipeng Chen
--- drivers/mmc/sdhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c index c6b250b9a1..4e57e12732 100644 --- a/drivers/mmc/sdhci.c +++ b/drivers/mmc/sdhci.c @@ -882,7 +882,7 @@ int sdhci_setup_cfg(struct mmc_config *cfg, struct sdhc

Re: WIP: Signing TI x509 certificates using binman

2023-03-31 Thread Neha Malcom Francis
Hi Simon On 31/03/23 02:01, Simon Glass wrote: Hi Neha, On Fri, 24 Mar 2023 at 22:28, Neha Malcom Francis wrote: Hi Simon, Before I roll out the entire series that works for packaging K3 bootloader images, wanted to get some reviews and comments regarding the implementation of the signing e

Re: [PATCH v3 1/3] starfive: pci: Add StarFive JH7110 pcie driver

2023-03-31 Thread Minda Chen
On 2023/3/30 1:27, Pali Rohár wrote: > Hello! > > On Wednesday 29 March 2023 18:01:41 Minda Chen wrote: >> From: Mason Huo >> >> Add pcie driver for StarFive JH7110, the driver depends on >> starfive gpio, pinctrl, clk and reset driver to do init. >> >> Several devices are tested: >> a) M.2

Re: [PATCH 33/38] fs: fat: Support reading from a larger block size

2023-03-31 Thread Heinrich Schuchardt
On 3/31/23 00:55, Heinrich Schuchardt wrote: Am 30. März 2023 23:32:22 MESZ schrieb Simon Glass : At present it is not possible to read from some CDROM drives since the FAT sector size does not match the media's block size. Add a conversion option for this, so that reading is possible. This d

Re: [PATCH 32/38] fs: fat: Shrink the size of a few strings

2023-03-31 Thread Heinrich Schuchardt
On 3/31/23 09:33, Ilias Apalodimas wrote: On Fri, 31 Mar 2023 at 09:51, Heinrich Schuchardt wrote: Am 31. März 2023 03:16:13 MESZ schrieb Simon Glass : Hi Heinrich, On Fri, 31 Mar 2023 at 13:05, Heinrich Schuchardt wrote: Am 31. März 2023 01:49:35 MESZ schrieb Simon Glass : Hi Heinri

Re: [PATCH 14/38] qfw: Show the file address if available

2023-03-31 Thread Mark Kettenis
> Date: Fri, 31 Mar 2023 00:31:17 +0200 > From: Heinrich Schuchardt > > Am 30. März 2023 23:32:03 MESZ schrieb Simon Glass : > >Some files have an associated address. Show this with the 'qfw list' > >command so that it is possible to dump the data. > > > >Signed-off-by: Simon Glass > >--- > > >

[PATCH v3 3/3] configs: rockchip: rock5b-rk3588: enable USB and regulators

2023-03-31 Thread Eugen Hristev
Enable USB command, USB drivers, PHY and regulators, for USB host operations. Signed-off-by: Eugen Hristev --- configs/rock5b-rk3588_defconfig | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock5b-rk3588_defconfig

[PATCH v3 2/3] phy: rockchip-inno-usb2: add initial support for rk3588 PHY

2023-03-31 Thread Eugen Hristev
Add initial support for the rk3588 PHY variant. The driver now looks for phy-supply and enables/disables the vbus accordingly. The lookup for the host-port reg inside the struct now does a do {} while() instead of a while() {} in order to allow a first check for reg == 0. Co-developed-by: Frank Wa

[PATCH v3 1/3] ARM: dts: rockchip: rk3588-rock-5b-u-boot: add USB 2.0 host

2023-03-31 Thread Eugen Hristev
Add USB 2.0 host nodes and PHYs. Co-developed-by: William Wu Signed-off-by: William Wu Signed-off-by: Eugen Hristev --- Changes in v2,v3: - none arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 169 1 file changed, 169 insertions(+) diff --git a/arch/arm/dts/rk3588-rock-5b-

[PATCH v4 2/2] regulator: rename dev_pdata to plat

2023-03-31 Thread Eugen Hristev
Simplify the subsystem by renaming `dev_pdata` to just `plat`. No functional change, just trivial renaming. Suggested-by: Simon Glass Signed-off-by: Eugen Hristev Reviewed-by: Simon Glass --- Changes in v3,v4: - none Changes in v2: - this is a new patch drivers/power/regulator/fan53555.c

[PATCH v4 1/2] regulator: implement basic reference counter

2023-03-31 Thread Eugen Hristev
Some devices share a regulator supply, when the first one will request regulator disable, the second device will have it's supply cut off before graciously shutting down. Hence there will be timeouts and other failed operations. Implement a reference counter mechanism similar with what is done in L

[PATCH 3/3] configs: Create minimal vexpress_fvp_defconfig

2023-03-31 Thread Peter Hoyes
From: Peter Hoyes The vexpress64 board family now relies on OF_CONTROL and OF_HAS_PRIOR_STAGE, so platform-specific configuration requirements are minimal. The vexpress_aemv8a_semi_defconfig file defines many flags that are not needed for a minimal boot, such as flash memory configuration. Ther

[PATCH 2/3] vexpress64: Enable VIRTIO_MMIO and RTC_PL031 in the base model

2023-03-31 Thread Peter Hoyes
From: Peter Hoyes The Arm EBBR (Embedded Base Boot Requirements) require that the time and basic networking EFI interfaces are available and working, so long as the hardware has an RTC and network interface. Arm FVPs typically have a memory-mapped PL031 RTC and a VIRTIO_NET device defined in the

[PATCH 1/3] vexpress64: Use OF_HAS_PRIOR_STAGE for BASE_FVP variant

2023-03-31 Thread Peter Hoyes
From: Peter Hoyes BASE_FVP now typically uses a devicetree provided by a prior boot stage (typically Arm TF-A), so imply this option by default when TARGET_VEXPRESS64_BASE_FVP is selected. OF_HAS_PRIOR_STAGE selects OF_BOARD so this change is minor, but aligns TARGET_VEXPRESS64_BASE_FVP with TAR

[RESEND PATCH v2] configs: imx8mn_bsh_smm_s2: remove console from bootargs

2023-03-31 Thread sbabic
> The Linux kernel device tree already specifies the device to be used for > boot console output with a stdout-path property under /chosen. > Commit 36b661dc919da ("Merge branch 'next'") re-added the console > setting that commit bede82f750752 ("configs: imx8mn_bsh_smm_s2: remove > console from boo

  1   2   >