Re: [U-Boot] [PATCH 3/4] davinci: emac: add support for more than 1 PHYs

2011-10-10 Thread Hadli, Manjunath
Laurence, On Sat, Oct 01, 2011 at 01:59:30, Laurence Withers wrote: > On Fri, Sep 30, 2011 at 05:27:11PM +0530, nagabhushana.netagu...@ti.com wrote: > > add support for more than 1 PHYs. Many of the davinci platforms have > > more than 1 PHYs on thier board. This patch extends support in davinci

Re: [U-Boot] [PATCH v2 0/6] da850: add board specific functions

2011-10-10 Thread Hadli, Manjunath
Laurence, On Sat, Oct 08, 2011 at 18:28:37, Laurence Withers wrote: > On Sat, Oct 08, 2011 at 02:58:32PM +0530, manjunath.ha...@ti.com wrote: > > There are two boards AM18xx and L138 both of which are based on da850 > > SOC. AM18xx boards have mac address stored in I2C EEPROM and they have > >

Re: [U-Boot] [PATCH v2 4/6] da850: revert cache disable patch

2011-10-10 Thread Hadli, Manjunath
Laurence, On Sat, Oct 08, 2011 at 18:26:39, Laurence Withers wrote: > On Sat, Oct 08, 2011 at 02:58:36PM +0530, manjunath.ha...@ti.com wrote: > > revert commit bd65d006a6088bcb857e079447d7549e2cd7054d as the > > disabling of cache need not be done explicitly. Subsequent patches to > > new cache m

Re: [U-Boot] [PATCH v15 1/9] nds32: add header files support for nds32

2011-10-10 Thread 馬克泡
Dear Wolfgang, 2011/10/7 Wolfgang Denk : > Dear =?UTF-8?B?6aas5YWL5rOh?=, > >> However, we've discussed before, to support a new architecture, there >> are some definitions >> and codes which the checkpatch rules cannot be adapted. > > First, we can adapt chackpatch rules.  It just needs to be don

Re: [U-Boot] [PATCH V2 05/13] i2c: Create common default i2c_set_bus_num() function

2011-10-10 Thread Heiko Schocher
Hello Wolfgang, Wolfgang Denk wrote: > Dear Heiko Schocher, > > In message <4e93d634.6080...@denx.de> you wrote: >> Then please have a look at: >> >> http://git.denx.de/?p=u-boot/u-boot-i2c.git;a=shortlog;h=refs/heads/multibus_v2 >> >> It is a complete i2c rework with adding multiadapter/multibus

Re: [U-Boot] [PATCH V2 05/13] i2c: Create common default i2c_set_bus_num() function

2011-10-10 Thread Aaron Williams
On Monday, October 10, 2011 10:48:07 PM Wolfgang Denk wrote: > Dear Heiko Schocher, > > In message <4e93d634.6080...@denx.de> you wrote: > > Then please have a look at: > > > > http://git.denx.de/?p=u-boot/u-boot-i2c.git;a=shortlog;h=refs/heads/multi > > bus_v2 > > > > It is a complete i2c rewor

Re: [U-Boot] [PATCH 05/10 v3] spl, nand: add 4bit HW ecc oob first nand_read_page function

2011-10-10 Thread Wolfgang Denk
Dear Heiko Schocher, In message <4e93d6ff.9020...@denx.de> you wrote: > > Hmm.. this is no new config option, it enables on davinci socs the > 4Bit NAND HW ECC generation ... and I need this in spl code too ... > Ok, you are right, there is no documentation of this config option. > Should I add t

Re: [U-Boot] [PATCH V2 05/13] i2c: Create common default i2c_set_bus_num() function

2011-10-10 Thread Wolfgang Denk
Dear Heiko Schocher, In message <4e93d634.6080...@denx.de> you wrote: > > Then please have a look at: > > http://git.denx.de/?p=u-boot/u-boot-i2c.git;a=shortlog;h=refs/heads/multibus_v2 > > It is a complete i2c rework with adding multiadapter/multibus > to the i2c framework (and a i2c_core.c) .

Re: [U-Boot] [PATCH 05/10 v3] spl, nand: add 4bit HW ecc oob first nand_read_page function

2011-10-10 Thread Heiko Schocher
Hello Scott, Scott Wood wrote: > On 10/06/2011 12:45 AM, Heiko Schocher wrote: >> similiar to commit dc7cd8e59ba077f3b4c1a4557c9cd86a31b9ab1f, only >> adapted for the new spl framework. >> >> Signed-off-by: Heiko Schocher >> Cc: Scott Wood >> Cc: Albert ARIBAUD >> Cc: Sandeep Paulraj >> >> ---

Re: [U-Boot] [PATCH v3 19/21] Use uintptr_t for 32/64-bit compatibility

2011-10-10 Thread Aaron Williams
On Monday, October 10, 2011 09:52:59 PM Mike Frysinger wrote: > On Monday 10 October 2011 22:46:10 Aaron Williams wrote: > > Our OCTEON platform is a 64-bit SOC and we run it in the MIPS N32 ABI > > mode (64-bit registers, 32-bit address space). > > right, n32 == 32bit pointers, so i don't conside

Re: [U-Boot] [PATCH V2 05/13] i2c: Create common default i2c_set_bus_num() function

2011-10-10 Thread Heiko Schocher
Hello Tabi, Tabi Timur-B04825 wrote: > On Mon, Oct 10, 2011 at 4:35 AM, Stefano Babic wrote: >> New default, weak i2c_set_bus_num() function. >> >> Signed-off-by: Stefano Babic >> Cc: Heiko Schocher > > I would prefer to see a new set of I2C functions that take a bus > number as a parameter, s

Re: [U-Boot] [PATCH v3 19/21] Use uintptr_t for 32/64-bit compatibility

2011-10-10 Thread Mike Frysinger
On Monday 10 October 2011 22:46:10 Aaron Williams wrote: > Our OCTEON platform is a 64-bit SOC and we run it in the MIPS N32 ABI mode > (64-bit registers, 32-bit address space). right, n32 == 32bit pointers, so i don't consider that a port with 64bit pointer issues > rather see drivers better ma

Re: [U-Boot] [PATCH] Introduce generic TPM support in u-boot

2011-10-10 Thread Mike Frysinger
On Tuesday 11 October 2011 00:23:48 Vadim Bendebury wrote: > On Mon, Oct 10, 2011 at 1:48 PM, Wolfgang Denk wrote: > > > Yet another inconvenience though is the requirement to be able to > > > trace accesses to the registers. Some of the registers can be accessed > > > in 32 bit mode or 8 bit mode,

Re: [U-Boot] [PATCH] Introduce generic TPM support in u-boot

2011-10-10 Thread Vadim Bendebury
On Mon, Oct 10, 2011 at 1:48 PM, Wolfgang Denk wrote: > [..] > > > Yet another inconvenience though is the requirement to be able to > > trace accesses to the registers. Some of the registers can be accessed > > in 32 bit mode or 8 bit mode, and this determines how many bytes get > > Can you not a

Re: [U-Boot] [PATCH v3 19/21] Use uintptr_t for 32/64-bit compatibility

2011-10-10 Thread Aaron Williams
Our OCTEON platform is a 64-bit SOC and we run it in the MIPS N32 ABI mode (64-bit registers, 32-bit address space). In our case we use virtual memory so we can move U-Boot to the top of memory which is often above 4GB. The only changes we had to make to U-Boot was that drivers need to use the p

Re: [U-Boot] [PATCH V2 1/2] mmc: change magic number to macro define

2011-10-10 Thread Graeme Russ
Hi Prafulla, On Fri, Oct 7, 2011 at 7:36 PM, Prafulla Wadaskar wrote: > > >> -Original Message- >> From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de] >> On Behalf Of Lei Wen >> Sent: Thursday, October 06, 2011 8:41 PM >> To: Marek Vasut >> Cc: Lei Wen; u-boot@lists.d

Re: [U-Boot] [PATCH V2 1/2] mmc: change magic number to macro define

2011-10-10 Thread Graeme Russ
Hi Lei Wen, On Tue, Oct 11, 2011 at 11:48 AM, Lei Wen wrote: > Hi Wolfgang, > > On Tue, Oct 11, 2011 at 1:33 AM, Wolfgang Denk wrote: >> Dear Lei Wen, >> >> In message >> you >> wrote: >>> >>> >> So macro may looks more concise and could parse from its meaning easily >>> >> eno= >>> >> ugh.

Re: [U-Boot] [PATCH V2 1/2] mmc: change magic number to macro define

2011-10-10 Thread Lei Wen
Hi Wolfgang, On Tue, Oct 11, 2011 at 1:33 AM, Wolfgang Denk wrote: > Dear Lei Wen, > > In message > you > wrote: >> >> >> So macro may looks more concise and could parse from its meaning easily >> >> eno= >> >> ugh. >> > >> > We do not accept (typeless) register offset definitions. Please use

Re: [U-Boot] [PATCH 4/6] davinci_emac: fix for running with dcache enabled

2011-10-10 Thread Anton Staaf
On Mon, Oct 10, 2011 at 11:45 AM, Anton Staaf wrote: > On Mon, Oct 10, 2011 at 11:31 AM, Wolfgang Denk wrote: >> Dear Anton Staaf, >> >> In message >> you >> wrote: >>> >>> > When PPC was building again, I tested it on ARM (which I assumed was >>> > OK, given that this was Anton's primary arch

[U-Boot] Pull request: nand flash

2011-10-10 Thread Scott Wood
The following changes since commit 0841ca90f22d73b0ea4642ef1ce33d879bb2f3ff: arm920t/s3c24x0/usb_ohci.c: fix warning: variable ... set but not used (2011-10-09 23:24:50 +0200) are available in the git repository at: git://git.denx.de/u-boot-nand-flash.git master Laurence Withers (1):

Re: [U-Boot] [PATCH v2 1/5] usb:gadget:s5p USB Device Controller (UDC) implementation

2011-10-10 Thread Scott Wood
On 10/10/2011 04:54 PM, Wolfgang Denk wrote: > Dear Scott Wood, > > In message <4e935bdc.7000...@freescale.com> you wrote: >> >>> Well, "user-visible strings" is definitely not the same thing as >>> "debug print code", at least not for me. >> >> They're visible to a user that has #defined DEBUG.

Re: [U-Boot] [PATCH v2 1/5] usb:gadget:s5p USB Device Controller (UDC) implementation

2011-10-10 Thread Wolfgang Denk
Dear Scott Wood, In message <4e935bdc.7000...@freescale.com> you wrote: > > > Well, "user-visible strings" is definitely not the same thing as > > "debug print code", at least not for me. > > They're visible to a user that has #defined DEBUG. They're something > one might want to grep on. check

Re: [U-Boot] [PATCH 1/6] davinci_emac: move arch-independent defines to separate header

2011-10-10 Thread Ilya Yanok
Dear Wolfgang, On 07.10.2011 01:02, Wolfgang Denk wrote: >> arch/arm/include/asm/arch-davinci/emac_defs.h | 293 --- >> drivers/net/davinci_emac.c|1 + >> drivers/net/davinci_emac.h| 317 >> + >> 3 files ch

Re: [U-Boot] [PATCH 05/10 v3] spl, nand: add 4bit HW ecc oob first nand_read_page function

2011-10-10 Thread Scott Wood
On 10/06/2011 12:45 AM, Heiko Schocher wrote: > similiar to commit dc7cd8e59ba077f3b4c1a4557c9cd86a31b9ab1f, only > adapted for the new spl framework. > > Signed-off-by: Heiko Schocher > Cc: Scott Wood > Cc: Albert ARIBAUD > Cc: Sandeep Paulraj > > --- > changes for v3: > - add comment from S

Re: [U-Boot] [PATCH 09/15 V5] iMX28: Add GPMI NAND driver

2011-10-10 Thread Scott Wood
On 09/30/2011 04:39 AM, Marek Vasut wrote: > +/* > + * There are several places in this driver where we have to handle the OOB > and > + * block marks. This is the function where things are the most complicated, > so > + * this is where we try to explain it all. All the other places refer back to

Re: [U-Boot] [PATCH v2 1/5] usb:gadget:s5p USB Device Controller (UDC) implementation

2011-10-10 Thread Scott Wood
On 10/10/2011 03:38 PM, Wolfgang Denk wrote: > Dear Scott Wood, > > In message <4e934ef5.9030...@freescale.com> you wrote: >> This code is a debug code. As fair as I remember debug print code shall not be break in Linux kernel for easier debugging. >>> >>> Can you please point me to the

Re: [U-Boot] [PATCH] Introduce generic TPM support in u-boot

2011-10-10 Thread Wolfgang Denk
Dear Vadim, I wrote: > > struct locality { > > u16 field_a; > > u8 field_b; > > insert here: > > u8 reserved[3]; > > u32 field_c; oops. I missed that the first entry was 16 bit only, so that would be: uint8_t reserved; only... Best regards, Wolfgang Denk -- DENX Softw

Re: [U-Boot] [PATCH] Introduce generic TPM support in u-boot

2011-10-10 Thread Wolfgang Denk
Dear Vadim Bendebury, In message you wrote: > > so, this chip has five different areas (localities) which have the > same structure, and are mapped at certain regular offsets inside the > chip. > > thus the structure describing the chip would be something like > > struct locality { > u16 fie

Re: [U-Boot] WARNING: space prohibited between function name and open parenthesis '('

2011-10-10 Thread Mike Frysinger
On Monday 10 October 2011 14:59:17 Stephen Warren wrote: > I'm getting a lot of the following when running checkpatch: > > WARNING: space prohibited between function name and open parenthesis '(' > > Should I ignore these? > > So far, I've written completely new code such that it doesn't trigger

Re: [U-Boot] [PATCH 0/4] Buffer overruns in printf

2011-10-10 Thread Simon Glass
Hi Wolfgang, On Mon, Oct 10, 2011 at 1:36 PM, Wolfgang Denk wrote: > Dear Simon Glass, > > In message > you > wrote: >> >> Just to follow up this thread, I am going to drop the network patch >> and resubmit the rest of it. This will make snprintf() available in >> U-Boot. > > Without code that

Re: [U-Boot] [PATCH v2 1/5] usb:gadget:s5p USB Device Controller (UDC) implementation

2011-10-10 Thread Wolfgang Denk
Dear Scott Wood, In message <4e934ef5.9030...@freescale.com> you wrote: > > >> This code is a debug code. As fair as I remember debug print code shall > >> not be break in Linux kernel for easier debugging. > > > > Can you please point me to the respective entry in the CodingStyle > > file? > >

Re: [U-Boot] [PATCH] Introduce generic TPM support in u-boot

2011-10-10 Thread Mike Frysinger
On Monday 10 October 2011 16:00:18 Vadim Bendebury wrote: > On Mon, Oct 10, 2011 at 3:45 AM, Wolfgang Denk wrote: > > > +#define TIS_REG(LOCALITY, REG) \ > > > + (void *)(CONFIG_TPM_TIS_BASE_ADDRESS + (LOCALITY << 12) + REG) > > > > We do not allow to access device registers through base addre

Re: [U-Boot] [PATCH 0/4] Buffer overruns in printf

2011-10-10 Thread Wolfgang Denk
Dear Simon Glass, In message you wrote: > > Just to follow up this thread, I am going to drop the network patch > and resubmit the rest of it. This will make snprintf() available in > U-Boot. Without code that uses it? We don't accept dead code... Best regards, Wolfgang Denk -- DENX Softw

Re: [U-Boot] WARNING: space prohibited between function name and open parenthesis '('

2011-10-10 Thread Wolfgang Denk
Dear Stephen Warren, In message <74cdbe0f657a3d45afbb94109fb122ff173b23b...@hqmail01.nvidia.com> you wrote: > I'm getting a lot of the following when running checkpatch: > > WARNING: space prohibited between function name and open parenthesis '(' > > Should I ignore these? No, these should be

Re: [U-Boot] [PATCH v2] NAND: davinci: choose correct 1-bit h/w ECC reg

2011-10-10 Thread Scott Wood
On 09/26/2011 11:02 AM, Laurence Withers wrote: > In nand_davinci_readecc(), select the correct NANDFECC register based > on CONFIG_SYS_NAND_CS rather than hardcoding the choice of NANDF1ECC. > This allows 1-bit hardware ECC to work with chip select other than CS2. > > Note this now matches the us

[U-Boot] [PATCH] arm: Tidy up of PRAM init to use getenv_f()

2011-10-10 Thread Simon Glass
It seems that few people use CONFIG_PRAM on ARM. The getenv_r() function has been renamed to getenv_f(). Signed-off-by: Simon Glass --- arch/arm/lib/board.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c index 1fe3751..653345

Re: [U-Boot] [PATCH v2 0/6] tegra2: Add more clock/pinmux functionality

2011-10-10 Thread Simon Glass
Hi Albert, On Tue, Sep 27, 2011 at 9:04 AM, Simon Glass wrote: > Hi Albert, > > On Tue, Sep 27, 2011 at 12:21 AM, Albert ARIBAUD > wrote: >> Hi Simon, >> >> On 26/09/2011 19:06, Simon Glass wrote: >>> >>> Hi Albert, >>> >>> On Wed, Sep 21, 2011 at 3:40 PM, Simon Glass  wrote: This adds

Re: [U-Boot] [PATCH] Introduce generic TPM support in u-boot

2011-10-10 Thread Vadim Bendebury
Wolfgang, thank you for your comments, I'll address them in a follow-up submission, but I have a question regarding the register access (and the issue was indeed brought up by vapier@ at an earlier review on a different submission). On Mon, Oct 10, 2011 at 3:45 AM, Wolfgang Denk wrote: > > > +#de

Re: [U-Boot] [PATCH v2 1/5] usb:gadget:s5p USB Device Controller (UDC) implementation

2011-10-10 Thread Scott Wood
On 10/09/2011 02:43 PM, Wolfgang Denk wrote: > Dear Lukasz Majewski, > > In message <20111007093950.17d94287@lmajewski.digital.local> you wrote: >> >> Most warnings are related to lines over 80 characters. >> This code is a debug code. As fair as I remember debug print code shall >> not be break

Re: [U-Boot] [PATCH v3] Move timestamp and version files into 'generated' subdir

2011-10-10 Thread Mike Frysinger
Acked-by: Mike Frysinger -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] imx: fix coding style

2011-10-10 Thread Fabio Estevam
Fix checkpatch warning and errors in several i.MX related files. Signed-off-by: Fabio Estevam --- arch/arm/cpu/arm1136/mx31/timer.c | 22 +++-- arch/arm/cpu/arm1136/mx35/generic.c |2 +- arch/arm/cpu/arm926ejs/mx25/generic.c | 110 +- arch/a

Re: [U-Boot] [PATCH] mcx: support for HTKW mcx board

2011-10-10 Thread Ilya Yanok
Hi Igor, thanks for your comments, I'll post the updated patches soon. Regards, Ilya. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v2 0/3] Buffer overruns in printf

2011-10-10 Thread Simon Glass
The printf family of functions in U-Boot cannot deal with a situation where the caller provides a buffer which turns out to be too small for the format string. This can result in buffer overflows, stack overflows and other bad behavior. This patch series tidies this up in the common vsprintf.c cod

[U-Boot] [PATCH v2 2/3] Add safe vsnprintf and snprintf library functions

2011-10-10 Thread Simon Glass
From: Sonny Rao From: Sonny Rao These functions are useful in U-Boot because they allow a graceful failure rather than an unpredictable stack overflow when printf() buffers are exceeded. Mostly copied from the Linux kernel. I copied vscnprintf and scnprintf so we can change printf and vprintf

[U-Boot] [PATCH v2 3/3] Make printf and vprintf safe from buffer overruns

2011-10-10 Thread Simon Glass
From: Sonny Rao From: Sonny Rao utilize the added vscnprintf functions to avoid buffer overruns The implementation is fairly dumb in that it doesn't detect that the buffer is too small, but at least will not cause crashes. Signed-off-by: Sonny Rao --- Changes in v2: - Use sizeof(printbuffer)

[U-Boot] [PATCH v2 1/3] Add limits.h to hold basic limits

2011-10-10 Thread Simon Glass
This brings a basic limits.h implementation into U-Boot. Signed-off-by: Simon Glass --- fs/ubifs/ubifs.h |4 +--- include/limits.h | 40 2 files changed, 41 insertions(+), 3 deletions(-) create mode 100644 include/limits.h diff --git a/fs/ubifs/ub

Re: [U-Boot] [PATCH] Move timestamp and version files into 'generated' subdir

2011-10-10 Thread Simon Glass
Hi Mike, On Fri, Oct 7, 2011 at 6:05 PM, Mike Frysinger wrote: > i like generated headers all being in the same place > > however, you forgot to update include/.gitignore :) > -mike > OK I did this and sent a new patch set to remove those lines, and a third (oops) since someone has already fixed

Re: [U-Boot] [PATCH 0/4] Buffer overruns in printf

2011-10-10 Thread Simon Glass
Hi, On Mon, Sep 26, 2011 at 11:52 PM, Albert ARIBAUD wrote: > On 27/09/2011 00:28, Scott Wood wrote: > >>> - users who actually wisht to limit outpout ca use either >> >> You say "actually wish to limit output" as if "let it corrupt memory if >> it's too large" is the normal thing to want. > > Wh

[U-Boot] WARNING: space prohibited between function name and open parenthesis '('

2011-10-10 Thread Stephen Warren
I'm getting a lot of the following when running checkpatch: WARNING: space prohibited between function name and open parenthesis '(' Should I ignore these? So far, I've written completely new code such that it doesn't trigger this warning, but where editing existing code (e.g. just changing the

[U-Boot] [PATCH v3] Move timestamp and version files into 'generated' subdir

2011-10-10 Thread Simon Glass
There is a rather subtle build problem where the build time stamp is not updated for out-of-tree builds if there exists an in-tree build which has a valid timestamp file. So if you do an in-tree build, then an out-of-tree build your timestamp will not change. The correct timestamp_autogenerated.h

Re: [U-Boot] [PATCH 4/6] davinci_emac: fix for running with dcache enabled

2011-10-10 Thread Anton Staaf
On Mon, Oct 10, 2011 at 11:31 AM, Wolfgang Denk wrote: > Dear Anton Staaf, > > In message > you > wrote: >> >> > When PPC was building again, I tested it on ARM (which I assumed was >> > OK, given that this was Anton's primary architecture). =A0That was when >> > I finally gave up, see >> >> Ye

Re: [U-Boot] [PATCH 2/3] USB: Rework usb_kbd.c

2011-10-10 Thread Mike Frysinger
On Monday 10 October 2011 14:33:47 Marek Vasut wrote: > On Monday, October 10, 2011 08:24:48 PM Mike Frysinger wrote: > > On Monday 10 October 2011 11:34:26 Marek Vasut wrote: > > > --- a/common/usb_kbd.c > > > +++ b/common/usb_kbd.c > > > > > > -#undef USB_KBD_DEBUG > > > +#ifdef USB_KBD_DEBUG

Re: [U-Boot] [PATCH 2/3] USB: Rework usb_kbd.c

2011-10-10 Thread Marek Vasut
On Monday, October 10, 2011 08:24:48 PM Mike Frysinger wrote: > On Monday 10 October 2011 11:34:26 Marek Vasut wrote: > > --- a/common/usb_kbd.c > > +++ b/common/usb_kbd.c > > > > -#undef USB_KBD_DEBUG > > +#ifdef USB_KBD_DEBUG > > +#define USB_KBD_PRINTF(fmt, args...) printf(fmt, ##args

Re: [U-Boot] [PATCH 4/6] davinci_emac: fix for running with dcache enabled

2011-10-10 Thread Wolfgang Denk
Dear Anton Staaf, In message you wrote: > > > When PPC was building again, I tested it on ARM (which I assumed was > > OK, given that this was Anton's primary architecture). =A0That was when > > I finally gave up, see > > Yes, the patches expose the fact that almost no boards define > CONFIG_SY

Re: [U-Boot] [PATCH V2 05/13] i2c: Create common default i2c_set_bus_num() function

2011-10-10 Thread Timur Tabi
Mike Frysinger wrote: > i think that'd require a much larger rework of the framework and thus would > be > better to do in addition to Stefano's work rather than in place of ? Hmmm... I guess it would be easier to do the rework eventually if i2c_set_bus_num() is universal, instead of just for Po

[U-Boot] [PATCH v2] Move timestamp and version files into 'generated' subdir

2011-10-10 Thread Simon Glass
There is a rather subtle build problem where the build time stamp is not updated for out-of-tree builds if there exists an in-tree build which has a valid timestamp file. So if you do an in-tree build, then an out-of-tree build your timestamp will not change. The correct timestamp_autogenerated.h

Re: [U-Boot] [PATCH] microblaze: Enable SERIAL_MULTI

2011-10-10 Thread Wolfgang Denk
Dear Mike Frysinger, In message <201110101352.15660.vap...@gentoo.org> you wrote: > > > > it's driver specific code in this file, so it doesn't make much sense to > > > have the board config define something just to get these prototypes > > > > It could be a CPU specific header file, then. > > s

Re: [U-Boot] [PATCH V2 05/13] i2c: Create common default i2c_set_bus_num() function

2011-10-10 Thread Mike Frysinger
On Monday 10 October 2011 13:53:48 Tabi Timur-B04825 wrote: > On Mon, Oct 10, 2011 at 4:35 AM, Stefano Babic wrote: > > New default, weak i2c_set_bus_num() function. > > > > Signed-off-by: Stefano Babic > > Cc: Heiko Schocher > > I would prefer to see a new set of I2C functions that take a bus

Re: [U-Boot] [PATCH 3/3] USB: Drop dead code from usb_kbd.c

2011-10-10 Thread Mike Frysinger
Acked-by: Mike Frysinger -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/3] USB: Rework usb_kbd.c

2011-10-10 Thread Mike Frysinger
On Monday 10 October 2011 11:34:26 Marek Vasut wrote: > --- a/common/usb_kbd.c > +++ b/common/usb_kbd.c > > -#undef USB_KBD_DEBUG > +#ifdef USB_KBD_DEBUG > +#define USB_KBD_PRINTF(fmt, args...) printf(fmt, ##args) > +#else > +#define USB_KBD_PRINTF(fmt, args...) > +#endif could we possibly j

[U-Boot] [PATCH v6 08/20] sandbox: Add board info for architecture

2011-10-10 Thread Simon Glass
This is required for the bdinfo command to work. This also cleans up the #ifdef mess for ethernet and lnum a little. Signed-off-by: Simon Glass --- common/cmd_bdinfo.c | 34 ++ 1 files changed, 30 insertions(+), 4 deletions(-) diff --git a/common/cmd_bdinfo.c

[U-Boot] [PATCH v6 17/20] Use uintptr_t for 32/64-bit compatibility

2011-10-10 Thread Simon Glass
This fixes a few problems when building on 64-bit machines. Signed-off-by: Simon Glass --- common/cmd_mem.c |2 +- common/fdt_support.c |8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/common/cmd_mem.c b/common/cmd_mem.c index e84cc4e..28476d7 100644 --- a/

[U-Boot] [PATCH v6 18/20] Adjust dependency rules to permit per-file flags

2011-10-10 Thread Simon Glass
The dependency rules are currently done in a shell 'for' loop. This does not permit Makefile variables to adjust preprocessor flags as is done with normal compile flags, using the CFLAGS_path/file.o syntax. This change moves the dependency generation into the Makefile itself, and permits a CPPFLAG

[U-Boot] [PATCH v6 05/20] sandbox: Add cpu files

2011-10-10 Thread Simon Glass
This is an initial implementation with all functions defined but not working. The lds file is very simple since we can mostly rely on the linker defaults. Signed-off-by: Simon Glass --- Changes in v2: - Remove setting of LDSCRIPT (top level Makefile does this anyway) - Add comment to do_reset()

[U-Boot] [PATCH v6 11/20] sandbox: Disable standalone/API support

2011-10-10 Thread Simon Glass
This is less useful on the sandbox architecture since we can simply link all our code with U-Boot. However some interest has been expressed in implementing this support. For now, it is disabled. Signed-off-by: Simon Glass --- Makefile |9 ++--- 1 files changed, 6 insertions(+), 3 deleti

[U-Boot] [PATCH v6 12/20] sandbox: Force command sections to be 4-byte aligned

2011-10-10 Thread Simon Glass
By default sections are 16-byte aligned on some architectures, but the command name structure (struct cmd_tbl_s) does not have padding to 16 bytes. We use the linker to collect elements of an array of these structures and then at run-time we want this array to be accessible. If the linker puts pad

[U-Boot] [PATCH v6 10/20] sandbox: Disable built-in malloc

2011-10-10 Thread Simon Glass
We prefer to U-Boot's malloc but for now it is easier to use the C library's version. Signed-off-by: Simon Glass --- common/Makefile |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/common/Makefile b/common/Makefile index 371a0d9..fee6de1 100644 --- a/common/Makefile +++

[U-Boot] [PATCH v6 20/20] sandbox: Makefile changes to build sandbox architecture

2011-10-10 Thread Simon Glass
At this point U-Boot will build and run on x86 under Linux. The idea is to define a new architecture called 'sandbox', alongside ARM and x86. This runs natively on Linux to suit the host machine. All hardware access is either omitted or emulated. The purpose of this system is to test the bulk of

[U-Boot] [PATCH v6 13/20] sandbox: Add OS dependent layer

2011-10-10 Thread Simon Glass
We want to keep all OS-dependent code in once place, with a simple interface to U-Boot. For now, this is that place. Signed-off-by: Simon Glass --- Changes in v2: - Move os layer into arch/sandbox - Remove clean and dist-clean targets from Makefile - Try and fail to remove the global -I/usr/inclu

[U-Boot] [PATCH v6 06/20] sandbox: Add architecture lib files

2011-10-10 Thread Simon Glass
These files are taken from the ARM board implementation and then reduced to remove unneeded cruft. Ideally we would work towards unifying arch/xxx/lib files, particularly board.c. Signed-off-by: Simon Glass --- Changes in v2: - Fix commit message typo, sadly - Remove ARM cruft from Makefile - Re

[U-Boot] [PATCH v6 16/20] sandbox: Add basic config file

2011-10-10 Thread Simon Glass
This basic provides required features along with a basic command set. Signed-off-by: Simon Glass --- Changes in v2: - Remove CONFIG_SYS_SDRAM_BASE which is always 0 for sandbox boards - Fix #define - Remove CONFIG_LMB Changes in v4: - Add CONFIG_SYS_SDRAM_SIZE for size of emulated SDRAM - Add #i

[U-Boot] [PATCH v6 03/20] sandbox: Add architecture image support

2011-10-10 Thread Simon Glass
We won't actually load an image with this architecture, but we still need to define it. Signed-off-by: Simon Glass --- Changes in v3: - Add architecture image support for sandbox Changes in v5: - Define IH_ARCH_DEFAULT which is now required arch/sandbox/include/asm/u-boot.h |3 +++ include

[U-Boot] [PATCH v6 07/20] sandbox: Add sandbox board

2011-10-10 Thread Simon Glass
This adds basic files for the sandbox board. The lds file is very simple since we can rely mostly on the linker defaults. Signed-off-by: Simon Glass --- Changes in v2: - Remove clean and dist-clean targets from Makefile - Move lds script out of the board directory Changes in v4: - Remove board/s

[U-Boot] [PATCH v6 01/20] sandbox: Add architecture header files

2011-10-10 Thread Simon Glass
This adds required header files for the sandbox architecture, and a basic description of what sandbox is (README.sandbox). Signed-off-by: Simon Glass --- Changes in v6: - Remove volatile keyword from arch/sandbox/include/asm/bitops.h arch/sandbox/include/asm/bitops.h | 162

[U-Boot] [PATCH v6 02/20] Fix use of int as pointer in image.c

2011-10-10 Thread Simon Glass
It is better to use %p in this case. Signed-off-by: Simon Glass Acked-by: Mike Frysinger --- Changes in v2: - Split this change out from 'Add architecture image support' common/image.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common/image.c b/common/image.c i

[U-Boot] [PATCH v6 19/20] Add generic gpio.h in asm-generic

2011-10-10 Thread Simon Glass
Since we want want to have a standard GPIO interface, this adds a definition for this into include/asm-generic/gpio.h. Signed-off-by: Simon Glass --- Changes in v5: - Move the introduction of include/asm-generic/gpio.h into a separate commit - Add comments to GPIO functions include/asm-generic/

[U-Boot] [PATCH v6 09/20] sandbox: Add bootm support

2011-10-10 Thread Simon Glass
This adds sandbox architecture support to bootm, although it is probably not useful to load sandbox code into the address space and execute it. This change at least make the file build correctly on 64-bit machines. Signed-off-by: Simon Glass --- Changes in v2: - Fix cast of int to pointer instea

[U-Boot] [PATCH v6 14/20] sandbox: Add main program

2011-10-10 Thread Simon Glass
Add a main program so that we can run U-Boot. Signed-off-by: Simon Glass --- Changes in v4: - Move main() into arch/sandbox/cpu/start.c arch/sandbox/cpu/Makefile |2 +- arch/sandbox/cpu/start.c | 33 + 2 files changed, 34 insertions(+), 1 deletions(-) cre

[U-Boot] [PATCH v6 04/20] sandbox: Add compiler defines to support a 64-bit x86_64 platform

2011-10-10 Thread Simon Glass
This sets __WORDSIZE to 8 correctly on 64-bit machines. Signed-off-by: Simon Glass --- Changes in v2: - Update commit message to remove 'temporary' - Allow __WORDSIZE to be defined in Makefile / elsewhere include/compiler.h | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-)

[U-Boot] [PATCH v6 15/20] sandbox: Add serial uart

2011-10-10 Thread Simon Glass
This uart simply writes to stdout and reads from stdin. We might imagine instead buffering the data so that a test interface can check output and inject input. Signed-off-by: Simon Glass --- Changes in v4: - Remove serial_exit() drivers/serial/Makefile |1 + drivers/serial/sandbox.c | 63

Re: [U-Boot] [PATCH 1/3] USB: Squash checkpatch warnings in usb_kbd.c

2011-10-10 Thread Mike Frysinger
Acked-by: Mike Frysinger -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v6 0/20] New 'sandbox' test architecture for U-Boot

2011-10-10 Thread Simon Glass
This patch set points towards a possible way to improve the test infrastructure in U-Boot. The goal is to have a test suite that can run in a minute or two on a Linux PC and test all non-platform code. This set aims to be just enough boot to U-Boot to a command prompt. You can type help; anything

Re: [U-Boot] [PATCH V2 05/13] i2c: Create common default i2c_set_bus_num() function

2011-10-10 Thread Tabi Timur-B04825
On Mon, Oct 10, 2011 at 4:35 AM, Stefano Babic wrote: > New default, weak i2c_set_bus_num() function. > > Signed-off-by: Stefano Babic > Cc: Heiko Schocher I would prefer to see a new set of I2C functions that take a bus number as a parameter, so that we can eliminate i2c_set_bus_num() (and the

Re: [U-Boot] [PATCH 4/6] davinci_emac: fix for running with dcache enabled

2011-10-10 Thread Anton Staaf
On Mon, Oct 10, 2011 at 10:44 AM, Wolfgang Denk wrote: > Dear Mike Frysinger, > > In message <201110101124.22548.vap...@gentoo.org> you wrote: >> >> > See the rest of the thread.  I had applied this patch set to a loal >> > tree, but it was breaking hundreds of systems, so had to back out the >> >

Re: [U-Boot] [PATCH 4/6] davinci_emac: fix for running with dcache enabled

2011-10-10 Thread Mike Frysinger
On Monday 10 October 2011 13:44:21 Wolfgang Denk wrote: > Mike Frysinger wrote: > > > See the rest of the thread. I had applied this patch set to a loal > > > tree, but it was breaking hundreds of systems, so had to back out the > > > patches again. > > > > > > I'm eager to get this code in mysel

Re: [U-Boot] [PATCH] microblaze: Enable SERIAL_MULTI

2011-10-10 Thread Mike Frysinger
On Monday 10 October 2011 13:35:13 Wolfgang Denk wrote: > Mike Frysinger wrote: > > > > >> defined(CONFIG_MB86R0x) || defined(CONFIG_MPC5xxx) || \ > > > > >> defined(CONFIG_MPC83xx) || defined(CONFIG_MPC85xx) || \ > > > > >> defined(CONFIG_MPC86xx) || defined(CONFIG_SYS_SC520) || \ >

Re: [U-Boot] [PATCH V3 05/13] i2c: Create common default i2c_set_bus_num() function

2011-10-10 Thread Mike Frysinger
On Monday 10 October 2011 11:31:39 Stefano Babic wrote: > On 10/10/2011 05:19 PM, Mike Frysinger wrote: > > On Monday 10 October 2011 06:50:12 Stefano Babic wrote: > >> +int __def_i2c_set_bus_num(unsigned int bus) > >> +{ > >> + return 0; > >> +} > >> +int i2c_set_bus_num(unsigned int) > >> + __a

Re: [U-Boot] [PATCH] mx31pdk: Remove unneeded config

2011-10-10 Thread Wolfgang Denk
Dear Fabio Estevam, In message you wrote: > > Ping? Pong. What's up? This is i.MX, and I haven't seen any ARM (nor even i.MX) pull requests yet. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D

Re: [U-Boot] [PATCH 4/6] davinci_emac: fix for running with dcache enabled

2011-10-10 Thread Wolfgang Denk
Dear Mike Frysinger, In message <201110101124.22548.vap...@gentoo.org> you wrote: > > > See the rest of the thread. I had applied this patch set to a loal > > tree, but it was breaking hundreds of systems, so had to back out the > > patches again. > > > > I'm eager to get this code in myself, bu

Re: [U-Boot] [PATCH] microblaze: Enable SERIAL_MULTI

2011-10-10 Thread Wolfgang Denk
Dear Mike Frysinger, In message <201110101118.05350.vap...@gentoo.org> you wrote: > > > > >> defined(CONFIG_MB86R0x) || defined(CONFIG_MPC5xxx) || \ > > > >> defined(CONFIG_MPC83xx) || defined(CONFIG_MPC85xx) || \ > > > >> defined(CONFIG_MPC86xx) || defined(CONFIG_SYS_SC520) || \ >

Re: [U-Boot] [PATCH V2 1/2] mmc: change magic number to macro define

2011-10-10 Thread Wolfgang Denk
Dear Lei Wen, In message you wrote: > > >> So macro may looks more concise and could parse from its meaning easily > >> eno= > >> ugh. > > > > We do not accept (typeless) register offset definitions. Please use a > > struct, so the compiler has a chance to perform type checking. > > I check t

Re: [U-Boot] [PATCH v3 4/4] tegra2: Add support for Ventana

2011-10-10 Thread Stephen Warren
Simon Glass wrote at Friday, October 07, 2011 6:03 PM: > On Thu, Oct 6, 2011 at 10:53 AM, Stephen Warren wrote: > > Ventana is a board which is very similar to Seaboard. Support it by > > re-using board/nvidia/seaboard/seaboard.c with minor run-time conditionals. ... > > diff --git a/board/nvidia/

Re: [U-Boot] [PATCH] mx31pdk: Remove unneeded config

2011-10-10 Thread Stefano Babic
On 09/12/2011 06:32 PM, Fabio Estevam wrote: > Currently there are two config options for building a U-boot binary for > MX31PDK: > > make mx31pdk_config > > or, > > make mx31pdk_nand_config > > mx31pdk_config was developed first when no NAND SPL support was available for > MX31 and it requi

Re: [U-Boot] [PATCH] mx31pdk: Remove unneeded config

2011-10-10 Thread Stefano Babic
On 10/10/2011 05:28 PM, Fabio Estevam wrote: > Hi Wolfgang, > > On Tue, Sep 13, 2011 at 8:10 AM, Stefano Babic wrote: >> On 09/12/2011 06:32 PM, Fabio Estevam wrote: >>> Currently there are two config options for building a U-boot binary for >>> MX31PDK: >>> >>> make mx31pdk_config >>> >>> or, >

[U-Boot] [PATCH 2/3] USB: Rework usb_kbd.c

2011-10-10 Thread Marek Vasut
* Support dynamic allocation of devices * Passing data via usb device privptr * Reorder functions to avoid forward declarations * Introduce generic polling mechanism to fix musb and ehci-hcd breakage due to using "extern new;" to access keyboard driver data! Signed-off-by: Marek Vasut Cc: Mike

[U-Boot] [PATCH 1/3] USB: Squash checkpatch warnings in usb_kbd.c

2011-10-10 Thread Marek Vasut
Signed-off-by: Marek Vasut Cc: Mike Frysinger Cc: Remy Bohmer Cc: Wolfgang Denk --- common/usb_kbd.c | 608 -- 1 files changed, 319 insertions(+), 289 deletions(-) diff --git a/common/usb_kbd.c b/common/usb_kbd.c index 503d175..0679420 1006

[U-Boot] [PATCH 3/3] USB: Drop dead code from usb_kbd.c

2011-10-10 Thread Marek Vasut
Signed-off-by: Marek Vasut Cc: Mike Frysinger Cc: Remy Bohmer Cc: Wolfgang Denk --- common/usb_kbd.c | 379 -- 1 files changed, 0 insertions(+), 379 deletions(-) diff --git a/common/usb_kbd.c b/common/usb_kbd.c index 94c8894..670d953 100644

[U-Boot] [PATCH 0/3] USB keyboard driver rework (round 2)

2011-10-10 Thread Marek Vasut
This series reworks the common/usb_kbd.c driver. The code in the driver was messy so this is mostly cleanup and reorganisation. NOTE: I don't consider it a V2 of the previous series because the patch 1/2 from the old series is no longer present and there were also some changes in the dead code int

Re: [U-Boot] [PATCH V3 05/13] i2c: Create common default i2c_set_bus_num() function

2011-10-10 Thread Stefano Babic
On 10/10/2011 05:19 PM, Mike Frysinger wrote: > On Monday 10 October 2011 06:50:12 Stefano Babic wrote: Hi Mike, >> +int __def_i2c_set_bus_num(unsigned int bus) >> +{ >> +return 0; >> +} >> +int i2c_set_bus_num(unsigned int) >> +__attribute__((weak, alias("__def_i2c_set_bus_num"))); > >

Re: [U-Boot] [PATCH] mx31pdk: Remove unneeded config

2011-10-10 Thread Fabio Estevam
Hi Wolfgang, On Tue, Sep 13, 2011 at 8:10 AM, Stefano Babic wrote: > On 09/12/2011 06:32 PM, Fabio Estevam wrote: >> Currently there are two config options for building a U-boot binary for >> MX31PDK: >> >> make mx31pdk_config >> >> or, >> >> make mx31pdk_nand_config >> >> mx31pdk_config was dev

  1   2   >