Laurence,
On Sat, Oct 08, 2011 at 18:26:39, Laurence Withers wrote:
> On Sat, Oct 08, 2011 at 02:58:36PM +0530, [email protected] wrote:
> > revert commit bd65d006a6088bcb857e079447d7549e2cd7054d as the 
> > disabling of cache need not be done explicitly. Subsequent patches to 
> > new cache management framework has fixed it.
> > EMAC issue with cache coherency still exists when cahces are enabled.
> 
> Hi Manjunath,
> 
> A small thing, but I'd recommend you drop the sentence "Subsequent patches to 
> new cache management framework has fixed it.", as it implies things were 
> broken (true) and are now fixed (still not true).

> 
> In fact, would it be better to simply drop this patch from the patch series 
> altogether, leaving the caches explicitly disabled, until such a time as the 
> EMAC driver is fixed (I guess we are mainly waiting to see if anyone wants to 
> tackle cache ops for the ARM926EJS) and the code has been verified with 
> caches enabled?
Sure. I am dropping this patch for now. We will tackle (or may be Yonuk) it 
Again soon.

> 
> Bye for now,
> -- 
> Laurence Withers, <[email protected]>                http://www.guralp.com/
> Direct tel:+447753988197 or tel:+443333408643               Software Engineer
> General support queries: <[email protected]>         CMG-DCM CMG-EAM CMG-NAM
> 

_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to