Re: [U-Boot] [PATCH] Error : Not finding asm/arch/gpio.h

2011-08-24 Thread Wolfgang Denk
Dear Faisal H, In message you wrote: > While building with omap3_beagle_config configuration, > getting an error about not finding asm/arch/gpio.h (which does not exist). > Found that header files are moved to arch/arm/include/asm/arch-. > Fixed the includes to find the file.. > > Signed-off-by

Re: [U-Boot] [PATCH] README: clean up and document the Freescale QE/FMAN firmware macros

2011-08-24 Thread Wolfgang Denk
Dear Timur Tabi, In message <4e558423.8020...@freescale.com> you wrote: > > > And why don't you add the documentation with the code? > > I haven't written the code yet. I want to make sure the idea is acceptable > before I start implementing it. Plus, since our internal code is different > tha

[U-Boot] [PATCH] Error : Not finding asm/arch/gpio.h

2011-08-24 Thread Faisal H
While building with omap3_beagle_config configuration, getting an error about not finding asm/arch/gpio.h (which does not exist). Found that header files are moved to arch/arm/include/asm/arch-. Fixed the includes to find the file.. Signed-off-by: Faisal Hassan Cc: Wolfgang Denk --- a/board/cm-b

Re: [U-Boot] gcc-4.6 warnings

2011-08-24 Thread Wolfgang Denk
Dear Kumar Gala, In message <348935c0-0c2d-4a7a-8abe-9d09e2904...@kernel.crashing.org> you wrote: > > > If the variable is not used, why don't we remove it, then? > > In the vast number of cases it because of some #ifdef case not be > defined in the given build. well, that's the reason for the

Re: [U-Boot] [PATCH 8/9] DM9000: change some printf to use debug instead

2011-08-24 Thread Wolfgang Denk
Dear Eric Jarrige, In message <683e266c-cdfb-4310-8145-1926c6fcc...@armadeus.org> you wrote: > > > If you touch that, then please do it right: us debug() instead, and > > remove DM9000_DBG. Thanks. > > Do you mean both changes in one patch? Yes, please. Best regards, Wolfgang Denk -- DENX

Re: [U-Boot] [PATCH v2 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-24 Thread Ajay Bhargav
- "Marek Vasut" wrote: > On Wednesday, August 24, 2011 05:42:06 PM Mike Frysinger wrote: > > On Wednesday, August 24, 2011 09:07:18 Ajay Bhargav wrote: > > > + darmdfec->p_rxdesc = (struct rx_desc *) > memalign(PKTALIGN, > > > + ARMDFEC_RXQ_DESC_ALIGNED_SIZE * RIN

Re: [U-Boot] [PATCH v2 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-24 Thread Ajay Bhargav
- "Marek Vasut" wrote: > On Wednesday, August 24, 2011 03:07:18 PM Ajay Bhargav wrote: > > This patch adds support for Fast Ethernet Controller driver for > > Armada100 series. > > > > Signed-off-by: Ajay Bhargav > > --- > > [...] > [...] > > + > > +static int armdfec_phy_timeout(u32 reg

Re: [U-Boot] [PATCH v2 2/3] Armada100: Enable Ethernet support for GplugD

2011-08-24 Thread Ajay Bhargav
- "Marek Vasut" wrote: [...] > > +/* Disable DCACHE */ > > +#define CONFIG_SYS_DCACHE_OFF > > ARMADA100 is still ARMv5? Then maybe you can try Hong Xu's patches for > dcache on > armv5. You'll have to modify the ethernet driver to be aware of the > dcache then > though. > > As dcache supp

Re: [U-Boot] [PATCH v2 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-24 Thread Ajay Bhargav
- "Mike Frysinger" wrote: > On Wednesday, August 24, 2011 09:07:18 Ajay Bhargav wrote: > > + darmdfec->p_rxdesc = (struct rx_desc *) memalign(PKTALIGN, > > + ARMDFEC_RXQ_DESC_ALIGNED_SIZE * RINGSZ + > 1); > > memalign() returns a void*, so you shouldnt need to ca

Re: [U-Boot] gcc-4.6 warnings

2011-08-24 Thread Kumar Gala
On Aug 24, 2011, at 2:05 PM, Wolfgang Denk wrote: > Dear Kumar Gala, > > In message <3aa0e5b6-7e38-4cb0-94e2-f7bba9a10...@kernel.crashing.org> you > wrote: >> We get a bunch of warnings like this with gcc-4.6.x: >> >> e1000.c:4334:3: warning: variable 'x' set but not used >> [-Wunused-but-set

Re: [U-Boot] [PATCH] beagleboard: enable HUB power on all variants of the BeagleBoard

2011-08-24 Thread Marek Vasut
On Thursday, August 25, 2011 05:30:59 AM Jason Kridner wrote: > On Wed, Aug 24, 2011 at 11:22 PM, Marek Vasut wrote: > > On Thursday, August 25, 2011 12:47:41 AM Joel A Fernandes wrote: > >> From: Christian Spielberger > >> > >> Signed-off-by: Joel A Fernandes > >> Cc: "Eric Bأ�nard" > >> Cc:

Re: [U-Boot] [PATCH] beagleboard: enable HUB power on all variants of the BeagleBoard

2011-08-24 Thread Jason Kridner
On Wed, Aug 24, 2011 at 11:22 PM, Marek Vasut wrote: > On Thursday, August 25, 2011 12:47:41 AM Joel A Fernandes wrote: >> From: Christian Spielberger >> >> Signed-off-by: Joel A Fernandes >> Cc: "Eric Bأ�nard" >> Cc: "Christian Spielberger" >> --- >> Pushing this patch myself as no one else d

Re: [U-Boot] [PATCH] beagleboard: enable HUB power on all variants of the BeagleBoard

2011-08-24 Thread Marek Vasut
On Thursday, August 25, 2011 12:47:41 AM Joel A Fernandes wrote: > From: Christian Spielberger > > Signed-off-by: Joel A Fernandes > Cc: "Eric Bأ�nard" > Cc: "Christian Spielberger" > --- > Pushing this patch myself as no one else did. > > Previous discussions: > http://article.gmane.org/gman

Re: [U-Boot] [PATCH 8/9] DM9000: change some printf to use debug instead

2011-08-24 Thread Marek Vasut
On Thursday, August 25, 2011 01:04:17 AM Eric Jarrige wrote: > Dear Wolfgang, > > On 24 août 2011, at 22:20, Wolfgang Denk wrote: > > Dear Eric Jarrige, > > > > In message <2b613989-addb-43d6-a8c3-a30d52452...@armadeus.org> you wrote: > I'am just wondering: I see that DM9000_DBG is used all

Re: [U-Boot] [RFC] New init sequence processing without init_sequence array

2011-08-24 Thread Graeme Russ
Hi Simon On Thu, Aug 25, 2011 at 9:41 AM, Simon Glass wrote: > Hi Graeme, [big snip] > > Ick. The more I read of this thread the more I like your original > implementation. It really doesn't seem that hard to see the order of > initcalls either from System.map or objdump | grep or similar. Writ

Re: [U-Boot] [PATCH 5/9] apf9328: add default board configuration file

2011-08-24 Thread Eric Jarrige
Hi Stefano, On 24 août 2011, at 08:22, Stefano Babic wrote: > On 08/24/2011 06:56 AM, Eric Jarrige wrote: >> Dear Wolfgang, Dear Stefano, > > Hi Eric, > We really need a set of default IP addresses for private network to simplify as much as possible the life of the armadeus project d

Re: [U-Boot] [RFC] New init sequence processing without init_sequence array

2011-08-24 Thread Simon Glass
Hi Graeme, On Wed, Aug 24, 2011 at 4:00 PM, Graeme Russ wrote: > Hi Wolfgang > > On Wed, Aug 24, 2011 at 11:58 PM, Graeme Russ wrote: >> Hi Wolfgang, >> >> On 24/08/11 23:24, Wolfgang Denk wrote: >>> Dear Graeme Russ, >>> >>> In message <4e54f501.6050...@gmail.com> you wrote: > > [snip] > >> >>

Re: [U-Boot] [PATCH 5/9] apf9328: add default board configuration file

2011-08-24 Thread Eric Jarrige
Dear Wolfgang, On 24 août 2011, at 08:34, Wolfgang Denk wrote: > Dear Eric, > > In message <20110824054915.0860711f9...@gemini.denx.de> I wrote: >> >>> Sure, DHCP is the best *technical* solution. >>> I meant for static IP address? >> >> Why does anybody need static IP addresses for the defaul

Re: [U-Boot] [PATCH 8/9] DM9000: change some printf to use debug instead

2011-08-24 Thread Eric Jarrige
Dear Wolfgang, On 24 août 2011, at 22:20, Wolfgang Denk wrote: > Dear Eric Jarrige, > > In message <2b613989-addb-43d6-a8c3-a30d52452...@armadeus.org> you wrote: >> I'am just wondering: I see that DM9000_DBG is used all over dm9000 code - do you know the reason why not just use debug

Re: [U-Boot] [PATCH] README: clean up and document the Freescale QE/FMAN firmware macros

2011-08-24 Thread Timur Tabi
Wolfgang Denk wrote: > Dear Tabi Timur-B04825, > > In message > you > wrote: >> >>> Note that some of the code managed by these macros have not yet been posted > > s/have/has/ ? Thanks. >>> externally. Such code will be posted, but properly documenting the macros >>> is the first step. >> >

Re: [U-Boot] [RFC] New init sequence processing without init_sequence array

2011-08-24 Thread Graeme Russ
Hi Wolfgang On Wed, Aug 24, 2011 at 11:58 PM, Graeme Russ wrote: > Hi Wolfgang, > > On 24/08/11 23:24, Wolfgang Denk wrote: >> Dear Graeme Russ, >> >> In message <4e54f501.6050...@gmail.com> you wrote: [snip] > > Hmmm, now we're talking ;) Let me ramble aimlessly for a second... > > I can see t

Re: [U-Boot] [PATCH] README: clean up and document the Freescale QE/FMAN firmware macros

2011-08-24 Thread Wolfgang Denk
Dear Tabi Timur-B04825, In message you wrote: > > > Note that some of the code managed by these macros have not yet been posted s/have/has/ ? > > externally.  Such code will be posted, but properly documenting the macros > > is the first step. > > Wolfgang, if you're okay with the text in this

Re: [U-Boot] [PATCH 5/9] apf9328: add default board configuration file

2011-08-24 Thread Wolfgang Denk
Dear Eric Jarrige, In message <8f000deb-1afc-403b-9b00-fa2bff2e1...@armadeus.org> you wrote: > > > Which new interface do you mean? And why would waiting for it help > > you? > > By interface I mean the changes you mentioned to avoid to have "filesize" > and "fileaddr" with the environment varia

Re: [U-Boot] [PATCH] tsec: Configure the buffer descriptor bases to always include all of the descriptors

2011-08-24 Thread Joe Hershberger
On Wed, Aug 24, 2011 at 5:46 PM, Wolfgang Denk wrote: > Dear Joe Hershberger, > > In message > you > wrote: >> >> It fixes something that was wrong before you committed >> 063c12633d5ad74d52152d9c358e715475e17629, but at this point, it's just >> cosmetic. > > I don't think this is worth to chan

[U-Boot] [PATCH] beagleboard: enable HUB power on all variants of the BeagleBoard

2011-08-24 Thread Joel A Fernandes
From: Christian Spielberger Signed-off-by: Joel A Fernandes Cc: "Eric Bénard" Cc: "Christian Spielberger" --- Pushing this patch myself as no one else did. Previous discussions: http://article.gmane.org/gmane.comp.boot-loaders.u-boot/105663/ http://article.gmane.org/gmane.comp.boot-loaders.u

Re: [U-Boot] [PATCH] tsec: Configure the buffer descriptor bases to always include all of the descriptors

2011-08-24 Thread Wolfgang Denk
Dear Joe Hershberger, In message you wrote: > > It fixes something that was wrong before you committed > 063c12633d5ad74d52152d9c358e715475e17629, but at this point, it's just > cosmetic. I don't think this is worth to change the code. Can you accept that we drop this patch? Best regards, Wo

Re: [U-Boot] [PATCH 6/7] powerpc/mpc8349emds: Migrate from spd_sdram to unified DDR driver

2011-08-24 Thread Wolfgang Denk
Dear York Sun, In message <1312923045-2612-6-git-send-email-york...@freescale.com> you wrote: > Update MPC8349EMDS to use unified DDR driver instead of spd_sdram.c. > The unified driver can initialize data using DDR controller. No need to > use DMA if just to initialze for ECC. > > Signed-off-by:

Re: [U-Boot] [PATCH 5/9] apf9328: add default board configuration file

2011-08-24 Thread Eric Jarrige
Dear Wolfgang, On 24 août 2011, at 07:49, Wolfgang Denk wrote: > Dear Eric Jarrige, > > In message you wrote: >> >>> Stefano is right. "filesize" and "fileaddr" are dynamic variables, >>> thet get created and updated on the fly. It makes no sense to >>> pre-define them to any specific value.

Re: [U-Boot] [PATCH 5/7] powerpc/mpc83xx: Migrate from spd_sdram to unified DDR driver

2011-08-24 Thread Wolfgang Denk
Dear York Sun, In message <1312923045-2612-5-git-send-email-york...@freescale.com> you wrote: > Unified DDR driver is maintained for better performance, robustness and bug > fixes. Upgrading to use unified DDR driver for MPC83xx takes advantage of > overall improvement. It requires changes for boa

Re: [U-Boot] [RFC PATCH] checkpatch.pl: Add ability to ignore various messages

2011-08-24 Thread Joe Perches
On Wed, 2011-08-24 at 23:25 +0200, Wolfgang Denk wrote: > > > This feature would be really useful for us, but I'd rather see this in > > > mainline than starting a fork. > > A better version is in Linus' current 3.0+ as of a couple of days ago. > > It's not in 3.0. > Great. Are you planning to sub

Re: [U-Boot] [PATCH 7/7] powerpc/8xxx: Add support for interactive DDR programming interface

2011-08-24 Thread Wolfgang Denk
Dear York Sun, In message <1312923045-2612-7-git-send-email-york...@freescale.com> you wrote: > Interactive DDR debugging provides a user interface to view and modify SPD, > DIMM parameters, board options and DDR controller registers before DDR is > initialized. With this feature, developers can f

Re: [U-Boot] [PATCH] ppc460: read get_sys_info from CPR registers instead of STRP registers

2011-08-24 Thread Wolfgang Denk
Dear Tirumala Marri, In message you wrote: > > As mentioned before, we might otherwise remove the dead code. > > [marri] Sorry I was on vacation last month. We do still need this code as > PPC460 is still used by many companies. We are working in submitting the > New patch set to fix most of t

Re: [U-Boot] [PATCH] new tool mkenvimage: generates an env image from an arbitrary config file

2011-08-24 Thread Wolfgang Denk
Dear David Wagner, In message <1312885889-20222-1-git-send-email-david.wag...@free-electrons.com> you wrote: > This tool takes a key=value configuration file (same as would a `printenv' > show) > and generates the corresponding environnment image, ready to be flashed. s/nnm/nm/ > > Signed-off

Re: [U-Boot] [PATCH] AT91: Defer Dataflash access to env_relocate_spec

2011-08-24 Thread Wolfgang Denk
Dear Hong Xu, In message <1312354896-24951-1-git-send-email-hong...@atmel.com> you wrote: > When env_init is called, the SPI is not actually initialized in U-Boot. > So that we can not read Dataflash for its content. > We simply mark it OK for now, and defer the real work to > `env_relocate_spec'.

Re: [U-Boot] [PATCH] post: fix up I/O helper usage

2011-08-24 Thread Wolfgang Denk
Dear Mike Frysinger, In message <201108141645.40439.vap...@gentoo.org> you wrote: > > > > Sorry, but I will not accept inl() here. > > > > so not even to fix build failures for most non-ppc arches ? i wont be > > able to post an updated patch for a while. > > so i can post a patch to use io{rea

Re: [U-Boot] [PATCH] README: clean up and document the Freescale QE/FMAN firmware macros

2011-08-24 Thread Tabi Timur-B04825
On Mon, Aug 22, 2011 at 4:45 PM, Timur Tabi wrote: > The Freescale QE and FMAN devices support uploading of firmware, and U-Boot > can locate that firmware on different types of storage media.  However, > the current macros used for this code are inconsistent and poorly documented. > > Note that s

Re: [U-Boot] [RFC PATCH] checkpatch.pl: Add ability to ignore various messages

2011-08-24 Thread Wolfgang Denk
Dear Joe Perches, In message <1311804639.21169.22.camel@Joe-Laptop> you wrote: > > > Did you receive any feedback for your proposal, especially from Andrew > > Morton? > > This feature would be really useful for us, but I'd rather see this in > > mainline than starting a fork. > > A better versio

Re: [U-Boot] __fsl_ddr_set_lawbar: ERROR (ctrl #0, intrlv=0)

2011-08-24 Thread Wolfgang Denk
Dear Kumar Gala, In message <17e34909-a735-4920-9980-059d95535...@kernel.crashing.org> you wrote: > > > If so, I wonder what has changed, because this used to be working in > > older versions of the kernel? I did not attampt a full git bisect, > > but from some old images I still found it appears

Re: [U-Boot] [u-boot][PATCH] tftp: Remove command repetition.

2011-08-24 Thread Wolfgang Denk
Dear Marek Belisko, In message <1313348911-10817-1-git-send-email-marek.beli...@open-nandra.com> you wrote: > Lot of commands in u-boot have repeat command flag but not all are > very usefull. Remove this flag for tftp to avoid repeated file download > when user press enter. Why don't you consid

Re: [U-Boot] [PATCH 8/9] DM9000: change some printf to use debug instead

2011-08-24 Thread Wolfgang Denk
Dear Eric Jarrige, In message <2b613989-addb-43d6-a8c3-a30d52452...@armadeus.org> you wrote: > > >> I'am just wondering: I see that DM9000_DBG is used all over dm9000 code > >> - do you know the reason why not just use debug()? > > dm9000 does not use debug() at all. > That's the reason to fix

Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

2011-08-24 Thread Anton Staaf
On Wed, Aug 24, 2011 at 12:18 PM, Lukasz Majewski wrote: > On Wed, 24 Aug 2011 11:25:42 -0700 > Anton Staaf wrote: > >> On Wed, Aug 24, 2011 at 11:12 AM, Wolfgang Denk wrote: >> > Dear Anton Staaf, >> > >> > In message >> > >> > you wrote: >> >> >> >> >> 4. get_dcache_line_size() can be simply

Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

2011-08-24 Thread Anton Staaf
On Wed, Aug 24, 2011 at 12:04 PM, Wolfgang Denk wrote: > Dear Anton Staaf, > > In message > you > wrote: >> >> > No, it is definitely NOT needed for this purpose - we have been using >> > CONFIG_SYS_CACHE_LINE_SIZE for more than a decade without problems, so >> > I don't really understand why w

Re: [U-Boot] [RFC] fastboot gadget support

2011-08-24 Thread Remy Bohmer
Hi, 2011/8/10 Sebastian Andrzej Siewior : > > It was tested before it has been re-written. It is possible that it is > broken. It is posted for reference only not for merging. Looking at this code, I can already say that the way it is written is not suitable for mainline acceptance at all. If you

Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

2011-08-24 Thread Lukasz Majewski
On Wed, 24 Aug 2011 11:25:42 -0700 Anton Staaf wrote: > On Wed, Aug 24, 2011 at 11:12 AM, Wolfgang Denk wrote: > > Dear Anton Staaf, > > > > In message > > > > you wrote: > >> > >> >> 4. get_dcache_line_size() can be simply defined as > >> >> #define get_dcache_line_size() CONFIG_SYS_CACHE_LINE

Re: [U-Boot] [PATCH V2 1/4] Added documentation for CONFIG_SYS_TEXT_BASE.

2011-08-24 Thread Wolfgang Denk
Dear Christopher Harvey, In message <20110824183457.gb3...@harvey-pc.matrox.com> you wrote: > > > > +- CONFIG_SYS_TEXT_BASE: > > > + Is the start address of the u-boot code. > > > + This value can be in ROM space since u-boot can startup from > > > + within ROM. This value

Re: [U-Boot] gcc-4.6 warnings

2011-08-24 Thread Wolfgang Denk
Dear Kumar Gala, In message <3aa0e5b6-7e38-4cb0-94e2-f7bba9a10...@kernel.crashing.org> you wrote: > We get a bunch of warnings like this with gcc-4.6.x: > > e1000.c:4334:3: warning: variable 'x' set but not used > [-Wunused-but-set-variable] > > Are we get with adding -Wunused-but-set-variable

Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

2011-08-24 Thread Wolfgang Denk
Dear Anton Staaf, In message you wrote: > > > No, it is definitely NOT needed for this purpose - we have been using > > CONFIG_SYS_CACHE_LINE_SIZE for more than a decade without problems, so > > I don't really understand why we now would need a new function for > > this? > > Ahh, I misunderstoo

Re: [U-Boot] gcc-4.6 warnings

2011-08-24 Thread Mike Frysinger
On Wednesday, August 24, 2011 14:29:43 Kumar Gala wrote: > We get a bunch of warnings like this with gcc-4.6.x: > > e1000.c:4334:3: warning: variable 'x' set but not used > [-Wunused-but-set-variable] > > Are we get with adding -Wunused-but-set-variable so they don't show up? in general, i like

Re: [U-Boot] [PATCH V2 1/4] Added documentation for CONFIG_SYS_TEXT_BASE.

2011-08-24 Thread Christopher Harvey
On Thu, Aug 04, 2011 at 08:20:33AM +0200, Albert ARIBAUD wrote: > Hi Christopher, > > Le 07/07/2011 16:26, Christopher Harvey a ?crit : > > Signed-off-by: Christopher Harvey > > --- > > V2: > > Make it clear that this is the start address of u-boot. > > > > README |6 ++ > > 1 files cha

[U-Boot] gcc-4.6 warnings

2011-08-24 Thread Kumar Gala
We get a bunch of warnings like this with gcc-4.6.x: e1000.c:4334:3: warning: variable 'x' set but not used [-Wunused-but-set-variable] Are we get with adding -Wunused-but-set-variable so they don't show up? - k ___ U-Boot mailing list U-Boot@lists.de

Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

2011-08-24 Thread Anton Staaf
On Wed, Aug 24, 2011 at 11:12 AM, Wolfgang Denk wrote: > Dear Anton Staaf, > > In message > you > wrote: >> >> >> 4. get_dcache_line_size() can be simply defined as >> >> #define get_dcache_line_size() CONFIG_SYS_CACHE_LINE_SIZE if we >> >> _really_ want to save a few bytes. >> > >> > Actually

Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

2011-08-24 Thread Wolfgang Denk
Dear Anton Staaf, In message you wrote: > > >> 4. get_dcache_line_size() can be simply defined as > >> #define get_dcache_line_size() CONFIG_SYS_CACHE_LINE_SIZE if we > >> _really_ want to save a few bytes. > > > > Actually I fail to understand why we would ever need > > get_dcache_line_size() i

Re: [U-Boot] [STATUS] ARM: board removal

2011-08-24 Thread Wolfgang Denk
Dear Albert ARIBAUD, In message <4e553288.9000...@aribaud.net> you wrote: > > Wolfgang, did you by any chance use some kind of script to produce your > patchset, and if so, could you regenerate the set of patches for the > remaining boards, those that currently have an 'action required' status

Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

2011-08-24 Thread Mike Frysinger
On Wednesday, August 24, 2011 13:27:05 Anton Staaf wrote: > On Wed, Aug 24, 2011 at 6:25 AM, Wolfgang Denk wrote: > > Lukasz Majewski wrote: > >> 4. get_dcache_line_size() can be simply defined as > >> #define get_dcache_line_size() CONFIG_SYS_CACHE_LINE_SIZE if we > >> _really_ want to save a few

Re: [U-Boot] [PATCH V4 3/4] ARM: Warn when the machine ID isn't set.

2011-08-24 Thread Christopher Harvey
On Wed, Aug 24, 2011 at 04:31:20PM +0200, Albert ARIBAUD wrote: > Le 04/08/2011 08:30, Albert ARIBAUD a ?crit : > > Hi Christopher, > > > > Le 18/07/2011 19:33, Christopher Harvey a ?crit : > >> Linux cannot boot without it. > >> > >> Signed-off-by: Christopher Harvey > >> --- > >> > >> V2: > >> Us

Re: [U-Boot] [PATCH] arm: tegra2: fix out-of-tree build

2011-08-24 Thread Anton Staaf
On Tue, Aug 23, 2011 at 8:03 PM, Che-liang Chiou wrote: > Hi Anton, > > Thanks for comments. Replied below. > > Regards, > Che-Liang > > On Wed, Aug 24, 2011 at 1:01 AM, Anton Staaf wrote: >> On Tue, Aug 23, 2011 at 3:03 AM, Che-Liang Chiou >> wrote: >>> The out-of-tree build fails because the

Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

2011-08-24 Thread Anton Staaf
On Wed, Aug 24, 2011 at 6:25 AM, Wolfgang Denk wrote: > Dear Lukasz Majewski, > > In message <20110824120744.097ba2c5@lmajewski.digital.local> you wrote: >> >> After reading dcache related threads I'd like to sum them up: >> >> 1. alloca() -> not acceptable to u-boot mainline by Wolfgang. I agree

Re: [U-Boot] [STATUS] ARM: board removal

2011-08-24 Thread Albert ARIBAUD
Le 24/08/2011 18:09, Reinhard Meyer a écrit : > Dear Albert, >> [snip] >> >> Also, the following boards, for which Reinhard is a delegate, are >> still undecided: >> >> [U-Boot,46/52] ARM: remove broken "at91rm9200dk" board 2011-07-17 >> Wolfgang Denk reinhardm New >> [U-Boot,45/52] ARM: remove bro

[U-Boot] [PATCH 2/3] powerpc/mpc8xxx: Move DDR RCW overriding to common code

2011-08-24 Thread York Sun
DDR RCW varies at different speeds. It is common for all platform. Move it out from corenet_ds. Signed-off-by: York Sun --- arch/powerpc/cpu/mpc8xxx/ddr/options.c | 15 +++ board/freescale/corenet_ds/ddr.c | 14 -- 2 files changed, 15 insertions(+), 14 deletions

[U-Boot] [PATCH 3/3] powerpc/corenet_ds: Use separated speed tables for UDIMM and RDIMM

2011-08-24 Thread York Sun
RDIMM has different timing parameters from UDIMM. Create new tables for RDIMMs. Single-, dual- and quad-rank RDIMMs have been verified with speeds from 800 to 1333MT/s. Speed table expands to include 1600MT/s for future use. Single- and quad-rank RDIMM entries are copied into UDIMM tables for futur

[U-Boot] [PATCH 1/3] powerpc/mpc8xxx: Extend CWL table

2011-08-24 Thread York Sun
Extend CAS write Latency (CWL) table to comply with DDR3 spec Signed-off-by: York Sun --- arch/powerpc/cpu/mpc8xxx/ddr/ctrl_regs.c | 18 -- 1 files changed, 16 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/cpu/mpc8xxx/ddr/ctrl_regs.c b/arch/powerpc/cpu/mpc8xxx/ddr/c

Re: [U-Boot] [PATCH v2 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-24 Thread Marek Vasut
On Wednesday, August 24, 2011 05:42:06 PM Mike Frysinger wrote: > On Wednesday, August 24, 2011 09:07:18 Ajay Bhargav wrote: > > + darmdfec->p_rxdesc = (struct rx_desc *) memalign(PKTALIGN, > > + ARMDFEC_RXQ_DESC_ALIGNED_SIZE * RINGSZ + 1); > > memalign() returns a void

Re: [U-Boot] [PATCH v2 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-24 Thread Marek Vasut
On Wednesday, August 24, 2011 03:07:18 PM Ajay Bhargav wrote: > This patch adds support for Fast Ethernet Controller driver for > Armada100 series. > > Signed-off-by: Ajay Bhargav > --- [...] > diff --git a/drivers/net/armada100_fec.c b/drivers/net/armada100_fec.c > new file mode 100644 > index

Re: [U-Boot] [PATCH v4 07/13] Add standard environment variables README

2011-08-24 Thread Jason Hobbs
On Tue, Aug 23, 2011 at 05:45:07PM -0400, Mike Frysinger wrote: > this somewhat duplicates the "Environment Variables" section in the top level > README. can't we have just one location for this stuff ? Ah, you're right. When I searched for existing doc before adding this file, I didn't think to

Re: [U-Boot] [PATCH v2 2/3] Armada100: Enable Ethernet support for GplugD

2011-08-24 Thread Marek Vasut
On Wednesday, August 24, 2011 03:07:19 PM Ajay Bhargav wrote: > This patch enables ethernet support for Marvell GplugD board. Network > related commands works. > > Signed-off-by: Ajay Bhargav > --- > Changes for v2: > - armada100_fec_initialize changed to armada100_fec_register > > arch/a

Re: [U-Boot] [PATCH v2 3/3] Armada100: Enable 88E3015 PHY support for GplugD

2011-08-24 Thread Marek Vasut
On Wednesday, August 24, 2011 03:07:20 PM Ajay Bhargav wrote: > This patch adds support for 88E3015 PHY for Marvell GplugD board. > This patch depends on series of patch which adds support for Marvell > GuruPlug-Display. > > Signed-off-by: Ajay Bhargav > --- > Changes for v2: > - Not change

Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

2011-08-24 Thread Mike Frysinger
On Wednesday, August 24, 2011 09:25:53 Wolfgang Denk wrote: > Lukasz Majewski wrote: > > 3. Mike's DMA_DECLARE_BUFFER(, , > > ) > > solution looks OK for me, at least for the stack allocated data (e.g. > > ext_csd). > > However this proposed implementation has been NAK'ed by Wolfgang. > > > > I'm

Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

2011-08-24 Thread Mike Frysinger
On Tuesday, August 23, 2011 17:48:50 Anton Staaf wrote: > I wasn't going to say it. :) How about something like this, which is > very similar to what you had Mike, but doesn't define the array in the > macro. It's a bit clearer what is going on, but also requires a bit > more work at each use. >

Re: [U-Boot] [STATUS] ARM: board removal

2011-08-24 Thread Reinhard Meyer
Dear Albert, > [snip] > > Also, the following boards, for which Reinhard is a delegate, are still > undecided: > > [U-Boot,46/52] ARM: remove broken "at91rm9200dk" board 2011-07-17 Wolfgang > Denk reinhardm New > [U-Boot,45/52] ARM: remove broken "m501sk" board 2011-07-17 Wolfgang Denk > reinhar

Re: [U-Boot] [PATCH v4 06/13] Replace space and tab checks with isblank

2011-08-24 Thread Jason Hobbs
On Tue, Aug 23, 2011 at 05:42:59PM -0400, Mike Frysinger wrote: > On Tuesday, August 23, 2011 17:06:54 Jason Hobbs wrote: > > - while (*nn == ' ' || *nn == '\t') > > + while (isblank(*nn)) > > nn++; > > at least for these "walking forward" ones, they could be replaced with: >

Re: [U-Boot] [PATCH 1/9] OMAP3: CM-T35: Use generic MMC driver

2011-08-24 Thread Tom Rini
On Wed, Aug 24, 2011 at 5:31 AM, Igor Grinberg wrote: > On 08/23/11 01:13, Tom Rini wrote: > >> Switch from the legacy omap3 mmc driver to the new generic omap hsmmc >> driver.  This patch is based on the work done for Beagle, etc. >> >> Signed-off-by: Tom Rini > > It is a good practice to CC the

Re: [U-Boot] [PATCH] ARM: Add Calxeda Highbank platform

2011-08-24 Thread Rob Herring
On 08/24/2011 10:06 AM, Wolfgang Denk wrote: > Dear Rob Herring, > > In message <1314193751-6097-1-git-send-email-robherri...@gmail.com> you wrote: >> From: Rob Herring >> >> Add basic support for Calxeda Highbank platform. Only minimal support with >> serial and SATA are included. >> >> Signed-o

Re: [U-Boot] [PATCH 2/2] mx3fb: move to CONFIG_VIDEO to support videomodes

2011-08-24 Thread Stefano Babic
On 08/24/2011 05:34 PM, Helmut Raiger wrote: > > I just found that the mx3fb driver uses: > > static inline u32 reg_read(unsigned long reg) > { > return __REG(reg); > } > > static inline void reg_write(u32 value, unsigned long reg) > { > __REG(reg) = value; > } > i.MX31 is quit

Re: [U-Boot] [PATCH 2/9] OMAP3: DIG297: Use generic MMC driver

2011-08-24 Thread Tom Rini
On Wed, Aug 24, 2011 at 6:43 AM, Luca Ceresoli wrote: > Tom Rini wrote: >> Switch from the legacy omap3 mmc driver to the new generic omap hsmmc >> driver.  This patch is based on the work done for Beagle, etc. >> >> Signed-off-by: Tom Rini > > Again, please Cc: the board maintainers in the future

Re: [U-Boot] [PATCH v2 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-24 Thread Mike Frysinger
On Wednesday, August 24, 2011 09:07:18 Ajay Bhargav wrote: > + darmdfec->p_rxdesc = (struct rx_desc *) memalign(PKTALIGN, > + ARMDFEC_RXQ_DESC_ALIGNED_SIZE * RINGSZ + 1); memalign() returns a void*, so you shouldnt need to cast its return value (you do this a couple of

Re: [U-Boot] [PATCH v4 04/13] Add isblank

2011-08-24 Thread Jason Hobbs
On Tue, Aug 23, 2011 at 05:40:35PM -0400, Mike Frysinger wrote: > On Tuesday, August 23, 2011 17:06:52 Jason Hobbs wrote: > > Existing ctype checks are implemented using a 256 byte lookup table, > > allowing each character to be in any of 8 character classes. Since there > > are 8 existing characte

Re: [U-Boot] [PATCH 2/2] mx3fb: move to CONFIG_VIDEO to support videomodes

2011-08-24 Thread Helmut Raiger
I just found that the mx3fb driver uses: static inline u32 reg_read(unsigned long reg) { return __REG(reg); } static inline void reg_write(u32 value, unsigned long reg) { __REG(reg) = value; } I am about to change this to readl() and writel(), should I do it in a separate 'cosm

Re: [U-Boot] [PATCH] ARM: Add Calxeda Highbank platform

2011-08-24 Thread Wolfgang Denk
Dear Rob Herring, In message <1314193751-6097-1-git-send-email-robherri...@gmail.com> you wrote: > From: Rob Herring > > Add basic support for Calxeda Highbank platform. Only minimal support with > serial and SATA are included. > > Signed-off-by: Jason Hobbs > Signed-off-by: Rob Herring > Cc:

Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

2011-08-24 Thread Lukasz Majewski
Hi Wolfgang, > I think I'd like to see a macro that can be used like this: > > void *dma_buffer_pointer = DMA_BUFFER(size_in_bytes); > Frankly speaking I don't know any easy way to define buffer this way in a macro (at least without digging deep enough to C preprocessor programming trick

Re: [U-Boot] [PATCH V4 3/4] ARM: Warn when the machine ID isn't set.

2011-08-24 Thread Albert ARIBAUD
Le 04/08/2011 08:30, Albert ARIBAUD a écrit : > Hi Christopher, > > Le 18/07/2011 19:33, Christopher Harvey a écrit : >> Linux cannot boot without it. >> >> Signed-off-by: Christopher Harvey >> --- >> >> V2: >> Used a #define instead of a constant. >> Used a printf instead of a debug. >> >> --- >>

[U-Boot] [PATCH] powerpc/85xx: Cleanup how SVR_MAJ() is defined on MPC8536

2011-08-24 Thread Kumar Gala
The MPC8536 seems to use only 3 bits for the major revision field in the SVR rather than the 4 bits used by all other processors. The most significant bit is used as a mfg code on MPC8536. Signed-off-by: Kumar Gala --- arch/powerpc/cpu/mpc85xx/cpu.c |3 --- arch/powerpc/include/asm/pr

[U-Boot] [STATUS] ARM: board removal

2011-08-24 Thread Albert ARIBAUD
Hi all, Quick status on the 52-part ARM board removal patch. After applying various patches and pulling some repositories, the following boards are still scheduled for removal: [U-Boot,37/52] ARM: remove broken "voiceblue" board 2011-07-17 Wolfgang Denk aaribaudNew [U-Boot,36/52]

Re: [U-Boot] [RFC] fastboot gadget support

2011-08-24 Thread Sebastian Andrzej Siewior
On 08/13/2011 12:22 PM, Remy Bohmer wrote: > Hi Sebastian, Hi Remy, > 2011/8/10 Sebastian Andrzej Siewior: >> This is the faastboot gadget code based on >> git://git.omapzoom.org/repo/u-boot.git as of commit 601ff71c8 including >> a few changes. Some of them are: >> - generic mmc framework >> - "n

Re: [U-Boot] [PATCH 2/9] OMAP3: DIG297: Use generic MMC driver

2011-08-24 Thread Luca Ceresoli
Tom Rini wrote: > Switch from the legacy omap3 mmc driver to the new generic omap hsmmc > driver. This patch is based on the work done for Beagle, etc. > > Signed-off-by: Tom Rini Again, please Cc: the board maintainers in the future, thanks. > --- > board/comelit/dig297/dig297.c |9 ++

Re: [U-Boot] [RFC] New init sequence processing without init_sequence array

2011-08-24 Thread Graeme Russ
Hi Wolfgang, On 24/08/11 23:24, Wolfgang Denk wrote: > Dear Graeme Russ, > > In message <4e54f501.6050...@gmail.com> you wrote: >> >>> Sorry, but when reading the source code or when revioewing patches I >>> cannot paick up any next funtion pointers, I'm stuck with reading the >>> source code onl

[U-Boot] [PATCH] ARM: Add Calxeda Highbank platform

2011-08-24 Thread Rob Herring
From: Rob Herring Add basic support for Calxeda Highbank platform. Only minimal support with serial and SATA are included. Signed-off-by: Jason Hobbs Signed-off-by: Rob Herring Cc: Albert ARIBAUD --- changes in v6: - Remove arch/arm/cpu/armv7/highbank/config.mk - Fix some whitespace errors

Re: [U-Boot] [RFC] New init sequence processing without init_sequence array

2011-08-24 Thread Detlev Zundel
Hi Wolfgang, [...] > I bet that rather sooner than later you will end up with some toold > that parses either the ELF file or the linker map or the symbol table > to generate a readable list for the current build. I bet a case of > beer that you will need such a tool. We don't need it now. obj

Re: [U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

2011-08-24 Thread Wolfgang Denk
Dear Lukasz Majewski, In message <20110824120744.097ba2c5@lmajewski.digital.local> you wrote: > > After reading dcache related threads I'd like to sum them up: > > 1. alloca() -> not acceptable to u-boot mainline by Wolfgang. I agree > that alloca is NOT the way to go. > > 2. malloc/memalign ->

Re: [U-Boot] [RFC] New init sequence processing without init_sequence array

2011-08-24 Thread Wolfgang Denk
Dear Graeme Russ, In message <4e54f501.6050...@gmail.com> you wrote: > > > Sorry, but when reading the source code or when revioewing patches I > > cannot paick up any next funtion pointers, I'm stuck with reading the > > source code only. > > Well, I guess I had a good shot at creating a 'bette

[U-Boot] [PATCH v2 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-24 Thread Ajay Bhargav
This patch adds support for Fast Ethernet Controller driver for Armada100 series. Signed-off-by: Ajay Bhargav --- Changes for v2: - removed random MAC generation - driver init function changed to register as per new naming convention - code cleanup (Thanks to Wolfgang, Mar

[U-Boot] [PATCH v2 3/3] Armada100: Enable 88E3015 PHY support for GplugD

2011-08-24 Thread Ajay Bhargav
This patch adds support for 88E3015 PHY for Marvell GplugD board. This patch depends on series of patch which adds support for Marvell GuruPlug-Display. Signed-off-by: Ajay Bhargav --- Changes for v2: - Not changed board/Marvell/gplugd/gplugd.c | 33 -

[U-Boot] [PATCH v2 2/3] Armada100: Enable Ethernet support for GplugD

2011-08-24 Thread Ajay Bhargav
This patch enables ethernet support for Marvell GplugD board. Network related commands works. Signed-off-by: Ajay Bhargav --- Changes for v2: - armada100_fec_initialize changed to armada100_fec_register arch/arm/include/asm/arch-armada100/armada100.h | 57 +++ arch

Re: [U-Boot] FDT without FIT?

2011-08-24 Thread Wolfgang Denk
Dear Simon Schwarz, In message <4e54c961.70...@gmail.com> you wrote: > > This prints: > # help bootm > bootm - boot application image from memory > > Usage: > bootm [addr [arg ...]] > - boot application image stored in memory > passing arguments 'arg ...'; when booting a Linux kerne

Re: [U-Boot] [RFC] New init sequence processing without init_sequence array

2011-08-24 Thread Graeme Russ
Hi Wolfgang, On 24/08/11 22:49, Wolfgang Denk wrote: > Dear Graeme Russ, > > In message > you > wrote: >> >>> Agreed. I should have written: I have a _readable_ source file that >>> can be parsed without additional tools. >> >> I would hardly call 'grep' an extra tool - How many programmers d

Re: [U-Boot] [PATCH v5] ARM: Add Calxeda Highbank platform

2011-08-24 Thread Wolfgang Denk
Dear Albert ARIBAUD, In message <4e54b862.2070...@aribaud.net> you wrote: > > Well, it is more a question of which toolchain(s) we want supported in > U-Boot. Denx ELDK is one of them I guess :) but now that ELDK 5.0 is > out, I don't know if ELDK 4.2 support is still required. It seems reasona

Re: [U-Boot] [RFC] New init sequence processing without init_sequence array

2011-08-24 Thread Wolfgang Denk
Dear Graeme Russ, In message you wrote: > > > Agreed. I should have written: I have a _readable_ source file that > > can be parsed without additional tools. > > I would hardly call 'grep' an extra tool - How many programmers do you > know that have never used grep? That's not the point. Th

Re: [U-Boot] [PATCH 1/2] mx31: make HSP clock for mx3fb driver available

2011-08-24 Thread Marek Vasut
On Wednesday, August 24, 2011 08:55:03 AM Helmut Raiger wrote: > On 08/22/2011 06:02 PM, Marek Vasut wrote: > > ... _COSMETIC_, while this new mx3fb driver really works nicely ;-) > > Oh my sense for metrosexuality of code really kicks in here ;-) > > Arousal was not my first objective, but delibe

Re: [U-Boot] [PATCH 1/9] OMAP3: CM-T35: Use generic MMC driver

2011-08-24 Thread Igor Grinberg
On 08/23/11 01:13, Tom Rini wrote: > Switch from the legacy omap3 mmc driver to the new generic omap hsmmc > driver. This patch is based on the work done for Beagle, etc. > > Signed-off-by: Tom Rini It is a good practice to CC the board maintainer. Thanks. Tested-by: Igor Grinberg > --- >

Re: [U-Boot] top of tree build fails for beagleboard

2011-08-24 Thread Aneesh V
Hi Jaya Kumar, On Wednesday 24 August 2011 05:39 PM, Jaya Kumar wrote: > Hi guys, > > I cloned top of tree and tried to build beagleboard. Fails right at > the end with: > > make[1]: Entering directory > `/home/beaglexm/clean_code_for_bootstuff/u-boot/board/ti/beagle' > beagle.c:41:27: error: as

[U-Boot] top of tree build fails for beagleboard

2011-08-24 Thread Jaya Kumar
Hi guys, I cloned top of tree and tried to build beagleboard. Fails right at the end with: make[1]: Entering directory `/home/beaglexm/clean_code_for_bootstuff/u-boot/board/ti/beagle' beagle.c:41:27: error: asm/arch/gpio.h: No such file or directory led.c:25:27: error: asm/arch/gpio.h: No such fi

  1   2   >